mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
9f33b8b7c1
-Wwrite-strings flags this attempt to pass a literal to a "char *": mi_cmd_interpreter_exec ("-interpreter-exec", argv, 2); Fix that by constifying mi_cmd_argv_ftype's 'command' parameter and adjusting all MI commands. gdb/ChangeLog: 2017-04-05 Pedro Alves <palves@redhat.com> * mi/mi-cmd-break.c (mi_cmd_break_insert_1, mi_cmd_break_insert) (mi_cmd_dprintf_insert, mi_cmd_break_passcount) (mi_cmd_break_watch, mi_cmd_break_commands): Constify 'command' parameter. * mi/mi-cmd-catch.c (mi_cmd_catch_assert, mi_cmd_catch_exception) (mi_cmd_catch_load, mi_cmd_catch_unload): Constify cmd' parameter. * mi/mi-cmd-disas.c (mi_cmd_disassemble): Constify 'command' parameter. * mi/mi-cmd-env.c (mi_cmd_env_pwd, mi_cmd_env_cd, mi_cmd_env_path) (mi_cmd_env_dir, mi_cmd_inferior_tty_set, _cmd_inferior_tty_show) * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file) (mi_cmd_file_list_exec_source_files) (mi_cmd_file_list_shared_libraries): Constify 'command' parameter. * mi/mi-cmd-info.c (mi_cmd_info_ada_exceptions) (mi_cmd_info_gdb_mi_command, mi_cmd_info_os): Constify 'command' parameter. * mi/mi-cmd-stack.c (mi_cmd_enable_frame_filters) (mi_cmd_stack_list_frames, mi_cmd_stack_info_depth) (mi_cmd_stack_list_locals, mi_cmd_stack_list_args) (mi_cmd_stack_list_variables, mi_cmd_stack_select_frame) (mi_cmd_stack_info_frame): Constify 'command' parameter. * mi/mi-cmd-target.c (mi_cmd_target_file_get) (mi_cmd_target_file_put, mi_cmd_target_file_delete): Constify 'command' parameter. * mi/mi-cmd-var.c (mi_cmd_var_create, mi_cmd_var_delete) (mi_cmd_var_set_format, mi_cmd_var_set_visualizer) (mi_cmd_var_set_frozen, mi_cmd_var_show_format) (mi_cmd_var_info_num_children, mi_cmd_var_list_children) (mi_cmd_var_info_type, mi_cmd_var_info_path_expression) (mi_cmd_var_info_expression, mi_cmd_var_show_attributes) (mi_cmd_var_evaluate_expression, mi_cmd_var_assign) (mi_cmd_var_update, mi_cmd_enable_pretty_printing) (mi_cmd_var_set_update_range): Constify 'command' parameter. * mi/mi-cmds.h (mi_cmd_argv_ftype): Constify 'command' parameter. * mi/mi-interp.c (mi_cmd_interpreter_exec): Constify 'command' parameter. * mi/mi-main.c (mi_cmd_gdb_exit, mi_cmd_exec_next) (mi_cmd_exec_next_instruction, mi_cmd_exec_step) (mi_cmd_exec_step_instruction, mi_cmd_exec_finish) (mi_cmd_exec_return ,mi_cmd_exec_jump, mi_cmd_exec_continue) (mi_cmd_exec_interrupt, mi_cmd_exec_run, mi_cmd_target_detach) (mi_cmd_target_flash_erase, mi_cmd_thread_select) (mi_cmd_thread_list_ids, mi_cmd_thread_info) (mi_cmd_list_thread_groups, mi_cmd_data_list_register_names) (mi_cmd_data_list_changed_registers) (mi_cmd_data_write_register_values) (mi_cmd_data_evaluate_expression, mi_cmd_data_read_memory) (mi_cmd_data_read_memory_bytes, mi_cmd_data_write_memory) (mi_cmd_data_write_memory_bytes, mi_cmd_enable_timings) (mi_cmd_list_features, mi_cmd_list_target_features) (mi_cmd_add_inferior, mi_cmd_remove_inferior) (mi_cmd_trace_define_variable, mi_cmd_trace_list_variables) (mi_cmd_trace_find, mi_cmd_trace_save, mi_cmd_trace_start) (mi_cmd_trace_status, mi_cmd_trace_stop, mi_cmd_ada_task_info) (mi_cmd_trace_frame_collected): Constify 'command' parameter. * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Constify 'command' parameter.
195 lines
5.4 KiB
C
195 lines
5.4 KiB
C
/* MI Command Set - disassemble commands.
|
|
Copyright (C) 2000-2017 Free Software Foundation, Inc.
|
|
Contributed by Cygnus Solutions (a Red Hat company).
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "arch-utils.h"
|
|
#include "target.h"
|
|
#include "value.h"
|
|
#include "mi-cmds.h"
|
|
#include "mi-getopt.h"
|
|
#include "ui-out.h"
|
|
#include "disasm.h"
|
|
|
|
/* The arguments to be passed on the command line and parsed here are
|
|
either:
|
|
|
|
START-ADDRESS: address to start the disassembly at.
|
|
END-ADDRESS: address to end the disassembly at.
|
|
|
|
or:
|
|
|
|
FILENAME: The name of the file where we want disassemble from.
|
|
LINE: The line around which we want to disassemble. It will
|
|
disassemble the function that contins that line.
|
|
HOW_MANY: Number of disassembly lines to display. With source, it
|
|
is the number of disassembly lines only, not counting the source
|
|
lines.
|
|
|
|
always required:
|
|
|
|
MODE: 0 -- disassembly.
|
|
1 -- disassembly and source (with deprecated source-centric view).
|
|
2 -- disassembly and opcodes.
|
|
3 -- disassembly, source-centric and opcodes.
|
|
4 -- disassembly, and source (with pc-centric view).
|
|
5 -- disassembly, source (pc-centric) and opcodes. */
|
|
|
|
void
|
|
mi_cmd_disassemble (const char *command, char **argv, int argc)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
struct ui_out *uiout = current_uiout;
|
|
CORE_ADDR start;
|
|
|
|
int mode, disasm_flags;
|
|
struct symtab *s;
|
|
|
|
/* Which options have we processed ... */
|
|
int file_seen = 0;
|
|
int line_seen = 0;
|
|
int num_seen = 0;
|
|
int start_seen = 0;
|
|
int end_seen = 0;
|
|
|
|
/* ... and their corresponding value. */
|
|
char *file_string = NULL;
|
|
int line_num = -1;
|
|
int how_many = -1;
|
|
CORE_ADDR low = 0;
|
|
CORE_ADDR high = 0;
|
|
struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
|
|
|
|
/* Options processing stuff. */
|
|
int oind = 0;
|
|
char *oarg;
|
|
enum opt
|
|
{
|
|
FILE_OPT, LINE_OPT, NUM_OPT, START_OPT, END_OPT
|
|
};
|
|
static const struct mi_opt opts[] =
|
|
{
|
|
{"f", FILE_OPT, 1},
|
|
{"l", LINE_OPT, 1},
|
|
{"n", NUM_OPT, 1},
|
|
{"s", START_OPT, 1},
|
|
{"e", END_OPT, 1},
|
|
{ 0, 0, 0 }
|
|
};
|
|
|
|
/* Get the options with their arguments. Keep track of what we
|
|
encountered. */
|
|
while (1)
|
|
{
|
|
int opt = mi_getopt ("-data-disassemble", argc, argv, opts,
|
|
&oind, &oarg);
|
|
if (opt < 0)
|
|
break;
|
|
switch ((enum opt) opt)
|
|
{
|
|
case FILE_OPT:
|
|
file_string = xstrdup (oarg);
|
|
file_seen = 1;
|
|
make_cleanup (xfree, file_string);
|
|
break;
|
|
case LINE_OPT:
|
|
line_num = atoi (oarg);
|
|
line_seen = 1;
|
|
break;
|
|
case NUM_OPT:
|
|
how_many = atoi (oarg);
|
|
num_seen = 1;
|
|
break;
|
|
case START_OPT:
|
|
low = parse_and_eval_address (oarg);
|
|
start_seen = 1;
|
|
break;
|
|
case END_OPT:
|
|
high = parse_and_eval_address (oarg);
|
|
end_seen = 1;
|
|
break;
|
|
}
|
|
}
|
|
argv += oind;
|
|
argc -= oind;
|
|
|
|
/* Allow only filename + linenum (with how_many which is not
|
|
required) OR start_addr + end_addr. */
|
|
|
|
if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen)
|
|
|| (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
|
|
|| (!line_seen && !file_seen && !num_seen && start_seen && end_seen)))
|
|
error (_("-data-disassemble: Usage: ( [-f filename -l linenum [-n "
|
|
"howmany]] | [-s startaddr -e endaddr]) [--] mode."));
|
|
|
|
if (argc != 1)
|
|
error (_("-data-disassemble: Usage: [-f filename -l linenum "
|
|
"[-n howmany]] [-s startaddr -e endaddr] [--] mode."));
|
|
|
|
mode = atoi (argv[0]);
|
|
if (mode < 0 || mode > 5)
|
|
error (_("-data-disassemble: Mode argument must be in the range 0-5."));
|
|
|
|
/* Convert the mode into a set of disassembly flags. */
|
|
|
|
disasm_flags = 0; /* Initialize here for -Wall. */
|
|
switch (mode)
|
|
{
|
|
case 0:
|
|
break;
|
|
case 1:
|
|
disasm_flags |= DISASSEMBLY_SOURCE_DEPRECATED;
|
|
break;
|
|
case 2:
|
|
disasm_flags |= DISASSEMBLY_RAW_INSN;
|
|
break;
|
|
case 3:
|
|
disasm_flags |= DISASSEMBLY_SOURCE_DEPRECATED | DISASSEMBLY_RAW_INSN;
|
|
break;
|
|
case 4:
|
|
disasm_flags |= DISASSEMBLY_SOURCE;
|
|
break;
|
|
case 5:
|
|
disasm_flags |= DISASSEMBLY_SOURCE | DISASSEMBLY_RAW_INSN;
|
|
break;
|
|
default:
|
|
gdb_assert_not_reached ("bad disassembly mode");
|
|
}
|
|
|
|
/* We must get the function beginning and end where line_num is
|
|
contained. */
|
|
|
|
if (line_seen && file_seen)
|
|
{
|
|
s = lookup_symtab (file_string);
|
|
if (s == NULL)
|
|
error (_("-data-disassemble: Invalid filename."));
|
|
if (!find_line_pc (s, line_num, &start))
|
|
error (_("-data-disassemble: Invalid line number"));
|
|
if (find_pc_partial_function (start, NULL, &low, &high) == 0)
|
|
error (_("-data-disassemble: "
|
|
"No function contains specified address"));
|
|
}
|
|
|
|
gdb_disassembly (gdbarch, uiout,
|
|
disasm_flags,
|
|
how_many, low, high);
|
|
|
|
do_cleanups (cleanups);
|
|
}
|