mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
d981640286
Many of the ld tests are not run for cross builds, in some cases because the test needs to run a newly linked executable, and in others simply because it was easier to write the test for native only. Even when a test needs to run, it's good to compile and link to exercise the linker. So that's what this patch does. I've also rid us of the old ld_link procedure with all the HOSTING_CRT0 etc. setup. It's much simpler to just link with $CC. This does mean that a cross build with cross-compiler installed but no cross C-library will give lots of failures. If that turns out to be too annoying, I guess we can write a tcl procedure to detect it and not run all the extra tests. * Makefile.am (bootstrap): Delete rule. (ld-partial, ld1, ld1-full, ld2, ld3): Likewise. (HOSTING_CRT0, HOSTING_SCRT0): Don't define. (HOSTING_LIBS, HOSTING_SLIBS, HOSTING_EMU): Likewise. * configure.ac (HOSTING_CRT0, HOSTING_SCRT0): Don't define. (HOSTING_LIBS, HOSTING_SLIBS): Likewise. * configure.host (HOSTING_CRT0, HOSTING_LIBS): Don't define. * Makefile.in: Regenerate. * configure: Regenerate. * testsuite/config/default.exp (get_link_files): Delete. (HOSTING_CRT0, HOSTING_SCRT0, HOSTING_LIBS, HOSTING_SLIBS): Don't define. (ld_simple_link): Delete. * testsuite/lib/ld-lib.exp (default_ld_link): Delete (default_ld_simple_link): Rename to default_ld_link. (ld_simple_link_defsyms): Rename to ld_link_defsyms. (run_ld_link_tests): Use ld_link, not ld_simple_link. (run_cc_link_tests): Likewise. (run_ld_link_exec_tests): Use $CC or $CXX to link, not $ld. Don't run exe when not native, and return unsupported. * testsuite/ld-bootstrap/bootstrap.exp: Create gccld1 etc. dirs. Link ld1 etc. using $CC. * testsuite/ld-cdtest/cdtest.exp: Link cdtest using $CC. * testsuite/ld-checks/checks.exp: Use ld_link, not ld_simple_link. * testsuite/ld-cygwin/exe-export.exp: Likewise. * testsuite/ld-elf/binutils.exp: Likewise. * testsuite/ld-elf/eh-group.exp: Likewise. * testsuite/ld-elf/exclude.exp: Likewise. * testsuite/ld-elf/frame.exp: Likewise. * testsuite/ld-elf/sec-to-seg.exp: Likewise. * testsuite/ld-elf/tls_common.exp: Likewise. * testsuite/ld-elfcomm/elfcomm.exp: Likewise. * testsuite/ld-fastcall/fastcall.exp: Likewise. * testsuite/ld-gc/gc.exp: Likewise. * testsuite/ld-ifunc/binutils.exp: Likewise. * testsuite/ld-mep/mep.exp: Likewise. * testsuite/ld-mips-elf/mips-elf-flags.exp: Likewise. * testsuite/ld-mn10300/mn10300.exp: Likewise. * testsuite/ld-nios2/nios2.exp: Likewise. * testsuite/ld-pe/pe-compile.exp: Likewise. * testsuite/ld-pe/pe-run.exp: Likewise. * testsuite/ld-pe/pe-run2.exp: Likewise. * testsuite/ld-plugin/plugin.exp: Likewise. * testsuite/ld-scripts/align.exp: Likewise. * testsuite/ld-scripts/alignof.exp: Likewise. * testsuite/ld-scripts/assert.exp: Likewise. * testsuite/ld-scripts/defined.exp: Likewise. * testsuite/ld-scripts/extern.exp: Likewise. * testsuite/ld-scripts/log2.exp: Likewise. * testsuite/ld-scripts/map-address.exp: Likewise. * testsuite/ld-scripts/phdrs.exp: Likewise. * testsuite/ld-scripts/phdrs2.exp: Likewise. * testsuite/ld-scripts/script.exp: Likewise. * testsuite/ld-scripts/section-flags.exp: Likewise. * testsuite/ld-scripts/sizeof.exp: Likewise. * testsuite/ld-scripts/sysroot-prefix.exp: Likewise. * testsuite/ld-scripts/weak.exp: Likewise. * testsuite/ld-selective/selective.exp: Likewise. * testsuite/ld-sh/sh.exp: Likewise. * testsuite/ld-sh/sh64/relax.exp: Likewise. * testsuite/ld-sh/sh64/relfail.exp: Likewise. * testsuite/ld-srec/srec.exp: Likewise. * testsuite/ld-tic6x/tic6x.exp: Likewise. * testsuite/ld-undefined/weak-undef.exp: Likewise. * testsuite/ld-versados/versados.exp: Likewise. * testsuite/ld-x86-64/dwarfreloc.exp: Likewise. * testsuite/ld-xtensa/coalesce.exp: Likewise. * testsuite/ld-xtensa/diff_overflow.exp: Likewise. * testsuite/ld-xtensa/lcall.exp: Likewise. * testsuite/ld-elf/audit.exp: Run non-native too. * testsuite/ld-elf/compress.exp: Likewise. Replace ld options with gcc -Wl, options. * testsuite/ld-elf/dwarf.exp: Run non-native too. Use ld_link, not ld_simple_link. Add -Wl,--no-as-needed to some tests. * testsuite/ld-elf/elf.exp: Run non-native too. Formatting. * testsuite/ld-elf/indirect.exp: Run non-native too. Add -Wl,--no-as-needed to most tests. * testsuite/ld-elf/shared.exp: Run non-native too. Use braces to simplify quoting. Set run_tests using [list] rather than brace assignment to expand $extralibs. Add -Wl,--no-as-needed to many test. Prefix ld options with -Wl,. (mix_pic_and_non_pic): Don't run exe if not native. * testsuite/ld-elf/wrap.exp: Run non-native too. Add -Wl,--no-as-needed and prefix ld options with -Wl,. * testsuite/ld-elfvers/vers.exp: Run non-native too. Use ld_link, not ld_simple_link. * testsuite/ld-elfvsb/elfvsb.exp: Likewise. (visibility_test): Don't run exe if not native. * testsuite/ld-elfweak/elfweak.exp: Run non-native too. Use ld_link, not ld_simple_link. (build_exec): Don't run exe if not native. * testsuite/ld-ifunc/ifunc.exp: Run non-native too. Use ld_link, not ld_simple_link. Link using $CC. Add -Wl,--no-as-needed to some tests and prefix ld options with -Wl,. Expect GNU for hppa-linux even when no ifuncs. Delete cleanup. * testsuite/ld-pie/pie.exp: Run non-native too. * testsuite/ld-plugin/lto.exp: Likewise. * testsuite/ld-shared/shared.exp: Likewise. Use ld_link, not ld_simple_link. (shared_test): Don't run exe if not native. * testsuite/ld-size/size.exp: Run non-native too. Add -Wl,--no-as-needed to some tests. Prefix ld options with -Wl,. * testsuite/ld-unique/unique.exp: Run non-native too. Use ld_link, not ld_simple_link. Link using $CC. Add -Wl,--no-as-needed to some tests and prefix ld options with -Wl,. Expect GNU for hppa-linux even when no unique syms. Delete cleanup. * testsuite/ld-x86-64/tls.exp: Add -Wl,--no-as-needed to some tests and prefix ld options with -Wl,. * testsuite/ld-x86-64/x86-64.exp: Use ld_link, not ld_simple_link. Add -Wl,--no-as-needed to some tests. Prefix ld options with -Wl,.
310 lines
8.9 KiB
Plaintext
310 lines
8.9 KiB
Plaintext
# Expect script for common symbol tests
|
|
# Copyright (C) 2003-2017 Free Software Foundation, Inc.
|
|
#
|
|
# This file is part of the GNU Binutils.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
#
|
|
# Written by H.J. Lu (hjl@gnu.org)
|
|
#
|
|
|
|
# Make sure that ld correctly handles common symbols in ELF.
|
|
|
|
# This test can only be run on ELF platforms.
|
|
if ![is_elf_format] {
|
|
return
|
|
}
|
|
|
|
# hpux assembly is weird
|
|
if [istarget "hppa*-*-hpux*"] {
|
|
return
|
|
}
|
|
|
|
proc test_sort_common {} {
|
|
global exec_output
|
|
global objdump
|
|
global srcdir
|
|
global subdir
|
|
global as
|
|
global ld
|
|
|
|
set test "--sort-common (descending)"
|
|
|
|
verbose "Check to see that --sort-common sorts in descending alignment"
|
|
|
|
# We do not run the sort common tests for the DLX target because we know that the linker
|
|
# will seg-fault. The built-in DLX linker script requires that there be something in the
|
|
# .text section and our sort-common.s file does not provide anything.
|
|
if [istarget dlx-*-*] {
|
|
untested "$test"
|
|
return 0
|
|
}
|
|
|
|
if { ![ld_assemble $as $srcdir/$subdir/sort-common.s tmpdir/sort-common.o] } {
|
|
unresolved "$test"
|
|
return 0
|
|
}
|
|
|
|
if { ![ld_link $ld tmpdir/sort-common.dx "--sort-common=descending tmpdir/sort-common.o"] } {
|
|
fail "$test"
|
|
return 0
|
|
}
|
|
|
|
send_log "$objdump --syms tmpdir/sort-common.dx | grep var | sort\n"
|
|
set exec_output [run_host_cmd "$objdump" "--syms tmpdir/sort-common.dx | grep var | sort"]
|
|
|
|
# Don't know why, but the CR ports fail this test.
|
|
setup_xfail "cr16-*-*" "crx-*-*"
|
|
|
|
# Note: The second regexp is for targets which put small commons in a .sbss
|
|
# section and large commons in a .bss section.
|
|
if { ![regexp ".*var_16.*var_8.*var_4.*var_2.*var_1.*" $exec_output]
|
|
&& ![regexp ".*sbss.*var_8.*var_4.*var_2.*var_1.*bss.*var_16.*" $exec_output] } {
|
|
fail $test
|
|
} else {
|
|
pass $test
|
|
}
|
|
|
|
set test "--sort-common (ascending)"
|
|
|
|
verbose "Check to see that --sort-common=ascending sorts in ascending alignment"
|
|
|
|
if { ![ld_link $ld tmpdir/sort-common.ax "--sort-common=ascending tmpdir/sort-common.o"] } {
|
|
fail "$test"
|
|
return 0
|
|
}
|
|
|
|
send_log "$objdump --syms tmpdir/sort-common.ax | grep var | sort\n"
|
|
set exec_output [run_host_cmd "$objdump" "--syms tmpdir/sort-common.ax | grep var | sort"]
|
|
|
|
if {![regexp ".*var_1.*var_2.*var_4.*var_8.*var_16.*" $exec_output]} {
|
|
fail $test
|
|
return 0
|
|
}
|
|
|
|
pass $test
|
|
return 1
|
|
}
|
|
|
|
test_sort_common
|
|
|
|
set test1 "size/aligment change of common symbols"
|
|
set test1w1 "$test1 (warning 1)"
|
|
set test1w2 "$test1 (warning 2)"
|
|
set test1c1 "$test1 (change 1)"
|
|
set test1c2 "$test1 (change 2)"
|
|
|
|
if { ![is_remote host] && [which $CC] == 0 } {
|
|
untested $test1w1
|
|
untested $test1w2
|
|
untested $test1c1
|
|
untested $test1c2
|
|
return
|
|
}
|
|
if { [istarget score-*-*] } {
|
|
untested $test1w1
|
|
untested $test1w2
|
|
untested $test1c1
|
|
untested $test1c2
|
|
return
|
|
}
|
|
|
|
proc dump_common1 { testname } {
|
|
global exec_output
|
|
global READELF
|
|
|
|
send_log "$READELF --syms tmpdir/common1.o | grep foo\n"
|
|
set exec_output [run_host_cmd "$READELF" "--syms tmpdir/common1.o | grep foo"]
|
|
|
|
if { ![regexp "(\[ \]*)(\[0-9\]+):(\[ \]*)(\[0\]*)80(\[ \]+)4(\[ \]+)(COMMON|OBJECT)(\[ \]+)GLOBAL(\[ \]+)DEFAULT(\[ \]+)(PRC\\\[0xff03\\\]|COM|SCOM)(\[ \]+)_?foo2" $exec_output]
|
|
|| ![regexp "(\[ \]*)(\[0-9\]+):(\[ \]*)(\[0-9\]+)(\[ \]+)21(\[ \]+)OBJECT(\[ \]+)GLOBAL(\[ \]+)DEFAULT(\[ \]+)(\[0-9\]+)(\[ \]+)_?foo1" $exec_output] } {
|
|
verbose $exec_output
|
|
fail $testname
|
|
return 0
|
|
}
|
|
|
|
return 1
|
|
}
|
|
|
|
proc stt_common_test { options testname } {
|
|
global exec_output
|
|
global READELF
|
|
global ld
|
|
|
|
set options "$options tmpdir/common1c.o"
|
|
|
|
if { ! [ld_link $ld tmpdir/common.exe $options] } {
|
|
unresolved $testname
|
|
return 0
|
|
}
|
|
|
|
send_log "$READELF --syms tmpdir/common.exe | grep foo\n"
|
|
set exec_output [run_host_cmd "$READELF" "--syms tmpdir/common.exe | grep foo"]
|
|
|
|
if {![regexp { +[0-9a-f]+. +[0-9a-f]+ OBJECT + GLOBAL +DEFAULT +[0-9]+ _?foo2} $exec_output] } {
|
|
fail $testname
|
|
return 0
|
|
}
|
|
|
|
pass $testname
|
|
return 1
|
|
}
|
|
|
|
if [istarget nios2*-*-*] {
|
|
set CFLAGS "$CFLAGS -G0"
|
|
}
|
|
|
|
# Explicitly use "-fcommon" so that even if $CFLAGS includes
|
|
# "-fno-common", these tests are compiled as expected.
|
|
if { ![ld_compile "$CC $CFLAGS -fcommon" $srcdir/$subdir/common1a.c tmpdir/common1a.o]
|
|
|| ![ld_compile "$CC $CFLAGS -fcommon" $srcdir/$subdir/common1b.c tmpdir/common1b.o]
|
|
|| ![ld_compile "$CC $CFLAGS -Wa,--elf-stt-common=yes -fcommon" $srcdir/$subdir/common1b.c tmpdir/common1c.o] } {
|
|
unresolved $test1
|
|
unresolved $test1
|
|
return
|
|
}
|
|
|
|
global ld
|
|
global link_output
|
|
|
|
set options "-r tmpdir/common1a.o tmpdir/common1b.o"
|
|
|
|
# SH64 targets needs an extra ld option for this test.
|
|
if [istarget sh64*-*-*] {
|
|
if [istarget sh64*l*-*-*] {
|
|
set options "-mshlelf32 $options"
|
|
} else {
|
|
set options "-mshelf32 $options"
|
|
}
|
|
}
|
|
|
|
if { [ld_link $ld tmpdir/common1.o $options] } {
|
|
unresolved $test1w1
|
|
return
|
|
}
|
|
|
|
# This test fails on MIPS because the backend sets type_change_ok.
|
|
# The size change warning is suppressed. Same on hppa64.
|
|
if {[istarget mips*-*-*] || [istarget hppa*64*-*-*]} {
|
|
if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
|
|
fail $test1w1
|
|
} else {
|
|
pass $test1w1
|
|
}
|
|
} else {
|
|
if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
|
|
|| ![regexp "Warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
|
|
fail $test1w1
|
|
} else {
|
|
pass $test1w1
|
|
}
|
|
}
|
|
|
|
if { [dump_common1 $test1c1] } {
|
|
pass $test1c1
|
|
}
|
|
|
|
set options "-r tmpdir/common1b.o tmpdir/common1a.o"
|
|
|
|
# SH64 targets needs an extra ld option for this test.
|
|
if [istarget sh64*-*-*] {
|
|
if [istarget sh64*l*-*-*] {
|
|
set options "-mshlelf32 $options"
|
|
} else {
|
|
set options "-mshelf32 $options"
|
|
}
|
|
}
|
|
|
|
if { [ld_link $ld tmpdir/common1.o $options] } {
|
|
unresolved $test1w2
|
|
return
|
|
}
|
|
|
|
if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
|
|
fail $test1w2
|
|
} else {
|
|
pass $test1w2
|
|
}
|
|
|
|
if { [dump_common1 $test1c2] } {
|
|
pass $test1c2
|
|
}
|
|
|
|
#
|
|
# The following tests are for when we are generating STT_COMMON symbols only.
|
|
#
|
|
# Handling of -z common and -z nocommon flags is enabled only if
|
|
# $GENERATE_SHLIB_SCRIPT is turned on in emulparams i.e. shared
|
|
# libraries are supported.
|
|
|
|
if ![check_shared_lib_support] {
|
|
return
|
|
}
|
|
|
|
stt_common_test "-static -e 0" "static link of common symbols"
|
|
stt_common_test "-shared" "shared link of common symbols"
|
|
stt_common_test "-pie" "position independent link of common symbols"
|
|
|
|
run_ld_link_tests [list \
|
|
[list \
|
|
"Build common-3x.o" \
|
|
"-r" "" "--elf-stt-common=no" \
|
|
{common-1.s} {} "common-3x.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3y.o" \
|
|
"-r" "" "--elf-stt-common=yes" \
|
|
{common-1.s} {} "common-3y.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3a.o" \
|
|
"-r tmpdir/common-3x.o tmpdir/common-3y.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3a.rd}} "common-3a.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3b.o" \
|
|
"-r tmpdir/common-3y.o tmpdir/common-3x.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3b.rd}} "common-3b.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3c.o" \
|
|
"-r -z nocommon tmpdir/common-3x.o tmpdir/common-3y.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3a.rd}} "common-3c.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3d.o" \
|
|
"-r -z common tmpdir/common-3x.o tmpdir/common-3y.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3b.rd}} "common-3b.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3e.o" \
|
|
"-r -z common tmpdir/common-3y.o tmpdir/common-3x.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3b.rd}} "common-3e.o" \
|
|
] \
|
|
[list \
|
|
"Build common-3f.o" \
|
|
"-r -z nocommon tmpdir/common-3y.o tmpdir/common-3x.o" "" "" \
|
|
{dummy.s} {{readelf {-s -W} common-3a.rd}} "common-3f.o" \
|
|
] \
|
|
]
|
|
|
|
set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
|
|
foreach t $test_list {
|
|
# We need to strip the ".d", but can leave the dirname.
|
|
verbose [file rootname $t]
|
|
run_dump_test [file rootname $t]
|
|
}
|