mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
190852c8ac
On Windows, starting a new process with GDBserver seems to work,
in the sense that the program does get started, and GDBserver
confirms that it is listening for GDB to connect. However, as soon as
GDB establishes the connection with GDBserver, and starts discussing
with it, GDBserver crashes, with a SEGV.
This SEGV occurs in remote-utils.c::prepare_resume_reply...
| regp = current_target_desc ()->expedite_regs;
| [...]
| while (*regp)
... because, in our case, REGP is NULL.
This patches fixes the issues by adding a parameter to init_target_desc,
in order to make sure that we always provide the list of registers when
we initialize a target description.
gdb/ChangeLog:
PR server/23158:
* regformats/regdat.sh: Adjust script, following the addition
of the new expedite_regs parameter to init_target_desc.
gdb/gdbserver/ChangeLog:
PR server/23158:
* tdesc.h (init_target_desc) <expedite_regs>: New parameter.
* tdesc.c (init_target_desc) <expedite_regs>: New parameter.
Use it to set the expedite_regs field in the given tdesc.
* x86-tdesc.h: New file.
* linux-aarch64-tdesc.c (aarch64_linux_read_description):
Adjust following the addition of the new expedite_regs parameter
to init_target_desc.
* linux-tic6x-low.c (tic6x_read_description): Likewise.
* linux-x86-tdesc.c: #include "x86-tdesc.h".
(i386_linux_read_description, amd64_linux_read_description):
Adjust following the addition of the new expedite_regs parameter
to init_target_desc.
* lynx-i386-low.c: #include "x86-tdesc.h".
(lynx_i386_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
* nto-x86-low.c: #include "x86-tdesc.h".
(nto_x86_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
* win32-i386-low.c: #include "x86-tdesc.h".
(i386_arch_setup): Adjust following the addition of the new
expedite_regs parameter to init_target_desc.
97 lines
2.8 KiB
C++
97 lines
2.8 KiB
C++
/* Target description definitions for remote server for GDB.
|
|
Copyright (C) 2012-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef TDESC_H
|
|
#define TDESC_H
|
|
|
|
#include "common/tdesc.h"
|
|
|
|
#include "regdef.h"
|
|
#include <vector>
|
|
|
|
/* A target description. Inherit from tdesc_feature so that target_desc
|
|
can be used as tdesc_feature. */
|
|
|
|
struct target_desc : tdesc_element
|
|
{
|
|
/* A vector of elements of register definitions that
|
|
describe the inferior's register set. */
|
|
std::vector<struct reg> reg_defs;
|
|
|
|
/* The register cache size, in bytes. */
|
|
int registers_size;
|
|
|
|
/* XML features in this target description. */
|
|
std::vector<tdesc_feature_up> features;
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
/* An array of register names. These are the "expedite" registers:
|
|
registers whose values are sent along with stop replies. */
|
|
const char **expedite_regs = NULL;
|
|
|
|
/* Defines what to return when looking for the "target.xml" file in
|
|
response to qXfer:features:read. Its contents can either be
|
|
verbatim XML code (prefixed with a '@') or else the name of the
|
|
actual XML file to be used in place of "target.xml".
|
|
|
|
If NULL then its content will be generated by parsing the target
|
|
description into xml. */
|
|
mutable const char *xmltarget = NULL;
|
|
|
|
/* The value of <architecture> element in the XML, replying GDB. */
|
|
const char *arch = NULL;
|
|
|
|
/* The value of <osabi> element in the XML, replying GDB. */
|
|
const char *osabi = NULL;
|
|
|
|
public:
|
|
target_desc ()
|
|
: registers_size (0)
|
|
{}
|
|
|
|
~target_desc ();
|
|
|
|
bool operator== (const target_desc &other) const;
|
|
|
|
bool operator!= (const target_desc &other) const
|
|
{
|
|
return !(*this == other);
|
|
}
|
|
#endif
|
|
|
|
void accept (tdesc_element_visitor &v) const override;
|
|
};
|
|
|
|
/* Copy target description SRC to DEST. */
|
|
|
|
void copy_target_description (struct target_desc *dest,
|
|
const struct target_desc *src);
|
|
|
|
/* Initialize TDESC, and then set its expedite_regs field to
|
|
EXPEDITE_REGS. */
|
|
|
|
void init_target_desc (struct target_desc *tdesc,
|
|
const char **expedite_regs);
|
|
|
|
/* Return the current inferior's target description. Never returns
|
|
NULL. */
|
|
|
|
const struct target_desc *current_target_desc (void);
|
|
|
|
#endif /* TDESC_H */
|