binutils-gdb/gdbserver
Simon Marchi 7b961964f8 gdbserver: hide fork child threads from GDB
This patch aims at fixing a bug where an inferior is unexpectedly
created when a fork happens at the same time as another event, and that
other event is reported to GDB first (and the fork event stays pending
in GDBserver).  This happens for example when we step a thread and
another thread forks at the same time.  The bug looks like (if I
reproduce the included test by hand):

    (gdb) show detach-on-fork
    Whether gdb will detach the child of a fork is on.
    (gdb) show follow-fork-mode
    Debugger response to a program call of fork or vfork is "parent".
    (gdb) si
    [New inferior 2]
    Reading /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.threads/step-while-fork-in-other-thread/step-while-fork-in-other-thread from remote target...
    Reading /home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.threads/step-while-fork-in-other-thread/step-while-fork-in-other-thread from remote target...
    Reading symbols from target:/home/simark/build/binutils-gdb/gdb/testsuite/outputs/gdb.threads/step-while-fork-in-other-thread/step-while-fork-in-other-thread...
    [New Thread 965190.965190]
    [Switching to Thread 965190.965190]
    Remote 'g' packet reply is too long (expected 560 bytes, got 816 bytes): ... <long series of bytes>

The sequence of events leading to the problem is:

 - We are using the all-stop user-visible mode as well as the
   synchronous / all-stop variant of the remote protocol
 - We have two threads, thread A that we single-step and thread B that
   calls fork at the same time
 - GDBserver's linux_process_target::wait pulls the "single step
   complete SIGTRAP" and the "fork" events from the kernel.  It
   arbitrarily choses one event to report, it happens to be the
   single-step SIGTRAP.  The fork stays pending in the thread_info.
 - GDBserver send that SIGTRAP as a stop reply to GDB
 - While in stop_all_threads, GDB calls update_thread_list, which ends
   up querying the remote thread list using qXfer:threads:read.
 - In the reply, GDBserver includes the fork child created as a result
   of thread B's fork.
 - GDB-side, the remote target sees the new PID, calls
   remote_notice_new_inferior, which ends up unexpectedly creating a new
   inferior, and things go downhill from there.

The problem here is that as long as GDB did not process the fork event,
it should pretend the fork child does not exist.  Ultimately, this event
will be reported, we'll go through follow_fork, and that process will be
detached.

The remote target (GDB-side), has some code to remove from the reported
thread list the threads that are the result of forks not processed by
GDB yet.  But that only works for fork events that have made their way
to the remote target (GDB-side), but haven't been consumed by the core
yet, so are still lingering as pending stop replies in the remote target
(see remove_new_fork_children in remote.c).  But in our case, the fork
event hasn't made its way to the GDB-side remote target.  We need to
implement the same kind of logic GDBserver-side: if there exists a
thread / inferior that is the result of a fork event GDBserver hasn't
reported yet, it should exclude that thread / inferior from the reported
thread list.

This was actually discussed a while ago, but not implemented AFAIK:

    https://pi.simark.ca/gdb-patches/1ad9f5a8-d00e-9a26-b0c9-3f4066af5142@redhat.com/#t
    https://sourceware.org/pipermail/gdb-patches/2016-June/133906.html

Implementation details-wise, the fix for this is all in GDBserver.  The
Linux layer of GDBserver already tracks unreported fork parent / child
relationships using the lwp_info::fork_relative, in order to avoid
wildcard actions resuming fork childs unknown to GDB.  This information
needs to be made available to the handle_qxfer_threads_worker function,
so it can filter the reported threads.  Add a new thread_pending_parent
target function that allows the Linux target to return the parent of an
eventual fork child.

Testing-wise, the test replicates pretty-much the sequence of events
shown above.  The setup of the test makes it such that the main thread
is about to fork.  We stepi the other thread, so that the step completes
very quickly, in a single event.  Meanwhile, the main thread is resumed,
so very likely has time to call fork.  This means that the bug may not
reproduce every time (if the main thread does not have time to call
fork), but it will reproduce more often than not.  The test fails
without the fix applied on the native-gdbserver and
native-extended-gdbserver boards.

At some point I suspected that which thread called fork and which thread
did the step influenced the order in which the events were reported, and
therefore the reproducibility of the bug.  So I made the test try  both
combinations: main thread forks while other thread steps, and vice
versa.  I'm not sure this is still necessary, but I left it there
anyway.  It doesn't hurt to test a few more combinations.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28288
Change-Id: I2158d5732fc7d7ca06b0eb01f88cf27bf527b990
2021-12-08 21:00:39 -05:00
..
.dir-locals.el gdb: additional settings for emacs in .dir-locals.el 2021-05-17 20:47:46 +01:00
.gitattributes
.gitignore
acinclude.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
aclocal.m4 gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
ax.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
ax.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
ChangeLog-2002-2021 gdb: move remaining ChangeLogs to legacy files 2021-07-26 12:20:33 +01:00
config.in Fix build on rhES5 2021-11-09 08:21:18 -07:00
configure Fix build on rhES5 2021-11-09 08:21:18 -07:00
configure.ac gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS 2021-06-19 23:06:01 -04:00
configure.srv gdb: or1k: implement gdb server 2021-10-29 05:22:12 +09:00
debug.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
debug.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
dll.cc gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
dll.h gdbserver: convert the global dll list into a process_info field 2021-03-22 09:18:04 +01:00
fork-child.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
gdb_proc_service.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
gdbreplay.cc Remove WinCE code from gdbreplay 2021-04-13 22:18:24 +01:00
gdbthread.h gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
hostio.cc Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
hostio.h Remove process_stratum_target::hostio_last_error abstraction 2021-04-13 13:26:44 +01:00
i387-fp.cc [gdb/tdep] Fix avx512 -m32 support in gdbserver 2021-12-02 18:20:13 +01:00
i387-fp.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
inferiors.cc gdbserver: make thread_info non-POD 2021-10-21 16:10:54 -04:00
inferiors.h gdb: make inferior::m_cwd an std::string 2021-07-23 15:38:54 -04:00
linux-aarch32-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-low.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch32-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-aarch64-ipa.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-low.cc [AArch64] Make gdbserver register set selection dynamic 2021-11-03 09:50:53 -03:00
linux-aarch64-tdesc.cc AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-aarch64-tdesc.h AArch64: Add target description/feature for MTE registers 2021-03-24 14:52:08 -03:00
linux-amd64-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-arm-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-i386-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ia64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-low.cc gdbserver: hide fork child threads from GDB 2021-12-08 21:00:39 -05:00
linux-low.h gdbserver: hide fork child threads from GDB 2021-12-08 21:00:39 -05:00
linux-m68k-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-mips-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-nios2-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-or1k-low.cc gdb: or1k: implement gdb server 2021-10-29 05:22:12 +09:00
linux-ppc-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ppc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-ppc-tdesc-init.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-riscv-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-s390-ipa.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-s390-low.cc gdb: fix some indentation issues 2021-05-27 15:01:28 -04:00
linux-s390-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-sh-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-sparc-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-tic6x-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-x86-low.cc gdb: make some variables static 2021-01-20 20:55:05 -05:00
linux-x86-tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-x86-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
linux-xtensa-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
Makefile.in Remove config.cache in gdbserver's "distclean" 2021-11-16 09:13:24 -07:00
mem-break.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
mem-break.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-aarch64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-amd64-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-i386-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
netbsd-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
netbsd-low.h gdbserver: constify the 'pid_to_exec_file' target op 2021-04-12 16:36:25 +02:00
notif.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
notif.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
proc-service.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
proc-service.list Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
README
regcache.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
regcache.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
remote-utils.cc gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
remote-utils.h gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
server.cc gdbserver: hide fork child threads from GDB 2021-12-08 21:00:39 -05:00
server.h GDBserver remote packet support for memory tagging 2021-03-24 14:49:21 -03:00
symbol.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
target.cc gdbserver: hide fork child threads from GDB 2021-12-08 21:00:39 -05:00
target.h gdbserver: hide fork child threads from GDB 2021-12-08 21:00:39 -05:00
tdesc.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
thread-db.cc Remove defaulted 'tid' parameter to ptid_t constructor 2021-09-23 09:30:54 -06:00
tracepoint.cc gdbserver: make target_pid_to_str return std::string 2021-10-25 14:33:55 -04:00
tracepoint.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
utils.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
utils.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
win32-i386-low.cc Fix x86_64 mingw build 2021-05-03 12:40:19 -06:00
win32-low.cc gdb, gdbserver: make target_waitstatus safe 2021-10-21 16:13:56 -04:00
win32-low.h Remove unused declaration from gdbserver/win32-low.h 2021-09-07 12:17:42 -06:00
x86-low.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
x86-low.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
x86-tdesc.h Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00
xtensa-xtregs.cc Update copyright year range in all GDB files 2021-01-01 12:12:21 +04:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.