Go to file
Tom de Vries 49fa1332a6 [gdb/symtab] Fix segfault in search_one_symtab
PR28539 describes a segfault in lambda function search_one_symtab due to
psymbol_functions::expand_symtabs_matching calling expansion_notify with a
nullptr symtab:
...
          struct compunit_symtab *symtab =
            psymtab_to_symtab (objfile, ps);

          if (expansion_notify != NULL)
            if (!expansion_notify (symtab))
              return false;
...

This happens as follows.  The partial symtab ps is a dwarf2_include_psymtab
for some header file:
...
(gdb) p ps.filename
$5 = 0x64fcf80 "/usr/include/c++/11/bits/stl_construct.h"
...

The includer of ps is a shared symtab for a partial unit, with as user:
...
(gdb) p ps.includer().user.filename
$11 = 0x64fc9f0 \
  "/usr/src/debug/llvm13-13.0.0-1.2.x86_64/tools/clang/lib/AST/Decl.cpp"
...

The call to psymtab_to_symtab expands the Decl.cpp symtab (and consequently
the shared symtab), but returns nullptr because:
...
struct dwarf2_include_psymtab : public partial_symtab
{
  ...
  compunit_symtab *get_compunit_symtab (struct objfile *objfile) const override
  {
    return nullptr;
  }
...

Fix this by returning the Decl.cpp symtab instead, which fixes the segfault
in the PR.

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28539
2021-11-29 16:19:16 +01:00
bfd Automatic date update in version.in 2021-11-29 00:00:09 +00:00
binutils Update description of string's -n option. 2021-11-29 14:52:42 +00:00
config Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
contrib Import mklog.py from gcc repo 2020-09-25 10:24:44 -04:00
cpu Re: opcodes: constify & local meps macros 2021-07-05 21:40:49 +09:30
elfcpp arm: add armv9-a architecture to -march 2021-11-01 10:51:03 +00:00
etc etc: switch to automake 2021-09-09 23:30:12 -04:00
gas PR28629 NIOS2 fallout 2021-11-29 09:29:29 +10:30
gdb [gdb/symtab] Fix segfault in search_one_symtab 2021-11-29 16:19:16 +01:00
gdbserver gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
gdbsupport gdb: introduce target_waitkind_str, use it in target_waitstatus::to_string 2021-11-22 13:57:49 -05:00
gnulib gnulib: import various network functions 2021-09-08 17:48:09 -04:00
gold Update bug reporting address 2021-11-23 15:39:26 +10:30
gprof Update bug reporting address 2021-11-23 15:39:26 +10:30
include opcodes/riscv: add disassembler options support to libopcodes 2021-11-26 10:18:35 +00:00
intl Regenerate a couple of files 2021-11-15 12:20:12 +10:30
ld Fix ifunc test fails on hppa*-*-* 2021-11-26 21:42:16 +00:00
libbacktrace sync libbacktrace from gcc 2021-11-14 18:07:50 +10:30
libctf doc/ctf-spec.texi: Remove "@validatemenus off" 2021-11-09 05:35:42 -08:00
libdecnumber Run autoreconf -vf throughout 2020-07-29 16:03:55 -04:00
libiberty Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
opcodes opcodes/riscv: add disassembler options support to libopcodes 2021-11-26 10:18:35 +00:00
readline Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
sim sim: testsuite: drop most specific istarget checks 2021-11-28 21:55:16 -05:00
texinfo
zlib configure: regenerate in all projects that use libtool.m4 2021-09-27 20:31:24 +01:00
.cvsignore
.gitattributes
.gitignore Add gnu global outputs to .gitignore 2020-12-02 10:00:27 -05:00
ar-lib
ChangeLog Document "memory-tag-violations". 2021-10-29 13:31:37 +03:00
compile
config-ml.in
config.guess Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
config.rpath
config.sub Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
configure top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
configure.ac top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4 libtool.m4: fix nm BSD flag detection 2021-09-27 20:31:23 +01:00
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS MAINTAINERS: Update path to readline config.{sub,guess} files 2021-05-24 18:11:49 +02:00
Makefile.def Import Makefile.def from gcc 2021-11-12 19:02:12 +10:30
Makefile.in Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
Makefile.tpl Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS 2021-09-28 12:21:21 +01:00
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.