mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
4dfef5be68
As follow-up to this discussion: https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html ... make runto_main not pass no-message to runto. This means that if we fail to run to main, for some reason, we'll emit a FAIL. This is the behavior we want the majority of (if not all) the time. Without this, we rely on tests logging a failure if runto_main fails, otherwise. They do so in a very inconsisteny mannet, sometimes using "fail", "unsupported" or "untested". The messages also vary widly. This patch removes all these messages as well. Also, remove a few "fail" where we call runto (and not runto_main). by default (without an explicit no-message argument), runto prints a failure already. In two places, gdb.multi/multi-re-run.exp and gdb.python/py-pp-registration.exp, remove "message" passed to runto. This removes a few PASSes that we don't care about (but FAILs will still be printed if we fail to run to where we want to). This aligns their behavior with the rest of the testsuite. Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
96 lines
3.1 KiB
Plaintext
96 lines
3.1 KiB
Plaintext
# Copyright 2013-2021 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
load_lib "ada.exp"
|
|
|
|
if { [skip_ada_tests] } { return -1 }
|
|
|
|
standard_ada_testfile foo
|
|
|
|
if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-bargs additional_flags=-static additional_flags=-margs ]] != "" } {
|
|
return -1
|
|
}
|
|
|
|
# # Some global variables used to simplify the maintenance of some of
|
|
# # the regular expressions below.
|
|
set any_nb "\[0-9\]+"
|
|
set eol "\[\r\n\]+"
|
|
|
|
# Before going any further, verify that we can insert exception
|
|
# catchpoints... That way, we won't have to do this while doing
|
|
# the actual GDB/MI testing.
|
|
|
|
clean_restart ${testfile}
|
|
|
|
if ![runto_main] then {
|
|
return 0
|
|
}
|
|
|
|
set msg "insert catchpoint on all Ada exceptions"
|
|
gdb_test_multiple "catch exception" $msg {
|
|
-re "Catchpoint $any_nb: all Ada exceptions$eol$gdb_prompt $" {
|
|
pass $msg
|
|
}
|
|
-re "Your Ada runtime appears to be missing some debugging information.*\[\r\n\]+$gdb_prompt $" {
|
|
# If the runtime was not built with enough debug information,
|
|
# or if it was stripped, we can not test exception
|
|
# catchpoints.
|
|
unsupported $msg
|
|
return -1
|
|
}
|
|
}
|
|
|
|
# Now, we can start the GDB/MI testing itself...
|
|
|
|
load_lib mi-support.exp
|
|
set MIFLAGS "-i=mi"
|
|
|
|
gdb_exit
|
|
if [mi_gdb_start] {
|
|
continue
|
|
}
|
|
|
|
mi_delete_breakpoints
|
|
mi_gdb_reinitialize_dir $srcdir/$subdir
|
|
mi_gdb_load ${binfile}
|
|
|
|
# And finally, the meat of the testcase... Insert an Ada exception
|
|
# catchpoint that uses both conditions and exception name.
|
|
|
|
mi_gdb_test "-catch-exception -c \"i = 2\" -e constraint_error" \
|
|
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",what=\"`constraint_error' Ada exception\",.*,cond=\"i = 2\",.*}" \
|
|
"catch C_E if i = 2"
|
|
|
|
# It is important that we start the program's execution after having
|
|
# inserted the exception catchpoint above. We want to verify that
|
|
# we are able to re-evaluate the exception catchpoint exception
|
|
# address and stop condition without problems when new shared libraries
|
|
# get mapped (during program startup).
|
|
|
|
mi_run_cmd
|
|
|
|
mi_expect_stop \
|
|
"breakpoint-hit\",disp=\"keep\",bkptno=\"$any_nb\",exception-name=\"CONSTRAINT_ERROR(\",exception-message=\"foo\\.adb:$decimal explicit raise)?" \
|
|
"foo" "" ".*" ".*" \
|
|
".*" \
|
|
"run to exception catchpoint hit"
|
|
|
|
# Make sure that any of the catchpoint re-evaluations didn't cause
|
|
# a clobbering of some of the exeption's info.
|
|
|
|
mi_gdb_test "-break-list" \
|
|
"\\^done,.*,what=\"`constraint_error' Ada exception\",.*,cond=\"i = 2\",.*" \
|
|
"-break-list"
|