mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
200fd2874d
While working on a later patch that required me to understand how GDB
starts up inferiors, I was confused by the
target_ops::post_startup_inferior method.
The post_startup_inferior target function is only called from
inf_ptrace_target::create_inferior.
Part of the target class hierarchy looks like this:
inf_child_target
|
'-- inf_ptrace_target
|
|-- linux_nat_target
|
|-- fbsd_nat_target
|
|-- nbsd_nat_target
|
|-- obsd_nat_target
|
'-- rs6000_nat_target
Every sub-class of inf_ptrace_target, except rs6000_nat_target,
implements ::post_startup_inferior. The rs6000_nat_target picks up
the implementation of ::post_startup_inferior not from
inf_ptrace_target, but from inf_child_target.
No descendent of inf_child_target, outside the inf_ptrace_target
sub-tree, implements ::post_startup_inferior, which isn't really
surprising, as they would never see the method called (remember, the
method is only called from inf_ptrace_target::create_inferior).
What I find confusing is the role inf_child_target plays in
implementing, what is really a helper function for just one of its
descendents.
In this commit I propose that we formally make ::post_startup_inferior
a helper function of inf_ptrace_target. To do this I will remove the
::post_startup_inferior from the target_ops API, and instead make this
a protected, pure virtual function on inf_ptrace_target.
I'll remove the empty implementation of ::post_startup_inferior from
the inf_child_target class, and add a new empty implementation to the
rs6000_nat_target class.
All the other descendents of inf_ptrace_target already provide an
implementation of this method and so don't need to change beyond
making the method protected within their class declarations.
To me, this makes much more sense now. The helper function, which is
only called from within the inf_ptrace_target class, is now a part of
the inf_ptrace_target class.
The only way in which this change is visible to a user is if the user
turns on 'set debug target 1'. With this debug flag on, prior to this
patch the user would see something like:
-> native->post_startup_inferior (...)
<- native->post_startup_inferior (2588939)
After this patch these lines are no longer present, as the
post_startup_inferior is no longer a top level target method. For me,
this is an acceptable change.
87 lines
2.6 KiB
C++
87 lines
2.6 KiB
C++
/* Low level child interface to ptrace.
|
|
|
|
Copyright (C) 2004-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef INF_PTRACE_H
|
|
#define INF_PTRACE_H
|
|
|
|
#include "inf-child.h"
|
|
|
|
/* An abstract prototype ptrace target. The client can override it
|
|
with local methods. */
|
|
|
|
struct inf_ptrace_target : public inf_child_target
|
|
{
|
|
~inf_ptrace_target () override = 0;
|
|
|
|
void attach (const char *, int) override;
|
|
|
|
void detach (inferior *inf, int) override;
|
|
|
|
void resume (ptid_t, int, enum gdb_signal) override;
|
|
|
|
ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override;
|
|
|
|
void files_info () override;
|
|
|
|
void kill () override;
|
|
|
|
void create_inferior (const char *, const std::string &,
|
|
char **, int) override;
|
|
|
|
void mourn_inferior () override;
|
|
|
|
bool thread_alive (ptid_t ptid) override;
|
|
|
|
std::string pid_to_str (ptid_t) override;
|
|
|
|
enum target_xfer_status xfer_partial (enum target_object object,
|
|
const char *annex,
|
|
gdb_byte *readbuf,
|
|
const gdb_byte *writebuf,
|
|
ULONGEST offset, ULONGEST len,
|
|
ULONGEST *xfered_len) override;
|
|
|
|
protected:
|
|
/* Cleanup the inferior after a successful ptrace detach. */
|
|
void detach_success (inferior *inf);
|
|
|
|
/* Some targets don't allow us to request notification of inferior events
|
|
such as fork and vfork immediately after the inferior is created.
|
|
(This is because of how gdb creates inferiors via invoking a shell to
|
|
do it. In such a scenario, if the shell init file has commands in it,
|
|
the shell will fork and exec for each of those commands, and we will
|
|
see each such fork event. Very bad.)
|
|
|
|
Such targets will supply an appropriate definition for this
|
|
function. */
|
|
virtual void post_startup_inferior (ptid_t ptid) = 0;
|
|
};
|
|
|
|
#ifndef __NetBSD__
|
|
/* Return which PID to pass to ptrace in order to observe/control the
|
|
tracee identified by PTID.
|
|
|
|
Unlike most other Operating Systems, NetBSD tracks both pid and lwp
|
|
and avoids this function. */
|
|
|
|
extern pid_t get_ptrace_pid (ptid_t);
|
|
#endif
|
|
|
|
#endif
|