mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
f08708cbf5
I finally got the all-targets sim building with Clang, these are all the
instances where an ATTRIBUTE_PRINTF or ATTRIBUTE_NULL_PRINTF attribute
needed to be added to avoid errors like:
/home/simark/src/binutils-gdb/sim/aarch64/../common/sim-profile.c:464:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf (fp, fmt, ap);
^~~
There are more fixes needed to get everything building, but adding these
attributes is trivial enough, so I send them all in a single patch.
Adding the format attributes introduces some format string errors when
building with GCC (because now format strings are checked), so
corresponding changes are needed to avoid breaking the build. Other
than simple format string specified changes, there is this one:
/home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c: In function 'hw_event_queue_schedule':
/home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c:95:15: error: too many arguments for format [-Werror=format-extra-args]
95 | NULL, dummy);
| ^~~~~
We can fix it and avoid using a dummy variable by simply calling
hw_event_queue_schedule_tracef instead of
hw_event_queue_schedule_vtracef.
sim/arm/ChangeLog:
* armdefs.h (ARMul_ConsolePrint): Use format attribute.
* wrapper.c (op_printf): Likewise.
sim/bfin/ChangeLog:
* interp.c (sim_open): Adjust format string specifier.
sim/common/ChangeLog:
* hw-events.h (hw_event_queue_schedule_tracef): Use format attribute.
(hw_event_queue_schedule_vtracef): Likewise.
* hw-tree.h (hw_tree_vparse): Likewise.
* sim-profile.c (profile_vprintf): Likewise.
* sim-trace.c (dis_printf): Likewise.
* sim-trace.h (trace_printf): Likewise.
(trace_vprintf): Likewise.
* sim-utils.h (sim_do_commandf): Likewise.
* hw-events.c (hw_event_queue_schedule): Use
hw_event_queue_schedule_tracef.
sim/rx/ChangeLog:
* trace.c (op_printf): Likewise.
sim/v850/ChangeLog:
* interp.c (sim_open): Adjust format string specifier.
Change-Id: I1445115ce57db15bb8e35dca93014555e7555794
65 lines
1.7 KiB
C
65 lines
1.7 KiB
C
/* Hardware event manager.
|
|
Copyright (C) 1998-2021 Free Software Foundation, Inc.
|
|
Contributed by Cygnus Support.
|
|
|
|
This file is part of GDB, the GNU debugger.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef HW_EVENTS_H
|
|
#define HW_EVENTS_H
|
|
|
|
/* Event manager customized for hardware models.
|
|
|
|
This interface is discussed further in sim-events.h. */
|
|
|
|
struct hw_event;
|
|
typedef void (hw_event_callback) (struct hw *me, void *data);
|
|
|
|
struct hw_event *hw_event_queue_schedule
|
|
(struct hw *me,
|
|
signed64 delta_time,
|
|
hw_event_callback *handler,
|
|
void *data);
|
|
|
|
struct hw_event *hw_event_queue_schedule_tracef
|
|
(struct hw *me,
|
|
signed64 delta_time,
|
|
hw_event_callback *handler,
|
|
void *data,
|
|
const char *fmt,
|
|
...) ATTRIBUTE_NULL_PRINTF (5, 6);
|
|
|
|
struct hw_event *hw_event_queue_schedule_vtracef
|
|
(struct hw *me,
|
|
signed64 delta_time,
|
|
hw_event_callback *handler,
|
|
void *data,
|
|
const char *fmt,
|
|
va_list ap) ATTRIBUTE_NULL_PRINTF (5, 0);
|
|
|
|
|
|
void hw_event_queue_deschedule
|
|
(struct hw *me,
|
|
struct hw_event *event_to_remove);
|
|
|
|
signed64 hw_event_queue_time
|
|
(struct hw *me);
|
|
|
|
/* Returns the time that remains before the event is raised. */
|
|
signed64 hw_event_remain_time
|
|
(struct hw *me, struct hw_event *event);
|
|
|
|
#endif
|