mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
200fd2874d
While working on a later patch that required me to understand how GDB
starts up inferiors, I was confused by the
target_ops::post_startup_inferior method.
The post_startup_inferior target function is only called from
inf_ptrace_target::create_inferior.
Part of the target class hierarchy looks like this:
inf_child_target
|
'-- inf_ptrace_target
|
|-- linux_nat_target
|
|-- fbsd_nat_target
|
|-- nbsd_nat_target
|
|-- obsd_nat_target
|
'-- rs6000_nat_target
Every sub-class of inf_ptrace_target, except rs6000_nat_target,
implements ::post_startup_inferior. The rs6000_nat_target picks up
the implementation of ::post_startup_inferior not from
inf_ptrace_target, but from inf_child_target.
No descendent of inf_child_target, outside the inf_ptrace_target
sub-tree, implements ::post_startup_inferior, which isn't really
surprising, as they would never see the method called (remember, the
method is only called from inf_ptrace_target::create_inferior).
What I find confusing is the role inf_child_target plays in
implementing, what is really a helper function for just one of its
descendents.
In this commit I propose that we formally make ::post_startup_inferior
a helper function of inf_ptrace_target. To do this I will remove the
::post_startup_inferior from the target_ops API, and instead make this
a protected, pure virtual function on inf_ptrace_target.
I'll remove the empty implementation of ::post_startup_inferior from
the inf_child_target class, and add a new empty implementation to the
rs6000_nat_target class.
All the other descendents of inf_ptrace_target already provide an
implementation of this method and so don't need to change beyond
making the method protected within their class declarations.
To me, this makes much more sense now. The helper function, which is
only called from within the inf_ptrace_target class, is now a part of
the inf_ptrace_target class.
The only way in which this change is visible to a user is if the user
turns on 'set debug target 1'. With this debug flag on, prior to this
patch the user would see something like:
-> native->post_startup_inferior (...)
<- native->post_startup_inferior (2588939)
After this patch these lines are no longer present, as the
post_startup_inferior is no longer a top level target method. For me,
this is an acceptable change.
155 lines
4.8 KiB
C++
155 lines
4.8 KiB
C++
/* Native-dependent code for FreeBSD.
|
|
|
|
Copyright (C) 2004-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef FBSD_NAT_H
|
|
#define FBSD_NAT_H
|
|
|
|
#include "inf-ptrace.h"
|
|
#include "regcache.h"
|
|
#include "regset.h"
|
|
#include <osreldate.h>
|
|
#include <sys/proc.h>
|
|
|
|
/* FreeBSD kernels 11.3 and later report valid si_code values for
|
|
SIGTRAP on all architectures. Older FreeBSD kernels that supported
|
|
TRAP_BRKPT did not report valid values for MIPS and sparc64. Even
|
|
older kernels without TRAP_BRKPT support did not report valid
|
|
values on any architecture. */
|
|
#if (__FreeBSD_kernel_version >= 1102502) || (__FreeBSD_version >= 1102502)
|
|
# define USE_SIGTRAP_SIGINFO
|
|
#elif defined(TRAP_BRKPT)
|
|
# if !defined(__mips__) && !defined(__sparc64__)
|
|
# define USE_SIGTRAP_SIGINFO
|
|
# endif
|
|
#endif
|
|
|
|
/* A prototype FreeBSD target. */
|
|
|
|
class fbsd_nat_target : public inf_ptrace_target
|
|
{
|
|
public:
|
|
char *pid_to_exec_file (int pid) override;
|
|
|
|
int find_memory_regions (find_memory_region_ftype func, void *data) override;
|
|
|
|
bool info_proc (const char *, enum info_proc_what) override;
|
|
|
|
enum target_xfer_status xfer_partial (enum target_object object,
|
|
const char *annex,
|
|
gdb_byte *readbuf,
|
|
const gdb_byte *writebuf,
|
|
ULONGEST offset, ULONGEST len,
|
|
ULONGEST *xfered_len) override;
|
|
|
|
bool thread_alive (ptid_t ptid) override;
|
|
std::string pid_to_str (ptid_t) override;
|
|
|
|
#ifdef HAVE_STRUCT_PTRACE_LWPINFO_PL_TDNAME
|
|
const char *thread_name (struct thread_info *) override;
|
|
#endif
|
|
|
|
void update_thread_list () override;
|
|
|
|
thread_control_capabilities get_thread_control_capabilities () override
|
|
{ return tc_schedlock; }
|
|
|
|
void create_inferior (const char *, const std::string &,
|
|
char **, int) override;
|
|
|
|
void resume (ptid_t, int, enum gdb_signal) override;
|
|
|
|
ptid_t wait (ptid_t, struct target_waitstatus *, target_wait_flags) override;
|
|
|
|
void post_attach (int) override;
|
|
|
|
#ifdef USE_SIGTRAP_SIGINFO
|
|
bool supports_stopped_by_sw_breakpoint () override;
|
|
bool stopped_by_sw_breakpoint () override;
|
|
#endif
|
|
|
|
#ifdef TDP_RFPPWAIT
|
|
void follow_fork (inferior *, ptid_t, target_waitkind, bool, bool) override;
|
|
|
|
int insert_fork_catchpoint (int) override;
|
|
int remove_fork_catchpoint (int) override;
|
|
|
|
int insert_vfork_catchpoint (int) override;
|
|
int remove_vfork_catchpoint (int) override;
|
|
#endif
|
|
|
|
int insert_exec_catchpoint (int) override;
|
|
int remove_exec_catchpoint (int) override;
|
|
|
|
#ifdef HAVE_STRUCT_PTRACE_LWPINFO_PL_SYSCALL_CODE
|
|
int set_syscall_catchpoint (int, bool, int, gdb::array_view<const int>)
|
|
override;
|
|
#endif
|
|
|
|
bool supports_multi_process () override;
|
|
|
|
bool supports_disable_randomization () override;
|
|
|
|
protected:
|
|
|
|
void post_startup_inferior (ptid_t) override;
|
|
|
|
private:
|
|
/* Helper routines for use in fetch_registers and store_registers in
|
|
subclasses. These routines fetch and store a single set of
|
|
registers described by REGSET. The REGSET's 'regmap' field must
|
|
point to an array of 'struct regcache_map_entry'.
|
|
|
|
FETCH_OP is a ptrace operation to fetch the set of registers from
|
|
a native thread. STORE_OP is a ptrace operation to store the set
|
|
of registers to a native thread.
|
|
|
|
The caller must provide storage for the set of registers in REGS,
|
|
and SIZE is the size of the storage. */
|
|
|
|
void fetch_register_set (struct regcache *regcache, int regnum, int fetch_op,
|
|
const struct regset *regset, void *regs, size_t size);
|
|
|
|
void store_register_set (struct regcache *regcache, int regnum, int fetch_op,
|
|
int store_op, const struct regset *regset,
|
|
void *regs, size_t size);
|
|
protected:
|
|
/* Wrapper versions of the above helpers which accept a register set
|
|
type such as 'struct reg' or 'struct fpreg'. */
|
|
|
|
template <class Regset>
|
|
void fetch_register_set (struct regcache *regcache, int regnum, int fetch_op,
|
|
const struct regset *regset)
|
|
{
|
|
Regset regs;
|
|
fetch_register_set (regcache, regnum, fetch_op, regset, ®s,
|
|
sizeof (regs));
|
|
}
|
|
|
|
template <class Regset>
|
|
void store_register_set (struct regcache *regcache, int regnum, int fetch_op,
|
|
int store_op, const struct regset *regset)
|
|
{
|
|
Regset regs;
|
|
store_register_set (regcache, regnum, fetch_op, store_op, regset, ®s,
|
|
sizeof (regs));
|
|
}
|
|
};
|
|
|
|
#endif /* fbsd-nat.h */
|