mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
30add7ee24
I noticed that when running these two tests in sequence: Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ... ERROR: GDB process no longer exists ERROR: Couldn't run foo-all Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ... The results in gdb.sum are: Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ... PASS: gdb.ada/arrayptr.exp: scenario=all: compilation foo.adb ERROR: GDB process no longer exists UNRESOLVED: gdb.ada/arrayptr.exp: scenario=all: gdb_breakpoint: set breakpoint at foo.adb:40 (eof) ERROR: Couldn't run foo-all Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ... UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1 The UNRESOLVED for arrayptr.exp is fine, as GDB crashes in that test, while trying to run to main. However, the UNRESOLVED in assign_1.exp doesn't make sense, GDB behaves as expected in that test: (gdb) set lang ada^M (gdb) UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada print $xxx := 1^M $1 = 1^M (gdb) PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1 The problem is that arrayptr.exp calls perror when failing to run to main, then returns. perror makes it so that the next test (as in pass/fail) will be recorded as UNRESOLVED. However, here, the next test (as in pass/fail) is in the next test (as in .exp). Hence the spurious UNRESOLVED in assign_1.exp. These perror when failing to run to X are not really useful, especially since runto records a FAIL on error, by default. Remove all the perrors on runto failure I could find. When there wasn't one already, add a return statement when failing to run, to avoid running the test of the test unnecessarily. I thought of adding a check ran between test (in gdb_finish probably) where we would emit a warning if errcnt > 0, meaning a test quit and left a perror "active". However, reading that variable would poke into the DejaGNU internals, not sure it's a good idea. Change-Id: I2203df6d06e199540b36f56470d1c5f1dc988f7b
186 lines
4.5 KiB
Plaintext
186 lines
4.5 KiB
Plaintext
# Copyright 1997-2022 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# file to test calls into shared libraries
|
|
# the source files for this test are:
|
|
#
|
|
# shmain.c
|
|
# shr1.c (shared lib)
|
|
# shr2.c (shared lib)
|
|
# ss.h (header for shr2.c)
|
|
#
|
|
# file written by Elena Zannoni: elz@ch.apollo.com
|
|
#
|
|
|
|
#debug shmain
|
|
#prop lib shr1.sl
|
|
#prop lib shr2.sl
|
|
|
|
|
|
if {[skip_shlib_tests]} {
|
|
return 0
|
|
}
|
|
|
|
if { [is_remote host] } {
|
|
gdb_remote_download host $srcdir/$subdir/ss.h
|
|
}
|
|
|
|
standard_testfile shmain.c shr1.c shr2.c
|
|
set srcfile ${srcdir}/${subdir}/${srcfile}
|
|
set lib1src ${srcdir}/${subdir}/${srcfile2}
|
|
set lib2src ${srcdir}/${subdir}/${srcfile3}
|
|
set lib1 [standard_output_file shr1.sl]
|
|
set lib2 [standard_output_file shr2.sl]
|
|
|
|
set lib_opts "debug"
|
|
set exec_opts [list debug shlib=${lib1} shlib=${lib2}]
|
|
|
|
if { [gdb_compile_shlib ${lib1src} ${lib1} $lib_opts] != ""
|
|
|| [gdb_compile_shlib ${lib2src} ${lib2} $lib_opts] != ""
|
|
|| [gdb_compile ${srcfile} ${binfile} executable $exec_opts] != ""} {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
|
|
# Start with a fresh gdb.
|
|
|
|
clean_restart ${binfile}
|
|
gdb_load_shlib $lib1
|
|
gdb_load_shlib $lib2
|
|
|
|
|
|
if {![runto_main]} {
|
|
return
|
|
}
|
|
|
|
|
|
#step -over
|
|
|
|
gdb_test "next 2" "g = shr1\\(g\\);" "next to shr1"
|
|
|
|
#print g
|
|
|
|
gdb_test "print g" "\[0-9\]* = 1"
|
|
|
|
#step -over
|
|
if ![gdb_skip_stdio_test "next over shr1"] {
|
|
gdb_test_stdio "next" \
|
|
"address of sgs is $hex" \
|
|
"g = shr2\\(g\\);" \
|
|
"next over shr1"
|
|
} else {
|
|
gdb_test "next" ".*" ""
|
|
}
|
|
|
|
|
|
#print g
|
|
gdb_test "print g" "\[0-9\]* = 2" "print g two"
|
|
|
|
#print shr1(1)
|
|
if ![gdb_skip_stdio_test "print shr1(1)"] {
|
|
gdb_test_stdio "print shr1(1)" \
|
|
"address of sgs is $hex" \
|
|
"\[0-9\]* = 2" \
|
|
"print shr1(1)"
|
|
}
|
|
|
|
#print shr1(g)
|
|
if ![gdb_skip_stdio_test "print shr1(g)"] {
|
|
gdb_test_stdio "print shr1(g)" \
|
|
"address of sgs is $hex" \
|
|
"\[0-9\]* = 4" \
|
|
"print shr1(g)"
|
|
}
|
|
|
|
#break shr2
|
|
#go
|
|
gdb_test "break shr2" \
|
|
"Breakpoint.*file.*shr2.c, line.*" \
|
|
"breakpoint function shr2"
|
|
|
|
gdb_test "continue" \
|
|
"Continuing\\..*Breakpoint ${decimal}, shr2 \\(.*\\) at.*shr2\\.c:${decimal}.*shr2-return \\*\\/" \
|
|
"run until breakpoint set at a function"
|
|
|
|
|
|
#print shr1(1)
|
|
if ![gdb_skip_stdio_test "print shr1(1) 2nd time"] {
|
|
gdb_test_stdio "print shr1(1)" \
|
|
"address of sgs is $hex" \
|
|
"\[0-9\]* = 2" \
|
|
"print shr1(1) 2nd time"
|
|
}
|
|
|
|
#print mainshr1(1)
|
|
gdb_test "print mainshr1(1)" "\[0-9\]* = 2" \
|
|
"print mainshr1(1) from shlib func"
|
|
|
|
#step -return
|
|
# A step at this point will either take us entirely out of
|
|
# the function or into the function's epilogue. The exact
|
|
# behavior will differ depending upon upon whether or not
|
|
# the compiler emits line number information for the epilogue.
|
|
gdb_test_multiple "step" "step out of shr2 to main" {
|
|
-re "main \\(\\) at.*g = mainshr1\\(g\\);.*$gdb_prompt $" {
|
|
pass "step out of shr2 to main"
|
|
}
|
|
-re ".*\\\}.*$gdb_prompt $" {
|
|
pass "step out of shr2 to main (stopped in shr2 epilogue)"
|
|
gdb_test_multiple "step" "step out of shr2 epilogue to main" {
|
|
-re -wrap "main \\(\\) at.*g = mainshr1\\(g\\);" {
|
|
pass $gdb_test_name
|
|
}
|
|
-re -wrap "main \\(\\) at.*g = shr2\\(g\\);" {
|
|
gdb_test "step" "g = mainshr1\\(g\\);" $gdb_test_name
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#print mainshr1(1)
|
|
gdb_test "print mainshr1(1)" "\[0-9\]* = 2"
|
|
|
|
#step
|
|
gdb_test "step" "mainshr1 \\(g=4\\) at.*return 2.g;" \
|
|
"step into mainshr1"
|
|
|
|
# Start with a fresh gdb.
|
|
|
|
clean_restart $binfile
|
|
|
|
# PR's 16495, 18213
|
|
# test that we can re-set breakpoints in shared libraries
|
|
gdb_breakpoint "shr1" "allow-pending"
|
|
|
|
set test "run to bp in shared library"
|
|
gdb_run_cmd
|
|
gdb_test_multiple "" $test {
|
|
-re "Breakpoint .,.*${gdb_prompt} " {
|
|
pass $gdb_test_name
|
|
}
|
|
}
|
|
|
|
gdb_continue_to_end "" continue 1
|
|
|
|
set test "re-run to bp in shared library (PR's 16495, 18213)"
|
|
gdb_run_cmd
|
|
gdb_test_multiple "" $test {
|
|
-re "Breakpoint .,.*${gdb_prompt} " {
|
|
pass $gdb_test_name
|
|
}
|
|
}
|
|
|
|
gdb_continue_to_end "after re-run" continue 1
|