binutils-gdb/gdb/testsuite/gdb.base/readnever.exp
Simon Marchi 30add7ee24 gdb/testsuite: remove perror calls when failing to run
I noticed that when running these two tests in sequence:

    Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ...
    ERROR: GDB process no longer exists
    ERROR: Couldn't run foo-all
    Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ...

The results in gdb.sum are:

    Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/arrayptr.exp ...
    PASS: gdb.ada/arrayptr.exp: scenario=all: compilation foo.adb
    ERROR: GDB process no longer exists
    UNRESOLVED: gdb.ada/arrayptr.exp: scenario=all: gdb_breakpoint: set breakpoint at foo.adb:40 (eof)
    ERROR: Couldn't run foo-all
    Running /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.ada/assign_1.exp ...
    UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada
    PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1

The UNRESOLVED for arrayptr.exp is fine, as GDB crashes in that test,
while trying to run to main.  However, the UNRESOLVED in assign_1.exp
doesn't make sense, GDB behaves as expected in that test:

    (gdb) set lang ada^M
    (gdb) UNRESOLVED: gdb.ada/assign_1.exp: changing the language to ada
    print $xxx := 1^M
    $1 = 1^M
    (gdb) PASS: gdb.ada/assign_1.exp: set convenience variable $xxx to 1

The problem is that arrayptr.exp calls perror when failing to run to
main, then returns.  perror makes it so that the next test (as in
pass/fail) will be recorded as UNRESOLVED.  However, here, the next test
(as in pass/fail) is in the next test (as in .exp).  Hence the spurious
UNRESOLVED in assign_1.exp.

These perror when failing to run to X are not really useful, especially
since runto records a FAIL on error, by default.  Remove all the
perrors on runto failure I could find.

When there wasn't one already, add a return statement when failing to
run, to avoid running the test of the test unnecessarily.

I thought of adding a check ran between test (in gdb_finish
probably) where we would emit a warning if errcnt > 0, meaning a test
quit and left a perror "active".  However, reading that variable would
poke into the DejaGNU internals, not sure it's a good idea.

Change-Id: I2203df6d06e199540b36f56470d1c5f1dc988f7b
2022-12-05 16:38:24 -05:00

92 lines
2.7 KiB
Plaintext

# Copyright 2016-2022 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
standard_testfile .c
if { [build_executable "failed to build" $testfile $srcfile { debug }] == -1 } {
untested "couldn't compile ${srcfile}"
return -1
}
# See if we have target board readnow.exp or similar.
if { [lsearch -exact $GDBFLAGS -readnow] != -1 \
|| [lsearch -exact $GDBFLAGS --readnow] != -1 } {
untested "--readnever not allowed in combination with --readnow"
return -1
}
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever"
if { [clean_restart ${binfile}] == -1 } {
return -1
}
}
if {![runto_main]} {
return
}
gdb_test "break fun_three" \
"Breakpoint $decimal at $hex"
gdb_test "continue" \
"Breakpoint $decimal, $hex in fun_three \\(\\)"
gdb_test "backtrace" \
[multi_line "#0 $hex in fun_three \\(\\)" \
"#1 $hex in fun_two \\(\\)" \
"#2 $hex in fun_one \\(\\)" \
"#3 $hex in main \\(\\)" ]
gdb_test_no_output "maint info symtabs" \
"maint info symtabs no output for --readnever"
gdb_test_no_output "maint info psymtabs" \
"maint info psymtabs no output for --readnever"
# Test invalid combination of flags.
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever --readnow"
gdb_exit
gdb_spawn
set test "test readnow and readnever at the same time"
gdb_test_multiple "" $test {
"'--readnow' and '--readnever' cannot be specified simultaneously" {
pass $test
set test "expect eof after failure"
gdb_test_multiple "" $test {
eof {
pass $test
}
}
}
}
}
# Test symbol-file's -readnever option.
# Restart GDB without the --readnever option.
gdb_exit
gdb_start
gdb_test "symbol-file ${binfile}0.o -readnever" \
"Reading symbols from ${binfile}0\.o\.\.\.\r\n\\\(No debugging symbols found in .*\\\)" \
"use symbol-file -readnever"
gdb_test_no_output "maint info symtabs" \
"maint info symtabs no output for symbol-file -readnever"
gdb_test_no_output "maint info psymtabs" \
"maint info psymtabs no output for symbol-file -readnever"