binutils-gdb/gdb/gdbserver
Kevin Buettner 3f52fdbcb5 Fix amd64->i386 linux syscall restart problem
This commit fixes some failures in gdb.base/interrupt.exp
when debugging a 32-bit i386 linux inferior from an amd64 host.

When running the following test...

  make check RUNTESTFLAGS="--target_board unix/-m32 interrupt.exp"

... without this commit, I see the following output:

FAIL: gdb.base/interrupt.exp: continue (the program exited)
FAIL: gdb.base/interrupt.exp: echo data
FAIL: gdb.base/interrupt.exp: Send Control-C, second time
FAIL: gdb.base/interrupt.exp: signal SIGINT (the program is no longer running)
ERROR: Undefined command "".
ERROR: GDB process no longer exists

		=== gdb Summary ===

When the test is run with this commit in place, we see 12 passes
instead.  This is the desired behavior.

Analysis:

On Linux, when a syscall is interrupted by a signal, the syscall
may return -ERESTARTSYS when a signal occurs.  Doing so indicates that
the syscall is restartable.  Then, depending on settings associated
with the signal handler, and after the signal handler is called, the
kernel can then either return -EINTR or can cause the syscall to be
restarted.  In this discussion, we are concerned with the latter
case.

On i386, the kernel returns this status via the EAX register.

When debugging a 32-bit (i386) process from a 64-bit (amd64)
GDB, the debugger fetches 64-bit registers even though the
process being debugged is 32-bit.  Since we're debugging a 32-bit
target, only 32 bits are being saved in the register cache.
Now, ideally, GDB would save all 64-bits in the regcache and
then would be able to restore those same values when it comes
time to continue the target.  I've looked into doing this, but
it's not easy and I don't see many benefits to doing so.  One
benefit, however, would be that EAX would appear as a negative
value for doing syscall restarts.

At the moment, GDB is setting the high 32 bits of RAX (and other
registers too) to 0.  So, when GDB restores EAX just prior to
a syscall restart, the high 32 bits of RAX are zeroed, thus making
it look like a positive value.  For this particular purpose, we
need to sign extend EAX so that RAX will appear as a negative
value when EAX is set to -ERESTARTSYS.  This in turn will cause
the signal handling code in the kernel to recognize -ERESTARTSYS
which will in turn cause the syscall to be restarted.

This commit is based on work by Jan Kratochvil from 2009:

https://sourceware.org/ml/gdb-patches/2009-11/msg00592.html

Jan's patch had the sign extension code in amd64-nat.c.  Several
other native targets make use of this code, so it seemed better
to move the sign extension code to a linux specific file.  I
also added similar code to gdbserver.

Another approach is to fix the problem in the kernel.  Hui Zhu
tried to get a fix into the kernel back in 2014, but it was not
accepted.  Discussion regarding this approach may be found here:

https://lore.kernel.org/patchwork/patch/457841/

Even if a fix were to be put into the kernel, we'd still need
some kind of fix in GDB in order to support older kernels.

Finally, I'll note that Fedora has been carrying a similar patch for
at least nine years.  Other distributions, including RHEL and CentOS
have picked up this change and have been using it too.

gdb/ChangeLog:

	* amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
	function.
	(fill_gregset): Call amd64_linux_collect_native_gregset instead
	of amd64_collect_native_gregset.
	(amd64_linux_nat_target::store_registers): Likewise.

gdb/gdbserver/ChangeLog:

	* linux-x86-low.c (x86_fill_gregset): Sign extend EAX value
	when using a 64-bit gdbserver.
2019-04-10 17:11:24 -07:00
..
.gitignore
acinclude.m4 Add parameter to allow enabling/disabling selftests via configure 2018-10-10 16:23:56 -04:00
aclocal.m4
ax.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
ax.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
ChangeLog Fix amd64->i386 linux syscall restart problem 2019-04-10 17:11:24 -07:00
config.in
configure Add parameter to allow enabling/disabling selftests via configure 2018-10-10 16:23:56 -04:00
configure.ac Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
configure.srv Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case) 2019-03-04 12:47:35 -05:00
debug.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
debug.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
dll.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
dll.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
event-loop.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
event-loop.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
fork-child.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
gdb_proc_service.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdbreplay.c Rename gdb exception types 2019-04-08 09:05:40 -06:00
gdbthread.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
hostio-errno.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
hostio.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
hostio.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
i387-fp.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
i387-fp.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
inferiors.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
inferiors.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
linux-aarch32-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-aarch32-low.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
linux-aarch64-ipa.c AArch64: Add pointer authentication feature 2019-03-22 09:58:42 +00:00
linux-aarch64-low.c gdbserver: Add linux_get_hwcap 2019-03-26 16:27:43 +00:00
linux-aarch64-tdesc-selftest.c AArch64: Add pointer authentication feature 2019-03-22 09:58:42 +00:00
linux-aarch64-tdesc.c AArch64: Add pointer authentication feature 2019-03-22 09:58:42 +00:00
linux-aarch64-tdesc.h AArch64: Add pointer authentication feature 2019-03-22 09:58:42 +00:00
linux-amd64-ipa.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-arm-low.c gdbserver: Add linux_get_hwcap 2019-03-26 16:27:43 +00:00
linux-bfin-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-cris-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-crisv32-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-i386-ipa.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-ia64-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-low.c Use find_thread_in_random in select_event_lwp 2019-04-09 12:03:25 -06:00
linux-low.h Use linux_get_auxv to get AT_PHDR in the PPC stub 2019-04-05 14:19:08 -03:00
linux-m32r-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-m68k-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-mips-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-nios2-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-ppc-ipa.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-ppc-low.c Use linux_get_auxv to get AT_PHDR in the PPC stub 2019-04-05 14:19:08 -03:00
linux-ppc-tdesc-init.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
linux-s390-ipa.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-s390-low.c gdbserver: Add linux_get_hwcap 2019-03-26 16:27:43 +00:00
linux-s390-tdesc.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
linux-sh-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-sparc-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-tic6x-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-tile-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
linux-x86-low.c Fix amd64->i386 linux syscall restart problem 2019-04-10 17:11:24 -07:00
linux-x86-tdesc-selftest.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
linux-x86-tdesc.c Support the fs_base and gs_base registers on i386. 2019-03-12 13:39:02 -07:00
linux-x86-tdesc.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
linux-xtensa-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
lynx-i386-low.c Support the fs_base and gs_base registers on i386. 2019-03-12 13:39:02 -07:00
lynx-low.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
lynx-low.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
lynx-ppc-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
Makefile.in [PR gdb/23985] Fix libinproctrace.so build 2019-01-30 18:03:36 +00:00
mem-break.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
mem-break.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
notif.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
notif.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
nto-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
nto-low.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
nto-x86-low.c Support the fs_base and gs_base registers on i386. 2019-03-12 13:39:02 -07:00
proc-service.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
proc-service.list Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
README
regcache.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
regcache.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
remote-utils.c Fix GDB compilation on MinGW (PR gdb/24292) 2019-03-02 15:13:54 +02:00
remote-utils.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
server.c Rename gdb exception types 2019-04-08 09:05:40 -06:00
server.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
spu-low.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
symbol.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
target.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
target.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
tdesc.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
tdesc.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
thread-db.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
tracepoint.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
tracepoint.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
utils.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
utils.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
win32-arm-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
win32-i386-low.c Support the fs_base and gs_base registers on i386. 2019-03-12 13:39:02 -07:00
win32-low.c Normalize includes to use common/ 2019-01-25 15:28:16 -07:00
win32-low.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
wincecompat.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
wincecompat.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
x86-low.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
x86-low.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
x86-tdesc.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
xtensa-xtregs.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol
implemented in remote.c, and various *-stub.c files.  They communicate via
either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual.

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection from `host' to local TCP port
2345.  (Currently, the `host' part is ignored.)  You can choose any number you
want for the port number as long as it does not conflict with any existing TCP
ports on the target system.  This same port number must be used in the host
GDBs `target remote' command, which will be described shortly.  Note that if
you chose a port number that conflicts with another service, GDBserver will
print an error message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

The supported targets as of November 2006 are:
	arm-*-linux*
	bfin-*-uclinux
	bfin-*-linux-uclibc
	crisv32-*-linux*
	cris-*-linux*
	i[34567]86-*-cygwin*
	i[34567]86-*-linux*
	i[34567]86-*-mingw*
	ia64-*-linux*
	m32r*-*-linux*
	m68*-*-linux*
	m68*-*-uclinux*
	mips*64*-*-linux*
	mips*-*-linux*
	powerpc[64]-*-linux*
	s390[x]-*-linux*
	sh-*-linux*
	spu*-*-*
	x86_64-*-linux*

Configuring GDBserver you should specify the same machine for host and
target (which are the machine that GDBserver is going to run on.  This
is not the same as the machine that GDB is going to run on; building
GDBserver automatically as part of building a whole tree of tools does
not currently work if cross-compilation is involved (we don't get the
right CC in the Makefile, to start with)).

Building GDBserver for your target is very straightforward.  If you build
GDB natively on a target which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-gdbserver-sources/configure
	% make

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  In a Bourne shell, for example:

	% export CC=your-cross-compiler
	% path-to-gdbserver-sources/configure your-target-name
	% make

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.