mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
117 lines
3.3 KiB
C
117 lines
3.3 KiB
C
/* Target-dependent code for Solaris x86.
|
||
|
||
Copyright (C) 2002-2024 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "value.h"
|
||
#include "osabi.h"
|
||
|
||
#include "sol2-tdep.h"
|
||
#include "i386-tdep.h"
|
||
#include "solib-svr4.h"
|
||
|
||
/* From <ia32/sys/reg.h>. */
|
||
static int i386_sol2_gregset_reg_offset[] =
|
||
{
|
||
11 * 4, /* %eax */
|
||
10 * 4, /* %ecx */
|
||
9 * 4, /* %edx */
|
||
8 * 4, /* %ebx */
|
||
17 * 4, /* %esp */
|
||
6 * 4, /* %ebp */
|
||
5 * 4, /* %esi */
|
||
4 * 4, /* %edi */
|
||
14 * 4, /* %eip */
|
||
16 * 4, /* %eflags */
|
||
15 * 4, /* %cs */
|
||
18 * 4, /* %ss */
|
||
3 * 4, /* %ds */
|
||
2 * 4, /* %es */
|
||
1 * 4, /* %fs */
|
||
0 * 4 /* %gs */
|
||
};
|
||
|
||
/* Solaris doesn't have a `struct sigcontext', but it does have a
|
||
`mcontext_t' that contains the saved set of machine registers. */
|
||
|
||
static CORE_ADDR
|
||
i386_sol2_mcontext_addr (const frame_info_ptr &this_frame)
|
||
{
|
||
CORE_ADDR sp, ucontext_addr;
|
||
|
||
sp = get_frame_register_unsigned (this_frame, I386_ESP_REGNUM);
|
||
ucontext_addr = get_frame_memory_unsigned (this_frame, sp + 8, 4);
|
||
|
||
return ucontext_addr + 36;
|
||
}
|
||
|
||
/* Solaris 2. */
|
||
|
||
static void
|
||
i386_sol2_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (gdbarch);
|
||
|
||
/* Solaris is SVR4-based. */
|
||
i386_svr4_init_abi (info, gdbarch);
|
||
|
||
sol2_init_abi (info, gdbarch);
|
||
|
||
/* Solaris reserves space for its FPU emulator in `fpregset_t'.
|
||
There is also some space reserved for the registers of a Weitek
|
||
math coprocessor. */
|
||
tdep->gregset_reg_offset = i386_sol2_gregset_reg_offset;
|
||
tdep->gregset_num_regs = ARRAY_SIZE (i386_sol2_gregset_reg_offset);
|
||
tdep->sizeof_gregset = 19 * 4;
|
||
tdep->sizeof_fpregset = 380;
|
||
|
||
/* Signal trampolines are slightly different from SVR4. */
|
||
tdep->sigtramp_p = sol2_sigtramp_p;
|
||
tdep->sigcontext_addr = i386_sol2_mcontext_addr;
|
||
tdep->sc_reg_offset = tdep->gregset_reg_offset;
|
||
tdep->sc_num_regs = tdep->gregset_num_regs;
|
||
|
||
/* Solaris has SVR4-style shared libraries. */
|
||
set_solib_svr4_fetch_link_map_offsets
|
||
(gdbarch, svr4_ilp32_fetch_link_map_offsets);
|
||
}
|
||
|
||
|
||
static enum gdb_osabi
|
||
i386_sol2_osabi_sniffer (bfd *abfd)
|
||
{
|
||
/* If we have a section named .SUNW_version, then it is almost
|
||
certainly Solaris 2. */
|
||
if (bfd_get_section_by_name (abfd, ".SUNW_version"))
|
||
return GDB_OSABI_SOLARIS;
|
||
|
||
return GDB_OSABI_UNKNOWN;
|
||
}
|
||
|
||
void _initialize_i386_sol2_tdep ();
|
||
void
|
||
_initialize_i386_sol2_tdep ()
|
||
{
|
||
/* Register an ELF OS ABI sniffer for Solaris 2 binaries. */
|
||
gdbarch_register_osabi_sniffer (bfd_arch_i386, bfd_target_elf_flavour,
|
||
i386_sol2_osabi_sniffer);
|
||
|
||
gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_SOLARIS,
|
||
i386_sol2_init_abi);
|
||
}
|