binutils-gdb/gdb/tui
Tom Tromey 0598af4880 Fix TUI use of "has_break" field
The TUI uses the "has_break" in two different ways: sometimes as a
boolean, and sometimes as flags.

This patch changes the TUI to be more type-safe here, and fixes the
code.  I could not find a bug that this caused, so apparently this is
just cosmetic.

This deletes some code from tui_set_disassem_content.  Whenver this is
called, I believe the TUI updates the breakpoint information
afterward, so this assignment is redundant; which is good because it
is also incorrect.

gdb/ChangeLog
2019-07-04  Tom Tromey  <tom@tromey.com>

	PR tui/24724:
	* tui/tui-winsource.c (tui_clear_source_content): Update.
	(tui_source_window_base::set_is_exec_point_at): Fix comment.
	(tui_update_breakpoint_info): Update.
	(tui_set_exec_info_content): Update.
	* tui/tui-source.c (tui_set_source_content_nil): Update.
	* tui/tui-disasm.c (tui_set_disassem_content): Don't set
	has_break.
	* tui/tui-data.h (enum tui_bp_flag): New.
	(tui_bp_flags): New enum flags type.
	(struct tui_source_element) <break_mode>: Change type.  Rename
	from has_break.
	(TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
	(TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
	constants.
	* tui/tui-winsource.h: Fix comment.
2019-07-04 10:36:31 -06:00
..
ChangeLog-1998-2003
tui-command.c
tui-command.h
tui-data.c Tidy tui_delete_win 2019-06-25 07:48:52 -06:00
tui-data.h Fix TUI use of "has_break" field 2019-07-04 10:36:31 -06:00
tui-disasm.c Fix TUI use of "has_break" field 2019-07-04 10:36:31 -06:00
tui-disasm.h
tui-file.c
tui-file.h
tui-hooks.c Remove "data_content" and "data_content_count" from TUI data window 2019-06-25 07:48:48 -06:00
tui-hooks.h
tui-interp.c
tui-io.c
tui-io.h
tui-layout.c Make tui_gen_win_info constructor protected 2019-06-25 07:48:51 -06:00
tui-layout.h
tui-out.c
tui-out.h
tui-regs.c Separate out data window 2019-06-25 07:48:48 -06:00
tui-regs.h
tui-source.c Fix TUI use of "has_break" field 2019-07-04 10:36:31 -06:00
tui-source.h More type safety for TUI source window functions 2019-06-25 07:48:50 -06:00
tui-stack.c
tui-stack.h
tui-win.c Remove union tui_which_element 2019-06-25 07:48:50 -06:00
tui-win.h
tui-windata.c Separate out data window 2019-06-25 07:48:48 -06:00
tui-windata.h Remove "data_content" and "data_content_count" from TUI data window 2019-06-25 07:48:48 -06:00
tui-wingeneral.c Tidy tui_delete_win 2019-06-25 07:48:52 -06:00
tui-wingeneral.h
tui-winsource.c Fix TUI use of "has_break" field 2019-07-04 10:36:31 -06:00
tui-winsource.h Fix TUI use of "has_break" field 2019-07-04 10:36:31 -06:00
tui.c
tui.h Fix "auxiliary" typo 2019-06-25 07:48:49 -06:00