mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
ea8812bcea
Keith reported that gdb.base/dso2dso.exp is broken, with the following
error:
| $ make check RUNTESTFLAGS=dso2dso.exp
| [snip]
| Running ../../../src/gdb/testsuite/gdb.base/dso2dso.exp ...
| ERROR: tcl error sourcing ../../../src/gdb/testsuite/gdb.base/dso2dso.exp.
| ERROR: couldn't open
| "../../../src/gdb/testsuite/gdb.base/../../../src/gdb/testsuite/gdb.base/dso2dso-dso1.c":
| no such file or directory
| while executing
| "error "$message""
| (procedure "gdb_get_line_number" line 14)
| invoked from within
| "gdb_get_line_number "STOP HERE" $srcfile_libdso1"
| (file "../../../src/gdb/testsuite/gdb.base/dso2dso.exp" line 60)
| invoked from within
| "source ../../../src/gdb/testsuite/gdb.base/dso2dso.exp"
| ("uplevel" body line 1)
| invoked from within
| "uplevel #0 source ../../../src/gdb/testsuite/gdb.base/dso2dso.exp"
| invoked from within
| "catch "uplevel #0 source $test_file_name""
This happens because gdb_get_line_number will prepend $srcdir/$subdir
if the given filename does not start with "/", and this happens when
GDB was configured using a relative path to the configure script.
When using an absolute path like I do, we avoid the pre-pending that
Keith is seeing.
gdb/testsuite/ChangeLog:
Keith Seitz <keiths@redhat.com>:
* gdb.base/dso2dso.exp: Pass basename of source file in call
to gdb_get_line_number.
Tested on x86_64-linux with both scenarios.
69 lines
2.0 KiB
Plaintext
69 lines
2.0 KiB
Plaintext
# Copyright 2015 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if { [skip_shlib_tests] } {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
set output_dir [standard_output_file {}]
|
|
|
|
set libdso2 $testfile-dso2
|
|
set srcfile_libdso2 $srcdir/$subdir/$libdso2.c
|
|
set binfile_libdso2 [standard_output_file $libdso2.so]
|
|
|
|
set libdso1 $testfile-dso1
|
|
set srcfile_libdso1 $srcdir/$subdir/$libdso1.c
|
|
set binfile_libdso1 [standard_output_file $libdso1.so]
|
|
|
|
if { [gdb_compile_shlib $srcfile_libdso2 $binfile_libdso2 \
|
|
[list debug additional_flags=-fPIC]] != "" } {
|
|
untested "Could not compile $binfile_libdso2."
|
|
return -1
|
|
}
|
|
|
|
if { [gdb_compile_shlib $srcfile_libdso1 $binfile_libdso1 \
|
|
[list debug additional_flags=-fPIC]] != "" } {
|
|
untested "Could not compile $binfile_libdso1."
|
|
return -1
|
|
}
|
|
|
|
if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable \
|
|
[list debug shlib=$binfile_libdso2 shlib=$binfile_libdso1]] != "" } {
|
|
return -1
|
|
}
|
|
|
|
clean_restart $binfile
|
|
gdb_load_shlibs $binfile_libdso2 $binfile_libdso1
|
|
|
|
if { ![runto_main] } {
|
|
return -1
|
|
}
|
|
|
|
# Verify that we can "next" over the call to sub2 (provided by
|
|
# libdso2) make from sub1 (provided by libdso1), and land at
|
|
# the expected location.
|
|
|
|
set bp_location [gdb_get_line_number "STOP HERE" [file tail $srcfile_libdso1]]
|
|
gdb_breakpoint ${srcfile_libdso1}:${bp_location}
|
|
|
|
gdb_continue_to_breakpoint "at call to sub2" \
|
|
".*sub2 ().*"
|
|
|
|
gdb_test "next" \
|
|
".*return 5;.*" \
|
|
"next over call to sub2"
|