mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-03 04:12:10 +08:00
492d29ea1c
This patch splits the TRY_CATCH macro into three, so that we go from
this:
~~~
volatile gdb_exception ex;
TRY_CATCH (ex, RETURN_MASK_ERROR)
{
}
if (ex.reason < 0)
{
}
~~~
to this:
~~~
TRY
{
}
CATCH (ex, RETURN_MASK_ERROR)
{
}
END_CATCH
~~~
Thus, we'll be getting rid of the local volatile exception object, and
declaring the caught exception in the catch block.
This allows reimplementing TRY/CATCH in terms of C++ exceptions when
building in C++ mode, while still allowing to build GDB in C mode
(using setjmp/longjmp), as a transition step.
TBC, after this patch, is it _not_ valid to have code between the TRY
and the CATCH blocks, like:
TRY
{
}
// some code here.
CATCH (ex, RETURN_MASK_ERROR)
{
}
END_CATCH
Just like it isn't valid to do that with C++'s native try/catch.
By switching to creating the exception object inside the CATCH block
scope, we can get rid of all the explicitly allocated volatile
exception objects all over the tree, and map the CATCH block more
directly to C++'s catch blocks.
The majority of the TRY_CATCH -> TRY+CATCH+END_CATCH conversion was
done with a script, rerun from scratch at every rebase, no manual
editing involved. After the mechanical conversion, a few places
needed manual intervention, to fix preexisting cases where we were
using the exception object outside of the TRY_CATCH block, and cases
where we were using "else" after a 'if (ex.reason) < 0)' [a CATCH
after this patch]. The result was folded into this patch so that GDB
still builds at each incremental step.
END_CATCH is necessary for two reasons:
First, because we name the exception object in the CATCH block, which
requires creating a scope, which in turn must be closed somewhere.
Declaring the exception variable in the initializer field of a for
block, like:
#define CATCH(EXCEPTION, mask) \
for (struct gdb_exception EXCEPTION; \
exceptions_state_mc_catch (&EXCEPTION, MASK); \
EXCEPTION = exception_none)
would avoid needing END_CATCH, but alas, in C mode, we build with C90,
which doesn't allow mixed declarations and code.
Second, because when TRY/CATCH are wired to real C++ try/catch, as
long as we need to handle cleanup chains, even if there's no CATCH
block that wants to catch the exception, we need for stop at every
frame in the unwind chain and run cleanups, then rethrow. That will
be done in END_CATCH.
After we require C++, we'll still need TRY/CATCH/END_CATCH until
cleanups are completely phased out -- TRY/CATCH in C++ mode will
save/restore the current cleanup chain, like in C mode, and END_CATCH
catches otherwise uncaugh exceptions, runs cleanups and rethrows, so
that C++ cleanups and exceptions can coexist.
IMO, this still makes the TRY/CATCH code look a bit more like a
newcomer would expect, so IMO worth it even if we weren't considering
C++.
gdb/ChangeLog.
2015-03-07 Pedro Alves <palves@redhat.com>
* common/common-exceptions.c (struct catcher) <exception>: No
longer a pointer to volatile exception. Now an exception value.
<mask>: Delete field.
(exceptions_state_mc_init): Remove all parameters. Adjust.
(exceptions_state_mc): No longer pop the catcher here.
(exceptions_state_mc_catch): New function.
(throw_exception): Adjust.
* common/common-exceptions.h (exceptions_state_mc_init): Remove
all parameters.
(exceptions_state_mc_catch): Declare.
(TRY_CATCH): Rename to ...
(TRY): ... this. Remove EXCEPTION and MASK parameters.
(CATCH, END_CATCH): New.
All callers adjusted.
gdb/gdbserver/ChangeLog:
2015-03-07 Pedro Alves <palves@redhat.com>
Adjust all callers of TRY_CATCH to use TRY/CATCH/END_CATCH
instead.
150 lines
4.5 KiB
C
150 lines
4.5 KiB
C
/* Handling of inferior events for the event loop for GDB, the GNU debugger.
|
|
Copyright (C) 1999-2015 Free Software Foundation, Inc.
|
|
Written by Elena Zannoni <ezannoni@cygnus.com> of Cygnus Solutions.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "inferior.h"
|
|
#include "infrun.h"
|
|
#include "target.h" /* For enum inferior_event_type. */
|
|
#include "event-loop.h"
|
|
#include "event-top.h"
|
|
#include "inf-loop.h"
|
|
#include "remote.h"
|
|
#include "language.h"
|
|
#include "gdbthread.h"
|
|
#include "continuations.h"
|
|
#include "interps.h"
|
|
#include "top.h"
|
|
#include "observer.h"
|
|
|
|
/* General function to handle events in the inferior. So far it just
|
|
takes care of detecting errors reported by select() or poll(),
|
|
otherwise it assumes that all is OK, and goes on reading data from
|
|
the fd. This however may not always be what we want to do. */
|
|
void
|
|
inferior_event_handler (enum inferior_event_type event_type,
|
|
gdb_client_data client_data)
|
|
{
|
|
struct cleanup *cleanup_if_error = make_bpstat_clear_actions_cleanup ();
|
|
|
|
switch (event_type)
|
|
{
|
|
case INF_REG_EVENT:
|
|
/* Catch errors for now, until the inner layers of
|
|
fetch_inferior_event (i.e. readchar) can return meaningful
|
|
error status. If an error occurs while getting an event from
|
|
the target, just cancel the current command. */
|
|
{
|
|
|
|
TRY
|
|
{
|
|
fetch_inferior_event (client_data);
|
|
}
|
|
CATCH (ex, RETURN_MASK_ALL)
|
|
{
|
|
bpstat_clear_actions ();
|
|
do_all_intermediate_continuations (1);
|
|
do_all_continuations (1);
|
|
|
|
throw_exception (ex);
|
|
}
|
|
END_CATCH
|
|
}
|
|
break;
|
|
|
|
case INF_EXEC_COMPLETE:
|
|
if (!non_stop)
|
|
{
|
|
/* Unregister the inferior from the event loop. This is done
|
|
so that when the inferior is not running we don't get
|
|
distracted by spurious inferior output. */
|
|
if (target_has_execution)
|
|
target_async (NULL, 0);
|
|
}
|
|
|
|
/* Do all continuations associated with the whole inferior (not
|
|
a particular thread). */
|
|
if (!ptid_equal (inferior_ptid, null_ptid))
|
|
do_all_inferior_continuations (0);
|
|
|
|
/* If we were doing a multi-step (eg: step n, next n), but it
|
|
got interrupted by a breakpoint, still do the pending
|
|
continuations. The continuation itself is responsible for
|
|
distinguishing the cases. The continuations are allowed to
|
|
touch the inferior memory, e.g. to remove breakpoints, so run
|
|
them before running breakpoint commands, which may resume the
|
|
target. */
|
|
if (non_stop
|
|
&& target_has_execution
|
|
&& !ptid_equal (inferior_ptid, null_ptid))
|
|
do_all_intermediate_continuations_thread (inferior_thread (), 0);
|
|
else
|
|
do_all_intermediate_continuations (0);
|
|
|
|
/* Always finish the previous command before running any
|
|
breakpoint commands. Any stop cancels the previous command.
|
|
E.g. a "finish" or "step-n" command interrupted by an
|
|
unrelated breakpoint is canceled. */
|
|
if (non_stop
|
|
&& target_has_execution
|
|
&& !ptid_equal (inferior_ptid, null_ptid))
|
|
do_all_continuations_thread (inferior_thread (), 0);
|
|
else
|
|
do_all_continuations (0);
|
|
|
|
/* When running a command list (from a user command, say), these
|
|
are only run when the command list is all done. */
|
|
if (interpreter_async)
|
|
{
|
|
|
|
check_frame_language_change ();
|
|
|
|
/* Don't propagate breakpoint commands errors. Either we're
|
|
stopping or some command resumes the inferior. The user will
|
|
be informed. */
|
|
TRY
|
|
{
|
|
bpstat_do_actions ();
|
|
}
|
|
CATCH (e, RETURN_MASK_ALL)
|
|
{
|
|
exception_print (gdb_stderr, e);
|
|
}
|
|
END_CATCH
|
|
}
|
|
break;
|
|
|
|
case INF_EXEC_CONTINUE:
|
|
/* Is there anything left to do for the command issued to
|
|
complete? */
|
|
|
|
if (non_stop)
|
|
do_all_intermediate_continuations_thread (inferior_thread (), 0);
|
|
else
|
|
do_all_intermediate_continuations (0);
|
|
break;
|
|
|
|
case INF_TIMER:
|
|
default:
|
|
printf_unfiltered (_("Event type not recognized.\n"));
|
|
break;
|
|
}
|
|
|
|
discard_cleanups (cleanup_if_error);
|
|
}
|