mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-23 13:21:43 +08:00
3eb7562a98
When executing commands on a secondary UI running the MI interpreter, some commands that should be synchronous are not. MI incorrectly continues processing input right after the synchronous command is sent, before the target stops. The problem happens when we emit MI async events (=library-loaded, etc.), and we go about restoring the previous terminal state, we end up calling target_terminal_ours, which incorrectly always installs the current UI's input_fd in the event loop... That is, code like this: old_chain = make_cleanup_restore_target_terminal (); target_terminal_ours_for_output (); fprintf_unfiltered (mi->event_channel, "library-loaded"); ... do_cleanups (old_chain); The fix is to move the add_file_handler/delete_file_handler calls out of target_terminal_$foo, making these completely no-ops unless called with the main UI as current UI. gdb/ChangeLog: 2016-08-09 Pedro Alves <palves@redhat.com> PR gdb/20418 * event-top.c (ui_register_input_event_handler) (ui_unregister_input_event_handler): New functions. (async_enable_stdin): Register input in the event loop. (async_disable_stdin): Unregister input from the event loop. (gdb_setup_readline): Register input in the event loop. * infrun.c (check_curr_ui_sync_execution_done): Register input in the event loop. * target.c (target_terminal_inferior): Don't unregister input from the event loop. (target_terminal_ours): Don't register input in the event loop. * target.h (target_terminal_inferior) (target_terminal_ours_for_output, target_terminal_ours): Update comments. * top.h (ui_register_input_event_handler) (ui_unregister_input_event_handler): New declarations. * utils.c (ui_unregister_input_event_handler_cleanup) (prepare_to_handle_input): New functions. (defaulted_query, prompt_for_continue): Use prepare_to_handle_input. gdb/testsuite/ChangeLog: 2016-08-09 Pedro Alves <palves@redhat.com> Simon Marchi <simon.marchi@ericsson.com> PR gdb/20418 * gdb.mi/new-ui-mi-sync.c, gdb.mi/new-ui-mi-sync.exp: New files. * lib/mi-support.exp (mi_expect_interrupt): Remove anchors. |
||
|---|---|---|
| .. | ||
| array.f | ||
| basics.c | ||
| ChangeLog-1999-2003 | ||
| dw2-ref-missing-frame-func.c | ||
| dw2-ref-missing-frame-main.c | ||
| dw2-ref-missing-frame.exp | ||
| dw2-ref-missing-frame.S | ||
| gdb669.exp | ||
| gdb680.exp | ||
| gdb701.c | ||
| gdb701.exp | ||
| gdb792.cc | ||
| gdb792.exp | ||
| gdb2549.exp | ||
| mi2-amd64-entry-value.c | ||
| mi2-amd64-entry-value.exp | ||
| mi2-amd64-entry-value.s | ||
| mi2-prompt.exp | ||
| mi2-var-child.exp | ||
| mi-async-run.c | ||
| mi-async-run.exp | ||
| mi-async.exp | ||
| mi-basics.exp | ||
| mi-break.exp | ||
| mi-breakpoint-changed.exp | ||
| mi-catch-load-so.c | ||
| mi-catch-load.c | ||
| mi-catch-load.exp | ||
| mi-cli.exp | ||
| mi-cmd-error.exp | ||
| mi-cmd-param-changed.exp | ||
| mi-condbreak-call-thr-state-mt.c | ||
| mi-condbreak-call-thr-state-st.c | ||
| mi-condbreak-call-thr-state.c | ||
| mi-condbreak-call-thr-state.exp | ||
| mi-console.c | ||
| mi-console.exp | ||
| mi-detach.exp | ||
| mi-disassemble.exp | ||
| mi-dprintf-pending.c | ||
| mi-dprintf-pending.exp | ||
| mi-dprintf-pendshr.c | ||
| mi-dprintf.c | ||
| mi-dprintf.exp | ||
| mi-editing.exp | ||
| mi-eval.exp | ||
| mi-exec-run.exp | ||
| mi-exit-code.c | ||
| mi-exit-code.exp | ||
| mi-file-transfer.exp | ||
| mi-file.exp | ||
| mi-fill-memory.exp | ||
| mi-fullname-deleted.exp | ||
| mi-hack-cli.exp | ||
| mi-i-cmd.exp | ||
| mi-info-os.exp | ||
| mi-inheritance-syntax-error.cc | ||
| mi-inheritance-syntax-error.exp | ||
| mi-language.exp | ||
| mi-linespec-err-cp.cc | ||
| mi-linespec-err-cp.exp | ||
| mi-logging.exp | ||
| mi-memory-changed.exp | ||
| mi-nonstop-exit.exp | ||
| mi-nonstop.exp | ||
| mi-ns-stale-regcache.exp | ||
| mi-nsintrall.exp | ||
| mi-nsmoribund.exp | ||
| mi-nsthrexec.exp | ||
| mi-pending.c | ||
| mi-pending.exp | ||
| mi-pendshr2.c | ||
| mi-pendshr.c | ||
| mi-pthreads.exp | ||
| mi-read-memory.c | ||
| mi-read-memory.exp | ||
| mi-record-changed.exp | ||
| mi-reg-undefined.c | ||
| mi-reg-undefined.exp | ||
| mi-reg-undefined.S | ||
| mi-regs.exp | ||
| mi-return.exp | ||
| mi-reverse.exp | ||
| mi-simplerun.exp | ||
| mi-solib.exp | ||
| mi-stack.c | ||
| mi-stack.exp | ||
| mi-start.c | ||
| mi-start.exp | ||
| mi-stepi.exp | ||
| mi-stepn.c | ||
| mi-stepn.exp | ||
| mi-syn-frame.c | ||
| mi-syn-frame.exp | ||
| mi-threads-interrupt.c | ||
| mi-threads-interrupt.exp | ||
| mi-undefined-cmd.exp | ||
| mi-until.exp | ||
| mi-var-block.exp | ||
| mi-var-child-f.exp | ||
| mi-var-child.c | ||
| mi-var-child.exp | ||
| mi-var-cmd.exp | ||
| mi-var-cp.cc | ||
| mi-var-cp.exp | ||
| mi-var-create-rtti.c | ||
| mi-var-create-rtti.exp | ||
| mi-var-display.exp | ||
| mi-var-invalidate.exp | ||
| mi-var-list-children-invalid-grandchild.c | ||
| mi-var-list-children-invalid-grandchild.exp | ||
| mi-var-rtti.cc | ||
| mi-var-rtti.exp | ||
| mi-vla-c99.exp | ||
| mi-vla-fortran.exp | ||
| mi-watch-nonstop.exp | ||
| mi-watch.exp | ||
| new-ui-mi-sync.c | ||
| new-ui-mi-sync.exp | ||
| non-stop-exit.c | ||
| non-stop.c | ||
| ns-stale-regcache.c | ||
| nsintrall.c | ||
| nsmoribund.c | ||
| nsthrexec.c | ||
| pending.c | ||
| pendshr1.c | ||
| pendshr2.c | ||
| pr11022.c | ||
| pr11022.exp | ||
| pthreads.c | ||
| solib-lib.c | ||
| solib-main.c | ||
| testcmds | ||
| until.c | ||
| var-cmd.c | ||
| vla.c | ||
| vla.f90 | ||
| watch-nonstop.c | ||