mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
ed2917de68
Currently md_end is typically used for some final actions rather than freeing memory like other *_end functions. Rename it to md_finish, and rename target implementation. The renaming of target functions makes it possible to find them all with "grep md_finish", eg. md_mips_end is renamed to mips_md_finish, not md_mips_finish. This patch leaves a number of md_end functions unchanged, those that either do nothing or deallocate memory, and calls them late. The idea here is that target maintainers implement md_end functions to tidy memory, if anyone cares. Freeing persistent memory in gas is not at all important, except that it can hide more important memory leaks, those that happen once per some frequent gas operation, amongst these unimportant memory leaks. * as.c (main): Rename md_end to md_finish. * config/tc-alpha.c, * config/tc-alpha.h, * config/tc-arc.c, * config/tc-arc.h, * config/tc-arm.c, * config/tc-arm.h, * config/tc-csky.c, * config/tc-csky.h, * config/tc-ia64.c, * config/tc-ia64.h, * config/tc-mcore.c, * config/tc-mcore.h, * config/tc-mips.c, * config/tc-mips.h, * config/tc-mmix.c, * config/tc-mmix.h, * config/tc-msp430.c, * config/tc-msp430.h, * config/tc-nds32.c, * config/tc-nds32.h, * config/tc-ppc.c, * config/tc-ppc.h, * config/tc-pru.c, * config/tc-pru.h, * config/tc-riscv.c, * config/tc-riscv.h, * config/tc-s390.c, * config/tc-s390.h, * config/tc-sparc.c, * config/tc-sparc.h, * config/tc-tic4x.c, * config/tc-tic4x.h, * config/tc-tic6x.c, * config/tc-tic6x.h, * config/tc-v850.c, * config/tc-v850.h, * config/tc-xtensa.c, * config/tc-xtensa.h, * config/tc-z80.c, * config/tc-z80.h: Similarly. * output-file.c (output_file_close): Call md_end.
119 lines
3.2 KiB
C
119 lines
3.2 KiB
C
/* output-file.c - Deal with the output file
|
|
Copyright (C) 1987-2022 Free Software Foundation, Inc.
|
|
|
|
This file is part of GAS, the GNU Assembler.
|
|
|
|
GAS is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3, or (at your option)
|
|
any later version.
|
|
|
|
GAS is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with GAS; see the file COPYING. If not, write to
|
|
the Free Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
|
|
02110-1301, USA. */
|
|
|
|
#include "as.h"
|
|
#include "subsegs.h"
|
|
#include "sb.h"
|
|
#include "macro.h"
|
|
#include "output-file.h"
|
|
|
|
#ifndef TARGET_MACH
|
|
#define TARGET_MACH 0
|
|
#endif
|
|
|
|
bfd *stdoutput;
|
|
|
|
void
|
|
output_file_create (const char *name)
|
|
{
|
|
if (name[0] == '-' && name[1] == '\0')
|
|
as_fatal (_("can't open a bfd on stdout %s"), name);
|
|
|
|
else if (!(stdoutput = bfd_openw (name, TARGET_FORMAT)))
|
|
{
|
|
bfd_error_type err = bfd_get_error ();
|
|
|
|
if (err == bfd_error_invalid_target)
|
|
as_fatal (_("selected target format '%s' unknown"), TARGET_FORMAT);
|
|
else
|
|
as_fatal (_("can't create %s: %s"), name, bfd_errmsg (err));
|
|
}
|
|
|
|
bfd_set_format (stdoutput, bfd_object);
|
|
bfd_set_arch_mach (stdoutput, TARGET_ARCH, TARGET_MACH);
|
|
if (flag_traditional_format)
|
|
stdoutput->flags |= BFD_TRADITIONAL_FORMAT;
|
|
}
|
|
|
|
static void
|
|
stash_frchain_obs (asection *sec)
|
|
{
|
|
segment_info_type *info = seg_info (sec);
|
|
if (info)
|
|
{
|
|
struct frchain *frchp;
|
|
for (frchp = info->frchainP; frchp; frchp = frchp->frch_next)
|
|
obstack_ptr_grow (¬es, &frchp->frch_obstack);
|
|
info->frchainP = NULL;
|
|
}
|
|
}
|
|
|
|
void
|
|
output_file_close (void)
|
|
{
|
|
bool res;
|
|
bfd *obfd = stdoutput;
|
|
struct obstack **obs;
|
|
asection *sec;
|
|
const char *filename;
|
|
|
|
if (obfd == NULL)
|
|
return;
|
|
|
|
/* Prevent an infinite loop - if the close failed we will call as_fatal
|
|
which will call xexit() which may call this function again... */
|
|
stdoutput = NULL;
|
|
|
|
/* We can't free obstacks attached to the output bfd sections before
|
|
closing the output bfd since data in those obstacks may need to
|
|
be accessed, but we can't access anything in the output bfd after
|
|
it is closed.. */
|
|
for (sec = obfd->sections; sec; sec = sec->next)
|
|
stash_frchain_obs (sec);
|
|
stash_frchain_obs (reg_section);
|
|
stash_frchain_obs (expr_section);
|
|
stash_frchain_obs (bfd_abs_section_ptr);
|
|
stash_frchain_obs (bfd_und_section_ptr);
|
|
obstack_ptr_grow (¬es, NULL);
|
|
obs = obstack_finish (¬es);
|
|
|
|
/* Close the bfd. */
|
|
if (!flag_always_generate_output && had_errors ())
|
|
res = bfd_cache_close_all ();
|
|
else
|
|
res = bfd_close (obfd);
|
|
|
|
filename = out_file_name;
|
|
out_file_name = NULL;
|
|
if (!keep_it && filename)
|
|
unlink_if_ordinary (filename);
|
|
|
|
#ifdef md_end
|
|
md_end ();
|
|
#endif
|
|
macro_end ();
|
|
read_end ();
|
|
symbol_end ();
|
|
subsegs_end (obs);
|
|
|
|
if (!res)
|
|
as_fatal ("%s: %s", filename, bfd_errmsg (bfd_get_error ()));
|
|
}
|