Go to file
Andrew Burgess 288712bbac gdb/remote: use scoped_restore to control starting_up flag
This commit makes use of a scoped_restore object to control the
remote_state::starting_up flag within the remote_target::start_remote
method.

Ideally I would have liked to create the scoped_restore inside
start_remote and just leave the restore in place until the end of the
scope, however, I'm worried that doing this would change the behaviour
of GDB.  Specifically, in start_remote, the following code is executed
once the starting_up flag has been restored to its previous value:

  if (breakpoints_should_be_inserted_now ())
    insert_breakpoints ();

I think (but am not 100% sure) that calling install_breakpoints could
end up back inside remote_target::can_download_tracepoint, which does
check the value of remote_state::starting_up.  And so, I'm concerned
that leaving the scoped_restore in place until the end of start_remote
will cause a possible change in behaviour.

To avoid this, and to leave things as close to the current behaviour
as possible, I've split remote_target::start_remote into two, there's
the main function body which moves into remote_target::start_remote_1,
this function uses the scoped_restore to change the ::starting_up
flag, then there's the old remote_target::start_remote, which now just
calls ::start_remote_1, and then does the insert_breakpoints call.

There should be no user visible changes after this commit, unless
there's a situation where the ::starting_up flag could previously have
been left set, if this was the case, then this situation should no
longer be possible.
2021-12-01 10:07:14 +00:00
bfd Automatic date update in version.in 2021-12-01 00:00:09 +00:00
binutils binutils: regenerate Makefile.in after doc/ changes 2021-11-30 14:02:05 -05:00
config Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
contrib
cpu Re: opcodes: constify & local meps macros 2021-07-05 21:40:49 +09:30
elfcpp arm: add armv9-a architecture to -march 2021-11-01 10:51:03 +00:00
etc etc: switch to automake 2021-09-09 23:30:12 -04:00
gas aarch64: Add missing system registers [PR27145] 2021-11-30 17:50:25 +00:00
gdb gdb/remote: use scoped_restore to control starting_up flag 2021-12-01 10:07:14 +00:00
gdbserver gdb: pass more const target_waitstatus by reference 2021-11-22 13:57:54 -05:00
gdbsupport gdb: introduce target_waitkind_str, use it in target_waitstatus::to_string 2021-11-22 13:57:49 -05:00
gnulib gnulib: import various network functions 2021-09-08 17:48:09 -04:00
gold gold: enable silent build rules 2021-11-30 19:41:31 -05:00
gprof gprof: enable silent build rules 2021-11-29 20:28:29 -05:00
include RISC-V: The vtype immediate with more than the defined 8 bits are preserved. 2021-11-30 19:03:48 +08:00
intl Regenerate a couple of files 2021-11-15 12:20:12 +10:30
ld ld: pru: Add pru_irq_map output section 2021-11-30 13:11:57 +00:00
libbacktrace sync libbacktrace from gcc 2021-11-14 18:07:50 +10:30
libctf libctf: enable silent build rules 2021-11-29 20:28:29 -05:00
libdecnumber
libiberty Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
opcodes aarch64: Add missing system registers [PR27145] 2021-11-30 17:50:25 +00:00
readline Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
sim sim: testsuite: drop most specific istarget checks 2021-11-28 21:55:16 -05:00
texinfo
zlib zlib: enable silent build rules 2021-11-29 20:28:29 -05:00
.cvsignore
.gitattributes
.gitignore
ar-lib
ChangeLog Document "memory-tag-violations". 2021-10-29 13:31:37 +03:00
compile
config-ml.in
config.guess Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
config.rpath
config.sub Update config.sub and config.guess for MIPS R3 and R5 ISA support 2021-05-24 18:11:49 +02:00
configure top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
configure.ac top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4 libtool.m4: fix nm BSD flag detection 2021-09-27 20:31:23 +01:00
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS MAINTAINERS: Update path to readline config.{sub,guess} files 2021-05-24 18:11:49 +02:00
Makefile.def Import Makefile.def from gcc 2021-11-12 19:02:12 +10:30
Makefile.in Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
Makefile.tpl Sync Makefile.tpl with GCC 2021-11-13 09:04:03 -08:00
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS 2021-09-28 12:21:21 +01:00
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.