mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
287fbf951a
The sim-main.h header is a bit of a dumping ground. Every arch can
(and many do) define all sorts of weird & common names that end up
conflicting with system headers. So including it before the system
headers sets us up for pain. v850 is a good example of this -- when
building for mingw, we see weird failures:
$ i686-w64-mingw32-gcc ... -c -o dv-sockser.o ../../../../sim/v850/../common/dv-sockser.c
In file included from ../../../../sim/v850/sim-main.h:11,
from ../../../../sim/v850/../common/dv-sockser.c:24:
../../../../sim/v850/../common/sim-base.h:97:32: error: expected ')' before '->' token
97 | # define STATE_CPU(sd, n) ((sd)->cpu[0])
| ^~
While gcc is unhelpful at first, running it through the preprocessor
by hand shows more details:
$ i686-w64-mingw32-gcc ... -E -dD -o dv-sockser.i ../../../../sim/v850/../common/dv-sockser.c
$ i686-w64-mingw32-gcc -c dv-sockser.i
In file included from /usr/i686-w64-mingw32/usr/include/minwindef.h:163,
from /usr/i686-w64-mingw32/usr/include/windef.h:9,
from /usr/i686-w64-mingw32/usr/include/windows.h:69,
from /usr/i686-w64-mingw32/usr/include/winsock2.h:23,
from ../../gnulib/import/sys/socket.h:684,
from ../../gnulib/import/netinet/in.h:43,
from ../../../../sim/v850/../common/dv-sockser.c:39:
/usr/i686-w64-mingw32/usr/include/winnt.h:4803:25: error: expected ')' before '->' token
4803 | DWORD State;
| ^
| )
This is because v850 sets up this common name:
All of this needs cleaning up someday, but since the dv-sockser code
definitely should be fixed in this way, lets do that now and unblock
the v850 code.
|
||
|---|---|---|
| .. | ||
| aarch64 | ||
| arm | ||
| avr | ||
| bfin | ||
| bpf | ||
| common | ||
| cr16 | ||
| cris | ||
| d10v | ||
| erc32 | ||
| example-synacor | ||
| frv | ||
| ft32 | ||
| h8300 | ||
| igen | ||
| iq2000 | ||
| lm32 | ||
| m4 | ||
| m32c | ||
| m32r | ||
| m68hc11 | ||
| mcore | ||
| microblaze | ||
| mips | ||
| mn10300 | ||
| moxie | ||
| msp430 | ||
| or1k | ||
| ppc | ||
| pru | ||
| riscv | ||
| rl78 | ||
| rx | ||
| sh | ||
| testsuite | ||
| v850 | ||
| .gitignore | ||
| aclocal.m4 | ||
| arch-subdir.mk.in | ||
| ChangeLog-2021 | ||
| config.h.in | ||
| configure | ||
| configure.ac | ||
| MAINTAINERS | ||
| Makefile.am | ||
| Makefile.in | ||
| README-HACKING | ||