binutils-gdb/gdb/testsuite/gdb.reverse/test_ioctl_TCSETSW.c
Carl Love cbc30d36ac Fix comparison of unsigned long int to int in record_linux_system_call.
The if statement in case gdb_sys_ioctl in function
record_linux_system_call in file gdb/linux-record.c is as follows:

   if (tmpulongest == tdep->ioctl_FIOCLEX
      || tmpulongest == tdep->ioctl_FIONCLEX
    ....
      || tmpulongest == tdep->ioctl_TCSETSW
     ...
   }

The PowerPC ioctl value for ioctl_TCSETW is 0x802c7415.  The variable
ioctl_TCSETW is defined in gdb/linux-record.h as an int.  The TCSETW value
has the MSB set to one so it is a negative integer.  The comparison of the
unsigned long value tmpulongest to a negative integer value for
ioctl_TCSETSW fails.

This patch changes the declarations for the ioctl_* values in struct
linux_record_tdep to unsigned long to fix the comparisons between
tmpulongest and the tdep->ioctl_* values.

An additional test gdb.reverse/test_ioctl_TCSETSW.exp is added to verify
the gdb record_linux_system_call() if statement for the ioctl TCSETSW
succeeds.

This patch has been tested on Power 10 and Intel with no test failures.
2022-06-10 16:19:01 +00:00

39 lines
1.3 KiB
C

/* This testcase is part of GDB, the GNU debugger.
Copyright 2012-2022 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <sys/ioctl.h>
#include <termios.h>
#include <stdio.h>
/* The purpose of this test is to verify gdb record_linux_system_call()
recognizes the call for ioctl TCSETSW. */
int
main(void)
{
struct termios term;
int result;
int fd = 0;
/* The test just needs to generate an ioctl call for TCSETSW to see if gdb
record detected it or not. Success or failure of the ioctl call is
irrelevant. */
result = tcsetattr(fd, TCSADRAIN, &term); /* TCSETSW call */
result = 0; /* TCSETSW called */
}