binutils-gdb/gdb/testsuite/gdb.base/morestack.exp
Andrew Burgess ef7a6b977b gdb/testsuite: remove global gcc_compiled from gdb.exp
After this commit the gcc_compiled global is no longer exported from
lib/gdb.exp.  In theory we could switch over all uses of gcc_compiled
to instead call test_compiler_info directly, however, I have instead
added a new proc to gdb.exp: 'is_c_compiler_gcc'.  I've then updated
the testsuite to call this proc instead of using the global.

Having a new proc specifically for this task means that we have a
single consistent pattern for detecting gcc.  By wrapping this logic
within a proc that calls test_compiler_info, rather than using the
global, means that test scripts don't need to call get_compiler_info
before they read the global, simply calling the new proc does
everything in one go.

As a result I've been able to remove the get_compiler_info calls from
all the test scripts that I've touched in this commit.

In some of the tests e.g. gdb.dwarf2/*.exp, the $gcc_compiled flag was
being checked at the top of the script to decide if the whole script
should be skipped or not.  In these cases I've called the new proc
directly and removed all uses of gcc_compiled.

In other cases, e.g. most of the gdb.base scripts, there were many
uses of gcc_compiled.  In these cases I set a new global gcc_compiled
near the top of the script, and leave the rest of the script
unchanged.

There should be no changes in what is tested after this commit.
2022-06-24 15:07:28 +01:00

53 lines
1.5 KiB
Plaintext

# Copyright (C) 2011-2022 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if {![is_c_compiler_gcc]} {
unsupported "gcc compiler is required"
return
}
standard_testfile
set opts "additional_flags=-fsplit-stack"
if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \
[list $opts]] } {
return -1
}
if ![runto_main] {
return -1
}
gdb_breakpoint "marker_hit"
gdb_breakpoint "marker_miss"
set test "continue"
gdb_test_multiple $test $test {
-re "marker_hit.*$gdb_prompt $" {
pass $test
}
-re "marker_miss.*$gdb_prompt $" {
# The testcase failed to violated the frame_id_inner condition by
# handing inner frame with higher (on the stack-grows-down arches)
# $sp address than the outer frame.
xfail $test
return 0
}
}
# FAIL was on `bt' producing:
# Backtrace stopped: previous frame inner to this frame (corrupt stack?)
gdb_test "up 3000" " in main .*"