binutils-gdb/gdb/process-stratum-target.c
Simon Marchi 7438771288 gdb: remove regcache's address space
While looking at the regcache code, I noticed that the address space
(passed to regcache when constructing it, and available through
regcache::aspace) wasn't relevant for the regcache itself.  Callers of
regcache::aspace use that method because it appears to be a convenient
way of getting the address space for a thread, if you already have the
regcache.  But there is always another way to get the address space, as
the callers pretty much always know which thread they are dealing with.
The regcache code itself doesn't use the address space.

This patch removes anything related to address_space from the regcache
code, and updates callers to get it from the thread in context.  This
removes a bit of unnecessary complexity from the regcache code.

The current get_thread_arch_regcache function gets an address_space for
the given thread using the target_thread_address_space function (which
calls the target_ops::thread_address_space method).  This suggest that
there might have been the intention of supporting per-thread address
spaces.  But digging through the history, I did not find any such case.
Maybe this method was just added because we needed a way to get an
address space from a ptid (because constructing a regcache required an
address space), and this seemed like the right way to do it, I don't
know.

The only implementations of thread_address_space and
process_stratum_target::thread_address_space and
linux_nat_target::thread_address_space, which essentially just return
the inferior's address space.  And thread_address_space is only used in
the current get_thread_arch_regcache, which gets removed.  So, I think
that the thread_address_space target method can be removed, and we can
assume that it's fine to use the inferior's address space everywhere.
Callers of regcache::aspace are updated to get the address space from
the relevant inferior, either using some context they already know
about, or in last resort using the current global context.

So, to summarize:

 - remove everything in regcache related to address spaces
 - in particular, remove get_thread_arch_regcache, and rename
   get_thread_arch_aspace_regcache to get_thread_arch_regcache
 - remove target_ops::thread_address_space, and
   target_thread_address_space
 - adjust all users of regcache::aspace to get the address space another
   way

Change-Id: I04fd41b22c83fe486522af7851c75bcfb31c88c7
2023-11-17 20:01:35 +00:00

221 lines
5.8 KiB
C

/* Abstract base class inherited by all process_stratum targets
Copyright (C) 2018-2023 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "process-stratum-target.h"
#include "inferior.h"
#include <algorithm>
process_stratum_target::~process_stratum_target ()
{
}
struct gdbarch *
process_stratum_target::thread_architecture (ptid_t ptid)
{
inferior *inf = find_inferior_ptid (this, ptid);
gdb_assert (inf != NULL);
return inf->arch ();
}
bool
process_stratum_target::has_all_memory ()
{
/* If no inferior selected, then we can't read memory here. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_memory ()
{
/* If no inferior selected, then we can't read memory here. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_stack ()
{
/* If no inferior selected, there's no stack. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_registers ()
{
/* Can't read registers from no inferior. */
return inferior_ptid != null_ptid;
}
bool
process_stratum_target::has_execution (inferior *inf)
{
/* If there's a process running already, we can't make it run
through hoops. */
return inf->pid != 0;
}
/* See process-stratum-target.h. */
void
process_stratum_target::follow_exec (inferior *follow_inf, ptid_t ptid,
const char *execd_pathname)
{
inferior *orig_inf = current_inferior ();
if (orig_inf != follow_inf)
{
/* Execution continues in a new inferior, push the original inferior's
process target on the new inferior's target stack. The process target
may decide to unpush itself from the original inferior's target stack
after that, at its discretion. */
follow_inf->push_target (orig_inf->process_target ());
thread_info *t = add_thread (follow_inf->process_target (), ptid);
/* Leave the new inferior / thread as the current inferior / thread. */
switch_to_thread (t);
}
}
/* See process-stratum-target.h. */
void
process_stratum_target::follow_fork (inferior *child_inf, ptid_t child_ptid,
target_waitkind fork_kind,
bool follow_child,
bool detach_on_fork)
{
if (child_inf != nullptr)
{
child_inf->push_target (this);
add_thread_silent (this, child_ptid);
}
}
/* See process-stratum-target.h. */
void
process_stratum_target::maybe_add_resumed_with_pending_wait_status
(thread_info *thread)
{
gdb_assert (!thread->resumed_with_pending_wait_status_node.is_linked ());
if (thread->resumed () && thread->has_pending_waitstatus ())
{
infrun_debug_printf ("adding to resumed threads with event list: %s",
thread->ptid.to_string ().c_str ());
m_resumed_with_pending_wait_status.push_back (*thread);
}
}
/* See process-stratum-target.h. */
void
process_stratum_target::maybe_remove_resumed_with_pending_wait_status
(thread_info *thread)
{
if (thread->resumed () && thread->has_pending_waitstatus ())
{
infrun_debug_printf ("removing from resumed threads with event list: %s",
thread->ptid.to_string ().c_str ());
gdb_assert (thread->resumed_with_pending_wait_status_node.is_linked ());
auto it = m_resumed_with_pending_wait_status.iterator_to (*thread);
m_resumed_with_pending_wait_status.erase (it);
}
else
gdb_assert (!thread->resumed_with_pending_wait_status_node.is_linked ());
}
/* See process-stratum-target.h. */
thread_info *
process_stratum_target::random_resumed_with_pending_wait_status
(inferior *inf, ptid_t filter_ptid)
{
auto matches = [inf, filter_ptid] (const thread_info &thread)
{
return thread.inf == inf && thread.ptid.matches (filter_ptid);
};
/* First see how many matching events we have. */
const auto &l = m_resumed_with_pending_wait_status;
unsigned int count = std::count_if (l.begin (), l.end (), matches);
if (count == 0)
return nullptr;
/* Now randomly pick a thread out of those that match the criteria. */
int random_selector
= (int) ((count * (double) rand ()) / (RAND_MAX + 1.0));
if (count > 1)
infrun_debug_printf ("Found %u events, selecting #%d",
count, random_selector);
/* Select the Nth thread that matches. */
auto it = std::find_if (l.begin (), l.end (),
[&random_selector, &matches]
(const thread_info &thread)
{
if (!matches (thread))
return false;
return random_selector-- == 0;
});
gdb_assert (it != l.end ());
return &*it;
}
/* See process-stratum-target.h. */
thread_info *
process_stratum_target::find_thread (ptid_t ptid)
{
inferior *inf = find_inferior_ptid (this, ptid);
if (inf == NULL)
return NULL;
return inf->find_thread (ptid);
}
/* See process-stratum-target.h. */
std::set<process_stratum_target *>
all_non_exited_process_targets ()
{
/* Inferiors may share targets. To eliminate duplicates, use a set. */
std::set<process_stratum_target *> targets;
for (inferior *inf : all_non_exited_inferiors ())
targets.insert (inf->process_target ());
return targets;
}
/* See process-stratum-target.h. */
void
switch_to_target_no_thread (process_stratum_target *target)
{
for (inferior *inf : all_inferiors (target))
{
switch_to_inferior_no_thread (inf);
break;
}
}