mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
7438771288
While looking at the regcache code, I noticed that the address space (passed to regcache when constructing it, and available through regcache::aspace) wasn't relevant for the regcache itself. Callers of regcache::aspace use that method because it appears to be a convenient way of getting the address space for a thread, if you already have the regcache. But there is always another way to get the address space, as the callers pretty much always know which thread they are dealing with. The regcache code itself doesn't use the address space. This patch removes anything related to address_space from the regcache code, and updates callers to get it from the thread in context. This removes a bit of unnecessary complexity from the regcache code. The current get_thread_arch_regcache function gets an address_space for the given thread using the target_thread_address_space function (which calls the target_ops::thread_address_space method). This suggest that there might have been the intention of supporting per-thread address spaces. But digging through the history, I did not find any such case. Maybe this method was just added because we needed a way to get an address space from a ptid (because constructing a regcache required an address space), and this seemed like the right way to do it, I don't know. The only implementations of thread_address_space and process_stratum_target::thread_address_space and linux_nat_target::thread_address_space, which essentially just return the inferior's address space. And thread_address_space is only used in the current get_thread_arch_regcache, which gets removed. So, I think that the thread_address_space target method can be removed, and we can assume that it's fine to use the inferior's address space everywhere. Callers of regcache::aspace are updated to get the address space from the relevant inferior, either using some context they already know about, or in last resort using the current global context. So, to summarize: - remove everything in regcache related to address spaces - in particular, remove get_thread_arch_regcache, and rename get_thread_arch_aspace_regcache to get_thread_arch_regcache - remove target_ops::thread_address_space, and target_thread_address_space - adjust all users of regcache::aspace to get the address space another way Change-Id: I04fd41b22c83fe486522af7851c75bcfb31c88c7
271 lines
8.0 KiB
C
271 lines
8.0 KiB
C
/* Target-dependent code for FreeBSD/aarch64.
|
|
|
|
Copyright (C) 2017-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
|
|
#include "gdbarch.h"
|
|
#include "fbsd-tdep.h"
|
|
#include "aarch64-tdep.h"
|
|
#include "aarch64-fbsd-tdep.h"
|
|
#include "inferior.h"
|
|
#include "osabi.h"
|
|
#include "solib-svr4.h"
|
|
#include "target.h"
|
|
#include "tramp-frame.h"
|
|
#include "trad-frame.h"
|
|
|
|
/* Register maps. */
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_gregmap[] =
|
|
{
|
|
{ 30, AARCH64_X0_REGNUM, 8 }, /* x0 ... x29 */
|
|
{ 1, AARCH64_LR_REGNUM, 8 },
|
|
{ 1, AARCH64_SP_REGNUM, 8 },
|
|
{ 1, AARCH64_PC_REGNUM, 8 },
|
|
{ 1, AARCH64_CPSR_REGNUM, 4 },
|
|
{ 0 }
|
|
};
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_fpregmap[] =
|
|
{
|
|
{ 32, AARCH64_V0_REGNUM, 16 }, /* v0 ... v31 */
|
|
{ 1, AARCH64_FPSR_REGNUM, 4 },
|
|
{ 1, AARCH64_FPCR_REGNUM, 4 },
|
|
{ 0 }
|
|
};
|
|
|
|
/* Register numbers are relative to tdep->tls_regnum_base. */
|
|
|
|
static const struct regcache_map_entry aarch64_fbsd_tls_regmap[] =
|
|
{
|
|
{ 1, 0, 8 }, /* tpidr */
|
|
{ 0 }
|
|
};
|
|
|
|
/* In a signal frame, sp points to a 'struct sigframe' which is
|
|
defined as:
|
|
|
|
struct sigframe {
|
|
siginfo_t sf_si;
|
|
ucontext_t sf_uc;
|
|
};
|
|
|
|
ucontext_t is defined as:
|
|
|
|
struct __ucontext {
|
|
sigset_t uc_sigmask;
|
|
mcontext_t uc_mcontext;
|
|
...
|
|
};
|
|
|
|
The mcontext_t contains the general purpose register set followed
|
|
by the floating point register set. The floating point register
|
|
set is only valid if the _MC_FP_VALID flag is set in mc_flags. */
|
|
|
|
#define AARCH64_SIGFRAME_UCONTEXT_OFFSET 80
|
|
#define AARCH64_UCONTEXT_MCONTEXT_OFFSET 16
|
|
#define AARCH64_MCONTEXT_FPREGS_OFFSET 272
|
|
#define AARCH64_MCONTEXT_FLAGS_OFFSET 800
|
|
#define AARCH64_MCONTEXT_FLAG_FP_VALID 0x1
|
|
|
|
/* Implement the "init" method of struct tramp_frame. */
|
|
|
|
static void
|
|
aarch64_fbsd_sigframe_init (const struct tramp_frame *self,
|
|
frame_info_ptr this_frame,
|
|
struct trad_frame_cache *this_cache,
|
|
CORE_ADDR func)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
CORE_ADDR sp = get_frame_register_unsigned (this_frame, AARCH64_SP_REGNUM);
|
|
CORE_ADDR mcontext_addr
|
|
= (sp
|
|
+ AARCH64_SIGFRAME_UCONTEXT_OFFSET
|
|
+ AARCH64_UCONTEXT_MCONTEXT_OFFSET);
|
|
gdb_byte buf[4];
|
|
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_gregmap, mcontext_addr,
|
|
regcache_map_entry_size (aarch64_fbsd_gregmap));
|
|
|
|
if (target_read_memory (mcontext_addr + AARCH64_MCONTEXT_FLAGS_OFFSET, buf,
|
|
4) == 0
|
|
&& (extract_unsigned_integer (buf, 4, byte_order)
|
|
& AARCH64_MCONTEXT_FLAG_FP_VALID))
|
|
trad_frame_set_reg_regmap (this_cache, aarch64_fbsd_fpregmap,
|
|
mcontext_addr + AARCH64_MCONTEXT_FPREGS_OFFSET,
|
|
regcache_map_entry_size (aarch64_fbsd_fpregmap));
|
|
|
|
trad_frame_set_id (this_cache, frame_id_build (sp, func));
|
|
}
|
|
|
|
static const struct tramp_frame aarch64_fbsd_sigframe =
|
|
{
|
|
SIGTRAMP_FRAME,
|
|
4,
|
|
{
|
|
{0x910003e0, ULONGEST_MAX}, /* mov x0, sp */
|
|
{0x91014000, ULONGEST_MAX}, /* add x0, x0, #SF_UC */
|
|
{0xd2803428, ULONGEST_MAX}, /* mov x8, #SYS_sigreturn */
|
|
{0xd4000001, ULONGEST_MAX}, /* svc 0x0 */
|
|
{TRAMP_SENTINEL_INSN, ULONGEST_MAX}
|
|
},
|
|
aarch64_fbsd_sigframe_init
|
|
};
|
|
|
|
/* Register set definitions. */
|
|
|
|
const struct regset aarch64_fbsd_gregset =
|
|
{
|
|
aarch64_fbsd_gregmap,
|
|
regcache_supply_regset, regcache_collect_regset
|
|
};
|
|
|
|
const struct regset aarch64_fbsd_fpregset =
|
|
{
|
|
aarch64_fbsd_fpregmap,
|
|
regcache_supply_regset, regcache_collect_regset
|
|
};
|
|
|
|
static void
|
|
aarch64_fbsd_supply_tls_regset (const struct regset *regset,
|
|
struct regcache *regcache,
|
|
int regnum, const void *buf, size_t size)
|
|
{
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
regcache->supply_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
|
}
|
|
|
|
static void
|
|
aarch64_fbsd_collect_tls_regset (const struct regset *regset,
|
|
const struct regcache *regcache,
|
|
int regnum, void *buf, size_t size)
|
|
{
|
|
struct gdbarch *gdbarch = regcache->arch ();
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
regcache->collect_regset (regset, tdep->tls_regnum_base, regnum, buf, size);
|
|
}
|
|
|
|
const struct regset aarch64_fbsd_tls_regset =
|
|
{
|
|
aarch64_fbsd_tls_regmap,
|
|
aarch64_fbsd_supply_tls_regset, aarch64_fbsd_collect_tls_regset
|
|
};
|
|
|
|
/* Implement the "iterate_over_regset_sections" gdbarch method. */
|
|
|
|
static void
|
|
aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
|
iterate_over_regset_sections_cb *cb,
|
|
void *cb_data,
|
|
const struct regcache *regcache)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
cb (".reg", AARCH64_FBSD_SIZEOF_GREGSET, AARCH64_FBSD_SIZEOF_GREGSET,
|
|
&aarch64_fbsd_gregset, NULL, cb_data);
|
|
cb (".reg2", AARCH64_FBSD_SIZEOF_FPREGSET, AARCH64_FBSD_SIZEOF_FPREGSET,
|
|
&aarch64_fbsd_fpregset, NULL, cb_data);
|
|
|
|
if (tdep->has_tls ())
|
|
cb (".reg-aarch-tls", AARCH64_FBSD_SIZEOF_TLSREGSET,
|
|
AARCH64_FBSD_SIZEOF_TLSREGSET, &aarch64_fbsd_tls_regset,
|
|
"TLS register", cb_data);
|
|
}
|
|
|
|
/* Implement the "core_read_description" gdbarch method. */
|
|
|
|
static const struct target_desc *
|
|
aarch64_fbsd_core_read_description (struct gdbarch *gdbarch,
|
|
struct target_ops *target, bfd *abfd)
|
|
{
|
|
asection *tls = bfd_get_section_by_name (abfd, ".reg-aarch-tls");
|
|
|
|
aarch64_features features;
|
|
features.tls = tls != nullptr? 1 : 0;
|
|
|
|
return aarch64_read_description (features);
|
|
}
|
|
|
|
/* Implement the get_thread_local_address gdbarch method. */
|
|
|
|
static CORE_ADDR
|
|
aarch64_fbsd_get_thread_local_address (struct gdbarch *gdbarch, ptid_t ptid,
|
|
CORE_ADDR lm_addr, CORE_ADDR offset)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
struct regcache *regcache;
|
|
|
|
regcache = get_thread_arch_regcache (current_inferior (), ptid, gdbarch);
|
|
|
|
target_fetch_registers (regcache, tdep->tls_regnum_base);
|
|
|
|
ULONGEST tpidr;
|
|
if (regcache->cooked_read (tdep->tls_regnum_base, &tpidr) != REG_VALID)
|
|
error (_("Unable to fetch %%tpidr"));
|
|
|
|
/* %tpidr points to the TCB whose first member is the dtv
|
|
pointer. */
|
|
CORE_ADDR dtv_addr = tpidr;
|
|
return fbsd_get_thread_local_address (gdbarch, dtv_addr, lm_addr, offset);
|
|
}
|
|
|
|
/* Implement the 'init_osabi' method of struct gdb_osabi_handler. */
|
|
|
|
static void
|
|
aarch64_fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
|
|
|
|
/* Generic FreeBSD support. */
|
|
fbsd_init_abi (info, gdbarch);
|
|
|
|
set_solib_svr4_fetch_link_map_offsets (gdbarch,
|
|
svr4_lp64_fetch_link_map_offsets);
|
|
|
|
tramp_frame_prepend_unwinder (gdbarch, &aarch64_fbsd_sigframe);
|
|
|
|
/* Enable longjmp. */
|
|
tdep->jb_pc = 13;
|
|
|
|
set_gdbarch_iterate_over_regset_sections
|
|
(gdbarch, aarch64_fbsd_iterate_over_regset_sections);
|
|
set_gdbarch_core_read_description (gdbarch,
|
|
aarch64_fbsd_core_read_description);
|
|
|
|
if (tdep->has_tls ())
|
|
{
|
|
set_gdbarch_fetch_tls_load_module_address (gdbarch,
|
|
svr4_fetch_objfile_link_map);
|
|
set_gdbarch_get_thread_local_address
|
|
(gdbarch, aarch64_fbsd_get_thread_local_address);
|
|
}
|
|
}
|
|
|
|
void _initialize_aarch64_fbsd_tdep ();
|
|
void
|
|
_initialize_aarch64_fbsd_tdep ()
|
|
{
|
|
gdbarch_register_osabi (bfd_arch_aarch64, 0, GDB_OSABI_FREEBSD,
|
|
aarch64_fbsd_init_abi);
|
|
}
|