mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
cb001c0d28
The object_p (and archive_p, core_file_p) functions are not supposed to have any target specific malloc'd memory attached to the bfd on their return. This should be obvious on a failure return, but it's also true for a successful return. The reason is that even though the object_p recognises the file, that particular target may not be used and thus the bfd won't be closed calling close_and_cleanup for the target that allocated the memory. It turns out that the object_p bfd_target* return value isn't needed. In all cases except ld/plugin.c the target is abfd->xvec and with ld/plugin.c the target isn't used. So this patch returns a cleanup function from object_p instead, called in bfd_check_format_matches to tidy the bfd before trying a different target match. The only cleanup that does anything at this stage is the alpha-vms one. bfd/ * targets.c (bfd_cleanup): New typedef. (struct bfd <_bfd_check_format>): Return a bfd_cleanup. * libbfd-in.h (_bfd_no_cleanup): Define. * format.c (bfd_reinit): Add cleanup parameter, call it. (bfd_check_format_matches): Set cleanup from _bfd_check_format call and pass to bfd_reinit. Delete temp, use abfd->xvec instead. * aout-target.h (callback, object_p): Return bfd_cleanup. * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise. * archive.c (bfd_generic_archive_p): Likewise. * binary.c (binary_object_p): Likewise. * coff-alpha.c (alpha_ecoff_object_p): Likewise. * coff-ia64.c (ia64coff_object_p): Likewise. * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise. * coff-sh.c (coff_small_object_p): Likewise. * coff-stgo32.c (go32_check_format): Likewise. * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p), (xcoff64_core_p): Likewise. * coffgen.c (coff_real_object_p, coff_object_p): Likewise. * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p), (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise. * elfcode.h (elf_object_p): Likewise. * elfcore.h (elf_core_file_p): Likewise. * i386msdos.c (msdos_object_p): Likewise. * ihex.c (ihex_object_p): Likewise. * libaout.h (some_aout_object_p): Likewise. * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target), (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise. * libbfd.c (_bfd_dummy_target): Likewise. * libcoff-in.h (coff_object_p): Likewise. * mach-o-aarch64.c (bfd_mach_o_arm64_object_p), (bfd_mach_o_arm64_core_p): Likewise. * mach-o-arm.c (bfd_mach_o_arm_object_p), (bfd_mach_o_arm_core_p): Likewise. * mach-o-i386.c (bfd_mach_o_i386_object_p), (bfd_mach_o_i386_core_p): Likewise. * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p), (bfd_mach_o_x86_64_core_p): Likewise. * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p), (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise. * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p), (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise. * mmo.c (mmo_object_p): Likewise. * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise. * peicode.h (coff_real_object_p, pe_ILF_object_p), (pe_bfd_object_p): Likewise. * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise. * ppcboot.c (ppcboot_object_p): Likewise. * rs6000-core.c (rs6000coff_core_p): Likewise. * som.c (som_object_setup, som_object_p): Likewise. * srec.c (srec_object_p, symbolsrec_object_p): Likewise. * tekhex.c (tekhex_object_p): Likewise. * vms-alpha.c (alpha_vms_object_p): Likewise. * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p), (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise. * wasm-module.c (wasm_object_p): Likewise. * xsym.c (bfd_sym_object_p): Likewise. * xsym.h (bfd_sym_object_p): Likewise. * aoutx.h (some_aout_object_p): Likewise, and callback parameter return type. * pdp11.c (some_aout_object_p): Likewise. * plugin.c (register_ld_plugin_object_p): Update object_p parameter type. * plugin.h (register_ld_plugin_object_p): Likewise. * bfd-in2.h: Regenerate. * libbfd.h: Regenerate. * libcoff.h: Regenerate. ld/ * plugin.c (plugin_object_p): Return a bfd_cleanup. (plugin_cleanup): New function.
215 lines
6.0 KiB
C
215 lines
6.0 KiB
C
/* BFD back-end for HP/Intel IA-64 COFF files.
|
|
Copyright (C) 1999-2020 Free Software Foundation, Inc.
|
|
Contributed by David Mosberger <davidm@hpl.hp.com>
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#include "sysdep.h"
|
|
#include "bfd.h"
|
|
#include "libbfd.h"
|
|
#include "coff/ia64.h"
|
|
#include "coff/internal.h"
|
|
#include "coff/pe.h"
|
|
#include "libcoff.h"
|
|
|
|
#define COFF_DEFAULT_SECTION_ALIGNMENT_POWER (2)
|
|
|
|
/* Windows ia64 uses 8K page size. */
|
|
#define COFF_PAGE_SIZE 0x2000
|
|
|
|
static reloc_howto_type howto_table[] =
|
|
{
|
|
EMPTY_HOWTO (0),
|
|
};
|
|
|
|
#define BADMAG(x) IA64BADMAG(x)
|
|
#define IA64 1 /* Customize coffcode.h */
|
|
|
|
#ifdef COFF_WITH_pep
|
|
# undef AOUTSZ
|
|
# define AOUTSZ PEPAOUTSZ
|
|
# define PEAOUTHDR PEPAOUTHDR
|
|
#endif
|
|
|
|
#define RTYPE2HOWTO(cache_ptr, dst) \
|
|
(cache_ptr)->howto = howto_table;
|
|
|
|
#ifdef COFF_WITH_PE
|
|
/* Return TRUE if this relocation should
|
|
appear in the output .reloc section. */
|
|
|
|
static bfd_boolean
|
|
in_reloc_p (bfd * abfd ATTRIBUTE_UNUSED,
|
|
reloc_howto_type *howto ATTRIBUTE_UNUSED)
|
|
{
|
|
return FALSE; /* We don't do relocs for now... */
|
|
}
|
|
#endif
|
|
|
|
#ifndef bfd_pe_print_pdata
|
|
#define bfd_pe_print_pdata NULL
|
|
#endif
|
|
|
|
#include "coffcode.h"
|
|
|
|
static bfd_cleanup
|
|
ia64coff_object_p (bfd *abfd)
|
|
{
|
|
#ifdef COFF_IMAGE_WITH_PE
|
|
{
|
|
struct external_DOS_hdr dos_hdr;
|
|
struct external_PEI_IMAGE_hdr image_hdr;
|
|
file_ptr offset;
|
|
|
|
if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0
|
|
|| (bfd_bread (&dos_hdr, (bfd_size_type) sizeof (dos_hdr), abfd)
|
|
!= sizeof (dos_hdr)))
|
|
{
|
|
if (bfd_get_error () != bfd_error_system_call)
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
return NULL;
|
|
}
|
|
|
|
/* There are really two magic numbers involved; the magic number
|
|
that says this is a NT executable (PEI) and the magic number
|
|
that determines the architecture. The former is IMAGE_DOS_SIGNATURE,
|
|
stored in the e_magic field. The latter is stored in the
|
|
f_magic field. If the NT magic number isn't valid, the
|
|
architecture magic number could be mimicked by some other
|
|
field (specifically, the number of relocs in section 3). Since
|
|
this routine can only be called correctly for a PEI file, check
|
|
the e_magic number here, and, if it doesn't match, clobber the
|
|
f_magic number so that we don't get a false match. */
|
|
if (H_GET_16 (abfd, dos_hdr.e_magic) != IMAGE_DOS_SIGNATURE)
|
|
{
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
return NULL;
|
|
}
|
|
|
|
offset = H_GET_32 (abfd, dos_hdr.e_lfanew);
|
|
if (bfd_seek (abfd, offset, SEEK_SET) != 0
|
|
|| (bfd_bread (&image_hdr, (bfd_size_type) sizeof (image_hdr), abfd)
|
|
!= sizeof (image_hdr)))
|
|
{
|
|
if (bfd_get_error () != bfd_error_system_call)
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
return NULL;
|
|
}
|
|
|
|
if (H_GET_32 (abfd, image_hdr.nt_signature)
|
|
!= 0x4550)
|
|
{
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
return NULL;
|
|
}
|
|
|
|
/* Here is the hack. coff_object_p wants to read filhsz bytes to
|
|
pick up the COFF header for PE, see "struct external_PEI_filehdr"
|
|
in include/coff/pe.h. We adjust so that that will work. */
|
|
if (bfd_seek (abfd, offset - sizeof (dos_hdr), SEEK_SET) != 0)
|
|
{
|
|
if (bfd_get_error () != bfd_error_system_call)
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
return NULL;
|
|
}
|
|
}
|
|
#endif
|
|
|
|
return coff_object_p (abfd);
|
|
}
|
|
|
|
const bfd_target
|
|
#ifdef TARGET_SYM
|
|
TARGET_SYM =
|
|
#else
|
|
ia64coff_vec =
|
|
#endif
|
|
{
|
|
#ifdef TARGET_NAME
|
|
TARGET_NAME,
|
|
#else
|
|
"coff-ia64", /* name */
|
|
#endif
|
|
bfd_target_coff_flavour,
|
|
BFD_ENDIAN_LITTLE, /* data byte order is little */
|
|
BFD_ENDIAN_LITTLE, /* header byte order is little */
|
|
|
|
(HAS_RELOC | EXEC_P /* object flags */
|
|
| HAS_LINENO | HAS_DEBUG
|
|
| HAS_SYMS | HAS_LOCALS | WP_TEXT | D_PAGED),
|
|
|
|
#ifndef COFF_WITH_PE
|
|
(SEC_HAS_CONTENTS | SEC_ALLOC | SEC_LOAD | SEC_RELOC /* section flags */
|
|
| SEC_CODE | SEC_DATA),
|
|
#else
|
|
(SEC_HAS_CONTENTS | SEC_ALLOC | SEC_LOAD | SEC_RELOC /* section flags */
|
|
| SEC_CODE | SEC_DATA
|
|
| SEC_LINK_ONCE | SEC_LINK_DUPLICATES),
|
|
#endif
|
|
|
|
#ifdef TARGET_UNDERSCORE
|
|
TARGET_UNDERSCORE, /* leading underscore */
|
|
#else
|
|
0, /* leading underscore */
|
|
#endif
|
|
'/', /* ar_pad_char */
|
|
15, /* ar_max_namelen */
|
|
0, /* match priority. */
|
|
|
|
bfd_getl64, bfd_getl_signed_64, bfd_putl64,
|
|
bfd_getl32, bfd_getl_signed_32, bfd_putl32,
|
|
bfd_getl16, bfd_getl_signed_16, bfd_putl16, /* data */
|
|
bfd_getl64, bfd_getl_signed_64, bfd_putl64,
|
|
bfd_getl32, bfd_getl_signed_32, bfd_putl32,
|
|
bfd_getl16, bfd_getl_signed_16, bfd_putl16, /* hdrs */
|
|
|
|
/* Note that we allow an object file to be treated as a core file as well. */
|
|
{ /* bfd_check_format */
|
|
_bfd_dummy_target,
|
|
ia64coff_object_p,
|
|
bfd_generic_archive_p,
|
|
ia64coff_object_p
|
|
},
|
|
{ /* bfd_set_format */
|
|
_bfd_bool_bfd_false_error,
|
|
coff_mkobject,
|
|
_bfd_generic_mkarchive,
|
|
_bfd_bool_bfd_false_error
|
|
},
|
|
{ /* bfd_write_contents */
|
|
_bfd_bool_bfd_false_error,
|
|
coff_write_object_contents,
|
|
_bfd_write_archive_contents,
|
|
_bfd_bool_bfd_false_error
|
|
},
|
|
|
|
BFD_JUMP_TABLE_GENERIC (coff),
|
|
BFD_JUMP_TABLE_COPY (coff),
|
|
BFD_JUMP_TABLE_CORE (_bfd_nocore),
|
|
BFD_JUMP_TABLE_ARCHIVE (_bfd_archive_coff),
|
|
BFD_JUMP_TABLE_SYMBOLS (coff),
|
|
BFD_JUMP_TABLE_RELOCS (coff),
|
|
BFD_JUMP_TABLE_WRITE (coff),
|
|
BFD_JUMP_TABLE_LINK (coff),
|
|
BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic),
|
|
|
|
NULL,
|
|
|
|
COFF_SWAP_TABLE
|
|
};
|