mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-03-07 13:39:43 +08:00
8480a37e14
We currently pass frames to function by value, as `frame_info_ptr`.
This is somewhat expensive:
- the size of `frame_info_ptr` is 64 bytes, which is a bit big to pass
by value
- the constructors and destructor link/unlink the object in the global
`frame_info_ptr::frame_list` list. This is an `intrusive_list`, so
it's not so bad: it's just assigning a few points, there's no memory
allocation as if it was `std::list`, but still it's useless to do
that over and over.
As suggested by Tom Tromey, change many function signatures to accept
`const frame_info_ptr &` instead of `frame_info_ptr`.
Some functions reassign their `frame_info_ptr` parameter, like:
void
the_func (frame_info_ptr frame)
{
for (; frame != nullptr; frame = get_prev_frame (frame))
{
...
}
}
I wondered what to do about them, do I leave them as-is or change them
(and need to introduce a separate local variable that can be
re-assigned). I opted for the later for consistency. It might not be
clear why some functions take `const frame_info_ptr &` while others take
`frame_info_ptr`. Also, if a function took a `frame_info_ptr` because
it did re-assign its parameter, I doubt that we would think to change it
to `const frame_info_ptr &` should the implementation change such that
it doesn't need to take `frame_info_ptr` anymore. It seems better to
have a simple rule and apply it everywhere.
Change-Id: I59d10addef687d157f82ccf4d54f5dde9a963fd0
Approved-By: Andrew Burgess <aburgess@redhat.com>
|
||
|---|---|---|
| .. | ||
| abbrev-cache.c | ||
| abbrev-cache.h | ||
| abbrev.c | ||
| abbrev.h | ||
| ada-imported.c | ||
| aranges.c | ||
| aranges.h | ||
| attribute.c | ||
| attribute.h | ||
| call-site.h | ||
| comp-unit-head.c | ||
| comp-unit-head.h | ||
| cooked-index.c | ||
| cooked-index.h | ||
| cu.c | ||
| cu.h | ||
| die.c | ||
| die.h | ||
| dwz.c | ||
| dwz.h | ||
| expr.c | ||
| expr.h | ||
| file-and-dir.h | ||
| frame-tailcall.c | ||
| frame-tailcall.h | ||
| frame.c | ||
| frame.h | ||
| index-cache.c | ||
| index-cache.h | ||
| index-common.c | ||
| index-common.h | ||
| index-write.c | ||
| index-write.h | ||
| leb.c | ||
| leb.h | ||
| line-header.c | ||
| line-header.h | ||
| loc.c | ||
| loc.h | ||
| macro.c | ||
| macro.h | ||
| mapped-index.h | ||
| public.h | ||
| read-debug-names.c | ||
| read-debug-names.h | ||
| read-gdb-index.c | ||
| read-gdb-index.h | ||
| read.c | ||
| read.h | ||
| sect-names.h | ||
| section.c | ||
| section.h | ||
| stringify.c | ||
| stringify.h | ||
| tag.h | ||
| types.h | ||