binutils-gdb/gdb/testsuite/gdb.base/dcache-line-read-error.c
Pedro Alves 0256a6ac4b Make the dcache (code/stack cache) handle line reading errors better
The dcache (code/stack cache) is supposed to be transparent, but it's
actually not in one case.  dcache tries to read chunks (cache lines)
at a time off of the target.  This may end up trying to read
unaccessible or unavailable memory.  Currently the caller gets an xfer
error in this case.  But if the specific bits of memory the caller
actually wanted are available and accessible, then the caller should
get the memory it wanted, not an error.

gdb/
2014-05-21  Pedro Alves  <palves@redhat.com>

	* dcache.c (dcache_read_memory_partial): If reading the cache line
	fails, fallback to reading just the memory the caller wanted.

gdb/testsuite/
2014-05-21  Pedro Alves  <palves@redhat.com>

	* gdb.base/dcache-line-read-error.c: New.
	* gdb.base/dcache-line-read-error.exp: New.
2014-05-21 13:58:16 +01:00

108 lines
2.7 KiB
C

/* This testcase is part of GDB, the GNU debugger.
Copyright 2012-2014 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <stdlib.h>
#include <stdio.h>
#include <sys/mman.h>
#include <unistd.h>
#include <string.h>
size_t pg_size;
void *first_mapped_page;
void *last_mapped_page;
void
breakpt (void)
{
/* Nothing. */
}
int
main (void)
{
void *p;
int pg_count;
size_t i;
/* Map 6 contiguous pages, and then unmap all second first, and
second last.
From GDB we will disassemble each of the _mapped_ pages, with a
code-cache (dcache) line size bigger than the page size (twice
bigger). This makes GDB try to read one page before the mapped
page once, and the page after another time. GDB should give no
error in either case.
That is, depending on where the kernel aligns the pages, we get
either:
.---.---.---.---.---.---.
| U | M | U | U | M | U |
'---'---'---'---'---'---.
| | | | <- line alignment
^^^^^^^ ^^^^^^^
| |
+ line1 + line2
Or:
.---.---.---.---.---.---.
| U | M | U | U | M | U |
'---'---'---'---'---'---.
| | | <- line alignment
^^^^^^^ ^^^^^^^
| |
line1 + + line2
Note we really want to test that dcache behaves correctly when
reading a cache line fails. We're just using unmapped memory as
proxy for any kind of error. */
pg_size = getpagesize ();
pg_count = 6;
p = mmap (0, pg_count * pg_size, PROT_READ|PROT_WRITE,
MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
if (p == MAP_FAILED)
{
perror ("mmap");
return EXIT_FAILURE;
}
/* Leave memory zero-initialized. Disassembling 0s should behave on
all targets. */
for (i = 0; i < pg_count; i++)
{
if (i == 1 || i == 4)
continue;
if (munmap (p + (i * pg_size), pg_size) == -1)
{
perror ("munmap");
return EXIT_FAILURE;
}
}
first_mapped_page = p + 1 * pg_size;;
last_mapped_page = p + 4 * pg_size;
breakpt ();
return EXIT_SUCCESS;
}