mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
c3b7b696c2
I see the following fail on arm-none-eabi target,
(gdb) b 24^M
Breakpoint 1 at 0x4: file
../../../../git/gdb/testsuite/gdb.base/break-on-linker-gcd-function.cc,
line 24.^M
(gdb) FAIL: gdb.base/break-on-linker-gcd-function.exp: b 24
Currently, we are using flag has_section_at_zero to determine whether
address zero in debug info means the corresponding code has been
GC'ed, like this:
case DW_LNE_set_address:
address = read_address (abfd, line_ptr, cu, &bytes_read);
if (address == 0 && !dwarf2_per_objfile->has_section_at_zero)
{
/* This line table is for a function which has been
GCd by the linker. Ignore it. PR gdb/12528 */
However, this is incorrect on some bare metal targets, as .text
section is located at 0x0, so dwarf2_per_objfile->has_section_at_zero
is true. If a function is GC'ed by linker, the address is zero. GDB
thinks address zero is a function's address rather than this function
is GC'ed.
In this patch, we choose 'lowpc' got in read_file_scope to check
whether 'lowpc' is greater than zero. If it isn't, address zero really
means the function is GC'ed. In this patch, we pass 'lowpc' in
read_file_scope through handle_DW_AT_stmt_list and dwarf_decode_lines,
and to dwarf_decode_lines_1 finally.
This patch fixes the fail above. This patch also covers the path that
partial symbol isn't used, which is tested by starting gdb with
--readnow option.
It is regression tested on x86-linux with
target_board=dwarf4-gdb-index, and arm-none-eabi. OK to apply?
gdb:
2014-09-19 Yao Qi <yao@codesourcery.com>
* dwarf2read.c (dwarf_decode_lines): Update declaration.
(handle_DW_AT_stmt_list): Add argument 'lowpc'. Update
comments. Callers update.
(dwarf_decode_lines): Likewise.
(dwarf_decode_lines_1): Add argument 'lowpc'. Update
comments. Skip the line table if 'lowpc' is greater than
'address'. Don't check
dwarf2_per_objfile->has_section_at_zero.
gdb/testsuite:
2014-09-19 Yao Qi <yao@codesourcery.com>
* gdb.base/break-on-linker-gcd-function.exp: Move test into new
proc set_breakpoint_on_gcd_function. Invoke
set_breakpoint_on_gcd_function. Restart GDB with --readnow and
invoke set_breakpoint_on_gcd_function again.
64 lines
1.8 KiB
Plaintext
64 lines
1.8 KiB
Plaintext
# Copyright 2011-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the gdb testsuite
|
|
|
|
# Test casting, especially between class types or pointer-to-class
|
|
# types.
|
|
|
|
# This file is part of the gdb testsuite
|
|
|
|
#
|
|
# test running programs
|
|
#
|
|
if { [skip_cplus_tests] } { continue }
|
|
|
|
standard_testfile .cc
|
|
|
|
if [get_compiler_info "c++"] {
|
|
return -1
|
|
}
|
|
|
|
set additional_flags {-ffunction-sections -Wl,--gc-sections}
|
|
if {[build_executable_from_specs $testfile.exp $testfile \
|
|
{c++ additional_flags=-Wl,--gc-sections} \
|
|
$srcfile {debug c++ additional_flags=-ffunction-sections}]} {
|
|
untested $testfile.exp
|
|
return -1
|
|
}
|
|
|
|
clean_restart $testfile
|
|
|
|
proc set_breakpoint_on_gcd_function {} {
|
|
# Single hex digit
|
|
set xd {[0-9a-f]}
|
|
|
|
# This accepts e.g. "Breakpoint 1 at 0x40968a" (fixed GDB)
|
|
# but rejects e.g. "Breakpoint 1 at 0x4" (broken GDB).
|
|
gdb_test "b [gdb_get_line_number "gdb break here"]" \
|
|
"Breakpoint \[0-9\] at 0x${xd}${xd}+: .*"
|
|
}
|
|
|
|
set_breakpoint_on_gcd_function
|
|
|
|
set saved_gdbflags $GDBFLAGS
|
|
set GDBFLAGS "$GDBFLAGS --readnow"
|
|
clean_restart ${testfile}
|
|
set GDBFLAGS $saved_gdbflags
|
|
|
|
with_test_prefix "readnow" {
|
|
set_breakpoint_on_gcd_function
|
|
}
|