mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
bbb826f5e9
After commit:
commit 51a948fdf0
Date: Mon Jul 20 14:18:04 2020 +0100
gdb: Have allocate_target_description return a unique_ptr
There were a few places where we could (should?) have delayed
releasing the target_desc_up until a little later. This commit
catches these cases.
In the case of ARC, the target_desc_up is now exposed right out to
gdbserver, which means making a small change there too.
There should be no user visible changes after this commit.
gdb/ChangeLog:
* arch/aarch32.c (aarch32_create_target_description): Release the
target_desc_up as late as possible.
* arch/aarch64.c (aarch64_create_target_description): Likewise.
* arch/amd64.c (amd64_create_target_description): Likewise.
* arch/arc.c (arc_create_target_description): Return a
target_desc_up, don't release it.
* arch/arc.h (arc_create_target_description): Update declaration.
(arc_lookup_target_description): Move target_desc_up into the
cache, and return a borrowed pointer.
* arch/arm.c (arm_create_target_description): Release the
target_desc_up as late as possible.
* arch/i386.c (i386_create_target_description): Likewise.
* arch/riscv.h (riscv_create_target_description): Update
declaration to match definition.
* arch/tic6x.c (tic6x_create_target_description): Release the
target_desc_up as late as possible.
gdbserver/ChangeLog:
* linux-arc-low.cc (arc_linux_read_description): Release the
unique_ptr returned from arc_create_target_description.
80 lines
2.6 KiB
C
80 lines
2.6 KiB
C
/* Copyright (C) 2017-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "gdbsupport/common-defs.h"
|
|
#include "amd64.h"
|
|
#include "gdbsupport/x86-xstate.h"
|
|
#include <stdlib.h>
|
|
|
|
#include "../features/i386/64bit-avx.c"
|
|
#include "../features/i386/64bit-avx512.c"
|
|
#include "../features/i386/64bit-core.c"
|
|
#include "../features/i386/64bit-linux.c"
|
|
#include "../features/i386/64bit-mpx.c"
|
|
#include "../features/i386/64bit-pkeys.c"
|
|
#include "../features/i386/64bit-segments.c"
|
|
#include "../features/i386/64bit-sse.c"
|
|
|
|
#include "../features/i386/x32-core.c"
|
|
|
|
/* Create amd64 target descriptions according to XCR0. If IS_X32 is
|
|
true, create the x32 ones. If IS_LINUX is true, create target
|
|
descriptions for Linux. If SEGMENTS is true, then include
|
|
the "org.gnu.gdb.i386.segments" feature registers. */
|
|
|
|
target_desc *
|
|
amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux,
|
|
bool segments)
|
|
{
|
|
target_desc_up tdesc = allocate_target_description ();
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
set_tdesc_architecture (tdesc.get (),
|
|
is_x32 ? "i386:x64-32" : "i386:x86-64");
|
|
|
|
if (is_linux)
|
|
set_tdesc_osabi (tdesc.get (), "GNU/Linux");
|
|
#endif
|
|
|
|
long regnum = 0;
|
|
|
|
if (is_x32)
|
|
regnum = create_feature_i386_x32_core (tdesc.get (), regnum);
|
|
else
|
|
regnum = create_feature_i386_64bit_core (tdesc.get (), regnum);
|
|
|
|
regnum = create_feature_i386_64bit_sse (tdesc.get (), regnum);
|
|
if (is_linux)
|
|
regnum = create_feature_i386_64bit_linux (tdesc.get (), regnum);
|
|
if (segments)
|
|
regnum = create_feature_i386_64bit_segments (tdesc.get (), regnum);
|
|
|
|
if (xcr0 & X86_XSTATE_AVX)
|
|
regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum);
|
|
|
|
if ((xcr0 & X86_XSTATE_MPX) && !is_x32)
|
|
regnum = create_feature_i386_64bit_mpx (tdesc.get (), regnum);
|
|
|
|
if (xcr0 & X86_XSTATE_AVX512)
|
|
regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum);
|
|
|
|
if ((xcr0 & X86_XSTATE_PKRU) && !is_x32)
|
|
regnum = create_feature_i386_64bit_pkeys (tdesc.get (), regnum);
|
|
|
|
return tdesc.release ();
|
|
}
|