mirror/binutils-gdb
2
0
Fork 0
mirror of https://sourceware.org/git/binutils-gdb.git synced 2024-12-09 04:21:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
1bc1068a0c
binutils-gdb/sim/cris
History
Joel Brobecker 2d7bb7580a callback.h:struct host_callback_struct compilation error on Windows hosts. 
On Windows, a recent gnulib update imported the lstat module, and
this caused a remote-sim.c build failure in struct host_callback_struct:

    In file included from /[...]/gdb/remote-sim.c:34:0:
    /[...]/gdb/../include/gdb/callback.h:93:9: error: duplicate member '_stati64'
       int (*lstat) (host_callback *, const char *, struct stat *);
             ^
What happens it that gnulib's stat.h makes the following defines:

     /* Large File Support on native Windows.  */
     #if 1
     # define stat _stati64
     #endif

and then:

    #if 1
    # if ! 0
    /* mingw does not support symlinks, therefore it does not have lstat.  But
       without links, stat does just fine.  */
    #  if !(defined __cplusplus && defined GNULIB_NAMESPACE)
    #   define lstat stat
    #  endif

So, the following fields in struct host_callback_struct...

      int (*stat) (host_callback *, const char *, struct stat *);
      int (*fstat) (host_callback *, int, struct stat *);
      int (*lstat) (host_callback *, const char *, struct stat *);

... get translated to...

      int (*_stati64) (host_callback *, const char *, struct _stati64 *);
      int (*_fstati64) (host_callback *, int, struct _stati64 *);
      int (*_stati64) (host_callback *, const char *, struct _stati64 *);

... which causes two fields to have the same name.

This patch fixes the issue by renaming the stat-related fields
by adding a "to_" prefix, similar to what is done in GDB's
target_ops vector.

include/gdb/ChangeLog:

	* callback.h (struct host_callback_struct) <to_stat>: Renamed
	from "stat".
	<to_fstat>: Renamed from "fstat".
	<to_lstat>: Renamed from "lstat".

sim/common/ChangeLog:

	* sim-io.c (sim_io_stat, sim_io_fstat): Adjust calls to "stat"
	and "fstat" callbacks by calls to "to_stat" and "to_fstat" (resp)
	callbacks following renaming in callback.h.
	* syscall.c (cb_syscall): Likewise.  Adjust calls to "lstat"
	callback by call to "to_lstat" callback

sim/cris/ChangeLog:

	* traps.c (cris_break_13_handler): Adjust call to "fstat" callback
	by call to "to_fstat" following renaming in callback.h.

sim/h8300/ChangeLog:

	* compile.c (sim_resume):  Adjust calls to "stat" and "fstat"
	callbacks by calls to "to_stat" and "to_fstat" (resp) callbacks
	following renaming in callback.h.
2014-12-03 13:43:08 +04:00
..
aclocal.m4 sim: use AM_MAINTAINER_MODE 2013-06-05 01:42:13 +00:00
arch.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
arch.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
ChangeLog callback.h:struct host_callback_struct compilation error on Windows hosts. 2014-12-03 13:43:08 +04:00
config.in Regenerate sim configury. 2014-08-15 15:51:50 -07:00
configure Fix --diable-shared --enable-plugins build breakage 2014-08-19 21:59:56 +09:30
configure.ac sim: rename common/aclocal.m4 to common/acinclude.m4 2011-10-18 00:31:00 +00:00
cpuall.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cpuv10.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cpuv10.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cpuv32.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cpuv32.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cris-desc.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cris-desc.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cris-opc.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cris-sim.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
cris-tmpl.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
crisv10f.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
crisv32f.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
decodev10.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
decodev10.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
decodev32.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
decodev32.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
devices.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
dv-cris.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
dv-rv.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
Makefile.in Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
mloop.in Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
modelv10.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
modelv32.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
rvdummy.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
semcrisv10f-switch.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
semcrisv32f-switch.c Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
sim-if.c sim: constify prog_name 2014-03-05 01:42:44 -05:00
sim-main.h Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
tconfig.in Update Copyright year range in all files maintained by GDB. 2014-01-01 07:54:24 +04:00
traps.c callback.h:struct host_callback_struct compilation error on Windows hosts. 2014-12-03 13:43:08 +04:00