mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
17c6c9d9f3
The microMIPS JALX instruction shares the R_MICROMIPS_26_S1 relocation with microMIPS J/JAL/JALS instructions, however unlike the latters its encoded immediate argument is unusually shifted left by 2 rather than 1 in calculating the value used for the operation requested. We already handle this exception in `mips_elf_calculate_relocation' in LD, in a scenario where JALX is produced as a result of relaxing JAL for the purpose of making a cross-mode jump. We also get it right in the disassembler in `decode_micromips_operand'. What we don't correctly do however is processing microMIPS JALX produced by GAS from an assembly source, where a non-zero constant argument or a symbol reference with a non-zero in-place addend has been used. In this case the same calculation is made as for microMIPS J/JAL/JALS, causing the wrong encoding to be produced by GAS on making an object file, and then again by LD in the final link. The latter in particular causes the calculation, where the addend fits in the relocatable field, to produce different final addresses for the same source code depending on whether REL or RELA relocations are used. Correct these issues by special-casing microMIPS JALX in the places that have been previously missed. bfd/ * elfxx-mips.c (mips_elf_read_rel_addend): Adjust the addend for microMIPS JALX. gas/ * config/tc-mips.c (append_insn): Correct the encoding of a constant argument for microMIPS JALX. (tc_gen_reloc): Correct the encoding of an in-place addend for microMIPS JALX. * testsuite/gas/mips/jalx-addend.d: New test. * testsuite/gas/mips/jalx-addend-n32.d: New test. * testsuite/gas/mips/jalx-addend-n64.d: New test. * testsuite/gas/mips/jalx-imm.d: New test. * testsuite/gas/mips/jalx-imm-n32.d: New test. * testsuite/gas/mips/jalx-imm-n64.d: New test. * testsuite/gas/mips/jalx-addend.s: New test source. * testsuite/gas/mips/jalx-imm.s: New test source. * testsuite/gas/mips/mips.exp: Run the new tests. ld/ * testsuite/ld-mips-elf/jalx-addend.d: New test. * testsuite/ld-mips-elf/jalx-addend-n32.d: New test. * testsuite/ld-mips-elf/jalx-addend-n64.d: New test. * testsuite/ld-mips-elf/mips-elf.exp: Run the new tests. |
||
|---|---|---|
| .. | ||
| config | ||
| ld-aarch64 | ||
| ld-alpha | ||
| ld-arc | ||
| ld-arm | ||
| ld-auto-import | ||
| ld-avr | ||
| ld-bootstrap | ||
| ld-cdtest | ||
| ld-checks | ||
| ld-cris | ||
| ld-crx | ||
| ld-cygwin | ||
| ld-d10v | ||
| ld-discard | ||
| ld-elf | ||
| ld-elfcomm | ||
| ld-elfvers | ||
| ld-elfvsb | ||
| ld-elfweak | ||
| ld-fastcall | ||
| ld-frv | ||
| ld-gc | ||
| ld-h8300 | ||
| ld-i386 | ||
| ld-ia64 | ||
| ld-ifunc | ||
| ld-libs | ||
| ld-linkonce | ||
| ld-m68hc11 | ||
| ld-m68k | ||
| ld-mep | ||
| ld-metag | ||
| ld-mips-elf | ||
| ld-misc | ||
| ld-mmix | ||
| ld-mn10300 | ||
| ld-nds32 | ||
| ld-nios2 | ||
| ld-pe | ||
| ld-pie | ||
| ld-plugin | ||
| ld-powerpc | ||
| ld-s390 | ||
| ld-scripts | ||
| ld-selective | ||
| ld-sh | ||
| ld-shared | ||
| ld-size | ||
| ld-sparc | ||
| ld-spu | ||
| ld-srec | ||
| ld-tic6x | ||
| ld-tilegx | ||
| ld-tilepro | ||
| ld-undefined | ||
| ld-unique | ||
| ld-v850 | ||
| ld-vax-elf | ||
| ld-versados | ||
| ld-visium | ||
| ld-vxworks | ||
| ld-x86-64 | ||
| ld-xc16x | ||
| ld-xstormy16 | ||
| ld-xtensa | ||
| lib | ||
| ChangeLog-2004 | ||
| ChangeLog-2005 | ||
| ChangeLog-2006 | ||
| ChangeLog-2007 | ||
| ChangeLog-2008 | ||
| ChangeLog-2009 | ||
| ChangeLog-2010 | ||
| ChangeLog-2011 | ||
| ChangeLog-2012 | ||
| ChangeLog-2013 | ||
| ChangeLog-2014 | ||
| ChangeLog-2015 | ||
| ChangeLog-9303 | ||