mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
991ff2922a
Commit 61b04dd04a
("Change inline frame breakpoint skipping logic
(fix gdb.gdb/selftest.exp)") caused a GDB crash when you set a
breakpoint by line number in an inline function, and then run to the
breakpoint:
$ gdb -q test Reading symbols from test...done.
(gdb) b inline-break.c:32
Breakpoint 1 at 0x40062f: file inline-break.c, line 32.
(gdb) run
Starting program: /[...]/test
[1] 75618 segmentation fault /[...]/gdb -q test
The problem occurs because we assume that a bp_location's symbol is
not NULL, which is not true when we set the breakpoint with a linespec
location:
Program received signal SIGSEGV, Segmentation fault.
0x00000000006f42bb in stopped_by_user_bp_inline_frame (
stop_chain=<optimized out>, frame_block=<optimized out>)
at gdb/inline-frame.c:305
305 && frame_block == SYMBOL_BLOCK_VALUE (loc->symbol))
(gdb) p loc->symbol
$1 = (const symbol *) 0x0
The same thing happens if you run to a breakpoint set in an inline
function by address:
(gdb) b *0x40062f
Breakpoint 3 at 0x40062f: file inline-break.c, line 32.
To fix this, add a null pointer check, to avoid the crash, and make it
so that if there's no symbol for the location, then we present the
stop at the inline function. This preserves the previous behavior
when e.g., setting a breakpoint by address, with "b *ADDRESS".
gdb/ChangeLog:
2018-06-29 Pedro Alves <palves@redhat.com>
* inline-frame.c (stopped_by_user_bp_inline_frame): Return
true if the the location has no symbol.
gdb/testsuite/ChangeLog:
2018-06-29 Pedro Alves <palves@redhat.com>
* gdb.opt/inline-break.c (func1): Add "break here" marker.
* gdb.opt/inline-break.exp: Test setting breakpoints by line
number and address and running to them.
244 lines
4.4 KiB
C
244 lines
4.4 KiB
C
/* This testcase is part of GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2012-2018 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
/* The file ../gdb.dwarf2/inline-break.S was generated manually from
|
|
this file, and should be regenerated if this file is modified. */
|
|
|
|
#ifdef __GNUC__
|
|
# define ATTR __attribute__((gnu_inline)) __attribute__((always_inline))
|
|
#else
|
|
# define ATTR
|
|
#endif
|
|
|
|
/* A static inlined function that is called once. */
|
|
|
|
static inline ATTR int
|
|
func1 (int x)
|
|
{
|
|
return x * 23; /* break here */
|
|
}
|
|
|
|
/* A non-static inlined function that is called once. */
|
|
|
|
inline ATTR int
|
|
func2 (int x)
|
|
{
|
|
return x * 17;
|
|
}
|
|
|
|
/* A static inlined function that calls another static inlined
|
|
function. */
|
|
|
|
static inline ATTR int
|
|
func3b (int x)
|
|
{
|
|
return x < 14 ? 1 : 2;
|
|
}
|
|
|
|
static inline ATTR int
|
|
func3a (int x)
|
|
{
|
|
return func3b (x * 23);
|
|
}
|
|
|
|
/* A non-static inlined function that calls a static inlined
|
|
function. */
|
|
|
|
static inline ATTR int
|
|
func4b (int x)
|
|
{
|
|
return x < 13 ? 1 : 2;
|
|
}
|
|
|
|
inline ATTR int
|
|
func4a (int x)
|
|
{
|
|
return func4b (x * 17);
|
|
}
|
|
|
|
/* A static inlined function that calls a non-static inlined
|
|
function. */
|
|
|
|
inline ATTR int
|
|
func5b (int x)
|
|
{
|
|
return x < 12 ? 1 : 2;
|
|
}
|
|
|
|
static inline ATTR int
|
|
func5a (int x)
|
|
{
|
|
return func5b (x * 23);
|
|
}
|
|
|
|
/* A non-static inlined function that calls another non-static inlined
|
|
function. */
|
|
|
|
inline ATTR int
|
|
func6b (int x)
|
|
{
|
|
return x < 14 ? 3 : 2;
|
|
}
|
|
|
|
inline ATTR int
|
|
func6a (int x)
|
|
{
|
|
return func6b (x * 17);
|
|
}
|
|
|
|
/* A static inlined function that is called more than once. */
|
|
|
|
static inline ATTR int
|
|
func7b (int x)
|
|
{
|
|
return x < 23 ? 1 : 4;
|
|
}
|
|
|
|
static inline ATTR int
|
|
func7a (int x)
|
|
{
|
|
return func7b (x * 29);
|
|
}
|
|
|
|
/* A non-static inlined function that is called more than once. */
|
|
|
|
inline ATTR int
|
|
func8b (int x)
|
|
{
|
|
return x < 7 ? 11 : 9;
|
|
}
|
|
|
|
static inline ATTR int
|
|
func8a (int x)
|
|
{
|
|
return func8b (x * 31);
|
|
}
|
|
|
|
static inline ATTR int
|
|
inline_func1 (int x)
|
|
{
|
|
int y = 1; /* inline_func1 */
|
|
|
|
return y + x;
|
|
}
|
|
|
|
static int
|
|
not_inline_func1 (int x)
|
|
{
|
|
int y = 2; /* not_inline_func1 */
|
|
|
|
return y + inline_func1 (x);
|
|
}
|
|
|
|
inline ATTR int
|
|
inline_func2 (int x)
|
|
{
|
|
int y = 3; /* inline_func2 */
|
|
|
|
return y + not_inline_func1 (x);
|
|
}
|
|
|
|
int
|
|
not_inline_func2 (int x)
|
|
{
|
|
int y = 4; /* not_inline_func2 */
|
|
|
|
return y + inline_func2 (x);
|
|
}
|
|
|
|
static inline ATTR int
|
|
inline_func3 (int x)
|
|
{
|
|
int y = 5; /* inline_func3 */
|
|
|
|
return y + not_inline_func2 (x);
|
|
}
|
|
|
|
static int
|
|
not_inline_func3 (int x)
|
|
{
|
|
int y = 6; /* not_inline_func3 */
|
|
|
|
return y + inline_func3 (x);
|
|
}
|
|
|
|
/* The following three functions serve to exercise GDB's inline frame
|
|
skipping logic when setting a user breakpoint on an inline function
|
|
by name. */
|
|
|
|
/* A static inlined function that is called by another static inlined
|
|
function. */
|
|
|
|
static inline ATTR int
|
|
func_inline_callee (int x)
|
|
{
|
|
return x * 23;
|
|
}
|
|
|
|
/* A static inlined function that calls another static inlined
|
|
function. The body of the function is as simple as possible so
|
|
that both functions are inlined to the same PC address. */
|
|
|
|
static inline ATTR int
|
|
func_inline_caller (int x)
|
|
{
|
|
return func_inline_callee (x);
|
|
}
|
|
|
|
/* An extern not-inline function that calls a static inlined
|
|
function. */
|
|
|
|
int
|
|
func_extern_caller (int x)
|
|
{
|
|
return func_inline_caller (x);
|
|
}
|
|
|
|
/* Entry point. */
|
|
|
|
int
|
|
main (int argc, char *argv[])
|
|
{
|
|
/* Declaring x as volatile here prevents GCC from combining calls.
|
|
If GCC is allowed to combine calls then some of them end up with
|
|
no instructions at all, so there is no specific address for GDB
|
|
to set a breakpoint at. */
|
|
volatile int x = argc;
|
|
|
|
x = func1 (x);
|
|
|
|
x = func2 (x);
|
|
|
|
x = func3a (x);
|
|
|
|
x = func4a (x);
|
|
|
|
x = func5a (x);
|
|
|
|
x = func6a (x);
|
|
|
|
x = func7a (x) + func7b (x);
|
|
|
|
x = func8a (x) + func8b (x);
|
|
|
|
x = not_inline_func3 (-21);
|
|
|
|
func_extern_caller (1);
|
|
|
|
return x;
|
|
}
|