mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
d7e747318f
This patch starts from the desire to eliminate make_cleanup_ui_file_delete, but then goes beyond. It makes ui_file & friends a real C++ class hierarchy, and switches temporary ui_file-like objects to stack-based allocation. - mem_fileopen -> string_file mem_fileopen is replaced with a new string_file class that is treated as a value class created on the stack. This alone eliminates most make_cleanup_ui_file_delete calls, and, simplifies code a whole lot (diffstat shows around 1k loc dropped.) string_file's internal buffer is a std::string, thus the "string" in the name. This simplifies the implementation much, compared to mem_fileopen, which managed growing its internal buffer manually. - ui_file_as_string, ui_file_strdup, ui_file_obsavestring all gone The new string_file class has a string() method that provides direct writable access to the internal std::string buffer. This replaced ui_file_as_string, which forced a copy of the same data the stream had inside. With direct access via a writable reference, we can instead move the string out of the string_stream, avoiding deep string copying. Related, ui_file_xstrdup calls are replaced with xstrdup'ping the stream's string, and ui_file_obsavestring is replaced by obstack_copy0. With all those out of the way, getting rid of the weird ui_file_put mechanism was possible. - New ui_file::printf, ui_file::puts, etc. methods These simplify / clarify client code. I considered splitting client-code changes, like these, e.g.: - stb = mem_fileopen (); - fprintf_unfiltered (stb, "%s%s%s", - _("The valid values are:\n"), - regdesc, - _("The default is \"std\".")); + string_file stb; + stb.printf ("%s%s%s", + _("The valid values are:\n"), + regdesc, + _("The default is \"std\".")); In two steps, with the first step leaving fprintf_unfiltered (etc.) calls in place, and only afterwards do a pass to change all those to call stb.printf etc.. I didn't do that split, because (when I tried), it turned out to be pointless make-work: the first pass would have to touch the fprintf_unfiltered line anyway, to replace "stb" with "&stb". - gdb_fopen replaced with stack-based objects This avoids the need for cleanups or unique_ptr's. I.e., this: struct ui_file *file = gdb_fopen (filename, "w"); if (filename == NULL) perror_with_name (filename); cleanups = make_cleanup_ui_file_delete (file); // use file. do_cleanups (cleanups); is replaced with this: stdio_file file; if (!file.open (filename, "w")) perror_with_name (filename); // use file. - odd contorsions in null_file_write / null_file_fputs around when to call to_fputs / to_write eliminated. - Global null_stream object A few places that were allocating a ui_file in order to print to "nowhere" are adjusted to instead refer to a new 'null_stream' global stream. - TUI's tui_sfileopen eliminated. TUI's ui_file much simplified The TUI's ui_file was serving a dual purpose. It supported being used as string buffer, and supported being backed by a stdio FILE. The string buffer part is gone, replaced by using of string_file. The 'FILE *' support is now much simplified, by making the TUI's ui_file inherit from stdio_file. gdb/ChangeLog: 2017-02-02 Pedro Alves <palves@redhat.com> * ada-lang.c (type_as_string): Use string_file. * ada-valprint.c (ada_print_floating): Use string_file. * ada-varobj.c (ada_varobj_scalar_image) (ada_varobj_get_value_image): Use string_file. * aix-thread.c (aix_thread_extra_thread_info): Use string_file. * arm-tdep.c (_initialize_arm_tdep): Use string_printf. * breakpoint.c (update_inserted_breakpoint_locations) (insert_breakpoint_locations, reattach_breakpoints) (print_breakpoint_location, print_one_detail_ranged_breakpoint) (print_it_watchpoint): Use string_file. (save_breakpoints): Use stdio_file. * c-exp.y (oper): Use string_file. * cli/cli-logging.c (set_logging_redirect): Use ui_file_up and tee_file. (pop_output_files): Use delete. (handle_redirections): Use stdio_file and tee_file. * cli/cli-setshow.c (do_show_command): Use string_file. * compile/compile-c-support.c (c_compute_program): Use string_file. * compile/compile-c-symbols.c (generate_vla_size): Take a 'string_file &' instead of a 'ui_file *'. (generate_c_for_for_one_variable): Take a 'string_file &' instead of a 'ui_file *'. Use string_file. (generate_c_for_variable_locations): Take a 'string_file &' instead of a 'ui_file *'. * compile/compile-internal.h (generate_c_for_for_one_variable): Take a 'string_file &' instead of a 'ui_file *'. * compile/compile-loc2c.c (push, pushf, unary, binary) (print_label, pushf_register_address, pushf_register) (do_compile_dwarf_expr_to_c): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * compile/compile.c (compile_to_object): Use string_file. * compile/compile.h (compile_dwarf_expr_to_c) (compile_dwarf_bounds_to_c): Take a 'string_file &' instead of a 'ui_file *'. * cp-support.c (inspect_type): Use string_file and obstack_copy0. (replace_typedefs_qualified_name): Use string_file and obstack_copy0. * disasm.c (gdb_pretty_print_insn): Use string_file. (gdb_disassembly): Adjust reference the null_stream global. (do_ui_file_delete): Delete. (gdb_insn_length): Use null_stream. * dummy-frame.c (maintenance_print_dummy_frames): Use stdio_file. * dwarf2loc.c (dwarf2_compile_property_to_c) (locexpr_generate_c_location, loclist_generate_c_location): Take a 'string_file &' instead of a 'ui_file *'. * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise. * dwarf2read.c (do_ui_file_peek_last): Delete. (dwarf2_compute_name): Use string_file. * event-top.c (gdb_setup_readline): Use stdio_file. * gdbarch.sh (verify_gdbarch): Use string_file. * gdbtypes.c (safe_parse_type): Use null_stream. * guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Use string_file. * guile/scm-disasm.c (gdbscm_print_insn_from_port): Take a 'string_file *' instead of a 'ui_file *'. (gdbscm_arch_disassemble): Use string_file. * guile/scm-frame.c (frscm_print_frame_smob): Use string_file. * guile/scm-ports.c (class ioscm_file_port): Now a class that inherits from ui_file. (ioscm_file_port_delete, ioscm_file_port_rewind) (ioscm_file_port_put): Delete. (ioscm_file_port_write): Rename to ... (ioscm_file_port::write): ... this. Remove file_port_magic checks. (ioscm_file_port_new): Delete. (ioscm_with_output_to_port_worker): Use ioscm_file_port and ui_file_up. * guile/scm-type.c (tyscm_type_name): Use string_file. * guile/scm-value.c (vlscm_print_value_smob, gdbscm_value_print): Use string_file. * infcmd.c (print_return_value_1): Use string_file. * infrun.c (print_target_wait_results): Use string_file. * language.c (add_language): Use string_file. * location.c (explicit_to_string_internal): Use string_file. * main.c (captured_main_1): Use null_file. * maint.c (maintenance_print_architecture): Use stdio_file. * mi/mi-cmd-stack.c (list_arg_or_local): Use string_file. * mi/mi-common.h (struct mi_interp) <out, err, log, targ, event_channel>: Change type to mi_console_file pointer. * mi/mi-console.c (mi_console_file_fputs, mi_console_file_flush) (mi_console_file_delete): Delete. (struct mi_console_file): Delete. (mi_console_file_magic): Delete. (mi_console_file_new): Delete. (mi_console_file::mi_console_file): New. (mi_console_file_delete): Delete. (mi_console_file_fputs): Delete. (mi_console_file::write): New. (mi_console_raw_packet): Delete. (mi_console_file::flush): New. (mi_console_file_flush): Delete. (mi_console_set_raw): Rename to ... (mi_console_file::set_raw): ... this. * mi/mi-console.h (class mi_console_file): New class. (mi_console_file_new, mi_console_set_raw): Delete. * mi/mi-interp.c (mi_interpreter_init): Use mi_console_file. (mi_set_logging): Use delete and tee_file. Adjust. * mi/mi-main.c (output_register): Use string_file. (mi_cmd_data_evaluate_expression): Use string_file. (mi_cmd_data_read_memory): Use string_file. (mi_cmd_execute, print_variable_or_computed): Use string_file. * mi/mi-out.c (mi_ui_out::main_stream): New. (mi_ui_out::rewind): Use main_stream and string_file. (mi_ui_out::put): Use main_stream and string_file. (mi_ui_out::mi_ui_out): Remove 'stream' parameter. Allocate a 'string_file' instead. (mi_out_new): Don't allocate a mem_fileopen stream here. * mi/mi-out.h (mi_ui_out::mi_ui_out): Remove 'stream' parameter. (mi_ui_out::main_stream): Declare method. * printcmd.c (eval_command): Use string_file. * psymtab.c (maintenance_print_psymbols): Use stdio_file. * python/py-arch.c (archpy_disassemble): Use string_file. * python/py-breakpoint.c (bppy_get_commands): Use string_file. * python/py-frame.c (frapy_str): Use string_file. * python/py-framefilter.c (py_print_type, py_print_single_arg): Use string_file. * python/py-type.c (typy_str): Use string_file. * python/py-unwind.c (unwind_infopy_str): Use string_file. * python/py-value.c (valpy_str): Use string_file. * record-btrace.c (btrace_insn_history): Use string_file. * regcache.c (regcache_print): Use stdio_file. * reggroups.c (maintenance_print_reggroups): Use stdio_file. * remote.c (escape_buffer): Use string_file. * rust-lang.c (rust_get_disr_info): Use string_file. * serial.c (serial_open_ops_1): Use stdio_file. (do_serial_close): Use delete. * stack.c (print_frame_arg): Use string_file. (print_frame_args): Remove local mem_fileopen stream, not used. (print_frame): Use string_file. * symmisc.c (maintenance_print_symbols): Use stdio_file. * symtab.h (struct symbol_computed_ops) <generate_c_location>: Take a 'string_file *' instead of a 'ui_file *'. * top.c (new_ui): Use stdio_file and stderr_file. (free_ui): Use delete. (execute_command_to_string): Use string_file. (quit_confirm): Use string_file. * tracepoint.c (collection_list::append_exp): Use string_file. * tui/tui-disasm.c (tui_disassemble): Use string_file. * tui/tui-file.c: Don't include "ui-file.h". (enum streamtype, struct tui_stream): Delete. (tui_file_new, tui_file_delete, tui_fileopen, tui_sfileopen) (tui_file_isatty, tui_file_rewind, tui_file_put): Delete. (tui_file::tui_file): New method. (tui_file_fputs): Delete. (tui_file_get_strbuf): Delete. (tui_file::puts): New method. (tui_file_adjust_strbuf): Delete. (tui_file_flush): Delete. (tui_file::flush): New method. * tui/tui-file.h: Tweak intro comment. Include ui-file.h. (tui_fileopen, tui_sfileopen, tui_file_get_strbuf) (tui_file_adjust_strbuf): Delete declarations. (class tui_file): New class. * tui/tui-io.c (tui_initialize_io): Use tui_file. * tui/tui-regs.c (tui_restore_gdbout): Use delete. (tui_register_format): Use string_stream. * tui/tui-stack.c (tui_make_status_line): Use string_file. (tui_get_function_from_frame): Use string_file. * typeprint.c (type_to_string): Use string_file. * ui-file.c (struct ui_file, ui_file_magic, ui_file_new): Delete. (null_stream): New global. (ui_file_delete): Delete. (ui_file::ui_file): New. (null_file_isatty): Delete. (ui_file::~ui_file): New. (null_file_rewind): Delete. (ui_file::printf): New. (null_file_put): Delete. (null_file_flush): Delete. (ui_file::putstr): New. (null_file_write): Delete. (ui_file::putstrn): New. (null_file_read): Delete. (ui_file::putc): New. (null_file_fputs): Delete. (null_file_write_async_safe): Delete. (ui_file::vprintf): New. (null_file_delete): Delete. (null_file::write): New. (null_file_fseek): Delete. (null_file::puts): New. (ui_file_data): Delete. (null_file::write_async_safe): New. (gdb_flush, ui_file_isatty): Adjust. (ui_file_put, ui_file_rewind): Delete. (ui_file_write): Adjust. (ui_file_write_for_put): Delete. (ui_file_write_async_safe, ui_file_read): Adjust. (ui_file_fseek): Delete. (fputs_unfiltered): Adjust. (set_ui_file_flush, set_ui_file_isatty, set_ui_file_rewind) (set_ui_file_put, set_ui_file_write, set_ui_file_write_async_safe) (set_ui_file_read, set_ui_file_fputs, set_ui_file_fseek) (set_ui_file_data): Delete. (string_file::~string_file, string_file::write) (struct accumulated_ui_file, do_ui_file_xstrdup, ui_file_xstrdup) (do_ui_file_as_string, ui_file_as_string): Delete. (do_ui_file_obsavestring, ui_file_obsavestring): Delete. (struct mem_file): Delete. (mem_file_new): Delete. (stdio_file::stdio_file): New. (mem_file_delete): Delete. (stdio_file::stdio_file): New. (mem_fileopen): Delete. (stdio_file::~stdio_file): New. (mem_file_rewind): Delete. (stdio_file::set_stream): New. (mem_file_put): Delete. (stdio_file::open): New. (mem_file_write): Delete. (stdio_file_magic, struct stdio_file): Delete. (stdio_file_new, stdio_file_delete, stdio_file_flush): Delete. (stdio_file::flush): New. (stdio_file_read): Rename to ... (stdio_file::read): ... this. Adjust. (stdio_file_write): Rename to ... (stdio_file::write): ... this. Adjust. (stdio_file_write_async_safe): Rename to ... (stdio_file::write_async_safe) ... this. Adjust. (stdio_file_fputs): Rename to ... (stdio_file::puts) ... this. Adjust. (stdio_file_isatty): Delete. (stdio_file_fseek): Delete. (stdio_file::isatty): New. (stderr_file_write): Rename to ... (stderr_file::write) ... this. Adjust. (stderr_file_fputs): Rename to ... (stderr_file::puts) ... this. Adjust. (stderr_fileopen, stdio_fileopen, gdb_fopen): Delete. (stderr_file::stderr_file): New. (tee_file_magic): Delete. (struct tee_file): Delete. (tee_file::tee_file): New. (tee_file_new): Delete. (tee_file::~tee_file): New. (tee_file_delete): Delete. (tee_file_flush): Rename to ... (tee_file::flush): ... this. Adjust. (tee_file_write): Rename to ... (tee_file::write): ... this. Adjust. (tee_file::write_async_safe): New. (tee_file_fputs): Rename to ... (tee_file::puts): ... this. Adjust. (tee_file_isatty): Rename to ... (tee_file::isatty): ... this. Adjust. * ui-file.h (struct obstack, struct ui_file): Don't forward-declare. (ui_file_new, ui_file_flush_ftype, set_ui_file_flush) (ui_file_write_ftype) (set_ui_file_write, ui_file_fputs_ftype, set_ui_file_fputs) (ui_file_write_async_safe_ftype, set_ui_file_write_async_safe) (ui_file_read_ftype, set_ui_file_read, ui_file_isatty_ftype) (set_ui_file_isatty, ui_file_rewind_ftype, set_ui_file_rewind) (ui_file_put_method_ftype, ui_file_put_ftype, set_ui_file_put) (ui_file_delete_ftype, set_ui_file_data, ui_file_fseek_ftype) (set_ui_file_fseek): Delete. (ui_file_data, ui_file_delete, ui_file_rewind) (struct ui_file): New. (ui_file_up): New. (class null_file): New. (null_stream): Declare. (ui_file_write_for_put, ui_file_put): Delete. (ui_file_xstrdup, ui_file_as_string, ui_file_obsavestring): Delete. (ui_file_fseek, mem_fileopen, stdio_fileopen, stderr_fileopen) (gdb_fopen, tee_file_new): Delete. (struct string_file): New. (struct stdio_file): New. (stdio_file_up): New. (struct stderr_file): New. (class tee_file): New. * ui-out.c (ui_out::field_stream): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * ui-out.h (class ui_out) <field_stream>: Likewise. * utils.c (do_ui_file_delete, make_cleanup_ui_file_delete) (null_stream): Delete. (error_stream): Take a 'string_file &' instead of a 'ui_file *'. Adjust. * utils.h (struct ui_file): Delete forward declaration.. (make_cleanup_ui_file_delete, null_stream): Delete declarations. (error_stream): Take a 'string_file &' instead of a 'ui_file *'. * varobj.c (varobj_value_get_print_value): Use string_file. * xtensa-tdep.c (xtensa_verify_config): Use string_file. * gdbarch.c: Regenerate.
769 lines
20 KiB
C
769 lines
20 KiB
C
/* Convert symbols from GDB to GCC
|
||
|
||
Copyright (C) 2014-2017 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
|
||
#include "defs.h"
|
||
#include "compile-internal.h"
|
||
#include "symtab.h"
|
||
#include "parser-defs.h"
|
||
#include "block.h"
|
||
#include "objfiles.h"
|
||
#include "compile.h"
|
||
#include "value.h"
|
||
#include "exceptions.h"
|
||
#include "gdbtypes.h"
|
||
#include "dwarf2loc.h"
|
||
|
||
|
||
|
||
/* Object of this type are stored in the compiler's symbol_err_map. */
|
||
|
||
struct symbol_error
|
||
{
|
||
/* The symbol. */
|
||
|
||
const struct symbol *sym;
|
||
|
||
/* The error message to emit. This is malloc'd and owned by the
|
||
hash table. */
|
||
|
||
char *message;
|
||
};
|
||
|
||
/* Hash function for struct symbol_error. */
|
||
|
||
static hashval_t
|
||
hash_symbol_error (const void *a)
|
||
{
|
||
const struct symbol_error *se = (const struct symbol_error *) a;
|
||
|
||
return htab_hash_pointer (se->sym);
|
||
}
|
||
|
||
/* Equality function for struct symbol_error. */
|
||
|
||
static int
|
||
eq_symbol_error (const void *a, const void *b)
|
||
{
|
||
const struct symbol_error *sea = (const struct symbol_error *) a;
|
||
const struct symbol_error *seb = (const struct symbol_error *) b;
|
||
|
||
return sea->sym == seb->sym;
|
||
}
|
||
|
||
/* Deletion function for struct symbol_error. */
|
||
|
||
static void
|
||
del_symbol_error (void *a)
|
||
{
|
||
struct symbol_error *se = (struct symbol_error *) a;
|
||
|
||
xfree (se->message);
|
||
xfree (se);
|
||
}
|
||
|
||
/* Associate SYMBOL with some error text. */
|
||
|
||
static void
|
||
insert_symbol_error (htab_t hash, const struct symbol *sym, const char *text)
|
||
{
|
||
struct symbol_error e;
|
||
void **slot;
|
||
|
||
e.sym = sym;
|
||
slot = htab_find_slot (hash, &e, INSERT);
|
||
if (*slot == NULL)
|
||
{
|
||
struct symbol_error *e = XNEW (struct symbol_error);
|
||
|
||
e->sym = sym;
|
||
e->message = xstrdup (text);
|
||
*slot = e;
|
||
}
|
||
}
|
||
|
||
/* Emit the error message corresponding to SYM, if one exists, and
|
||
arrange for it not to be emitted again. */
|
||
|
||
static void
|
||
error_symbol_once (struct compile_c_instance *context,
|
||
const struct symbol *sym)
|
||
{
|
||
struct symbol_error search;
|
||
struct symbol_error *err;
|
||
char *message;
|
||
|
||
if (context->symbol_err_map == NULL)
|
||
return;
|
||
|
||
search.sym = sym;
|
||
err = (struct symbol_error *) htab_find (context->symbol_err_map, &search);
|
||
if (err == NULL || err->message == NULL)
|
||
return;
|
||
|
||
message = err->message;
|
||
err->message = NULL;
|
||
make_cleanup (xfree, message);
|
||
error (_("%s"), message);
|
||
}
|
||
|
||
|
||
|
||
/* Compute the name of the pointer representing a local symbol's
|
||
address. */
|
||
|
||
static char *
|
||
symbol_substitution_name (struct symbol *sym)
|
||
{
|
||
return concat ("__", SYMBOL_NATURAL_NAME (sym), "_ptr", (char *) NULL);
|
||
}
|
||
|
||
/* Convert a given symbol, SYM, to the compiler's representation.
|
||
CONTEXT is the compiler instance. IS_GLOBAL is true if the
|
||
symbol came from the global scope. IS_LOCAL is true if the symbol
|
||
came from a local scope. (Note that the two are not strictly
|
||
inverses because the symbol might have come from the static
|
||
scope.) */
|
||
|
||
static void
|
||
convert_one_symbol (struct compile_c_instance *context,
|
||
struct block_symbol sym,
|
||
int is_global,
|
||
int is_local)
|
||
{
|
||
gcc_type sym_type;
|
||
const char *filename = symbol_symtab (sym.symbol)->filename;
|
||
unsigned short line = SYMBOL_LINE (sym.symbol);
|
||
|
||
error_symbol_once (context, sym.symbol);
|
||
|
||
if (SYMBOL_CLASS (sym.symbol) == LOC_LABEL)
|
||
sym_type = 0;
|
||
else
|
||
sym_type = convert_type (context, SYMBOL_TYPE (sym.symbol));
|
||
|
||
if (SYMBOL_DOMAIN (sym.symbol) == STRUCT_DOMAIN)
|
||
{
|
||
/* Binding a tag, so we don't need to build a decl. */
|
||
C_CTX (context)->c_ops->tagbind (C_CTX (context),
|
||
SYMBOL_NATURAL_NAME (sym.symbol),
|
||
sym_type, filename, line);
|
||
}
|
||
else
|
||
{
|
||
gcc_decl decl;
|
||
enum gcc_c_symbol_kind kind;
|
||
CORE_ADDR addr = 0;
|
||
char *symbol_name = NULL;
|
||
|
||
switch (SYMBOL_CLASS (sym.symbol))
|
||
{
|
||
case LOC_TYPEDEF:
|
||
kind = GCC_C_SYMBOL_TYPEDEF;
|
||
break;
|
||
|
||
case LOC_LABEL:
|
||
kind = GCC_C_SYMBOL_LABEL;
|
||
addr = SYMBOL_VALUE_ADDRESS (sym.symbol);
|
||
break;
|
||
|
||
case LOC_BLOCK:
|
||
kind = GCC_C_SYMBOL_FUNCTION;
|
||
addr = BLOCK_START (SYMBOL_BLOCK_VALUE (sym.symbol));
|
||
if (is_global && TYPE_GNU_IFUNC (SYMBOL_TYPE (sym.symbol)))
|
||
addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr);
|
||
break;
|
||
|
||
case LOC_CONST:
|
||
if (TYPE_CODE (SYMBOL_TYPE (sym.symbol)) == TYPE_CODE_ENUM)
|
||
{
|
||
/* Already handled by convert_enum. */
|
||
return;
|
||
}
|
||
C_CTX (context)->c_ops->build_constant
|
||
(C_CTX (context),
|
||
sym_type, SYMBOL_NATURAL_NAME (sym.symbol),
|
||
SYMBOL_VALUE (sym.symbol),
|
||
filename, line);
|
||
return;
|
||
|
||
case LOC_CONST_BYTES:
|
||
error (_("Unsupported LOC_CONST_BYTES for symbol \"%s\"."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
|
||
case LOC_UNDEF:
|
||
internal_error (__FILE__, __LINE__, _("LOC_UNDEF found for \"%s\"."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
|
||
case LOC_COMMON_BLOCK:
|
||
error (_("Fortran common block is unsupported for compilation "
|
||
"evaluaton of symbol \"%s\"."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
|
||
case LOC_OPTIMIZED_OUT:
|
||
error (_("Symbol \"%s\" cannot be used for compilation evaluation "
|
||
"as it is optimized out."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
|
||
case LOC_COMPUTED:
|
||
if (is_local)
|
||
goto substitution;
|
||
/* Probably TLS here. */
|
||
warning (_("Symbol \"%s\" is thread-local and currently can only "
|
||
"be referenced from the current thread in "
|
||
"compiled code."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
/* FALLTHROUGH */
|
||
case LOC_UNRESOLVED:
|
||
/* 'symbol_name' cannot be used here as that one is used only for
|
||
local variables from compile_dwarf_expr_to_c.
|
||
Global variables can be accessed by GCC only by their address, not
|
||
by their name. */
|
||
{
|
||
struct value *val;
|
||
struct frame_info *frame = NULL;
|
||
|
||
if (symbol_read_needs_frame (sym.symbol))
|
||
{
|
||
frame = get_selected_frame (NULL);
|
||
if (frame == NULL)
|
||
error (_("Symbol \"%s\" cannot be used because "
|
||
"there is no selected frame"),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
}
|
||
|
||
val = read_var_value (sym.symbol, sym.block, frame);
|
||
if (VALUE_LVAL (val) != lval_memory)
|
||
error (_("Symbol \"%s\" cannot be used for compilation "
|
||
"evaluation as its address has not been found."),
|
||
SYMBOL_PRINT_NAME (sym.symbol));
|
||
|
||
kind = GCC_C_SYMBOL_VARIABLE;
|
||
addr = value_address (val);
|
||
}
|
||
break;
|
||
|
||
|
||
case LOC_REGISTER:
|
||
case LOC_ARG:
|
||
case LOC_REF_ARG:
|
||
case LOC_REGPARM_ADDR:
|
||
case LOC_LOCAL:
|
||
substitution:
|
||
kind = GCC_C_SYMBOL_VARIABLE;
|
||
symbol_name = symbol_substitution_name (sym.symbol);
|
||
break;
|
||
|
||
case LOC_STATIC:
|
||
kind = GCC_C_SYMBOL_VARIABLE;
|
||
addr = SYMBOL_VALUE_ADDRESS (sym.symbol);
|
||
break;
|
||
|
||
case LOC_FINAL_VALUE:
|
||
default:
|
||
gdb_assert_not_reached ("Unreachable case in convert_one_symbol.");
|
||
|
||
}
|
||
|
||
/* Don't emit local variable decls for a raw expression. */
|
||
if (context->base.scope != COMPILE_I_RAW_SCOPE
|
||
|| symbol_name == NULL)
|
||
{
|
||
decl = C_CTX (context)->c_ops->build_decl
|
||
(C_CTX (context),
|
||
SYMBOL_NATURAL_NAME (sym.symbol),
|
||
kind,
|
||
sym_type,
|
||
symbol_name, addr,
|
||
filename, line);
|
||
|
||
C_CTX (context)->c_ops->bind (C_CTX (context), decl, is_global);
|
||
}
|
||
|
||
xfree (symbol_name);
|
||
}
|
||
}
|
||
|
||
/* Convert a full symbol to its gcc form. CONTEXT is the compiler to
|
||
use, IDENTIFIER is the name of the symbol, SYM is the symbol
|
||
itself, and DOMAIN is the domain which was searched. */
|
||
|
||
static void
|
||
convert_symbol_sym (struct compile_c_instance *context, const char *identifier,
|
||
struct block_symbol sym, domain_enum domain)
|
||
{
|
||
const struct block *static_block;
|
||
int is_local_symbol;
|
||
|
||
/* If we found a symbol and it is not in the static or global
|
||
scope, then we should first convert any static or global scope
|
||
symbol of the same name. This lets this unusual case work:
|
||
|
||
int x; // Global.
|
||
int func(void)
|
||
{
|
||
int x;
|
||
// At this spot, evaluate "extern int x; x"
|
||
}
|
||
*/
|
||
|
||
static_block = block_static_block (sym.block);
|
||
/* STATIC_BLOCK is NULL if FOUND_BLOCK is the global block. */
|
||
is_local_symbol = (sym.block != static_block && static_block != NULL);
|
||
if (is_local_symbol)
|
||
{
|
||
struct block_symbol global_sym;
|
||
|
||
global_sym = lookup_symbol (identifier, NULL, domain, NULL);
|
||
/* If the outer symbol is in the static block, we ignore it, as
|
||
it cannot be referenced. */
|
||
if (global_sym.symbol != NULL
|
||
&& global_sym.block != block_static_block (global_sym.block))
|
||
{
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_convert_symbol \"%s\": global symbol\n",
|
||
identifier);
|
||
convert_one_symbol (context, global_sym, 1, 0);
|
||
}
|
||
}
|
||
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_convert_symbol \"%s\": local symbol\n",
|
||
identifier);
|
||
convert_one_symbol (context, sym, 0, is_local_symbol);
|
||
}
|
||
|
||
/* Convert a minimal symbol to its gcc form. CONTEXT is the compiler
|
||
to use and BMSYM is the minimal symbol to convert. */
|
||
|
||
static void
|
||
convert_symbol_bmsym (struct compile_c_instance *context,
|
||
struct bound_minimal_symbol bmsym)
|
||
{
|
||
struct minimal_symbol *msym = bmsym.minsym;
|
||
struct objfile *objfile = bmsym.objfile;
|
||
struct type *type;
|
||
enum gcc_c_symbol_kind kind;
|
||
gcc_type sym_type;
|
||
gcc_decl decl;
|
||
CORE_ADDR addr;
|
||
|
||
addr = MSYMBOL_VALUE_ADDRESS (objfile, msym);
|
||
|
||
/* Conversion copied from write_exp_msymbol. */
|
||
switch (MSYMBOL_TYPE (msym))
|
||
{
|
||
case mst_text:
|
||
case mst_file_text:
|
||
case mst_solib_trampoline:
|
||
type = objfile_type (objfile)->nodebug_text_symbol;
|
||
kind = GCC_C_SYMBOL_FUNCTION;
|
||
break;
|
||
|
||
case mst_text_gnu_ifunc:
|
||
/* nodebug_text_gnu_ifunc_symbol would cause:
|
||
function return type cannot be function */
|
||
type = objfile_type (objfile)->nodebug_text_symbol;
|
||
kind = GCC_C_SYMBOL_FUNCTION;
|
||
addr = gnu_ifunc_resolve_addr (target_gdbarch (), addr);
|
||
break;
|
||
|
||
case mst_data:
|
||
case mst_file_data:
|
||
case mst_bss:
|
||
case mst_file_bss:
|
||
type = objfile_type (objfile)->nodebug_data_symbol;
|
||
kind = GCC_C_SYMBOL_VARIABLE;
|
||
break;
|
||
|
||
case mst_slot_got_plt:
|
||
type = objfile_type (objfile)->nodebug_got_plt_symbol;
|
||
kind = GCC_C_SYMBOL_FUNCTION;
|
||
break;
|
||
|
||
default:
|
||
type = objfile_type (objfile)->nodebug_unknown_symbol;
|
||
kind = GCC_C_SYMBOL_VARIABLE;
|
||
break;
|
||
}
|
||
|
||
sym_type = convert_type (context, type);
|
||
decl = C_CTX (context)->c_ops->build_decl (C_CTX (context),
|
||
MSYMBOL_NATURAL_NAME (msym),
|
||
kind, sym_type, NULL, addr,
|
||
NULL, 0);
|
||
C_CTX (context)->c_ops->bind (C_CTX (context), decl, 1 /* is_global */);
|
||
}
|
||
|
||
/* See compile-internal.h. */
|
||
|
||
void
|
||
gcc_convert_symbol (void *datum,
|
||
struct gcc_c_context *gcc_context,
|
||
enum gcc_c_oracle_request request,
|
||
const char *identifier)
|
||
{
|
||
struct compile_c_instance *context = (struct compile_c_instance *) datum;
|
||
domain_enum domain;
|
||
int found = 0;
|
||
|
||
switch (request)
|
||
{
|
||
case GCC_C_ORACLE_SYMBOL:
|
||
domain = VAR_DOMAIN;
|
||
break;
|
||
case GCC_C_ORACLE_TAG:
|
||
domain = STRUCT_DOMAIN;
|
||
break;
|
||
case GCC_C_ORACLE_LABEL:
|
||
domain = LABEL_DOMAIN;
|
||
break;
|
||
default:
|
||
gdb_assert_not_reached ("Unrecognized oracle request.");
|
||
}
|
||
|
||
/* We can't allow exceptions to escape out of this callback. Safest
|
||
is to simply emit a gcc error. */
|
||
TRY
|
||
{
|
||
struct block_symbol sym;
|
||
|
||
sym = lookup_symbol (identifier, context->base.block, domain, NULL);
|
||
if (sym.symbol != NULL)
|
||
{
|
||
convert_symbol_sym (context, identifier, sym, domain);
|
||
found = 1;
|
||
}
|
||
else if (domain == VAR_DOMAIN)
|
||
{
|
||
struct bound_minimal_symbol bmsym;
|
||
|
||
bmsym = lookup_minimal_symbol (identifier, NULL, NULL);
|
||
if (bmsym.minsym != NULL)
|
||
{
|
||
convert_symbol_bmsym (context, bmsym);
|
||
found = 1;
|
||
}
|
||
}
|
||
}
|
||
|
||
CATCH (e, RETURN_MASK_ALL)
|
||
{
|
||
C_CTX (context)->c_ops->error (C_CTX (context), e.message);
|
||
}
|
||
END_CATCH
|
||
|
||
if (compile_debug && !found)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_convert_symbol \"%s\": lookup_symbol failed\n",
|
||
identifier);
|
||
return;
|
||
}
|
||
|
||
/* See compile-internal.h. */
|
||
|
||
gcc_address
|
||
gcc_symbol_address (void *datum, struct gcc_c_context *gcc_context,
|
||
const char *identifier)
|
||
{
|
||
struct compile_c_instance *context = (struct compile_c_instance *) datum;
|
||
gcc_address result = 0;
|
||
int found = 0;
|
||
|
||
/* We can't allow exceptions to escape out of this callback. Safest
|
||
is to simply emit a gcc error. */
|
||
TRY
|
||
{
|
||
struct symbol *sym;
|
||
|
||
/* We only need global functions here. */
|
||
sym = lookup_symbol (identifier, NULL, VAR_DOMAIN, NULL).symbol;
|
||
if (sym != NULL && SYMBOL_CLASS (sym) == LOC_BLOCK)
|
||
{
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_symbol_address \"%s\": full symbol\n",
|
||
identifier);
|
||
result = BLOCK_START (SYMBOL_BLOCK_VALUE (sym));
|
||
if (TYPE_GNU_IFUNC (SYMBOL_TYPE (sym)))
|
||
result = gnu_ifunc_resolve_addr (target_gdbarch (), result);
|
||
found = 1;
|
||
}
|
||
else
|
||
{
|
||
struct bound_minimal_symbol msym;
|
||
|
||
msym = lookup_bound_minimal_symbol (identifier);
|
||
if (msym.minsym != NULL)
|
||
{
|
||
if (compile_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_symbol_address \"%s\": minimal "
|
||
"symbol\n",
|
||
identifier);
|
||
result = BMSYMBOL_VALUE_ADDRESS (msym);
|
||
if (MSYMBOL_TYPE (msym.minsym) == mst_text_gnu_ifunc)
|
||
result = gnu_ifunc_resolve_addr (target_gdbarch (), result);
|
||
found = 1;
|
||
}
|
||
}
|
||
}
|
||
|
||
CATCH (e, RETURN_MASK_ERROR)
|
||
{
|
||
C_CTX (context)->c_ops->error (C_CTX (context), e.message);
|
||
}
|
||
END_CATCH
|
||
|
||
if (compile_debug && !found)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"gcc_symbol_address \"%s\": failed\n",
|
||
identifier);
|
||
return result;
|
||
}
|
||
|
||
|
||
|
||
/* A hash function for symbol names. */
|
||
|
||
static hashval_t
|
||
hash_symname (const void *a)
|
||
{
|
||
const struct symbol *sym = (const struct symbol *) a;
|
||
|
||
return htab_hash_string (SYMBOL_NATURAL_NAME (sym));
|
||
}
|
||
|
||
/* A comparison function for hash tables that just looks at symbol
|
||
names. */
|
||
|
||
static int
|
||
eq_symname (const void *a, const void *b)
|
||
{
|
||
const struct symbol *syma = (const struct symbol *) a;
|
||
const struct symbol *symb = (const struct symbol *) b;
|
||
|
||
return strcmp (SYMBOL_NATURAL_NAME (syma), SYMBOL_NATURAL_NAME (symb)) == 0;
|
||
}
|
||
|
||
/* If a symbol with the same name as SYM is already in HASHTAB, return
|
||
1. Otherwise, add SYM to HASHTAB and return 0. */
|
||
|
||
static int
|
||
symbol_seen (htab_t hashtab, struct symbol *sym)
|
||
{
|
||
void **slot;
|
||
|
||
slot = htab_find_slot (hashtab, sym, INSERT);
|
||
if (*slot != NULL)
|
||
return 1;
|
||
|
||
*slot = sym;
|
||
return 0;
|
||
}
|
||
|
||
/* Generate C code to compute the length of a VLA. */
|
||
|
||
static void
|
||
generate_vla_size (struct compile_c_instance *compiler,
|
||
string_file &stream,
|
||
struct gdbarch *gdbarch,
|
||
unsigned char *registers_used,
|
||
CORE_ADDR pc,
|
||
struct type *type,
|
||
struct symbol *sym)
|
||
{
|
||
type = check_typedef (type);
|
||
|
||
if (TYPE_CODE (type) == TYPE_CODE_REF)
|
||
type = check_typedef (TYPE_TARGET_TYPE (type));
|
||
|
||
switch (TYPE_CODE (type))
|
||
{
|
||
case TYPE_CODE_RANGE:
|
||
{
|
||
if (TYPE_HIGH_BOUND_KIND (type) == PROP_LOCEXPR
|
||
|| TYPE_HIGH_BOUND_KIND (type) == PROP_LOCLIST)
|
||
{
|
||
const struct dynamic_prop *prop = &TYPE_RANGE_DATA (type)->high;
|
||
char *name = c_get_range_decl_name (prop);
|
||
struct cleanup *cleanup = make_cleanup (xfree, name);
|
||
|
||
dwarf2_compile_property_to_c (stream, name,
|
||
gdbarch, registers_used,
|
||
prop, pc, sym);
|
||
do_cleanups (cleanup);
|
||
}
|
||
}
|
||
break;
|
||
|
||
case TYPE_CODE_ARRAY:
|
||
generate_vla_size (compiler, stream, gdbarch, registers_used, pc,
|
||
TYPE_INDEX_TYPE (type), sym);
|
||
generate_vla_size (compiler, stream, gdbarch, registers_used, pc,
|
||
TYPE_TARGET_TYPE (type), sym);
|
||
break;
|
||
|
||
case TYPE_CODE_UNION:
|
||
case TYPE_CODE_STRUCT:
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < TYPE_NFIELDS (type); ++i)
|
||
if (!field_is_static (&TYPE_FIELD (type, i)))
|
||
generate_vla_size (compiler, stream, gdbarch, registers_used, pc,
|
||
TYPE_FIELD_TYPE (type, i), sym);
|
||
}
|
||
break;
|
||
}
|
||
}
|
||
|
||
/* Generate C code to compute the address of SYM. */
|
||
|
||
static void
|
||
generate_c_for_for_one_variable (struct compile_c_instance *compiler,
|
||
string_file &stream,
|
||
struct gdbarch *gdbarch,
|
||
unsigned char *registers_used,
|
||
CORE_ADDR pc,
|
||
struct symbol *sym)
|
||
{
|
||
|
||
TRY
|
||
{
|
||
if (is_dynamic_type (SYMBOL_TYPE (sym)))
|
||
{
|
||
/* We need to emit to a temporary buffer in case an error
|
||
occurs in the middle. */
|
||
string_file local_file;
|
||
|
||
generate_vla_size (compiler, local_file, gdbarch, registers_used, pc,
|
||
SYMBOL_TYPE (sym), sym);
|
||
|
||
stream.write (local_file.c_str (), local_file.size ());
|
||
}
|
||
|
||
if (SYMBOL_COMPUTED_OPS (sym) != NULL)
|
||
{
|
||
char *generated_name = symbol_substitution_name (sym);
|
||
struct cleanup *cleanup = make_cleanup (xfree, generated_name);
|
||
/* We need to emit to a temporary buffer in case an error
|
||
occurs in the middle. */
|
||
string_file local_file;
|
||
|
||
SYMBOL_COMPUTED_OPS (sym)->generate_c_location (sym, local_file,
|
||
gdbarch,
|
||
registers_used,
|
||
pc, generated_name);
|
||
stream.write (local_file.c_str (), local_file.size ());
|
||
|
||
do_cleanups (cleanup);
|
||
}
|
||
else
|
||
{
|
||
switch (SYMBOL_CLASS (sym))
|
||
{
|
||
case LOC_REGISTER:
|
||
case LOC_ARG:
|
||
case LOC_REF_ARG:
|
||
case LOC_REGPARM_ADDR:
|
||
case LOC_LOCAL:
|
||
error (_("Local symbol unhandled when generating C code."));
|
||
|
||
case LOC_COMPUTED:
|
||
gdb_assert_not_reached (_("LOC_COMPUTED variable "
|
||
"missing a method."));
|
||
|
||
default:
|
||
/* Nothing to do for all other cases, as they don't represent
|
||
local variables. */
|
||
break;
|
||
}
|
||
}
|
||
}
|
||
|
||
CATCH (e, RETURN_MASK_ERROR)
|
||
{
|
||
if (compiler->symbol_err_map == NULL)
|
||
compiler->symbol_err_map = htab_create_alloc (10,
|
||
hash_symbol_error,
|
||
eq_symbol_error,
|
||
del_symbol_error,
|
||
xcalloc,
|
||
xfree);
|
||
insert_symbol_error (compiler->symbol_err_map, sym, e.message);
|
||
}
|
||
END_CATCH
|
||
}
|
||
|
||
/* See compile-internal.h. */
|
||
|
||
unsigned char *
|
||
generate_c_for_variable_locations (struct compile_c_instance *compiler,
|
||
string_file &stream,
|
||
struct gdbarch *gdbarch,
|
||
const struct block *block,
|
||
CORE_ADDR pc)
|
||
{
|
||
struct cleanup *outer;
|
||
const struct block *static_block = block_static_block (block);
|
||
unsigned char *registers_used;
|
||
|
||
/* If we're already in the static or global block, there is nothing
|
||
to write. */
|
||
if (static_block == NULL || block == static_block)
|
||
return NULL;
|
||
|
||
registers_used = XCNEWVEC (unsigned char, gdbarch_num_regs (gdbarch));
|
||
outer = make_cleanup (xfree, registers_used);
|
||
|
||
/* Ensure that a given name is only entered once. This reflects the
|
||
reality of shadowing. */
|
||
htab_up symhash (htab_create_alloc (1, hash_symname, eq_symname, NULL,
|
||
xcalloc, xfree));
|
||
|
||
while (1)
|
||
{
|
||
struct symbol *sym;
|
||
struct block_iterator iter;
|
||
|
||
/* Iterate over symbols in this block, generating code to
|
||
compute the location of each local variable. */
|
||
for (sym = block_iterator_first (block, &iter);
|
||
sym != NULL;
|
||
sym = block_iterator_next (&iter))
|
||
{
|
||
if (!symbol_seen (symhash.get (), sym))
|
||
generate_c_for_for_one_variable (compiler, stream, gdbarch,
|
||
registers_used, pc, sym);
|
||
}
|
||
|
||
/* If we just finished the outermost block of a function, we're
|
||
done. */
|
||
if (BLOCK_FUNCTION (block) != NULL)
|
||
break;
|
||
block = BLOCK_SUPERBLOCK (block);
|
||
}
|
||
|
||
discard_cleanups (outer);
|
||
return registers_used;
|
||
}
|