binutils-gdb/gdb/netbsd-nat.c
Simon Marchi dda83cd783 gdb, gdbserver, gdbsupport: fix leading space vs tabs issues
Many spots incorrectly use only spaces for indentation (for example,
there are a lot of spots in ada-lang.c).  I've always found it awkward
when I needed to edit one of these spots: do I keep the original wrong
indentation, or do I fix it?  What if the lines around it are also
wrong, do I fix them too?  I probably don't want to fix them in the same
patch, to avoid adding noise to my patch.

So I propose to fix as much as possible once and for all (hopefully).

One typical counter argument for this is that it makes code archeology
more difficult, because git-blame will show this commit as the last
change for these lines.  My counter counter argument is: when
git-blaming, you often need to do "blame the file at the parent commit"
anyway, to go past some other refactor that touched the line you are
interested in, but is not the change you are looking for.  So you
already need a somewhat efficient way to do this.

Using some interactive tool, rather than plain git-blame, makes this
trivial.  For example, I use "tig blame <file>", where going back past
the commit that changed the currently selected line is one keystroke.
It looks like Magit in Emacs does it too (though I've never used it).
Web viewers of Github and Gitlab do it too.  My point is that it won't
really make archeology more difficult.

The other typical counter argument is that it will cause conflicts with
existing patches.  That's true... but it's a one time cost, and those
are not conflicts that are difficult to resolve.  I have also tried "git
rebase --ignore-whitespace", it seems to work well.  Although that will
re-introduce the faulty indentation, so one needs to take care of fixing
the indentation in the patch after that (which is easy).

gdb/ChangeLog:

	* aarch64-linux-tdep.c: Fix indentation.
	* aarch64-ravenscar-thread.c: Fix indentation.
	* aarch64-tdep.c: Fix indentation.
	* aarch64-tdep.h: Fix indentation.
	* ada-lang.c: Fix indentation.
	* ada-lang.h: Fix indentation.
	* ada-tasks.c: Fix indentation.
	* ada-typeprint.c: Fix indentation.
	* ada-valprint.c: Fix indentation.
	* ada-varobj.c: Fix indentation.
	* addrmap.c: Fix indentation.
	* addrmap.h: Fix indentation.
	* agent.c: Fix indentation.
	* aix-thread.c: Fix indentation.
	* alpha-bsd-nat.c: Fix indentation.
	* alpha-linux-tdep.c: Fix indentation.
	* alpha-mdebug-tdep.c: Fix indentation.
	* alpha-nbsd-tdep.c: Fix indentation.
	* alpha-obsd-tdep.c: Fix indentation.
	* alpha-tdep.c: Fix indentation.
	* amd64-bsd-nat.c: Fix indentation.
	* amd64-darwin-tdep.c: Fix indentation.
	* amd64-linux-nat.c: Fix indentation.
	* amd64-linux-tdep.c: Fix indentation.
	* amd64-nat.c: Fix indentation.
	* amd64-obsd-tdep.c: Fix indentation.
	* amd64-tdep.c: Fix indentation.
	* amd64-windows-tdep.c: Fix indentation.
	* annotate.c: Fix indentation.
	* arc-tdep.c: Fix indentation.
	* arch-utils.c: Fix indentation.
	* arch/arm-get-next-pcs.c: Fix indentation.
	* arch/arm.c: Fix indentation.
	* arm-linux-nat.c: Fix indentation.
	* arm-linux-tdep.c: Fix indentation.
	* arm-nbsd-tdep.c: Fix indentation.
	* arm-pikeos-tdep.c: Fix indentation.
	* arm-tdep.c: Fix indentation.
	* arm-tdep.h: Fix indentation.
	* arm-wince-tdep.c: Fix indentation.
	* auto-load.c: Fix indentation.
	* auxv.c: Fix indentation.
	* avr-tdep.c: Fix indentation.
	* ax-gdb.c: Fix indentation.
	* ax-general.c: Fix indentation.
	* bfin-linux-tdep.c: Fix indentation.
	* block.c: Fix indentation.
	* block.h: Fix indentation.
	* blockframe.c: Fix indentation.
	* bpf-tdep.c: Fix indentation.
	* break-catch-sig.c: Fix indentation.
	* break-catch-syscall.c: Fix indentation.
	* break-catch-throw.c: Fix indentation.
	* breakpoint.c: Fix indentation.
	* breakpoint.h: Fix indentation.
	* bsd-uthread.c: Fix indentation.
	* btrace.c: Fix indentation.
	* build-id.c: Fix indentation.
	* buildsym-legacy.h: Fix indentation.
	* buildsym.c: Fix indentation.
	* c-typeprint.c: Fix indentation.
	* c-valprint.c: Fix indentation.
	* c-varobj.c: Fix indentation.
	* charset.c: Fix indentation.
	* cli/cli-cmds.c: Fix indentation.
	* cli/cli-decode.c: Fix indentation.
	* cli/cli-decode.h: Fix indentation.
	* cli/cli-script.c: Fix indentation.
	* cli/cli-setshow.c: Fix indentation.
	* coff-pe-read.c: Fix indentation.
	* coffread.c: Fix indentation.
	* compile/compile-cplus-types.c: Fix indentation.
	* compile/compile-object-load.c: Fix indentation.
	* compile/compile-object-run.c: Fix indentation.
	* completer.c: Fix indentation.
	* corefile.c: Fix indentation.
	* corelow.c: Fix indentation.
	* cp-abi.h: Fix indentation.
	* cp-namespace.c: Fix indentation.
	* cp-support.c: Fix indentation.
	* cp-valprint.c: Fix indentation.
	* cris-linux-tdep.c: Fix indentation.
	* cris-tdep.c: Fix indentation.
	* darwin-nat-info.c: Fix indentation.
	* darwin-nat.c: Fix indentation.
	* darwin-nat.h: Fix indentation.
	* dbxread.c: Fix indentation.
	* dcache.c: Fix indentation.
	* disasm.c: Fix indentation.
	* dtrace-probe.c: Fix indentation.
	* dwarf2/abbrev.c: Fix indentation.
	* dwarf2/attribute.c: Fix indentation.
	* dwarf2/expr.c: Fix indentation.
	* dwarf2/frame.c: Fix indentation.
	* dwarf2/index-cache.c: Fix indentation.
	* dwarf2/index-write.c: Fix indentation.
	* dwarf2/line-header.c: Fix indentation.
	* dwarf2/loc.c: Fix indentation.
	* dwarf2/macro.c: Fix indentation.
	* dwarf2/read.c: Fix indentation.
	* dwarf2/read.h: Fix indentation.
	* elfread.c: Fix indentation.
	* eval.c: Fix indentation.
	* event-top.c: Fix indentation.
	* exec.c: Fix indentation.
	* exec.h: Fix indentation.
	* expprint.c: Fix indentation.
	* f-lang.c: Fix indentation.
	* f-typeprint.c: Fix indentation.
	* f-valprint.c: Fix indentation.
	* fbsd-nat.c: Fix indentation.
	* fbsd-tdep.c: Fix indentation.
	* findvar.c: Fix indentation.
	* fork-child.c: Fix indentation.
	* frame-unwind.c: Fix indentation.
	* frame-unwind.h: Fix indentation.
	* frame.c: Fix indentation.
	* frv-linux-tdep.c: Fix indentation.
	* frv-tdep.c: Fix indentation.
	* frv-tdep.h: Fix indentation.
	* ft32-tdep.c: Fix indentation.
	* gcore.c: Fix indentation.
	* gdb_bfd.c: Fix indentation.
	* gdbarch.sh: Fix indentation.
	* gdbarch.c: Re-generate
	* gdbarch.h: Re-generate.
	* gdbcore.h: Fix indentation.
	* gdbthread.h: Fix indentation.
	* gdbtypes.c: Fix indentation.
	* gdbtypes.h: Fix indentation.
	* glibc-tdep.c: Fix indentation.
	* gnu-nat.c: Fix indentation.
	* gnu-nat.h: Fix indentation.
	* gnu-v2-abi.c: Fix indentation.
	* gnu-v3-abi.c: Fix indentation.
	* go32-nat.c: Fix indentation.
	* guile/guile-internal.h: Fix indentation.
	* guile/scm-cmd.c: Fix indentation.
	* guile/scm-frame.c: Fix indentation.
	* guile/scm-iterator.c: Fix indentation.
	* guile/scm-math.c: Fix indentation.
	* guile/scm-ports.c: Fix indentation.
	* guile/scm-pretty-print.c: Fix indentation.
	* guile/scm-value.c: Fix indentation.
	* h8300-tdep.c: Fix indentation.
	* hppa-linux-nat.c: Fix indentation.
	* hppa-linux-tdep.c: Fix indentation.
	* hppa-nbsd-nat.c: Fix indentation.
	* hppa-nbsd-tdep.c: Fix indentation.
	* hppa-obsd-nat.c: Fix indentation.
	* hppa-tdep.c: Fix indentation.
	* hppa-tdep.h: Fix indentation.
	* i386-bsd-nat.c: Fix indentation.
	* i386-darwin-nat.c: Fix indentation.
	* i386-darwin-tdep.c: Fix indentation.
	* i386-dicos-tdep.c: Fix indentation.
	* i386-gnu-nat.c: Fix indentation.
	* i386-linux-nat.c: Fix indentation.
	* i386-linux-tdep.c: Fix indentation.
	* i386-nto-tdep.c: Fix indentation.
	* i386-obsd-tdep.c: Fix indentation.
	* i386-sol2-nat.c: Fix indentation.
	* i386-tdep.c: Fix indentation.
	* i386-tdep.h: Fix indentation.
	* i386-windows-tdep.c: Fix indentation.
	* i387-tdep.c: Fix indentation.
	* i387-tdep.h: Fix indentation.
	* ia64-libunwind-tdep.c: Fix indentation.
	* ia64-libunwind-tdep.h: Fix indentation.
	* ia64-linux-nat.c: Fix indentation.
	* ia64-linux-tdep.c: Fix indentation.
	* ia64-tdep.c: Fix indentation.
	* ia64-tdep.h: Fix indentation.
	* ia64-vms-tdep.c: Fix indentation.
	* infcall.c: Fix indentation.
	* infcmd.c: Fix indentation.
	* inferior.c: Fix indentation.
	* infrun.c: Fix indentation.
	* iq2000-tdep.c: Fix indentation.
	* language.c: Fix indentation.
	* linespec.c: Fix indentation.
	* linux-fork.c: Fix indentation.
	* linux-nat.c: Fix indentation.
	* linux-tdep.c: Fix indentation.
	* linux-thread-db.c: Fix indentation.
	* lm32-tdep.c: Fix indentation.
	* m2-lang.c: Fix indentation.
	* m2-typeprint.c: Fix indentation.
	* m2-valprint.c: Fix indentation.
	* m32c-tdep.c: Fix indentation.
	* m32r-linux-tdep.c: Fix indentation.
	* m32r-tdep.c: Fix indentation.
	* m68hc11-tdep.c: Fix indentation.
	* m68k-bsd-nat.c: Fix indentation.
	* m68k-linux-nat.c: Fix indentation.
	* m68k-linux-tdep.c: Fix indentation.
	* m68k-tdep.c: Fix indentation.
	* machoread.c: Fix indentation.
	* macrocmd.c: Fix indentation.
	* macroexp.c: Fix indentation.
	* macroscope.c: Fix indentation.
	* macrotab.c: Fix indentation.
	* macrotab.h: Fix indentation.
	* main.c: Fix indentation.
	* mdebugread.c: Fix indentation.
	* mep-tdep.c: Fix indentation.
	* mi/mi-cmd-catch.c: Fix indentation.
	* mi/mi-cmd-disas.c: Fix indentation.
	* mi/mi-cmd-env.c: Fix indentation.
	* mi/mi-cmd-stack.c: Fix indentation.
	* mi/mi-cmd-var.c: Fix indentation.
	* mi/mi-cmds.c: Fix indentation.
	* mi/mi-main.c: Fix indentation.
	* mi/mi-parse.c: Fix indentation.
	* microblaze-tdep.c: Fix indentation.
	* minidebug.c: Fix indentation.
	* minsyms.c: Fix indentation.
	* mips-linux-nat.c: Fix indentation.
	* mips-linux-tdep.c: Fix indentation.
	* mips-nbsd-tdep.c: Fix indentation.
	* mips-tdep.c: Fix indentation.
	* mn10300-linux-tdep.c: Fix indentation.
	* mn10300-tdep.c: Fix indentation.
	* moxie-tdep.c: Fix indentation.
	* msp430-tdep.c: Fix indentation.
	* namespace.h: Fix indentation.
	* nat/fork-inferior.c: Fix indentation.
	* nat/gdb_ptrace.h: Fix indentation.
	* nat/linux-namespaces.c: Fix indentation.
	* nat/linux-osdata.c: Fix indentation.
	* nat/netbsd-nat.c: Fix indentation.
	* nat/x86-dregs.c: Fix indentation.
	* nbsd-nat.c: Fix indentation.
	* nbsd-tdep.c: Fix indentation.
	* nios2-linux-tdep.c: Fix indentation.
	* nios2-tdep.c: Fix indentation.
	* nto-procfs.c: Fix indentation.
	* nto-tdep.c: Fix indentation.
	* objfiles.c: Fix indentation.
	* objfiles.h: Fix indentation.
	* opencl-lang.c: Fix indentation.
	* or1k-tdep.c: Fix indentation.
	* osabi.c: Fix indentation.
	* osabi.h: Fix indentation.
	* osdata.c: Fix indentation.
	* p-lang.c: Fix indentation.
	* p-typeprint.c: Fix indentation.
	* p-valprint.c: Fix indentation.
	* parse.c: Fix indentation.
	* ppc-linux-nat.c: Fix indentation.
	* ppc-linux-tdep.c: Fix indentation.
	* ppc-nbsd-nat.c: Fix indentation.
	* ppc-nbsd-tdep.c: Fix indentation.
	* ppc-obsd-nat.c: Fix indentation.
	* ppc-ravenscar-thread.c: Fix indentation.
	* ppc-sysv-tdep.c: Fix indentation.
	* ppc64-tdep.c: Fix indentation.
	* printcmd.c: Fix indentation.
	* proc-api.c: Fix indentation.
	* producer.c: Fix indentation.
	* producer.h: Fix indentation.
	* prologue-value.c: Fix indentation.
	* prologue-value.h: Fix indentation.
	* psymtab.c: Fix indentation.
	* python/py-arch.c: Fix indentation.
	* python/py-bpevent.c: Fix indentation.
	* python/py-event.c: Fix indentation.
	* python/py-event.h: Fix indentation.
	* python/py-finishbreakpoint.c: Fix indentation.
	* python/py-frame.c: Fix indentation.
	* python/py-framefilter.c: Fix indentation.
	* python/py-inferior.c: Fix indentation.
	* python/py-infthread.c: Fix indentation.
	* python/py-objfile.c: Fix indentation.
	* python/py-prettyprint.c: Fix indentation.
	* python/py-registers.c: Fix indentation.
	* python/py-signalevent.c: Fix indentation.
	* python/py-stopevent.c: Fix indentation.
	* python/py-stopevent.h: Fix indentation.
	* python/py-threadevent.c: Fix indentation.
	* python/py-tui.c: Fix indentation.
	* python/py-unwind.c: Fix indentation.
	* python/py-value.c: Fix indentation.
	* python/py-xmethods.c: Fix indentation.
	* python/python-internal.h: Fix indentation.
	* python/python.c: Fix indentation.
	* ravenscar-thread.c: Fix indentation.
	* record-btrace.c: Fix indentation.
	* record-full.c: Fix indentation.
	* record.c: Fix indentation.
	* reggroups.c: Fix indentation.
	* regset.h: Fix indentation.
	* remote-fileio.c: Fix indentation.
	* remote.c: Fix indentation.
	* reverse.c: Fix indentation.
	* riscv-linux-tdep.c: Fix indentation.
	* riscv-ravenscar-thread.c: Fix indentation.
	* riscv-tdep.c: Fix indentation.
	* rl78-tdep.c: Fix indentation.
	* rs6000-aix-tdep.c: Fix indentation.
	* rs6000-lynx178-tdep.c: Fix indentation.
	* rs6000-nat.c: Fix indentation.
	* rs6000-tdep.c: Fix indentation.
	* rust-lang.c: Fix indentation.
	* rx-tdep.c: Fix indentation.
	* s12z-tdep.c: Fix indentation.
	* s390-linux-tdep.c: Fix indentation.
	* score-tdep.c: Fix indentation.
	* ser-base.c: Fix indentation.
	* ser-mingw.c: Fix indentation.
	* ser-uds.c: Fix indentation.
	* ser-unix.c: Fix indentation.
	* serial.c: Fix indentation.
	* sh-linux-tdep.c: Fix indentation.
	* sh-nbsd-tdep.c: Fix indentation.
	* sh-tdep.c: Fix indentation.
	* skip.c: Fix indentation.
	* sol-thread.c: Fix indentation.
	* solib-aix.c: Fix indentation.
	* solib-darwin.c: Fix indentation.
	* solib-frv.c: Fix indentation.
	* solib-svr4.c: Fix indentation.
	* solib.c: Fix indentation.
	* source.c: Fix indentation.
	* sparc-linux-tdep.c: Fix indentation.
	* sparc-nbsd-tdep.c: Fix indentation.
	* sparc-obsd-tdep.c: Fix indentation.
	* sparc-ravenscar-thread.c: Fix indentation.
	* sparc-tdep.c: Fix indentation.
	* sparc64-linux-tdep.c: Fix indentation.
	* sparc64-nbsd-tdep.c: Fix indentation.
	* sparc64-obsd-tdep.c: Fix indentation.
	* sparc64-tdep.c: Fix indentation.
	* stabsread.c: Fix indentation.
	* stack.c: Fix indentation.
	* stap-probe.c: Fix indentation.
	* stubs/ia64vms-stub.c: Fix indentation.
	* stubs/m32r-stub.c: Fix indentation.
	* stubs/m68k-stub.c: Fix indentation.
	* stubs/sh-stub.c: Fix indentation.
	* stubs/sparc-stub.c: Fix indentation.
	* symfile-mem.c: Fix indentation.
	* symfile.c: Fix indentation.
	* symfile.h: Fix indentation.
	* symmisc.c: Fix indentation.
	* symtab.c: Fix indentation.
	* symtab.h: Fix indentation.
	* target-float.c: Fix indentation.
	* target.c: Fix indentation.
	* target.h: Fix indentation.
	* tic6x-tdep.c: Fix indentation.
	* tilegx-linux-tdep.c: Fix indentation.
	* tilegx-tdep.c: Fix indentation.
	* top.c: Fix indentation.
	* tracefile-tfile.c: Fix indentation.
	* tracepoint.c: Fix indentation.
	* tui/tui-disasm.c: Fix indentation.
	* tui/tui-io.c: Fix indentation.
	* tui/tui-regs.c: Fix indentation.
	* tui/tui-stack.c: Fix indentation.
	* tui/tui-win.c: Fix indentation.
	* tui/tui-winsource.c: Fix indentation.
	* tui/tui.c: Fix indentation.
	* typeprint.c: Fix indentation.
	* ui-out.h: Fix indentation.
	* unittests/copy_bitwise-selftests.c: Fix indentation.
	* unittests/memory-map-selftests.c: Fix indentation.
	* utils.c: Fix indentation.
	* v850-tdep.c: Fix indentation.
	* valarith.c: Fix indentation.
	* valops.c: Fix indentation.
	* valprint.c: Fix indentation.
	* valprint.h: Fix indentation.
	* value.c: Fix indentation.
	* value.h: Fix indentation.
	* varobj.c: Fix indentation.
	* vax-tdep.c: Fix indentation.
	* windows-nat.c: Fix indentation.
	* windows-tdep.c: Fix indentation.
	* xcoffread.c: Fix indentation.
	* xml-syscall.c: Fix indentation.
	* xml-tdesc.c: Fix indentation.
	* xstormy16-tdep.c: Fix indentation.
	* xtensa-config.c: Fix indentation.
	* xtensa-linux-nat.c: Fix indentation.
	* xtensa-linux-tdep.c: Fix indentation.
	* xtensa-tdep.c: Fix indentation.

gdbserver/ChangeLog:

	* ax.cc: Fix indentation.
	* dll.cc: Fix indentation.
	* inferiors.h: Fix indentation.
	* linux-low.cc: Fix indentation.
	* linux-nios2-low.cc: Fix indentation.
	* linux-ppc-ipa.cc: Fix indentation.
	* linux-ppc-low.cc: Fix indentation.
	* linux-x86-low.cc: Fix indentation.
	* linux-xtensa-low.cc: Fix indentation.
	* regcache.cc: Fix indentation.
	* server.cc: Fix indentation.
	* tracepoint.cc: Fix indentation.

gdbsupport/ChangeLog:

	* common-exceptions.h: Fix indentation.
	* event-loop.cc: Fix indentation.
	* fileio.cc: Fix indentation.
	* filestuff.cc: Fix indentation.
	* gdb-dlfcn.cc: Fix indentation.
	* gdb_string_view.h: Fix indentation.
	* job-control.cc: Fix indentation.
	* signals.cc: Fix indentation.

Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
2020-11-02 10:28:45 -05:00

816 lines
22 KiB
C

/* Native-dependent code for NetBSD.
Copyright (C) 2006-2020 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "netbsd-nat.h"
#include "nat/netbsd-nat.h"
#include "gdbthread.h"
#include "netbsd-tdep.h"
#include "inferior.h"
#include "gdbarch.h"
#include <sys/types.h>
#include <sys/ptrace.h>
#include <sys/sysctl.h>
#include <sys/wait.h>
/* Return the name of a file that can be opened to get the symbols for
the child process identified by PID. */
char *
nbsd_nat_target::pid_to_exec_file (int pid)
{
return const_cast<char *> (netbsd_nat::pid_to_exec_file (pid));
}
/* Return the current directory for the process identified by PID. */
static std::string
nbsd_pid_to_cwd (int pid)
{
char buf[PATH_MAX];
size_t buflen;
int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_CWD};
buflen = sizeof (buf);
if (sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0))
return "";
return buf;
}
/* Return the kinfo_proc2 structure for the process identified by PID. */
static bool
nbsd_pid_to_kinfo_proc2 (pid_t pid, struct kinfo_proc2 *kp)
{
gdb_assert (kp != nullptr);
size_t size = sizeof (*kp);
int mib[6] = {CTL_KERN, KERN_PROC2, KERN_PROC_PID, pid,
static_cast<int> (size), 1};
return !sysctl (mib, ARRAY_SIZE (mib), kp, &size, NULL, 0);
}
/* Return the command line for the process identified by PID. */
static gdb::unique_xmalloc_ptr<char[]>
nbsd_pid_to_cmdline (int pid)
{
int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_ARGV};
size_t size = 0;
if (::sysctl (mib, ARRAY_SIZE (mib), NULL, &size, NULL, 0) == -1 || size == 0)
return nullptr;
gdb::unique_xmalloc_ptr<char[]> args (XNEWVAR (char, size));
if (::sysctl (mib, ARRAY_SIZE (mib), args.get (), &size, NULL, 0) == -1
|| size == 0)
return nullptr;
/* Arguments are returned as a flattened string with NUL separators.
Join the arguments with spaces to form a single string. */
for (size_t i = 0; i < size - 1; i++)
if (args[i] == '\0')
args[i] = ' ';
args[size - 1] = '\0';
return args;
}
/* Return true if PTID is still active in the inferior. */
bool
nbsd_nat_target::thread_alive (ptid_t ptid)
{
return netbsd_nat::thread_alive (ptid);
}
/* Return the name assigned to a thread by an application. Returns
the string in a static buffer. */
const char *
nbsd_nat_target::thread_name (struct thread_info *thr)
{
ptid_t ptid = thr->ptid;
return netbsd_nat::thread_name (ptid);
}
/* Implement the "post_attach" target_ops method. */
static void
nbsd_add_threads (nbsd_nat_target *target, pid_t pid)
{
auto fn
= [&target] (ptid_t ptid)
{
if (!in_thread_list (target, ptid))
{
if (inferior_ptid.lwp () == 0)
thread_change_ptid (target, inferior_ptid, ptid);
else
add_thread (target, ptid);
}
};
netbsd_nat::for_each_thread (pid, fn);
}
/* Implement the "post_startup_inferior" target_ops method. */
void
nbsd_nat_target::post_startup_inferior (ptid_t ptid)
{
netbsd_nat::enable_proc_events (ptid.pid ());
}
/* Implement the "post_attach" target_ops method. */
void
nbsd_nat_target::post_attach (int pid)
{
netbsd_nat::enable_proc_events (pid);
nbsd_add_threads (this, pid);
}
/* Implement the "update_thread_list" target_ops method. */
void
nbsd_nat_target::update_thread_list ()
{
delete_exited_threads ();
}
/* Convert PTID to a string. */
std::string
nbsd_nat_target::pid_to_str (ptid_t ptid)
{
int lwp = ptid.lwp ();
if (lwp != 0)
{
pid_t pid = ptid.pid ();
return string_printf ("LWP %d of process %d", lwp, pid);
}
return normal_pid_to_str (ptid);
}
/* Retrieve all the memory regions in the specified process. */
static gdb::unique_xmalloc_ptr<struct kinfo_vmentry[]>
nbsd_kinfo_get_vmmap (pid_t pid, size_t *size)
{
int mib[5] = {CTL_VM, VM_PROC, VM_PROC_MAP, pid,
sizeof (struct kinfo_vmentry)};
size_t length = 0;
if (sysctl (mib, ARRAY_SIZE (mib), NULL, &length, NULL, 0))
{
*size = 0;
return NULL;
}
/* Prereserve more space. The length argument is volatile and can change
between the sysctl(3) calls as this function can be called against a
running process. */
length = length * 5 / 3;
gdb::unique_xmalloc_ptr<struct kinfo_vmentry[]> kiv
(XNEWVAR (kinfo_vmentry, length));
if (sysctl (mib, ARRAY_SIZE (mib), kiv.get (), &length, NULL, 0))
{
*size = 0;
return NULL;
}
*size = length / sizeof (struct kinfo_vmentry);
return kiv;
}
/* Iterate over all the memory regions in the current inferior,
calling FUNC for each memory region. OBFD is passed as the last
argument to FUNC. */
int
nbsd_nat_target::find_memory_regions (find_memory_region_ftype func,
void *data)
{
pid_t pid = inferior_ptid.pid ();
size_t nitems;
gdb::unique_xmalloc_ptr<struct kinfo_vmentry[]> vmentl
= nbsd_kinfo_get_vmmap (pid, &nitems);
if (vmentl == NULL)
perror_with_name (_("Couldn't fetch VM map entries."));
for (size_t i = 0; i < nitems; i++)
{
struct kinfo_vmentry *kve = &vmentl[i];
/* Skip unreadable segments and those where MAP_NOCORE has been set. */
if (!(kve->kve_protection & KVME_PROT_READ)
|| kve->kve_flags & KVME_FLAG_NOCOREDUMP)
continue;
/* Skip segments with an invalid type. */
switch (kve->kve_type)
{
case KVME_TYPE_VNODE:
case KVME_TYPE_ANON:
case KVME_TYPE_SUBMAP:
case KVME_TYPE_OBJECT:
break;
default:
continue;
}
size_t size = kve->kve_end - kve->kve_start;
if (info_verbose)
{
fprintf_filtered (gdb_stdout,
"Save segment, %ld bytes at %s (%c%c%c)\n",
(long) size,
paddress (target_gdbarch (), kve->kve_start),
kve->kve_protection & KVME_PROT_READ ? 'r' : '-',
kve->kve_protection & KVME_PROT_WRITE ? 'w' : '-',
kve->kve_protection & KVME_PROT_EXEC ? 'x' : '-');
}
/* Invoke the callback function to create the corefile segment.
Pass MODIFIED as true, we do not know the real modification state. */
func (kve->kve_start, size, kve->kve_protection & KVME_PROT_READ,
kve->kve_protection & KVME_PROT_WRITE,
kve->kve_protection & KVME_PROT_EXEC, 1, data);
}
return 0;
}
/* Implement the "info_proc" target_ops method. */
bool
nbsd_nat_target::info_proc (const char *args, enum info_proc_what what)
{
pid_t pid;
bool do_cmdline = false;
bool do_cwd = false;
bool do_exe = false;
bool do_mappings = false;
bool do_status = false;
switch (what)
{
case IP_MINIMAL:
do_cmdline = true;
do_cwd = true;
do_exe = true;
break;
case IP_STAT:
case IP_STATUS:
do_status = true;
break;
case IP_MAPPINGS:
do_mappings = true;
break;
case IP_CMDLINE:
do_cmdline = true;
break;
case IP_EXE:
do_exe = true;
break;
case IP_CWD:
do_cwd = true;
break;
case IP_ALL:
do_cmdline = true;
do_cwd = true;
do_exe = true;
do_mappings = true;
do_status = true;
break;
default:
error (_("Not supported on this target."));
}
gdb_argv built_argv (args);
if (built_argv.count () == 0)
{
pid = inferior_ptid.pid ();
if (pid == 0)
error (_("No current process: you must name one."));
}
else if (built_argv.count () == 1 && isdigit (built_argv[0][0]))
pid = strtol (built_argv[0], NULL, 10);
else
error (_("Invalid arguments."));
printf_filtered (_("process %d\n"), pid);
if (do_cmdline)
{
gdb::unique_xmalloc_ptr<char[]> cmdline = nbsd_pid_to_cmdline (pid);
if (cmdline != nullptr)
printf_filtered ("cmdline = '%s'\n", cmdline.get ());
else
warning (_("unable to fetch command line"));
}
if (do_cwd)
{
std::string cwd = nbsd_pid_to_cwd (pid);
if (cwd != "")
printf_filtered ("cwd = '%s'\n", cwd.c_str ());
else
warning (_("unable to fetch current working directory"));
}
if (do_exe)
{
const char *exe = pid_to_exec_file (pid);
if (exe != nullptr)
printf_filtered ("exe = '%s'\n", exe);
else
warning (_("unable to fetch executable path name"));
}
if (do_mappings)
{
size_t nvment;
gdb::unique_xmalloc_ptr<struct kinfo_vmentry[]> vmentl
= nbsd_kinfo_get_vmmap (pid, &nvment);
if (vmentl != nullptr)
{
int addr_bit = TARGET_CHAR_BIT * sizeof (void *);
nbsd_info_proc_mappings_header (addr_bit);
struct kinfo_vmentry *kve = vmentl.get ();
for (int i = 0; i < nvment; i++, kve++)
nbsd_info_proc_mappings_entry (addr_bit, kve->kve_start,
kve->kve_end, kve->kve_offset,
kve->kve_flags, kve->kve_protection,
kve->kve_path);
}
else
warning (_("unable to fetch virtual memory map"));
}
if (do_status)
{
struct kinfo_proc2 kp;
if (!nbsd_pid_to_kinfo_proc2 (pid, &kp))
warning (_("Failed to fetch process information"));
else
{
auto process_status
= [] (int8_t stat)
{
switch (stat)
{
case SIDL:
return "IDL";
case SACTIVE:
return "ACTIVE";
case SDYING:
return "DYING";
case SSTOP:
return "STOP";
case SZOMB:
return "ZOMB";
case SDEAD:
return "DEAD";
default:
return "? (unknown)";
}
};
printf_filtered ("Name: %s\n", kp.p_comm);
printf_filtered ("State: %s\n", process_status(kp.p_realstat));
printf_filtered ("Parent process: %" PRId32 "\n", kp.p_ppid);
printf_filtered ("Process group: %" PRId32 "\n", kp.p__pgid);
printf_filtered ("Session id: %" PRId32 "\n", kp.p_sid);
printf_filtered ("TTY: %" PRId32 "\n", kp.p_tdev);
printf_filtered ("TTY owner process group: %" PRId32 "\n", kp.p_tpgid);
printf_filtered ("User IDs (real, effective, saved): "
"%" PRIu32 " %" PRIu32 " %" PRIu32 "\n",
kp.p_ruid, kp.p_uid, kp.p_svuid);
printf_filtered ("Group IDs (real, effective, saved): "
"%" PRIu32 " %" PRIu32 " %" PRIu32 "\n",
kp.p_rgid, kp.p_gid, kp.p_svgid);
printf_filtered ("Groups:");
for (int i = 0; i < kp.p_ngroups; i++)
printf_filtered (" %" PRIu32, kp.p_groups[i]);
printf_filtered ("\n");
printf_filtered ("Minor faults (no memory page): %" PRIu64 "\n",
kp.p_uru_minflt);
printf_filtered ("Major faults (memory page faults): %" PRIu64 "\n",
kp.p_uru_majflt);
printf_filtered ("utime: %" PRIu32 ".%06" PRIu32 "\n",
kp.p_uutime_sec, kp.p_uutime_usec);
printf_filtered ("stime: %" PRIu32 ".%06" PRIu32 "\n",
kp.p_ustime_sec, kp.p_ustime_usec);
printf_filtered ("utime+stime, children: %" PRIu32 ".%06" PRIu32 "\n",
kp.p_uctime_sec, kp.p_uctime_usec);
printf_filtered ("'nice' value: %" PRIu8 "\n", kp.p_nice);
printf_filtered ("Start time: %" PRIu32 ".%06" PRIu32 "\n",
kp.p_ustart_sec, kp.p_ustart_usec);
int pgtok = getpagesize () / 1024;
printf_filtered ("Data size: %" PRIuMAX " kB\n",
(uintmax_t) kp.p_vm_dsize * pgtok);
printf_filtered ("Stack size: %" PRIuMAX " kB\n",
(uintmax_t) kp.p_vm_ssize * pgtok);
printf_filtered ("Text size: %" PRIuMAX " kB\n",
(uintmax_t) kp.p_vm_tsize * pgtok);
printf_filtered ("Resident set size: %" PRIuMAX " kB\n",
(uintmax_t) kp.p_vm_rssize * pgtok);
printf_filtered ("Maximum RSS: %" PRIu64 " kB\n", kp.p_uru_maxrss);
printf_filtered ("Pending Signals:");
for (size_t i = 0; i < ARRAY_SIZE (kp.p_siglist.__bits); i++)
printf_filtered (" %08" PRIx32, kp.p_siglist.__bits[i]);
printf_filtered ("\n");
printf_filtered ("Ignored Signals:");
for (size_t i = 0; i < ARRAY_SIZE (kp.p_sigignore.__bits); i++)
printf_filtered (" %08" PRIx32, kp.p_sigignore.__bits[i]);
printf_filtered ("\n");
printf_filtered ("Caught Signals:");
for (size_t i = 0; i < ARRAY_SIZE (kp.p_sigcatch.__bits); i++)
printf_filtered (" %08" PRIx32, kp.p_sigcatch.__bits[i]);
printf_filtered ("\n");
}
}
return true;
}
/* Resume execution of a specified PTID, that points to a process or a thread
within a process. If one thread is specified, all other threads are
suspended. If STEP is nonzero, single-step it. If SIGNAL is nonzero,
give it that signal. */
static void
nbsd_resume(nbsd_nat_target *target, ptid_t ptid, int step,
enum gdb_signal signal)
{
int request;
gdb_assert (minus_one_ptid != ptid);
if (ptid.lwp_p ())
{
/* If ptid is a specific LWP, suspend all other LWPs in the process. */
inferior *inf = find_inferior_ptid (target, ptid);
for (thread_info *tp : inf->non_exited_threads ())
{
if (tp->ptid.lwp () == ptid.lwp ())
request = PT_RESUME;
else
request = PT_SUSPEND;
if (ptrace (request, tp->ptid.pid (), NULL, tp->ptid.lwp ()) == -1)
perror_with_name (("ptrace"));
}
}
else
{
/* If ptid is a wildcard, resume all matching threads (they won't run
until the process is continued however). */
for (thread_info *tp : all_non_exited_threads (target, ptid))
if (ptrace (PT_RESUME, tp->ptid.pid (), NULL, tp->ptid.lwp ()) == -1)
perror_with_name (("ptrace"));
}
if (step)
{
for (thread_info *tp : all_non_exited_threads (target, ptid))
if (ptrace (PT_SETSTEP, tp->ptid.pid (), NULL, tp->ptid.lwp ()) == -1)
perror_with_name (("ptrace"));
}
else
{
for (thread_info *tp : all_non_exited_threads (target, ptid))
if (ptrace (PT_CLEARSTEP, tp->ptid.pid (), NULL, tp->ptid.lwp ()) == -1)
perror_with_name (("ptrace"));
}
if (catch_syscall_enabled () > 0)
request = PT_SYSCALL;
else
request = PT_CONTINUE;
/* An address of (void *)1 tells ptrace to continue from
where it was. If GDB wanted it to start some other way, we have
already written a new program counter value to the child. */
if (ptrace (request, ptid.pid (), (void *)1, gdb_signal_to_host (signal)) == -1)
perror_with_name (("ptrace"));
}
/* Resume execution of thread PTID, or all threads of all inferiors
if PTID is -1. If STEP is nonzero, single-step it. If SIGNAL is nonzero,
give it that signal. */
void
nbsd_nat_target::resume (ptid_t ptid, int step, enum gdb_signal signal)
{
if (minus_one_ptid != ptid)
nbsd_resume (this, ptid, step, signal);
else
{
for (inferior *inf : all_non_exited_inferiors (this))
nbsd_resume (this, ptid_t (inf->pid, 0, 0), step, signal);
}
}
/* Implement a safe wrapper around waitpid(). */
static pid_t
nbsd_wait (ptid_t ptid, struct target_waitstatus *ourstatus,
target_wait_flags options)
{
pid_t pid;
int status;
set_sigint_trap ();
do
{
/* The common code passes WNOHANG that leads to crashes, overwrite it. */
pid = waitpid (ptid.pid (), &status, 0);
}
while (pid == -1 && errno == EINTR);
clear_sigint_trap ();
if (pid == -1)
perror_with_name (_("Child process unexpectedly missing"));
store_waitstatus (ourstatus, status);
return pid;
}
/* Wait for the child specified by PTID to do something. Return the
process ID of the child, or MINUS_ONE_PTID in case of error; store
the status in *OURSTATUS. */
ptid_t
nbsd_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus,
target_wait_flags target_options)
{
pid_t pid = nbsd_wait (ptid, ourstatus, target_options);
ptid_t wptid = ptid_t (pid);
/* If the child stopped, keep investigating its status. */
if (ourstatus->kind != TARGET_WAITKIND_STOPPED)
return wptid;
/* Extract the event and thread that received a signal. */
ptrace_siginfo_t psi;
if (ptrace (PT_GET_SIGINFO, pid, &psi, sizeof (psi)) == -1)
perror_with_name (("ptrace"));
/* Pick child's siginfo_t. */
siginfo_t *si = &psi.psi_siginfo;
int lwp = psi.psi_lwpid;
int signo = si->si_signo;
const int code = si->si_code;
/* Construct PTID with a specified thread that received the event.
If a signal was targeted to the whole process, lwp is 0. */
wptid = ptid_t (pid, lwp, 0);
/* Bail out on non-debugger oriented signals.. */
if (signo != SIGTRAP)
return wptid;
/* Stop examining non-debugger oriented SIGTRAP codes. */
if (code <= SI_USER || code == SI_NOINFO)
return wptid;
/* Process state for threading events */
ptrace_state_t pst = {};
if (code == TRAP_LWP)
{
if (ptrace (PT_GET_PROCESS_STATE, pid, &pst, sizeof (pst)) == -1)
perror_with_name (("ptrace"));
}
if (code == TRAP_LWP && pst.pe_report_event == PTRACE_LWP_EXIT)
{
/* If GDB attaches to a multi-threaded process, exiting
threads might be skipped during post_attach that
have not yet reported their PTRACE_LWP_EXIT event.
Ignore exited events for an unknown LWP. */
thread_info *thr = find_thread_ptid (this, wptid);
if (thr == nullptr)
ourstatus->kind = TARGET_WAITKIND_SPURIOUS;
else
{
ourstatus->kind = TARGET_WAITKIND_THREAD_EXITED;
/* NetBSD does not store an LWP exit status. */
ourstatus->value.integer = 0;
if (print_thread_events)
printf_unfiltered (_("[%s exited]\n"),
target_pid_to_str (wptid).c_str ());
delete_thread (thr);
}
/* The GDB core expects that the rest of the threads are running. */
if (ptrace (PT_CONTINUE, pid, (void *) 1, 0) == -1)
perror_with_name (("ptrace"));
return wptid;
}
if (in_thread_list (this, ptid_t (pid)))
thread_change_ptid (this, ptid_t (pid), wptid);
if (code == TRAP_LWP && pst.pe_report_event == PTRACE_LWP_CREATE)
{
/* If GDB attaches to a multi-threaded process, newborn
threads might be added by nbsd_add_threads that have
not yet reported their PTRACE_LWP_CREATE event. Ignore
born events for an already-known LWP. */
if (in_thread_list (this, wptid))
ourstatus->kind = TARGET_WAITKIND_SPURIOUS;
else
{
add_thread (this, wptid);
ourstatus->kind = TARGET_WAITKIND_THREAD_CREATED;
}
return wptid;
}
if (code == TRAP_EXEC)
{
ourstatus->kind = TARGET_WAITKIND_EXECD;
ourstatus->value.execd_pathname = xstrdup (pid_to_exec_file (pid));
return wptid;
}
if (code == TRAP_TRACE)
{
/* Unhandled at this level. */
return wptid;
}
if (code == TRAP_SCE || code == TRAP_SCX)
{
int sysnum = si->si_sysnum;
if (!catch_syscall_enabled () || !catching_syscall_number (sysnum))
{
/* If the core isn't interested in this event, ignore it. */
ourstatus->kind = TARGET_WAITKIND_SPURIOUS;
return wptid;
}
ourstatus->kind =
(code == TRAP_SCE) ? TARGET_WAITKIND_SYSCALL_ENTRY :
TARGET_WAITKIND_SYSCALL_RETURN;
ourstatus->value.syscall_number = sysnum;
return wptid;
}
if (code == TRAP_BRKPT)
{
/* Unhandled at this level. */
return wptid;
}
/* Unclassified SIGTRAP event. */
ourstatus->kind = TARGET_WAITKIND_SPURIOUS;
return wptid;
}
/* Implement the "insert_exec_catchpoint" target_ops method. */
int
nbsd_nat_target::insert_exec_catchpoint (int pid)
{
/* Nothing to do. */
return 0;
}
/* Implement the "remove_exec_catchpoint" target_ops method. */
int
nbsd_nat_target::remove_exec_catchpoint (int pid)
{
/* Nothing to do. */
return 0;
}
/* Implement the "set_syscall_catchpoint" target_ops method. */
int
nbsd_nat_target::set_syscall_catchpoint (int pid, bool needed,
int any_count,
gdb::array_view<const int> syscall_counts)
{
/* Ignore the arguments. inf-ptrace.c will use PT_SYSCALL which
will catch all system call entries and exits. The system calls
are filtered by GDB rather than the kernel. */
return 0;
}
/* Implement the "supports_multi_process" target_ops method. */
bool
nbsd_nat_target::supports_multi_process ()
{
return true;
}
/* Implement the "xfer_partial" target_ops method. */
enum target_xfer_status
nbsd_nat_target::xfer_partial (enum target_object object,
const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf,
ULONGEST offset, ULONGEST len,
ULONGEST *xfered_len)
{
pid_t pid = inferior_ptid.pid ();
switch (object)
{
case TARGET_OBJECT_SIGNAL_INFO:
{
len = netbsd_nat::qxfer_siginfo(pid, annex, readbuf, writebuf, offset,
len);
if (len == -1)
return TARGET_XFER_E_IO;
*xfered_len = len;
return TARGET_XFER_OK;
}
case TARGET_OBJECT_MEMORY:
{
size_t xfered;
int res;
if (writebuf != nullptr)
res = netbsd_nat::write_memory (pid, writebuf, offset, len, &xfered);
else
res = netbsd_nat::read_memory (pid, readbuf, offset, len, &xfered);
if (res != 0)
{
if (res == EACCES)
fprintf_unfiltered (gdb_stderr, "Cannot %s process at %s (%s). "
"Is PaX MPROTECT active? See security(7), "
"sysctl(7), paxctl(8)\n",
(writebuf ? "write to" : "read from"),
pulongest (offset), safe_strerror (errno));
return TARGET_XFER_E_IO;
}
if (xfered == 0)
return TARGET_XFER_EOF;
*xfered_len = (ULONGEST) xfered;
return TARGET_XFER_OK;
}
default:
return inf_ptrace_target::xfer_partial (object, annex,
readbuf, writebuf, offset,
len, xfered_len);
}
}
/* Implement the "supports_dumpcore" target_ops method. */
bool
nbsd_nat_target::supports_dumpcore ()
{
return true;
}
/* Implement the "dumpcore" target_ops method. */
void
nbsd_nat_target::dumpcore (const char *filename)
{
pid_t pid = inferior_ptid.pid ();
if (ptrace (PT_DUMPCORE, pid, const_cast<char *>(filename),
strlen (filename)) == -1)
perror_with_name (("ptrace"));
}