mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
c44191f8e3
There's an early exit in libdebuginfod's debuginfod_query_server, which checks both for: - getenv (DEBUGINFOD_URLS_ENV_VAR) == NULL, and - (getenv (DEBUGINFOD_URLS_ENV_VAR))[0] == '\0'. In debuginfod_source_query and debuginfod_debuginfo_query (which both end up calling debuginfod_query_server) there are also early exits checking the same env var, but those just check for NULL. Make the early exit tests in debuginfod-support.c match those in libdebuginfod. gdb/ChangeLog: 2020-11-18 Tom de Vries <tdevries@suse.de> * debuginfod-support.c (debuginfod_source_query) (debuginfod_debuginfo_query): Also do early exit if "(getenv (DEBUGINFOD_URLS_ENV_VAR))[0] == '\0'".
177 lines
4.5 KiB
C
177 lines
4.5 KiB
C
/* debuginfod utilities for GDB.
|
|
Copyright (C) 2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include <errno.h>
|
|
#include "cli/cli-style.h"
|
|
#include "gdbsupport/scoped_fd.h"
|
|
#include "debuginfod-support.h"
|
|
|
|
#ifndef HAVE_LIBDEBUGINFOD
|
|
scoped_fd
|
|
debuginfod_source_query (const unsigned char *build_id,
|
|
int build_id_len,
|
|
const char *srcpath,
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
{
|
|
return scoped_fd (-ENOSYS);
|
|
}
|
|
|
|
scoped_fd
|
|
debuginfod_debuginfo_query (const unsigned char *build_id,
|
|
int build_id_len,
|
|
const char *filename,
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
{
|
|
return scoped_fd (-ENOSYS);
|
|
}
|
|
#else
|
|
#include <elfutils/debuginfod.h>
|
|
|
|
struct user_data
|
|
{
|
|
user_data (const char *desc, const char *fname)
|
|
: desc (desc), fname (fname), has_printed (false)
|
|
{ }
|
|
|
|
const char * const desc;
|
|
const char * const fname;
|
|
bool has_printed;
|
|
};
|
|
|
|
/* Deleter for a debuginfod_client. */
|
|
|
|
struct debuginfod_client_deleter
|
|
{
|
|
void operator() (debuginfod_client *c)
|
|
{
|
|
debuginfod_end (c);
|
|
}
|
|
};
|
|
|
|
using debuginfod_client_up
|
|
= std::unique_ptr<debuginfod_client, debuginfod_client_deleter>;
|
|
|
|
static int
|
|
progressfn (debuginfod_client *c, long cur, long total)
|
|
{
|
|
user_data *data = static_cast<user_data *> (debuginfod_get_user_data (c));
|
|
|
|
if (check_quit_flag ())
|
|
{
|
|
printf_filtered ("Cancelling download of %s %ps...\n",
|
|
data->desc,
|
|
styled_string (file_name_style.style (), data->fname));
|
|
return 1;
|
|
}
|
|
|
|
if (!data->has_printed && total != 0)
|
|
{
|
|
/* Print this message only once. */
|
|
data->has_printed = true;
|
|
printf_filtered ("Downloading %s %ps...\n",
|
|
data->desc,
|
|
styled_string (file_name_style.style (), data->fname));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static debuginfod_client_up
|
|
debuginfod_init ()
|
|
{
|
|
debuginfod_client_up c (debuginfod_begin ());
|
|
|
|
if (c != nullptr)
|
|
debuginfod_set_progressfn (c.get (), progressfn);
|
|
|
|
return c;
|
|
}
|
|
|
|
/* See debuginfod-support.h */
|
|
|
|
scoped_fd
|
|
debuginfod_source_query (const unsigned char *build_id,
|
|
int build_id_len,
|
|
const char *srcpath,
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
{
|
|
const char *urls_env_var = getenv (DEBUGINFOD_URLS_ENV_VAR);
|
|
if (urls_env_var == NULL || urls_env_var[0] == '\0')
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
debuginfod_client_up c = debuginfod_init ();
|
|
|
|
if (c == nullptr)
|
|
return scoped_fd (-ENOMEM);
|
|
|
|
user_data data ("source file", srcpath);
|
|
|
|
debuginfod_set_user_data (c.get (), &data);
|
|
scoped_fd fd (debuginfod_find_source (c.get (),
|
|
build_id,
|
|
build_id_len,
|
|
srcpath,
|
|
nullptr));
|
|
|
|
/* TODO: Add 'set debug debuginfod' command to control when error messages are shown. */
|
|
if (fd.get () < 0 && fd.get () != -ENOENT)
|
|
printf_filtered (_("Download failed: %s. Continuing without source file %ps.\n"),
|
|
safe_strerror (-fd.get ()),
|
|
styled_string (file_name_style.style (), srcpath));
|
|
else
|
|
*destname = make_unique_xstrdup (srcpath);
|
|
|
|
return fd;
|
|
}
|
|
|
|
/* See debuginfod-support.h */
|
|
|
|
scoped_fd
|
|
debuginfod_debuginfo_query (const unsigned char *build_id,
|
|
int build_id_len,
|
|
const char *filename,
|
|
gdb::unique_xmalloc_ptr<char> *destname)
|
|
{
|
|
const char *urls_env_var = getenv (DEBUGINFOD_URLS_ENV_VAR);
|
|
if (urls_env_var == NULL || urls_env_var[0] == '\0')
|
|
return scoped_fd (-ENOSYS);
|
|
|
|
debuginfod_client_up c = debuginfod_init ();
|
|
|
|
if (c == nullptr)
|
|
return scoped_fd (-ENOMEM);
|
|
|
|
char *dname = nullptr;
|
|
user_data data ("separate debug info for", filename);
|
|
|
|
debuginfod_set_user_data (c.get (), &data);
|
|
scoped_fd fd (debuginfod_find_debuginfo (c.get (), build_id, build_id_len,
|
|
&dname));
|
|
|
|
if (fd.get () < 0 && fd.get () != -ENOENT)
|
|
printf_filtered (_("Download failed: %s. Continuing without debug info for %ps.\n"),
|
|
safe_strerror (-fd.get ()),
|
|
styled_string (file_name_style.style (), filename));
|
|
|
|
destname->reset (dname);
|
|
|
|
return fd;
|
|
}
|
|
#endif
|