mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-03 04:12:10 +08:00
e6b6fad2fe
This extends the commit 4581a1c7d3 fix to more targets, which
hardens BFD a little. I think the real underlying problem was the
bfd_canonicalize_reloc call in load_specific_debug_section which
passed a NULL for "symbols". Fix that too.
PR 22509
bfd/
* aoutx.h (swap_ext_reloc_out): Gracefully handle NULL symbols.
* i386lynx.c (swap_ext_reloc_out): Likewise.
* pdp11.c (pdp11_aout_swap_reloc_out): Likewise.
* coff-tic30.c (reloc_processing): Likewise.
* coff-tic4x.c (tic4x_reloc_processing): Likewise.
* coff-tic54x.c (tic54x_reloc_processing): Likewise.
* coff-z80.c (reloc_processing): Likewise.
* coff-z8k.c (reloc_processing): Likewise.
* ecoff.c (ecoff_slurp_reloc_table): Likewise.
* som.c (som_set_reloc_info): Likewise.
binutils/
* objdump.c (load_specific_debug_section): Pass syms to
bfd_canonicalize_reloc.
243 lines
7.1 KiB
C
243 lines
7.1 KiB
C
/* BFD back-end for TMS320C30 coff binaries.
|
|
Copyright (C) 1998-2022 Free Software Foundation, Inc.
|
|
Contributed by Steven Haworth (steve@pm.cse.rmit.edu.au)
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
|
|
02110-1301, USA. */
|
|
|
|
#include "sysdep.h"
|
|
#include "bfd.h"
|
|
#include "libbfd.h"
|
|
#include "bfdlink.h"
|
|
#include "coff/tic30.h"
|
|
#include "coff/internal.h"
|
|
#include "libcoff.h"
|
|
|
|
#define COFF_DEFAULT_SECTION_ALIGNMENT_POWER (1)
|
|
|
|
reloc_howto_type tic30_coff_howto_table[] =
|
|
{
|
|
HOWTO (R_TIC30_ABS16, 2, 2, 16, false, 0, 0, NULL,
|
|
"16", false, 0x0000FFFF, 0x0000FFFF, false),
|
|
HOWTO (R_TIC30_ABS24, 2, 4, 24, false, 8, complain_overflow_bitfield, NULL,
|
|
"24", false, 0xFFFFFF00, 0xFFFFFF00, false),
|
|
HOWTO (R_TIC30_LDP, 18, 1, 24, false, 0, complain_overflow_bitfield, NULL,
|
|
"LDP", false, 0x00FF0000, 0x000000FF, false),
|
|
HOWTO (R_TIC30_ABS32, 2, 4, 32, false, 0, complain_overflow_bitfield, NULL,
|
|
"32", false, 0xFFFFFFFF, 0xFFFFFFFF, false),
|
|
HOWTO (R_TIC30_PC16, 2, 2, 16, true, 0, complain_overflow_signed, NULL,
|
|
"PCREL", false, 0x0000FFFF, 0x0000FFFF, false),
|
|
EMPTY_HOWTO (-1)
|
|
};
|
|
|
|
#ifndef coff_bfd_reloc_type_lookup
|
|
#define coff_bfd_reloc_type_lookup tic30_coff_reloc_type_lookup
|
|
#define coff_bfd_reloc_name_lookup tic30_coff_reloc_name_lookup
|
|
|
|
/* For the case statement use the code values used in tc_gen_reloc to
|
|
map to the howto table entries that match those in both the aout
|
|
and coff implementations. */
|
|
|
|
static reloc_howto_type *
|
|
tic30_coff_reloc_type_lookup (bfd *abfd ATTRIBUTE_UNUSED,
|
|
bfd_reloc_code_real_type code)
|
|
{
|
|
switch (code)
|
|
{
|
|
case BFD_RELOC_8:
|
|
case BFD_RELOC_TIC30_LDP:
|
|
return &tic30_coff_howto_table[2];
|
|
case BFD_RELOC_16:
|
|
return &tic30_coff_howto_table[0];
|
|
case BFD_RELOC_24:
|
|
return &tic30_coff_howto_table[1];
|
|
case BFD_RELOC_16_PCREL:
|
|
return &tic30_coff_howto_table[4];
|
|
case BFD_RELOC_32:
|
|
return &tic30_coff_howto_table[3];
|
|
default:
|
|
return (reloc_howto_type *) NULL;
|
|
}
|
|
}
|
|
|
|
static reloc_howto_type *
|
|
tic30_coff_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
|
|
const char *r_name)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0;
|
|
i < (sizeof (tic30_coff_howto_table)
|
|
/ sizeof (tic30_coff_howto_table[0]));
|
|
i++)
|
|
if (tic30_coff_howto_table[i].name != NULL
|
|
&& strcasecmp (tic30_coff_howto_table[i].name, r_name) == 0)
|
|
return &tic30_coff_howto_table[i];
|
|
|
|
return NULL;
|
|
}
|
|
|
|
#endif
|
|
|
|
/* Turn a howto into a reloc number. */
|
|
|
|
static int
|
|
coff_tic30_select_reloc (reloc_howto_type *howto)
|
|
{
|
|
return howto->type;
|
|
}
|
|
|
|
#define SELECT_RELOC(x,howto) x.r_type = coff_tic30_select_reloc(howto)
|
|
|
|
#define BADMAG(x) TIC30BADMAG(x)
|
|
#define TIC30 1 /* Customize coffcode.h */
|
|
#define __A_MAGIC_SET__
|
|
|
|
/* Code to swap in the reloc */
|
|
#define SWAP_IN_RELOC_OFFSET H_GET_32
|
|
#define SWAP_OUT_RELOC_OFFSET H_PUT_32
|
|
#define SWAP_OUT_RELOC_EXTRA(abfd, src, dst) dst->r_stuff[0] = 'S'; \
|
|
dst->r_stuff[1] = 'C';
|
|
|
|
/* Code to turn a r_type into a howto ptr, uses the above howto table. */
|
|
|
|
static void
|
|
rtype2howto (arelent *internal, struct internal_reloc *dst)
|
|
{
|
|
switch (dst->r_type)
|
|
{
|
|
case R_TIC30_ABS16:
|
|
internal->howto = &tic30_coff_howto_table[0];
|
|
break;
|
|
case R_TIC30_ABS24:
|
|
internal->howto = &tic30_coff_howto_table[1];
|
|
break;
|
|
case R_TIC30_ABS32:
|
|
internal->howto = &tic30_coff_howto_table[3];
|
|
break;
|
|
case R_TIC30_LDP:
|
|
internal->howto = &tic30_coff_howto_table[2];
|
|
break;
|
|
case R_TIC30_PC16:
|
|
internal->howto = &tic30_coff_howto_table[4];
|
|
break;
|
|
default:
|
|
internal->howto = NULL;
|
|
break;
|
|
}
|
|
}
|
|
|
|
#define RTYPE2HOWTO(internal, relocentry) rtype2howto (internal, relocentry)
|
|
|
|
/* Perform any necessary magic to the addend in a reloc entry */
|
|
|
|
#define CALC_ADDEND(abfd, symbol, ext_reloc, cache_ptr) \
|
|
cache_ptr->addend = ext_reloc.r_offset;
|
|
|
|
#define RELOC_PROCESSING(relent,reloc,symbols,abfd,section) \
|
|
reloc_processing(relent, reloc, symbols, abfd, section)
|
|
|
|
static void
|
|
reloc_processing (arelent *relent,
|
|
struct internal_reloc *reloc,
|
|
asymbol **symbols,
|
|
bfd *abfd,
|
|
asection *section)
|
|
{
|
|
relent->address = reloc->r_vaddr;
|
|
rtype2howto (relent, reloc);
|
|
|
|
if (reloc->r_symndx == -1 || symbols == NULL)
|
|
relent->sym_ptr_ptr = bfd_abs_section_ptr->symbol_ptr_ptr;
|
|
else if (reloc->r_symndx >= 0 && reloc->r_symndx < obj_conv_table_size (abfd))
|
|
relent->sym_ptr_ptr = symbols + obj_convert (abfd)[reloc->r_symndx];
|
|
else
|
|
{
|
|
_bfd_error_handler
|
|
/* xgettext:c-format */
|
|
(_("%pB: warning: illegal symbol index %ld in relocs"),
|
|
abfd, reloc->r_symndx);
|
|
relent->sym_ptr_ptr = bfd_abs_section_ptr->symbol_ptr_ptr;
|
|
}
|
|
relent->addend = reloc->r_offset;
|
|
relent->address -= section->vma;
|
|
}
|
|
|
|
#ifndef bfd_pe_print_pdata
|
|
#define bfd_pe_print_pdata NULL
|
|
#endif
|
|
|
|
#include "coffcode.h"
|
|
|
|
const bfd_target tic30_coff_vec =
|
|
{
|
|
"coff-tic30", /* name */
|
|
bfd_target_coff_flavour,
|
|
BFD_ENDIAN_BIG, /* data byte order is big */
|
|
BFD_ENDIAN_LITTLE, /* header byte order is little */
|
|
|
|
(HAS_RELOC | EXEC_P /* object flags */
|
|
| HAS_LINENO | HAS_DEBUG
|
|
| HAS_SYMS | HAS_LOCALS | WP_TEXT),
|
|
|
|
(SEC_HAS_CONTENTS | SEC_ALLOC | SEC_LOAD | SEC_RELOC), /* section flags */
|
|
'_', /* leading symbol underscore */
|
|
'/', /* ar_pad_char */
|
|
15, /* ar_max_namelen */
|
|
0, /* match priority. */
|
|
TARGET_KEEP_UNUSED_SECTION_SYMBOLS, /* keep unused section symbols. */
|
|
bfd_getb64, bfd_getb_signed_64, bfd_putb64,
|
|
bfd_getb32, bfd_getb_signed_32, bfd_putb32,
|
|
bfd_getb16, bfd_getb_signed_16, bfd_putb16, /* data */
|
|
bfd_getl64, bfd_getl_signed_64, bfd_putl64,
|
|
bfd_getl32, bfd_getl_signed_32, bfd_putl32,
|
|
bfd_getl16, bfd_getl_signed_16, bfd_putl16, /* hdrs */
|
|
|
|
{ /* bfd_check_format */
|
|
_bfd_dummy_target,
|
|
coff_object_p,
|
|
bfd_generic_archive_p,
|
|
_bfd_dummy_target
|
|
},
|
|
{ /* bfd_set_format */
|
|
_bfd_bool_bfd_false_error,
|
|
coff_mkobject,
|
|
_bfd_generic_mkarchive,
|
|
_bfd_bool_bfd_false_error
|
|
},
|
|
{ /* bfd_write_contents */
|
|
_bfd_bool_bfd_false_error,
|
|
coff_write_object_contents,
|
|
_bfd_write_archive_contents,
|
|
_bfd_bool_bfd_false_error
|
|
},
|
|
|
|
BFD_JUMP_TABLE_GENERIC (coff),
|
|
BFD_JUMP_TABLE_COPY (coff),
|
|
BFD_JUMP_TABLE_CORE (_bfd_nocore),
|
|
BFD_JUMP_TABLE_ARCHIVE (_bfd_archive_coff),
|
|
BFD_JUMP_TABLE_SYMBOLS (coff),
|
|
BFD_JUMP_TABLE_RELOCS (coff),
|
|
BFD_JUMP_TABLE_WRITE (coff),
|
|
BFD_JUMP_TABLE_LINK (coff),
|
|
BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic),
|
|
|
|
NULL,
|
|
|
|
COFF_SWAP_TABLE
|
|
};
|