mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
51a8a7c2e3
For the ifunc symbol, which is referenced by GOT rather than PLT relocs, we should add the dynamic reloc (usually IRELATIVE) into the .rel.iplt when generating the static executable. But if we use riscv_elf_append_rela to add the dynamic relocs into .rela.iplt, this may cause the overwrite problem. The reason is that we don't handle the `reloc_index` of .rela.iplt, but the riscv_elf_append_rela adds the relocs to the place that are calculated from the reloc_index (in seqential). Therefore, we may overwrite the dynamic relocs when the `reloc_index` of .rela.iplt isn't handled correctly. One solution is that we can add these dynamic relocs (GOT ifunc) from the last of .rela.iplt section. But I'm not sure if it is the best way. bfd/ * elfnn-riscv.c (riscv_elf_link_hash_table): Add last_iplt_index. (riscv_elf_size_dynamic_sections): Initialize the last_iplt_index. (riscv_elf_relocate_section): Use riscv_elf_append_rela. (riscv_elf_finish_dynamic_symbol): If the use_elf_append_rela is false, then we should add the dynamic relocs from the last of the .rela.iplt, and don't use the riscv_elf_append_rela to add. ld/ * testsuite/ld-riscv-elf/ifunc-plt-got-overwrite.s: New testcase. * testsuite/ld-riscv-elf/ifunc-plt-got-overwrite.d: Likewise. * testsuite/ld-riscv-elf/ifunc-plt-got-overwrite-exe.rd: Likewise. * testsuite/ld-riscv-elf/ifunc-plt-got-overwrite-pic.rd: Likewise. * testsuite/ld-riscv-elf/ifunc-plt-got-overwrite-pie.rd: Likewise. * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
210 lines
7.8 KiB
Plaintext
210 lines
7.8 KiB
Plaintext
# Expect script for RISC-V ELF linker tests
|
|
# Copyright (C) 2017-2020 Free Software Foundation, Inc.
|
|
#
|
|
# This file is part of the GNU Binutils.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
#
|
|
|
|
# target: rv32 or rv64.
|
|
# output: Which output you want? (exe, pie, .so)
|
|
proc run_dump_test_ifunc { name target output} {
|
|
set asflags ""
|
|
set ldflags "-z nocombreloc"
|
|
|
|
switch -- $output {
|
|
exe {
|
|
set ext "exe"
|
|
}
|
|
pie {
|
|
set ext "pie"
|
|
set ldflags "$ldflags -pie"
|
|
}
|
|
pic {
|
|
set ext "so"
|
|
set ldflags "$ldflags -shared"
|
|
}
|
|
}
|
|
|
|
switch -- $target {
|
|
rv32 {
|
|
set asflags "$asflags -march=rv32i -mabi=ilp32"
|
|
set ldflags "$ldflags -melf32lriscv"
|
|
}
|
|
rv64 {
|
|
set asflags "$asflags -march=rv64i -mabi=lp64 -defsym __64_bit__=1"
|
|
set ldflags "$ldflags -melf64lriscv"
|
|
}
|
|
}
|
|
|
|
run_ld_link_tests [list \
|
|
[list "$name ($target-$output)" \
|
|
"$ldflags" "" \
|
|
"$asflags" \
|
|
[list "$name.s"] \
|
|
[concat [list "readelf -rW $name-$output.rd"] \
|
|
[list "objdump -dw $name.d"]] \
|
|
"$name-$target.$ext"]]
|
|
}
|
|
|
|
if [istarget "riscv*-*-*"] {
|
|
run_dump_test "call-relax"
|
|
run_dump_test "c-lui"
|
|
run_dump_test "c-lui-2"
|
|
run_dump_test "disas-jalr"
|
|
run_dump_test "pcrel-lo-addend"
|
|
run_dump_test "pcrel-lo-addend-2"
|
|
run_dump_test "attr-merge-arch-01"
|
|
run_dump_test "attr-merge-arch-02"
|
|
run_dump_test "attr-merge-arch-03"
|
|
run_dump_test "attr-merge-strict-align-01"
|
|
run_dump_test "attr-merge-strict-align-02"
|
|
run_dump_test "attr-merge-strict-align-03"
|
|
run_dump_test "attr-merge-strict-align-04"
|
|
run_dump_test "attr-merge-strict-align-05"
|
|
run_dump_test "attr-merge-stack-align"
|
|
run_dump_test "attr-merge-priv-spec-01"
|
|
run_dump_test "attr-merge-priv-spec-02"
|
|
run_dump_test "attr-merge-priv-spec-03"
|
|
run_dump_test "attr-merge-arch-failed-01"
|
|
run_dump_test "attr-merge-arch-failed-02"
|
|
run_dump_test "attr-merge-stack-align-failed"
|
|
run_dump_test "attr-merge-priv-spec-failed-01"
|
|
run_dump_test "attr-merge-priv-spec-failed-02"
|
|
run_dump_test "attr-merge-priv-spec-failed-03"
|
|
run_dump_test "attr-merge-priv-spec-failed-04"
|
|
run_dump_test "attr-merge-priv-spec-failed-05"
|
|
run_dump_test "attr-merge-priv-spec-failed-06"
|
|
run_ld_link_tests {
|
|
{ "Weak reference 32" "-T weakref.ld -melf32lriscv" ""
|
|
"-march=rv32i -mabi=ilp32" {weakref32.s}
|
|
{{objdump -d weakref32.d}} "weakref32"}
|
|
{ "Weak reference 64" "-T weakref.ld -melf64lriscv" ""
|
|
"-march=rv64i -mabi=lp64" {weakref64.s}
|
|
{{objdump -d weakref64.d}} "weakref64"}
|
|
}
|
|
|
|
# The following tests require shared library support.
|
|
if ![check_shared_lib_support] {
|
|
return
|
|
}
|
|
|
|
set abis { rv32gc ilp32 elf32lriscv rv64gc lp64 elf64lriscv }
|
|
foreach { arch abi emul } $abis {
|
|
# This checks whether our linker scripts handle __global_pointer$
|
|
# correctly. It should be defined in executables and PIE, but not
|
|
# in shared libraries.
|
|
set suff64 [string map {ilp32 "" lp64 -64} $abi]
|
|
run_ld_link_tests [list \
|
|
[list "gp test ($abi shared library)" \
|
|
"-m$emul -shared" "" \
|
|
"-march=$arch -mabi=$abi -fpic" \
|
|
{ gp-test.s } \
|
|
[list "readelf --syms gp-test-lib.sd"] \
|
|
"gp-test-lib-${abi}.so"] \
|
|
[list "gp test ($abi executable)" \
|
|
"-m$emul" "" \
|
|
"-march=$arch -mabi=$abi" \
|
|
{ gp-test.s } \
|
|
[list "readelf --syms gp-test.sd"] \
|
|
"gp-test-${abi}"]]
|
|
}
|
|
|
|
run_ld_link_tests {
|
|
{ "Link non-pic code into a shared library (setup)"
|
|
"-shared" "" "" {lib-nopic-01a.s}
|
|
{} "lib-nopic-01a.so" }
|
|
}
|
|
run_dump_test "lib-nopic-01b"
|
|
|
|
# IFUNC testcases.
|
|
# Check IFUNC by single type relocs.
|
|
run_dump_test_ifunc "ifunc-reloc-call-01" rv32 exe
|
|
run_dump_test_ifunc "ifunc-reloc-call-01" rv32 pie
|
|
run_dump_test_ifunc "ifunc-reloc-call-01" rv32 pic
|
|
run_dump_test_ifunc "ifunc-reloc-call-02" rv32 exe
|
|
run_dump_test_ifunc "ifunc-reloc-call-02" rv32 pie
|
|
run_dump_test_ifunc "ifunc-reloc-call-02" rv32 pic
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv32 exe
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv32 pie
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv32 pic
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv32 exe
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv32 pie
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv32 pic
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv32 exe
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv32 pie
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv32 pic
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv64 exe
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv64 pie
|
|
run_dump_test_ifunc "ifunc-reloc-pcrel" rv64 pic
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv64 exe
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv64 pie
|
|
run_dump_test_ifunc "ifunc-reloc-data" rv64 pic
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv64 exe
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv64 pie
|
|
run_dump_test_ifunc "ifunc-reloc-got" rv64 pic
|
|
# Check the IFUNC PLT and non-PLT relocs.
|
|
run_dump_test_ifunc "ifunc-nonplt" rv32 exe
|
|
run_dump_test_ifunc "ifunc-nonplt" rv32 pie
|
|
run_dump_test_ifunc "ifunc-nonplt" rv32 pic
|
|
run_dump_test_ifunc "ifunc-plt-01" rv32 exe
|
|
run_dump_test_ifunc "ifunc-plt-01" rv32 pie
|
|
run_dump_test_ifunc "ifunc-plt-01" rv32 pic
|
|
run_dump_test_ifunc "ifunc-plt-02" rv32 exe
|
|
run_dump_test_ifunc "ifunc-plt-02" rv32 pie
|
|
run_dump_test_ifunc "ifunc-plt-02" rv32 pic
|
|
run_dump_test_ifunc "ifunc-nonplt" rv64 exe
|
|
run_dump_test_ifunc "ifunc-nonplt" rv64 pie
|
|
run_dump_test_ifunc "ifunc-nonplt" rv64 pic
|
|
run_dump_test_ifunc "ifunc-plt-01" rv64 exe
|
|
run_dump_test_ifunc "ifunc-plt-01" rv64 pie
|
|
run_dump_test_ifunc "ifunc-plt-01" rv64 pic
|
|
run_dump_test_ifunc "ifunc-plt-02" rv64 exe
|
|
run_dump_test_ifunc "ifunc-plt-02" rv64 pie
|
|
run_dump_test_ifunc "ifunc-plt-02" rv64 pic
|
|
# Check the .rela.iplt overwrite issue.
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv32 exe
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv32 pie
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv32 pic
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv64 exe
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv64 pie
|
|
run_dump_test_ifunc "ifunc-plt-got-overwrite" rv64 pic
|
|
|
|
# Setup shared libraries.
|
|
run_ld_link_tests {
|
|
{ "Build shared library for IFUNC non-PLT caller"
|
|
"-shared" "" "" {ifunc-seperate-caller-nonplt.s}
|
|
{} "ifunc-seperate-caller.so" }
|
|
{ "Build shared library for IFUNC PLT caller"
|
|
"-shared" "" "" {ifunc-seperate-caller-plt.s}
|
|
{} "ifunc-seperate-caller.so" }
|
|
{ "Build shared library for IFUNC resolver"
|
|
"-shared" "" "" {ifunc-seperate-resolver.s}
|
|
{} "ifunc-seperate-resolver.so" }
|
|
}
|
|
# The IFUNC resolver and caller are in the seperate modules.
|
|
# If IFUNC resolver and caller are linked to the same module,
|
|
# then the result are the same as the run_dump_test_ifunc.
|
|
run_dump_test "ifunc-seperate-nonplt-exe"
|
|
run_dump_test "ifunc-seperate-nonplt-pie"
|
|
run_dump_test "ifunc-seperate-nonplt-pic"
|
|
run_dump_test "ifunc-seperate-plt-exe"
|
|
run_dump_test "ifunc-seperate-plt-pie"
|
|
run_dump_test "ifunc-seperate-plt-pic"
|
|
run_dump_test "ifunc-seperate-pcrel-pie"
|
|
run_dump_test "ifunc-seperate-pcrel-pic"
|
|
}
|