mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
528e15722b
This patch replaces some simple uses of xstrprintf with with string_printf, removing the need to do manual memory freeing. The change in ada-lang.c fixes an apparent memory leak. Regtested on the buildbot. gdb/ChangeLog: * common/filestuff.h (gdb_fopen_cloexec): New overload. (gdb_open_cloexec): Likewise. * nat/linux-osdata.c (command_from_pid): Use string_printf. (commandline_from_pid): Likewise. (linux_xfer_osdata_threads): Likewise. (linux_xfer_osdata_fds): Likewise. * ada-lang.c (is_package_name): Likewise. * auxv.c (procfs_xfer_auxv): Likewise. * breakpoint.c (print_one_breakpoint_location): Use uiout::field_fmt. (print_one_catch_solib): Use string_printf. * coff-pe-read.c (add_pe_exported_sym): Likewise. (add_pe_forwarded_sym): Likewise. * dwarf2read.c (create_type_unit_group): Likewise. (build_error_marker_type): Likewise. * infcall.c (get_function_name): Likewise. * valprint.c (print_converted_chars_to_obstack): Likewise. * xtensa-tdep.c (xtensa_register_type): Likewise.
121 lines
3.4 KiB
C++
121 lines
3.4 KiB
C++
/* Low-level file-handling.
|
|
Copyright (C) 2012-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef FILESTUFF_H
|
|
#define FILESTUFF_H
|
|
|
|
#include <dirent.h>
|
|
|
|
/* Note all the file descriptors which are open when this is called.
|
|
These file descriptors will not be closed by close_most_fds. */
|
|
|
|
extern void notice_open_fds (void);
|
|
|
|
/* Mark a file descriptor as inheritable across an exec. */
|
|
|
|
extern void mark_fd_no_cloexec (int fd);
|
|
|
|
/* Mark a file descriptor as no longer being inheritable across an
|
|
exec. This is only meaningful when FD was previously passed to
|
|
mark_fd_no_cloexec. */
|
|
|
|
extern void unmark_fd_no_cloexec (int fd);
|
|
|
|
/* Close all open file descriptors other than those marked by
|
|
'notice_open_fds', and stdin, stdout, and stderr. Errors that
|
|
occur while closing are ignored. */
|
|
|
|
extern void close_most_fds (void);
|
|
|
|
/* Like 'open', but ensures that the returned file descriptor has the
|
|
close-on-exec flag set. */
|
|
|
|
extern int gdb_open_cloexec (const char *filename, int flags,
|
|
/* mode_t */ unsigned long mode);
|
|
|
|
/* Convenience wrapper for the above, which takes the filename as an
|
|
std::string. */
|
|
|
|
static inline int
|
|
gdb_open_cloexec (const std::string &filename, int flags,
|
|
/* mode_t */ unsigned long mode)
|
|
{
|
|
return gdb_open_cloexec (filename.c_str (), flags, mode);
|
|
}
|
|
|
|
struct gdb_file_deleter
|
|
{
|
|
void operator() (FILE *file) const
|
|
{
|
|
fclose (file);
|
|
}
|
|
};
|
|
|
|
/* A unique pointer to a FILE. */
|
|
|
|
typedef std::unique_ptr<FILE, gdb_file_deleter> gdb_file_up;
|
|
|
|
/* Like 'fopen', but ensures that the returned file descriptor has the
|
|
close-on-exec flag set. */
|
|
|
|
extern gdb_file_up gdb_fopen_cloexec (const char *filename,
|
|
const char *opentype);
|
|
|
|
/* Convenience wrapper for the above, which takes the filename as an
|
|
std::string. */
|
|
|
|
static inline gdb_file_up
|
|
gdb_fopen_cloexec (const std::string &filename, const char *opentype)
|
|
{
|
|
return gdb_fopen_cloexec (filename.c_str (), opentype);
|
|
}
|
|
|
|
/* Like 'socketpair', but ensures that the returned file descriptors
|
|
have the close-on-exec flag set. */
|
|
|
|
extern int gdb_socketpair_cloexec (int domain, int style, int protocol,
|
|
int filedes[2]);
|
|
|
|
/* Like 'socket', but ensures that the returned file descriptor has
|
|
the close-on-exec flag set. */
|
|
|
|
extern int gdb_socket_cloexec (int domain, int style, int protocol);
|
|
|
|
/* Like 'pipe', but ensures that the returned file descriptors have
|
|
the close-on-exec flag set. */
|
|
|
|
extern int gdb_pipe_cloexec (int filedes[2]);
|
|
|
|
/* Return a new cleanup that closes FD. */
|
|
|
|
extern struct cleanup *make_cleanup_close (int fd);
|
|
|
|
struct gdb_dir_deleter
|
|
{
|
|
void operator() (DIR *dir) const
|
|
{
|
|
closedir (dir);
|
|
}
|
|
};
|
|
|
|
/* A unique pointer to a DIR. */
|
|
|
|
typedef std::unique_ptr<DIR, gdb_dir_deleter> gdb_dir_up;
|
|
|
|
#endif /* FILESTUFF_H */
|