mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
8ce18f9cdf
I reckon it's quite OK to write &p->field in C when p might be NULL, and lots of old C programmers probably agree with me. However, ubsan disagrees and so do some people I respect. I suspect C++ influence is to blame for the ubsan behaviour. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92634. So far no one has educated me as to why I'm wrong to claim that there isn't anything in the C standard to say that p->field is always (*p).field. Note 79 doesn't quite do that because it doesn't cover null pointers. If there was such an equivalence then you could claim &p->field has a null pointer reference when p is NULL, even though no C compiler would ever dereference p. Anyway, to silence ubsan I'm going to apply the following though I prefer to avoid casts when possible. And I'm using (void *) deliberately because this is C, not C++! * ldlang.c (lang_output_section_find_by_flags): Don't use &p->field when p might be NULL. * ldelf.c (output_rel_find, ldelf_place_orphan): Likewise. (insert_os_after, lang_insert_orphan, lookup_name): Likewise. (strip_excluded_output_sections, lang_clear_os_map): Likewise. (lang_check, lang_for_each_input_file): Likewise. (lang_reset_memory_regions, find_replacements_insert_point): Likewise. (find_rescan_insertion, lang_propagate_lma_regions): Likewise. (lang_record_phdrs): Likewise. * emultempl/alphaelf.em (alpha_after_open): Likewise. * emultempl/mmo.em (mmo_place_orphan): Likewise. * emultempl/pe.em (gld_${EMULATION_NAME}_place_orphan): Likewise. * emultempl/pep.em (gld_${EMULATION_NAME}_place_orphan): Likewise. * emultempl/ppc32elf.em (ppc_after_check_relocs): Likewise. * emultempl/spuelf.em (spu_before_allocation): Likewise. (embedded_spu_file): Likewise. |
||
|---|---|---|
| .. | ||
| aarch64elf.em | ||
| aix.em | ||
| alphaelf.em | ||
| arclinux.em | ||
| armcoff.em | ||
| armelf.em | ||
| astring.sed | ||
| avrelf.em | ||
| beos.em | ||
| bfin.em | ||
| cr16elf.em | ||
| crxelf.em | ||
| cskyelf.em | ||
| elf-generic.em | ||
| elf-x86.em | ||
| elf.em | ||
| epiphanyelf_4x4.em | ||
| genelf.em | ||
| generic.em | ||
| hppaelf.em | ||
| ia64elf.em | ||
| irix.em | ||
| linux.em | ||
| m68hc1xelf.em | ||
| m68kelf.em | ||
| metagelf.em | ||
| mipself.em | ||
| mmix-elfnmmo.em | ||
| mmixelf.em | ||
| mmo.em | ||
| msp430.em | ||
| nds32elf.em | ||
| needrelax.em | ||
| netbsd.em | ||
| nios2elf.em | ||
| ostring.sed | ||
| pe.em | ||
| pep.em | ||
| ppc32elf.em | ||
| ppc64elf.em | ||
| pruelf.em | ||
| README | ||
| riscvelf.em | ||
| rxelf.em | ||
| s390.em | ||
| scoreelf.em | ||
| solaris2-x86.em | ||
| solaris2.em | ||
| spu_icache.o_c | ||
| spu_icache.S | ||
| spu_ovl.o_c | ||
| spu_ovl.S | ||
| spuelf.em | ||
| tic6xdsbt.em | ||
| ticoff.em | ||
| v850elf.em | ||
| vanilla.em | ||
| vms.em | ||
| vxworks.em | ||
| xtensaelf.em | ||
| z80.em | ||
The files in this directory are sourced by genscripts.sh, after
setting some variables to substitute in, to produce
C source files that contain jump tables for each emulation.
Copyright (C) 2012-2019 Free Software Foundation, Inc.
Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.