mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 03:51:15 +08:00
3bab069c29
get_stab_string_offset currently creates the stabstr section if not already present, in the process keeping a reference to the malloc'd section name string. Really, the name belongs in bfd_alloc'd memory or some obstack so that it doesn't show as a memory leak on exit. s_stab_generic at least does allocate the name for the stab section on an obstack, but doesn't tidy that as well as it could. Return paths after issuing a warning don't release the memory, nor the memory for the "string" copy. This patch fixes these problems. s_stab_generic is rearranged so that creation of the sections occurs earlier, before any potential uses of the note obstack during expression parsing. That makes it possible to always free the section name strings unless used to create new sections. I've also avoided get_absolute_expression_and_terminator as I see that function might skip over end-of-line, and lack of a --input_line_pointer might have caused the following source line to be ignored. (Other uses of this function in gas are OK.) * config/obj-coff.c (obj_coff_init_stab_section): Add stabstr param. Pass to get_stab_string_offset rather than name of section. * config/obj-som.c (obj_som_init_stab_section): Likewise. * config/obj-elf.c (obj_elf_init_stab_section): Likewise. (elf_init_stab_section): Adjust. * config/obj-coff.h (INIT_STAB_SECTION): Update. (obj_coff_init_stab_section): Update prototype. * config/obj-som.h: Similarly. * config/obj-elf.h: Similarly. * config/obj-multi.h (INIT_STAB_SECTION): Update. * obj.h (struct format_ops <init_stab_section>): Update. * read.h (get_stab_string_offset): Update prototype. * stabs.c (cached_sec): Delete. (stabs_begin): Adjust to suit. (get_stab_string_offset): Add stabstr param, delete stabstr_name and free_stabstr_secname params. Don't make stabstr section here. (eat_comma): New function. (s_stab_generic): Replace stab_secname_obstack_end param with bool freenames. Move creation of stab and stabstr sections earlier, so the names can be freed earlier before possible use of notes obstack during expression parsing. Tidy error paths ensuring "string" is freed. Use get_absolute_expression in place of get_absolute_expression_and_terminator. (s_stab): Adjust. (s_xstab): Use notes_concat to make stabstr section name.
331 lines
8.6 KiB
C
331 lines
8.6 KiB
C
/* SOM object file format.
|
|
Copyright (C) 1993-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GAS, the GNU Assembler.
|
|
|
|
GAS is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as
|
|
published by the Free Software Foundation; either version 3,
|
|
or (at your option) any later version.
|
|
|
|
GAS is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
|
|
the GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with GAS; see the file COPYING. If not, write to the Free
|
|
Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
|
|
02110-1301, USA.
|
|
|
|
Written by the Center for Software Science at the University of Utah
|
|
and by Cygnus Support. */
|
|
|
|
#include "as.h"
|
|
#include "subsegs.h"
|
|
#include "aout/stab_gnu.h"
|
|
|
|
static int version_seen = 0;
|
|
static int copyright_seen = 0;
|
|
static int compiler_seen = 0;
|
|
|
|
/* Unused by SOM. */
|
|
|
|
void
|
|
obj_read_begin_hook (void)
|
|
{
|
|
}
|
|
|
|
/* Handle a .compiler directive. This is intended to create the
|
|
compilation unit auxiliary header for MPE such that the linkeditor
|
|
can handle SOM extraction from archives. The format of the quoted
|
|
string is "sourcefile language version" and is delimited by blanks. */
|
|
|
|
void
|
|
obj_som_compiler (int unused ATTRIBUTE_UNUSED)
|
|
{
|
|
char *buf;
|
|
char c;
|
|
char *filename;
|
|
char *language_name;
|
|
char *p;
|
|
char *version_id;
|
|
|
|
if (compiler_seen)
|
|
{
|
|
as_bad (_("Only one .compiler pseudo-op per file!"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
SKIP_WHITESPACE ();
|
|
if (*input_line_pointer == '\"')
|
|
{
|
|
buf = input_line_pointer;
|
|
++input_line_pointer;
|
|
while (is_a_char (next_char_of_string ()))
|
|
;
|
|
c = *input_line_pointer;
|
|
*input_line_pointer = '\000';
|
|
}
|
|
else
|
|
{
|
|
as_bad (_("Expected quoted string"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
/* Parse the quoted string into its component parts. Skip the
|
|
quote. */
|
|
filename = buf + 1;
|
|
p = filename;
|
|
while (*p != ' ' && *p != '\000')
|
|
p++;
|
|
if (*p == '\000')
|
|
{
|
|
as_bad (_(".compiler directive missing language and version"));
|
|
return;
|
|
}
|
|
*p = '\000';
|
|
|
|
language_name = ++p;
|
|
while (*p != ' ' && *p != '\000')
|
|
p++;
|
|
if (*p == '\000')
|
|
{
|
|
as_bad (_(".compiler directive missing version"));
|
|
return;
|
|
}
|
|
*p = '\000';
|
|
|
|
version_id = ++p;
|
|
while (*p != '\000')
|
|
p++;
|
|
/* Remove the trailing quote. */
|
|
*(--p) = '\000';
|
|
|
|
compiler_seen = 1;
|
|
if (! bfd_som_attach_compilation_unit (stdoutput, filename, language_name,
|
|
"GNU Tools", version_id))
|
|
{
|
|
bfd_perror (stdoutput->filename);
|
|
as_fatal (_("FATAL: Attaching compiler header %s"), stdoutput->filename);
|
|
}
|
|
*input_line_pointer = c;
|
|
demand_empty_rest_of_line ();
|
|
}
|
|
|
|
/* Handle a .version directive. */
|
|
|
|
void
|
|
obj_som_version (int unused ATTRIBUTE_UNUSED)
|
|
{
|
|
char *version, c;
|
|
|
|
if (version_seen)
|
|
{
|
|
as_bad (_("Only one .version pseudo-op per file!"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
SKIP_WHITESPACE ();
|
|
if (*input_line_pointer == '\"')
|
|
{
|
|
version = input_line_pointer;
|
|
++input_line_pointer;
|
|
while (is_a_char (next_char_of_string ()))
|
|
;
|
|
c = *input_line_pointer;
|
|
*input_line_pointer = '\000';
|
|
}
|
|
else
|
|
{
|
|
as_bad (_("Expected quoted string"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
version_seen = 1;
|
|
if (!bfd_som_attach_aux_hdr (stdoutput, VERSION_AUX_ID, version))
|
|
as_fatal (_("attaching version header %s: %s"),
|
|
stdoutput->filename, bfd_errmsg (bfd_get_error ()));
|
|
|
|
*input_line_pointer = c;
|
|
demand_empty_rest_of_line ();
|
|
}
|
|
|
|
/* Handle a .copyright directive. This probably isn't complete, but
|
|
it's of dubious value anyway and (IMHO) not worth the time to finish.
|
|
If you care about copyright strings that much, you fix it. */
|
|
|
|
void
|
|
obj_som_copyright (int unused ATTRIBUTE_UNUSED)
|
|
{
|
|
char *copyright, c;
|
|
|
|
if (copyright_seen)
|
|
{
|
|
as_bad (_("Only one .copyright pseudo-op per file!"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
SKIP_WHITESPACE ();
|
|
if (*input_line_pointer == '\"')
|
|
{
|
|
copyright = input_line_pointer;
|
|
++input_line_pointer;
|
|
while (is_a_char (next_char_of_string ()))
|
|
;
|
|
c = *input_line_pointer;
|
|
*input_line_pointer = '\000';
|
|
}
|
|
else
|
|
{
|
|
as_bad (_("Expected quoted string"));
|
|
ignore_rest_of_line ();
|
|
return;
|
|
}
|
|
|
|
copyright_seen = 1;
|
|
if (!bfd_som_attach_aux_hdr (stdoutput, COPYRIGHT_AUX_ID, copyright))
|
|
as_fatal (_("attaching copyright header %s: %s"),
|
|
stdoutput->filename, bfd_errmsg (bfd_get_error ()));
|
|
|
|
*input_line_pointer = c;
|
|
demand_empty_rest_of_line ();
|
|
}
|
|
|
|
/* Perform any initialization necessary for stabs support.
|
|
|
|
For SOM we need to create the space which will contain the
|
|
two stabs subspaces. Additionally we need to set up the
|
|
space/subspace relationships and set space/subspace attributes
|
|
which BFD does not understand. */
|
|
|
|
void
|
|
obj_som_init_stab_section (segT stab, segT stabstr)
|
|
{
|
|
segT saved_seg = now_seg;
|
|
segT space;
|
|
subsegT saved_subseg = now_subseg;
|
|
char *p;
|
|
const char * file;
|
|
unsigned int stroff;
|
|
|
|
/* Nothing to do if the section has already been created. */
|
|
if (bfd_get_section_by_name (stdoutput, "$GDB_DEBUG$"))
|
|
return;
|
|
|
|
/* Make the space which will contain the debug subspaces. */
|
|
space = bfd_make_section_old_way (stdoutput, "$GDB_DEBUG$");
|
|
|
|
/* Set SOM specific attributes for the space. In particular we set
|
|
the space "defined", "private", "sort_key", and "spnum" values.
|
|
|
|
Due to a bug in pxdb (called by hpux linker), the sort keys
|
|
of the various stabs spaces/subspaces need to be "small". We
|
|
reserve range 72/73 which appear to work well. */
|
|
obj_set_section_attributes (space, 1, 1, 72, 2);
|
|
bfd_set_section_alignment (space, 2);
|
|
|
|
/* Set the containing space for both stab sections to be $GDB_DEBUG$
|
|
(just created above). Also set some attributes which BFD does
|
|
not understand. In particular, access bits, sort keys, and load
|
|
quadrant. */
|
|
obj_set_subsection_attributes (stab, space, 0x1f, 73, 0, 0, 0, 0);
|
|
bfd_set_section_alignment (stab, 2);
|
|
|
|
/* Make some space for the first special stab entry and zero the memory.
|
|
It contains information about the length of this file's
|
|
stab string and the like. Using it avoids the need to
|
|
relocate the stab strings.
|
|
|
|
The $GDB_STRINGS$ space will be created as a side effect of
|
|
the call to get_stab_string_offset. */
|
|
p = frag_more (12);
|
|
memset (p, 0, 12);
|
|
file = as_where ((unsigned int *) NULL);
|
|
stroff = get_stab_string_offset (file, stabstr);
|
|
know (stroff == 1);
|
|
md_number_to_chars (p, stroff, 4);
|
|
seg_info (stab)->stabu.p = p;
|
|
|
|
/* Set the containing space for both stab sections to be $GDB_DEBUG$
|
|
(just created above). Also set some attributes which BFD does
|
|
not understand. In particular, access bits, sort keys, and load
|
|
quadrant. */
|
|
obj_set_subsection_attributes (stabstr, space, 0x1f, 72, 0, 0, 0, 0);
|
|
bfd_set_section_alignment (stabstr, 2);
|
|
|
|
subseg_set (saved_seg, saved_subseg);
|
|
}
|
|
|
|
/* Fill in the counts in the first entry in a .stabs section. */
|
|
|
|
static void
|
|
adjust_stab_sections (bfd *abfd, asection *sec, void *xxx ATTRIBUTE_UNUSED)
|
|
{
|
|
asection *strsec;
|
|
char *p;
|
|
int strsz, nsyms;
|
|
|
|
if (strcmp ("$GDB_SYMBOLS$", sec->name))
|
|
return;
|
|
|
|
strsec = bfd_get_section_by_name (abfd, "$GDB_STRINGS$");
|
|
if (strsec)
|
|
strsz = bfd_section_size (strsec);
|
|
else
|
|
strsz = 0;
|
|
nsyms = bfd_section_size (sec) / 12 - 1;
|
|
|
|
p = seg_info (sec)->stabu.p;
|
|
gas_assert (p != 0);
|
|
|
|
bfd_h_put_16 (abfd, (bfd_vma) nsyms, (bfd_byte *) p + 6);
|
|
bfd_h_put_32 (abfd, (bfd_vma) strsz, (bfd_byte *) p + 8);
|
|
}
|
|
|
|
/* Called late in the assembly phase to adjust the special
|
|
stab entry and to set the starting address for each code subspace. */
|
|
|
|
void
|
|
som_frob_file (void)
|
|
{
|
|
bfd_map_over_sections (stdoutput, adjust_stab_sections, (void *) 0);
|
|
}
|
|
|
|
static void
|
|
obj_som_weak (int ignore ATTRIBUTE_UNUSED)
|
|
{
|
|
char *name;
|
|
int c;
|
|
symbolS *symbolP;
|
|
|
|
do
|
|
{
|
|
c = get_symbol_name (&name);
|
|
symbolP = symbol_find_or_make (name);
|
|
*input_line_pointer = c;
|
|
SKIP_WHITESPACE_AFTER_NAME ();
|
|
S_SET_WEAK (symbolP);
|
|
if (c == ',')
|
|
{
|
|
input_line_pointer++;
|
|
SKIP_WHITESPACE ();
|
|
if (*input_line_pointer == '\n')
|
|
c = '\n';
|
|
}
|
|
}
|
|
while (c == ',');
|
|
demand_empty_rest_of_line ();
|
|
}
|
|
|
|
const pseudo_typeS obj_pseudo_table[] =
|
|
{
|
|
{"weak", obj_som_weak, 0},
|
|
{NULL, NULL, 0}
|
|
};
|