mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
04902b0995
This patch started by adding comprehensive unit tests for enum_flags.
For the testing part, it adds:
- tests of normal expected uses of the API.
- checks that _invalid_ uses of the API would fail to compile. I.e.,
it validates that enum_flags really is a strong type, and that
incorrect mixing of enum types would be caught at compile time. It
pulls that off making use of SFINEA and C++11's decltype/constexpr.
This revealed many holes in the enum_flags API. For example, the f1
assignment below currently incorrectly fails to compile:
enum_flags<flags> f1 = FLAG1;
enum_flags<flags> f2 = FLAG2 | f1;
The unit tests also revealed that this useful use case doesn't work:
enum flag { FLAG1 = 1, FLAG2 = 2 };
enum_flags<flag> src = FLAG1;
enum_flags<flag> f1 = condition ? src : FLAG2;
It fails to compile because enum_flags<flag> and flag are convertible
to each other.
Turns out that making enum_flags be implicitly convertible to the
backing raw enum type was not a good idea.
If we make it convertible to the underlying type instead, we fix that
ternary operator use case, and, we find cases throughout the codebase
that should be using the enum_flags but were using the raw backing
enum instead. So it's a good change overall.
Also, several operators were missing.
These holes and more are plugged by this patch, by reworking how the
enum_flags operators are implemented, and making use of C++11's
feature of being able to delete methods/functions.
There are cases in gdb/compile/ where we need to call a function in a
C plugin API that expects the raw enum. To address cases like that,
this adds a "raw()" method to enum_flags. This way we can keep using
the safer enum_flags to construct the value, and then be explicit when
we need to get at the raw enum.
This makes most of the enum_flags operators constexpr. Beyond
enabling more compiler optimizations and enabling the new unit tests,
this has other advantages, like making it possible to use operator|
with enum_flags values in switch cases, where only compile-time
constants are allowed:
enum_flags<flags> f = FLAG1 | FLAG2;
switch (f)
{
case FLAG1 | FLAG2:
break;
}
Currently that fails to compile.
It also switches to a different mechanism of enabling the global
operators. The current mechanism isn't namespace friendly, the new
one is.
It also switches to C++11-style SFINAE -- instead of wrapping the
return type in a SFINAE-friently structure, we use an unnamed template
parameter. I.e., this:
template <typename enum_type,
typename = is_enum_flags_enum_type_t<enum_type>>
enum_type
operator& (enum_type e1, enum_type e2)
instead of:
template <typename enum_type>
typename enum_flags_type<enum_type>::type
operator& (enum_type e1, enum_type e2)
Note that the static_assert inside operator~() was converted to a
couple overloads (signed vs unsigned), because static_assert is too
late for SFINAE-based tests, which is important for the CHECK_VALID
unit tests.
Tested with gcc {4.8, 7.1, 9.3} and clang {5.0.2, 10.0.0}.
gdb/ChangeLog:
* Makefile.in (SELFTESTS_SRCS): Add
unittests/enum-flags-selftests.c.
* btrace.c (ftrace_update_caller, ftrace_fixup_calle): Use
btrace_function_flags instead of enum btrace_function_flag.
* compile/compile-c-types.c (convert_qualified): Use
enum_flags::raw.
* compile/compile-cplus-symbols.c (convert_one_symbol)
(convert_symbol_bmsym):
* compile/compile-cplus-types.c (compile_cplus_convert_method)
(compile_cplus_convert_struct_or_union_methods)
(compile_cplus_instance::convert_qualified_base):
* go-exp.y (parse_string_or_char): Add cast to int.
* unittests/enum-flags-selftests.c: New file.
* record-btrace.c (btrace_thread_flag_to_str): Change parameter's
type to btrace_thread_flags from btrace_thread_flag.
(record_btrace_cancel_resume, record_btrace_step_thread): Change
local's type to btrace_thread_flags from btrace_thread_flag. Add
cast in DEBUG call.
gdbsupport/ChangeLog:
* enum-flags.h: Include "traits.h".
(DEF_ENUM_FLAGS_TYPE): Declare a function instead of defining a
structure.
(enum_underlying_type): Update comment.
(namespace enum_flags_detail): New. Move struct zero_type here.
(EnumIsUnsigned, EnumIsSigned): New.
(class enum_flags): Make most methods constexpr.
(operator&=, operator|=, operator^=): Take an enum_flags instead
of an enum_type. Make rvalue ref versions deleted.
(operator enum_type()): Delete.
(operator&, operator|, operator^, operator~): Delete, moved out of
class.
(raw()): New method.
(is_enum_flags_enum_type_t): Declare.
(ENUM_FLAGS_GEN_BINOP, ENUM_FLAGS_GEN_COMPOUND_ASSIGN)
(ENUM_FLAGS_GEN_COMP): New. Use them to reimplement global
operators.
(operator~): Now constexpr and reimplemented.
(operator<<, operator>>): New deleted functions.
* valid-expr.h (CHECK_VALID_EXPR_5, CHECK_VALID_EXPR_6): New.
|
||
|---|---|---|
| .. | ||
| .dir-locals.el | ||
| .gitattributes | ||
| acinclude.m4 | ||
| aclocal.m4 | ||
| agent.cc | ||
| agent.h | ||
| alt-stack.h | ||
| array-view.h | ||
| ax.def | ||
| block-signals.h | ||
| break-common.h | ||
| btrace-common.cc | ||
| btrace-common.h | ||
| buffer.cc | ||
| buffer.h | ||
| byte-vector.h | ||
| ChangeLog | ||
| check-defines.el | ||
| cleanups.cc | ||
| cleanups.h | ||
| common-debug.cc | ||
| common-debug.h | ||
| common-defs.h | ||
| common-exceptions.cc | ||
| common-exceptions.h | ||
| common-gdbthread.h | ||
| common-inferior.cc | ||
| common-inferior.h | ||
| common-regcache.cc | ||
| common-regcache.h | ||
| common-types.h | ||
| common-utils.cc | ||
| common-utils.h | ||
| common.m4 | ||
| config.in | ||
| configure | ||
| configure.ac | ||
| create-version.sh | ||
| def-vector.h | ||
| default-init-alloc.h | ||
| eintr.h | ||
| enum-flags.h | ||
| environ.cc | ||
| environ.h | ||
| errors.cc | ||
| errors.h | ||
| event-loop.cc | ||
| event-loop.h | ||
| fileio.cc | ||
| fileio.h | ||
| filestuff.cc | ||
| filestuff.h | ||
| filtered-iterator.h | ||
| format.cc | ||
| format.h | ||
| forward-scope-exit.h | ||
| function-view.h | ||
| gdb_assert.h | ||
| gdb_binary_search.h | ||
| gdb_locale.h | ||
| gdb_optional.h | ||
| gdb_proc_service.h | ||
| gdb_ref_ptr.h | ||
| gdb_select.h | ||
| gdb_setjmp.h | ||
| gdb_signals.h | ||
| gdb_splay_tree.h | ||
| gdb_string_view.h | ||
| gdb_string_view.tcc | ||
| gdb_sys_time.h | ||
| gdb_tilde_expand.cc | ||
| gdb_tilde_expand.h | ||
| gdb_unique_ptr.h | ||
| gdb_unlinker.h | ||
| gdb_vecs.cc | ||
| gdb_vecs.h | ||
| gdb_wait.cc | ||
| gdb_wait.h | ||
| gdb-dlfcn.cc | ||
| gdb-dlfcn.h | ||
| gdb-safe-ctype.h | ||
| gdb-sigmask.h | ||
| hash_enum.h | ||
| host-defs.h | ||
| job-control.cc | ||
| job-control.h | ||
| Makefile.am | ||
| Makefile.in | ||
| netstuff.cc | ||
| netstuff.h | ||
| new-op.cc | ||
| next-iterator.h | ||
| observable.h | ||
| offset-type.h | ||
| parallel-for.h | ||
| pathstuff.cc | ||
| pathstuff.h | ||
| poison.h | ||
| preprocessor.h | ||
| print-utils.cc | ||
| print-utils.h | ||
| ptid.cc | ||
| ptid.h | ||
| README | ||
| refcounted-object.h | ||
| rsp-low.cc | ||
| rsp-low.h | ||
| run-time-clock.cc | ||
| run-time-clock.h | ||
| safe-iterator.h | ||
| safe-strerror.cc | ||
| scope-exit.h | ||
| scoped_fd.h | ||
| scoped_mmap.cc | ||
| scoped_mmap.h | ||
| scoped_restore.h | ||
| selftest.cc | ||
| selftest.h | ||
| selftest.m4 | ||
| signals-state-save-restore.cc | ||
| signals-state-save-restore.h | ||
| signals.cc | ||
| symbol.h | ||
| tdesc.cc | ||
| tdesc.h | ||
| thread-pool.cc | ||
| thread-pool.h | ||
| traits.h | ||
| underlying.h | ||
| valid-expr.h | ||
| version.h | ||
| warning.m4 | ||
| x86-xstate.h | ||
| xml-utils.cc | ||
| xml-utils.h | ||
This is a helper library that is used by gdb and gdbserver. To send patches, follow the gdb patch submission instructions in ../gdb/CONTRIBUTE. For maintainers, see ../gdb/MAINTAINERS.