mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
c4e54771f8
I'm checking this in as obvious. I was looking at instances of "alloc.*sizeof" and noticed a couple where the types in question are incorrect. In gdbtypes, the code allocates sizeof(int) to represent a struct rank. In mi-cmds, the code uses "struct mi_cmd **" -- one "*" too many. In both cases the problems are latent because in practice the sizes are the same as the sizes of the correct types. Still, it's better to be correct. I think gdb would be improved by a wholesale change from explicit sizeofs to using the libiberty.h allocation macros. In most cases they are both shorter and have better type safety. However, the resulting patch is rather large. Built and regtested on x86-64 Fedora 20. 2014-05-19 Tom Tromey <tromey@redhat.com> * gdbtypes.c (rank_function): Use XNEWVEC. * mi/mi-cmds.c (build_table): Use XCNEWVEC. |
||
---|---|---|
.. | ||
ChangeLog-1999-2003 | ||
mi-cmd-break.c | ||
mi-cmd-break.h | ||
mi-cmd-catch.c | ||
mi-cmd-disas.c | ||
mi-cmd-env.c | ||
mi-cmd-file.c | ||
mi-cmd-info.c | ||
mi-cmd-stack.c | ||
mi-cmd-target.c | ||
mi-cmd-var.c | ||
mi-cmds.c | ||
mi-cmds.h | ||
mi-common.c | ||
mi-common.h | ||
mi-console.c | ||
mi-console.h | ||
mi-getopt.c | ||
mi-getopt.h | ||
mi-interp.c | ||
mi-main.c | ||
mi-main.h | ||
mi-out.c | ||
mi-out.h | ||
mi-parse.c | ||
mi-parse.h | ||
mi-symbol-cmds.c |