mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-03-07 13:39:43 +08:00
4bce7cdaf4
An assertion was recently added to array_view::operator[] to ensure we don't do out of bounds accesses. However, when the array_view is copied to or from using memcpy, it bypasses that safety. To address this, add a `copy` free function that copies data from an array view to another, ensuring that the destination and source array views have the same size. When copying to or from parts of an array_view, we are expected to use gdb::array_view::slice, which does its own bounds check. With all that, any copy operation that goes out of bounds should be caught by an assertion at runtime. copy is implemented using std::copy and std::copy_backward, which, at least on libstdc++, appears to pick memmove when copying trivial data. So in the end there shouldn't be much difference vs using a bare memcpy, as we do right now. When copying non-trivial data, std::copy and std::copy_backward assigns each element in a loop. To properly support overlapping ranges, we must use std::copy or std::copy_backward, depending on whether the destination is before the source or vice-versa. std::copy and std::copy_backward don't support copying exactly overlapping ranges (where the source range is equal to the destination range). But in this case, no copy is needed anyway, so we do nothing. The order of parameters of the new copy function is based on std::copy and std::copy_backward, where the source comes before the destination. Change a few randomly selected spots to use the new function, to show how it can be used. Add a test for the new function, testing both with arrays of a trivial type (int) and of a non-trivial type (foo). Test non-overlapping ranges as well as three kinds of overlapping ranges: source before dest, dest before source, and dest == source. Change-Id: Ibeaca04e0028410fd44ce82f72e60058d6230a03 |
||
|---|---|---|
| .. | ||
| .dir-locals.el | ||
| .gitattributes | ||
| acinclude.m4 | ||
| aclocal.m4 | ||
| agent.cc | ||
| agent.h | ||
| alt-stack.h | ||
| array-view.h | ||
| ax.def | ||
| block-signals.h | ||
| break-common.h | ||
| btrace-common.cc | ||
| btrace-common.h | ||
| buffer.cc | ||
| buffer.h | ||
| byte-vector.h | ||
| ChangeLog-2020-2021 | ||
| check-defines.el | ||
| cleanups.cc | ||
| cleanups.h | ||
| common-debug.cc | ||
| common-debug.h | ||
| common-defs.h | ||
| common-exceptions.cc | ||
| common-exceptions.h | ||
| common-gdbthread.h | ||
| common-inferior.cc | ||
| common-inferior.h | ||
| common-regcache.cc | ||
| common-regcache.h | ||
| common-types.h | ||
| common-utils.cc | ||
| common-utils.h | ||
| common.m4 | ||
| config.in | ||
| configure | ||
| configure.ac | ||
| create-version.sh | ||
| def-vector.h | ||
| default-init-alloc.h | ||
| eintr.h | ||
| enum-flags.h | ||
| environ.cc | ||
| environ.h | ||
| errors.cc | ||
| errors.h | ||
| event-loop.cc | ||
| event-loop.h | ||
| fileio.cc | ||
| fileio.h | ||
| filestuff.cc | ||
| filestuff.h | ||
| filtered-iterator.h | ||
| format.cc | ||
| format.h | ||
| forward-scope-exit.h | ||
| function-view.h | ||
| gdb_assert.h | ||
| gdb_binary_search.h | ||
| gdb_file.h | ||
| gdb_locale.h | ||
| gdb_optional.h | ||
| gdb_proc_service.h | ||
| gdb_ref_ptr.h | ||
| gdb_select.h | ||
| gdb_setjmp.h | ||
| gdb_signals.h | ||
| gdb_splay_tree.h | ||
| gdb_string_view.h | ||
| gdb_string_view.tcc | ||
| gdb_sys_time.h | ||
| gdb_tilde_expand.cc | ||
| gdb_tilde_expand.h | ||
| gdb_unique_ptr.h | ||
| gdb_unlinker.h | ||
| gdb_vecs.cc | ||
| gdb_vecs.h | ||
| gdb_wait.cc | ||
| gdb_wait.h | ||
| gdb-dlfcn.cc | ||
| gdb-dlfcn.h | ||
| gdb-safe-ctype.h | ||
| gdb-sigmask.h | ||
| gdb-xfree.h | ||
| hash_enum.h | ||
| host-defs.h | ||
| intrusive_list.h | ||
| iterator-range.h | ||
| job-control.cc | ||
| job-control.h | ||
| Makefile.am | ||
| Makefile.in | ||
| netstuff.cc | ||
| netstuff.h | ||
| new-op.cc | ||
| next-iterator.h | ||
| observable.h | ||
| offset-type.h | ||
| parallel-for.h | ||
| pathstuff.cc | ||
| pathstuff.h | ||
| poison.h | ||
| preprocessor.h | ||
| print-utils.cc | ||
| print-utils.h | ||
| ptid.cc | ||
| ptid.h | ||
| ptrace.m4 | ||
| README | ||
| refcounted-object.h | ||
| reference-to-pointer-iterator.h | ||
| rsp-low.cc | ||
| rsp-low.h | ||
| run-time-clock.cc | ||
| run-time-clock.h | ||
| safe-iterator.h | ||
| safe-strerror.cc | ||
| scope-exit.h | ||
| scoped_fd.h | ||
| scoped_ignore_signal.h | ||
| scoped_ignore_sigttou.h | ||
| scoped_mmap.cc | ||
| scoped_mmap.h | ||
| scoped_restore.h | ||
| search.cc | ||
| search.h | ||
| selftest.cc | ||
| selftest.h | ||
| selftest.m4 | ||
| signals-state-save-restore.cc | ||
| signals-state-save-restore.h | ||
| signals.cc | ||
| symbol.h | ||
| tdesc.cc | ||
| tdesc.h | ||
| thread-pool.cc | ||
| thread-pool.h | ||
| traits.h | ||
| underlying.h | ||
| valid-expr.h | ||
| version.h | ||
| warning.m4 | ||
| x86-xstate.h | ||
| xml-utils.cc | ||
| xml-utils.h | ||
This is a helper library that is used by gdb and gdbserver. To send patches, follow the gdb patch submission instructions in ../gdb/CONTRIBUTE. For maintainers, see ../gdb/MAINTAINERS.