binutils-gdb/gold
Cary Coutant 033bfb739b Fix symbol values and relocation addends for relocatable links.
The fix for PR 19291 broke some other cases where -r is used with scripts,
as reported in PR 22266. The original fix for PR 22266 ended up breaking
many cases for REL targets, where the addends are stored in the section data,
and are not being adjusted properly.

The problem was basically that in a relocatable output file (ET_REL),
symbol values are supposed to be relative to the start address of their
section. Usually in a relocatable file, all sections start at 0, so the
failure to get this right is often irrelevant, but with a linker script,
we occasionally see an output section whose starting address is not 0,
and gold would occasionally write a symbol with its relocated value instead
of its section-relative value.

This patch reverts the recent fix for PR 22266 as well as my original fix
for PR 19291. The original fix moved the symbol value adjustment to
write_local_symbols, but neglected to undo a few places where the adjustment
was also being applied, resulting in an occasional double adjustment. The
more recent fix removed those other adjustments, but then failed to
re-account for the adjustment when rewriting the relocations on REL targets.

With the old attempts reverted, we now apply the symbol value adjustment to
the one case that had been missed (non-section symbols in merge sections).
But now we also need to account for the adjustment when rewriting the addends
for RELA relocations.

gold/
	PR gold/19291
	PR gold/22266
	* object.cc (Sized_relobj_file::compute_final_local_value_internal):
	Revert changes from 2017-11-08 patch.  Adjust symbol value in
	relocatable links for non-section symbols.
	(Sized_relobj_file::compute_final_local_value): Revert changes from
	2017-11-08 patch.
	(Sized_relobj_file::do_finalize_local_symbols): Likewise.
	(Sized_relobj_file::write_local_symbols): Revert changes from
	2015-11-25 patch.
	* object.h (Sized_relobj_file::compute_final_local_value_internal):
	Revert changes from 2017-11-08 patch.
	* powerpc.cc (Target_powerpc::relocate_relocs): Adjust addend for
	relocatable links.
	* target-reloc.h (relocate_relocs): Adjust addend for relocatable links.
	* testsuite/pr22266_a.c (hello): New function.
	* testsuite/pr22266_main.c (main): Add test for merge sections.
	* testsuite/pr22266_script.t: Add rule for .rodata.
2017-11-27 17:32:55 -08:00
..
po
testsuite Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
aarch64-reloc-property.cc
aarch64-reloc-property.h
aarch64-reloc.def
aarch64.cc [GOLD] Set non-exec stack for aarch64 2017-09-22 07:58:28 -07:00
aclocal.m4
archive.cc
archive.h
arm-reloc-property.cc
arm-reloc-property.h
arm-reloc.def
arm.cc Implement BE8 support for ARM. 2017-10-19 20:53:14 -07:00
attributes.cc
attributes.h
binary.cc
binary.h
ChangeLog Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
ChangeLog-0815
ChangeLog-2016
common.cc
common.h
compressed_output.cc
compressed_output.h
config.in
configure
configure.ac
configure.tgt
copy-relocs.cc
copy-relocs.h
cref.cc
cref.h
debug.h
defstd.cc
defstd.h
descriptors.cc
descriptors.h
dirsearch.cc
dirsearch.h
dwarf_reader.cc Fix DWARF reader to use correct size for DW_FORM_ref_addr. 2017-11-19 17:56:30 -08:00
dwarf_reader.h Fix DWARF reader to use correct size for DW_FORM_ref_addr. 2017-11-19 17:56:30 -08:00
dwp.cc
dwp.h
dynobj.cc
dynobj.h
ehframe.cc
ehframe.h
errors.cc
errors.h
expression.cc
ffsll.c
fileread.cc
fileread.h
freebsd.h
ftruncate.c
gc.cc
gc.h
gdb-index.cc
gdb-index.h
gold-threads.cc
gold-threads.h
gold.cc
gold.h
i386.cc
icf.cc
icf.h
incremental-dump.cc
incremental.cc
incremental.h
int_encoding.cc
int_encoding.h
layout.cc gold: Ignore def/ref from a dynamic object for special symbols 2017-11-08 16:02:50 -08:00
layout.h
main.cc
Makefile.am
Makefile.in Check for export dynamic symbol options when doing symbol resolution in plugins. 2017-09-20 15:45:04 -07:00
mapfile.cc
mapfile.h
merge.cc
merge.h
mips.cc
mremap.c
nacl.cc
nacl.h
NEWS
object.cc Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
object.h Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
options.cc
options.h New gold linker option -z,text-unlikely-segment. 2017-10-20 11:00:28 -07:00
output.cc
output.h
parameters.cc
parameters.h
plugin.cc Check for export dynamic symbol options when doing symbol resolution in plugins. 2017-09-20 15:45:04 -07:00
plugin.h
powerpc.cc Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
pread.c
README
readsyms.cc
readsyms.h
reduced_debug_output.cc
reduced_debug_output.h
reloc-types.h
reloc.cc
reloc.h
resolve.cc [GOLD] clone assert breakage 2017-09-22 15:20:12 +09:30
s390.cc
script-c.h
script-sections.cc
script-sections.h
script.cc
script.h
sparc.cc Fix incorrect register mask. 2017-09-26 07:33:04 -07:00
stringpool.cc
stringpool.h
symtab.cc gold: Ignore def/ref from a dynamic object for special symbols 2017-11-08 16:02:50 -08:00
symtab.h gold: Ignore def/ref from a dynamic object for special symbols 2017-11-08 16:02:50 -08:00
system.h ngettext support 2017-11-07 15:52:52 +10:30
target-reloc.h Fix symbol values and relocation addends for relocatable links. 2017-11-27 17:32:55 -08:00
target-select.cc
target-select.h
target.cc
target.h [GOLD] Symbol flag for PowerPC64 localentry:0 tracking 2017-08-28 16:27:33 +09:30
tilegx.cc
timer.cc
timer.h
tls.h
TODO
token.h
version.cc
workqueue-internal.h
workqueue-threads.cc
workqueue.cc
workqueue.h
x86_64.cc
yyscript.y

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

gold is an ELF linker.  It is intended to have complete support for
ELF and to run as fast as possible on modern systems.  For normal use
it is a drop-in replacement for the older GNU linker.

gold is part of the GNU binutils.  See ../binutils/README for more
general notes, including where to send bug reports.

gold was originally developed at Google, and was contributed to the
Free Software Foundation in March 2008.  At Google it was designed by
Ian Lance Taylor, with major contributions by Cary Coutant, Craig
Silverstein, and Andrew Chatham.

The existing GNU linker manual is intended to be accurate
documentation for features which gold supports.  gold supports most of
the features of the GNU linker for ELF targets.  Notable
omissions--features of the GNU linker not currently supported in
gold--are:
  * MRI compatible linker scripts
  * cross-reference reports (--cref)
  * various other minor options


Notes on the code
=================

These are some notes which may be helpful to people working on the
source code of gold itself.

gold is written in C++.  It is a GNU program, and therefore follows
the GNU formatting standards as modified for C++.  Source documents in
order of decreasing precedence:
    http://www.gnu.org/prep/standards/
    http://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html
    http://www.zembu.com/eng/procs/c++style.html

The linker is intended to have complete support for cross-compilation,
while still supporting the normal case of native linking as fast as
possible.  In order to do this, many classes are actually templates
whose parameter is the ELF file class (e.g., 32 bits or 64 bits).  The
C++ code is the same, but we don't pay the execution time cost of
always using 64-bit integers if the target is 32 bits.  Many of these
class templates also have an endianness parameter: true for
big-endian, false for little-endian.

The linker is multi-threaded.  The Task class represents a single unit
of work.  Task objects are stored on a single Workqueue object.  Tasks
communicate via Task_token objects.  Task_token objects are only
manipulated while holding the master Workqueue lock.  Relatively few
mutexes are used.


Build requirements
==================

The gold source code uses templates heavily.  Building it requires a
recent version of g++.  g++ 4.0.3 and 4.1.3 are known to work.  g++
3.2, 3.4.3, and 4.1.2 are known to fail.

The linker script parser uses features which are only in newer
versions of bison.  bison 2.3 is known to work.  bison 1.26 is known
to fail.  If you are building gold from an official binutils release,
the bison output should already be included.


Copyright (C) 2012-2017 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.