mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
735 lines
20 KiB
C
735 lines
20 KiB
C
/* Caching code for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 1992-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "dcache.h"
|
|
#include "gdbcmd.h"
|
|
#include "gdbcore.h"
|
|
#include "target-dcache.h"
|
|
#include "inferior.h"
|
|
#include "splay-tree.h"
|
|
#include "gdbarch.h"
|
|
|
|
/* Commands with a prefix of `{set,show} dcache'. */
|
|
static struct cmd_list_element *dcache_set_list = NULL;
|
|
static struct cmd_list_element *dcache_show_list = NULL;
|
|
|
|
/* The data cache could lead to incorrect results because it doesn't
|
|
know about volatile variables, thus making it impossible to debug
|
|
functions which use memory mapped I/O devices. Set the nocache
|
|
memory region attribute in those cases.
|
|
|
|
In general the dcache speeds up performance. Some speed improvement
|
|
comes from the actual caching mechanism, but the major gain is in
|
|
the reduction of the remote protocol overhead; instead of reading
|
|
or writing a large area of memory in 4 byte requests, the cache
|
|
bundles up the requests into LINE_SIZE chunks, reducing overhead
|
|
significantly. This is most useful when accessing a large amount
|
|
of data, such as when performing a backtrace.
|
|
|
|
The cache is a splay tree along with a linked list for replacement.
|
|
Each block caches a LINE_SIZE area of memory. Within each line we
|
|
remember the address of the line (which must be a multiple of
|
|
LINE_SIZE) and the actual data block.
|
|
|
|
Lines are only allocated as needed, so DCACHE_SIZE really specifies the
|
|
*maximum* number of lines in the cache.
|
|
|
|
At present, the cache is write-through rather than writeback: as soon
|
|
as data is written to the cache, it is also immediately written to
|
|
the target. Therefore, cache lines are never "dirty". Whether a given
|
|
line is valid or not depends on where it is stored in the dcache_struct;
|
|
there is no per-block valid flag. */
|
|
|
|
/* NOTE: Interaction of dcache and memory region attributes
|
|
|
|
As there is no requirement that memory region attributes be aligned
|
|
to or be a multiple of the dcache page size, dcache_read_line() and
|
|
dcache_write_line() must break up the page by memory region. If a
|
|
chunk does not have the cache attribute set, an invalid memory type
|
|
is set, etc., then the chunk is skipped. Those chunks are handled
|
|
in target_xfer_memory() (or target_xfer_memory_partial()).
|
|
|
|
This doesn't occur very often. The most common occurrence is when
|
|
the last bit of the .text segment and the first bit of the .data
|
|
segment fall within the same dcache page with a ro/cacheable memory
|
|
region defined for the .text segment and a rw/non-cacheable memory
|
|
region defined for the .data segment. */
|
|
|
|
/* The maximum number of lines stored. The total size of the cache is
|
|
equal to DCACHE_SIZE times LINE_SIZE. */
|
|
#define DCACHE_DEFAULT_SIZE 4096
|
|
static unsigned dcache_size = DCACHE_DEFAULT_SIZE;
|
|
|
|
/* The default size of a cache line. Smaller values reduce the time taken to
|
|
read a single byte and make the cache more granular, but increase
|
|
overhead and reduce the effectiveness of the cache as a prefetcher. */
|
|
#define DCACHE_DEFAULT_LINE_SIZE 64
|
|
static unsigned dcache_line_size = DCACHE_DEFAULT_LINE_SIZE;
|
|
|
|
/* Each cache block holds LINE_SIZE bytes of data
|
|
starting at a multiple-of-LINE_SIZE address. */
|
|
|
|
#define LINE_SIZE_MASK(dcache) ((dcache->line_size - 1))
|
|
#define XFORM(dcache, x) ((x) & LINE_SIZE_MASK (dcache))
|
|
#define MASK(dcache, x) ((x) & ~LINE_SIZE_MASK (dcache))
|
|
|
|
struct dcache_block
|
|
{
|
|
/* For least-recently-allocated and free lists. */
|
|
struct dcache_block *prev;
|
|
struct dcache_block *next;
|
|
|
|
CORE_ADDR addr; /* address of data */
|
|
int refs; /* # hits */
|
|
gdb_byte data[1]; /* line_size bytes at given address */
|
|
};
|
|
|
|
struct dcache_struct
|
|
{
|
|
splay_tree tree;
|
|
struct dcache_block *oldest; /* least-recently-allocated list. */
|
|
|
|
/* The free list is maintained identically to OLDEST to simplify
|
|
the code: we only need one set of accessors. */
|
|
struct dcache_block *freelist;
|
|
|
|
/* The number of in-use lines in the cache. */
|
|
int size;
|
|
CORE_ADDR line_size; /* current line_size. */
|
|
|
|
/* The ptid of last inferior to use cache or null_ptid. */
|
|
ptid_t ptid;
|
|
};
|
|
|
|
typedef void (block_func) (struct dcache_block *block, void *param);
|
|
|
|
static struct dcache_block *dcache_hit (DCACHE *dcache, CORE_ADDR addr);
|
|
|
|
static int dcache_read_line (DCACHE *dcache, struct dcache_block *db);
|
|
|
|
static struct dcache_block *dcache_alloc (DCACHE *dcache, CORE_ADDR addr);
|
|
|
|
static bool dcache_enabled_p = false; /* OBSOLETE */
|
|
|
|
static void
|
|
show_dcache_enabled_p (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
fprintf_filtered (file, _("Deprecated remotecache flag is %s.\n"), value);
|
|
}
|
|
|
|
/* Add BLOCK to circular block list BLIST, behind the block at *BLIST.
|
|
*BLIST is not updated (unless it was previously NULL of course).
|
|
This is for the least-recently-allocated list's sake:
|
|
BLIST points to the oldest block.
|
|
??? This makes for poor cache usage of the free list,
|
|
but is it measurable? */
|
|
|
|
static void
|
|
append_block (struct dcache_block **blist, struct dcache_block *block)
|
|
{
|
|
if (*blist)
|
|
{
|
|
block->next = *blist;
|
|
block->prev = (*blist)->prev;
|
|
block->prev->next = block;
|
|
(*blist)->prev = block;
|
|
/* We don't update *BLIST here to maintain the invariant that for the
|
|
least-recently-allocated list *BLIST points to the oldest block. */
|
|
}
|
|
else
|
|
{
|
|
block->next = block;
|
|
block->prev = block;
|
|
*blist = block;
|
|
}
|
|
}
|
|
|
|
/* Remove BLOCK from circular block list BLIST. */
|
|
|
|
static void
|
|
remove_block (struct dcache_block **blist, struct dcache_block *block)
|
|
{
|
|
if (block->next == block)
|
|
{
|
|
*blist = NULL;
|
|
}
|
|
else
|
|
{
|
|
block->next->prev = block->prev;
|
|
block->prev->next = block->next;
|
|
/* If we removed the block *BLIST points to, shift it to the next block
|
|
to maintain the invariant that for the least-recently-allocated list
|
|
*BLIST points to the oldest block. */
|
|
if (*blist == block)
|
|
*blist = block->next;
|
|
}
|
|
}
|
|
|
|
/* Iterate over all elements in BLIST, calling FUNC.
|
|
PARAM is passed to FUNC.
|
|
FUNC may remove the block it's passed, but only that block. */
|
|
|
|
static void
|
|
for_each_block (struct dcache_block **blist, block_func *func, void *param)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
if (*blist == NULL)
|
|
return;
|
|
|
|
db = *blist;
|
|
do
|
|
{
|
|
struct dcache_block *next = db->next;
|
|
|
|
func (db, param);
|
|
db = next;
|
|
}
|
|
while (*blist && db != *blist);
|
|
}
|
|
|
|
/* BLOCK_FUNC routine for dcache_free. */
|
|
|
|
static void
|
|
free_block (struct dcache_block *block, void *param)
|
|
{
|
|
xfree (block);
|
|
}
|
|
|
|
/* Free a data cache. */
|
|
|
|
void
|
|
dcache_free (DCACHE *dcache)
|
|
{
|
|
splay_tree_delete (dcache->tree);
|
|
for_each_block (&dcache->oldest, free_block, NULL);
|
|
for_each_block (&dcache->freelist, free_block, NULL);
|
|
xfree (dcache);
|
|
}
|
|
|
|
|
|
/* BLOCK_FUNC function for dcache_invalidate.
|
|
This doesn't remove the block from the oldest list on purpose.
|
|
dcache_invalidate will do it later. */
|
|
|
|
static void
|
|
invalidate_block (struct dcache_block *block, void *param)
|
|
{
|
|
DCACHE *dcache = (DCACHE *) param;
|
|
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) block->addr);
|
|
append_block (&dcache->freelist, block);
|
|
}
|
|
|
|
/* Free all the data cache blocks, thus discarding all cached data. */
|
|
|
|
void
|
|
dcache_invalidate (DCACHE *dcache)
|
|
{
|
|
for_each_block (&dcache->oldest, invalidate_block, dcache);
|
|
|
|
dcache->oldest = NULL;
|
|
dcache->size = 0;
|
|
dcache->ptid = null_ptid;
|
|
|
|
if (dcache->line_size != dcache_line_size)
|
|
{
|
|
/* We've been asked to use a different line size.
|
|
All of our freelist blocks are now the wrong size, so free them. */
|
|
|
|
for_each_block (&dcache->freelist, free_block, dcache);
|
|
dcache->freelist = NULL;
|
|
dcache->line_size = dcache_line_size;
|
|
}
|
|
}
|
|
|
|
/* Invalidate the line associated with ADDR. */
|
|
|
|
static void
|
|
dcache_invalidate_line (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (db)
|
|
{
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) db->addr);
|
|
remove_block (&dcache->oldest, db);
|
|
append_block (&dcache->freelist, db);
|
|
--dcache->size;
|
|
}
|
|
}
|
|
|
|
/* If addr is present in the dcache, return the address of the block
|
|
containing it. Otherwise return NULL. */
|
|
|
|
static struct dcache_block *
|
|
dcache_hit (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
splay_tree_node node = splay_tree_lookup (dcache->tree,
|
|
(splay_tree_key) MASK (dcache, addr));
|
|
|
|
if (!node)
|
|
return NULL;
|
|
|
|
db = (struct dcache_block *) node->value;
|
|
db->refs++;
|
|
return db;
|
|
}
|
|
|
|
/* Fill a cache line from target memory.
|
|
The result is 1 for success, 0 if the (entire) cache line
|
|
wasn't readable. */
|
|
|
|
static int
|
|
dcache_read_line (DCACHE *dcache, struct dcache_block *db)
|
|
{
|
|
CORE_ADDR memaddr;
|
|
gdb_byte *myaddr;
|
|
int len;
|
|
int res;
|
|
int reg_len;
|
|
struct mem_region *region;
|
|
|
|
len = dcache->line_size;
|
|
memaddr = db->addr;
|
|
myaddr = db->data;
|
|
|
|
while (len > 0)
|
|
{
|
|
/* Don't overrun if this block is right at the end of the region. */
|
|
region = lookup_mem_region (memaddr);
|
|
if (region->hi == 0 || memaddr + len < region->hi)
|
|
reg_len = len;
|
|
else
|
|
reg_len = region->hi - memaddr;
|
|
|
|
/* Skip non-readable regions. The cache attribute can be ignored,
|
|
since we may be loading this for a stack access. */
|
|
if (region->attrib.mode == MEM_WO)
|
|
{
|
|
memaddr += reg_len;
|
|
myaddr += reg_len;
|
|
len -= reg_len;
|
|
continue;
|
|
}
|
|
|
|
res = target_read_raw_memory (memaddr, myaddr, reg_len);
|
|
if (res != 0)
|
|
return 0;
|
|
|
|
memaddr += reg_len;
|
|
myaddr += reg_len;
|
|
len -= reg_len;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Get a free cache block, put or keep it on the valid list,
|
|
and return its address. */
|
|
|
|
static struct dcache_block *
|
|
dcache_alloc (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
if (dcache->size >= dcache_size)
|
|
{
|
|
/* Evict the least recently allocated line. */
|
|
db = dcache->oldest;
|
|
remove_block (&dcache->oldest, db);
|
|
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) db->addr);
|
|
}
|
|
else
|
|
{
|
|
db = dcache->freelist;
|
|
if (db)
|
|
remove_block (&dcache->freelist, db);
|
|
else
|
|
db = ((struct dcache_block *)
|
|
xmalloc (offsetof (struct dcache_block, data)
|
|
+ dcache->line_size));
|
|
|
|
dcache->size++;
|
|
}
|
|
|
|
db->addr = MASK (dcache, addr);
|
|
db->refs = 0;
|
|
|
|
/* Put DB at the end of the list, it's the newest. */
|
|
append_block (&dcache->oldest, db);
|
|
|
|
splay_tree_insert (dcache->tree, (splay_tree_key) db->addr,
|
|
(splay_tree_value) db);
|
|
|
|
return db;
|
|
}
|
|
|
|
/* Using the data cache DCACHE, store in *PTR the contents of the byte at
|
|
address ADDR in the remote machine.
|
|
|
|
Returns 1 for success, 0 for error. */
|
|
|
|
static int
|
|
dcache_peek_byte (DCACHE *dcache, CORE_ADDR addr, gdb_byte *ptr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (!db)
|
|
{
|
|
db = dcache_alloc (dcache, addr);
|
|
|
|
if (!dcache_read_line (dcache, db))
|
|
return 0;
|
|
}
|
|
|
|
*ptr = db->data[XFORM (dcache, addr)];
|
|
return 1;
|
|
}
|
|
|
|
/* Write the byte at PTR into ADDR in the data cache.
|
|
|
|
The caller should have written the data through to target memory
|
|
already.
|
|
|
|
If ADDR is not in cache, this function does nothing; writing to an
|
|
area of memory which wasn't present in the cache doesn't cause it
|
|
to be loaded in. */
|
|
|
|
static void
|
|
dcache_poke_byte (DCACHE *dcache, CORE_ADDR addr, const gdb_byte *ptr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (db)
|
|
db->data[XFORM (dcache, addr)] = *ptr;
|
|
}
|
|
|
|
static int
|
|
dcache_splay_tree_compare (splay_tree_key a, splay_tree_key b)
|
|
{
|
|
if (a > b)
|
|
return 1;
|
|
else if (a == b)
|
|
return 0;
|
|
else
|
|
return -1;
|
|
}
|
|
|
|
/* Allocate and initialize a data cache. */
|
|
|
|
DCACHE *
|
|
dcache_init (void)
|
|
{
|
|
DCACHE *dcache = XNEW (DCACHE);
|
|
|
|
dcache->tree = splay_tree_new (dcache_splay_tree_compare,
|
|
NULL,
|
|
NULL);
|
|
|
|
dcache->oldest = NULL;
|
|
dcache->freelist = NULL;
|
|
dcache->size = 0;
|
|
dcache->line_size = dcache_line_size;
|
|
dcache->ptid = null_ptid;
|
|
|
|
return dcache;
|
|
}
|
|
|
|
|
|
/* Read LEN bytes from dcache memory at MEMADDR, transferring to
|
|
debugger address MYADDR. If the data is presently cached, this
|
|
fills the cache. Arguments/return are like the target_xfer_partial
|
|
interface. */
|
|
|
|
enum target_xfer_status
|
|
dcache_read_memory_partial (struct target_ops *ops, DCACHE *dcache,
|
|
CORE_ADDR memaddr, gdb_byte *myaddr,
|
|
ULONGEST len, ULONGEST *xfered_len)
|
|
{
|
|
ULONGEST i;
|
|
|
|
/* If this is a different inferior from what we've recorded,
|
|
flush the cache. */
|
|
|
|
if (inferior_ptid != dcache->ptid)
|
|
{
|
|
dcache_invalidate (dcache);
|
|
dcache->ptid = inferior_ptid;
|
|
}
|
|
|
|
for (i = 0; i < len; i++)
|
|
{
|
|
if (!dcache_peek_byte (dcache, memaddr + i, myaddr + i))
|
|
{
|
|
/* That failed. Discard its cache line so we don't have a
|
|
partially read line. */
|
|
dcache_invalidate_line (dcache, memaddr + i);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (i == 0)
|
|
{
|
|
/* Even though reading the whole line failed, we may be able to
|
|
read a piece starting where the caller wanted. */
|
|
return raw_memory_xfer_partial (ops, myaddr, NULL, memaddr, len,
|
|
xfered_len);
|
|
}
|
|
else
|
|
{
|
|
*xfered_len = i;
|
|
return TARGET_XFER_OK;
|
|
}
|
|
}
|
|
|
|
/* FIXME: There would be some benefit to making the cache write-back and
|
|
moving the writeback operation to a higher layer, as it could occur
|
|
after a sequence of smaller writes have been completed (as when a stack
|
|
frame is constructed for an inferior function call). Note that only
|
|
moving it up one level to target_xfer_memory[_partial]() is not
|
|
sufficient since we want to coalesce memory transfers that are
|
|
"logically" connected but not actually a single call to one of the
|
|
memory transfer functions. */
|
|
|
|
/* Just update any cache lines which are already present. This is
|
|
called by the target_xfer_partial machinery when writing raw
|
|
memory. */
|
|
|
|
void
|
|
dcache_update (DCACHE *dcache, enum target_xfer_status status,
|
|
CORE_ADDR memaddr, const gdb_byte *myaddr,
|
|
ULONGEST len)
|
|
{
|
|
ULONGEST i;
|
|
|
|
for (i = 0; i < len; i++)
|
|
if (status == TARGET_XFER_OK)
|
|
dcache_poke_byte (dcache, memaddr + i, myaddr + i);
|
|
else
|
|
{
|
|
/* Discard the whole cache line so we don't have a partially
|
|
valid line. */
|
|
dcache_invalidate_line (dcache, memaddr + i);
|
|
}
|
|
}
|
|
|
|
/* Print DCACHE line INDEX. */
|
|
|
|
static void
|
|
dcache_print_line (DCACHE *dcache, int index)
|
|
{
|
|
splay_tree_node n;
|
|
struct dcache_block *db;
|
|
int i, j;
|
|
|
|
if (dcache == NULL)
|
|
{
|
|
printf_filtered (_("No data cache available.\n"));
|
|
return;
|
|
}
|
|
|
|
n = splay_tree_min (dcache->tree);
|
|
|
|
for (i = index; i > 0; --i)
|
|
{
|
|
if (!n)
|
|
break;
|
|
n = splay_tree_successor (dcache->tree, n->key);
|
|
}
|
|
|
|
if (!n)
|
|
{
|
|
printf_filtered (_("No such cache line exists.\n"));
|
|
return;
|
|
}
|
|
|
|
db = (struct dcache_block *) n->value;
|
|
|
|
printf_filtered (_("Line %d: address %s [%d hits]\n"),
|
|
index, paddress (target_gdbarch (), db->addr), db->refs);
|
|
|
|
for (j = 0; j < dcache->line_size; j++)
|
|
{
|
|
printf_filtered ("%02x ", db->data[j]);
|
|
|
|
/* Print a newline every 16 bytes (48 characters). */
|
|
if ((j % 16 == 15) && (j != dcache->line_size - 1))
|
|
printf_filtered ("\n");
|
|
}
|
|
printf_filtered ("\n");
|
|
}
|
|
|
|
/* Parse EXP and show the info about DCACHE. */
|
|
|
|
static void
|
|
dcache_info_1 (DCACHE *dcache, const char *exp)
|
|
{
|
|
splay_tree_node n;
|
|
int i, refcount;
|
|
|
|
if (exp)
|
|
{
|
|
char *linestart;
|
|
|
|
i = strtol (exp, &linestart, 10);
|
|
if (linestart == exp || i < 0)
|
|
{
|
|
printf_filtered (_("Usage: info dcache [LINENUMBER]\n"));
|
|
return;
|
|
}
|
|
|
|
dcache_print_line (dcache, i);
|
|
return;
|
|
}
|
|
|
|
printf_filtered (_("Dcache %u lines of %u bytes each.\n"),
|
|
dcache_size,
|
|
dcache ? (unsigned) dcache->line_size
|
|
: dcache_line_size);
|
|
|
|
if (dcache == NULL || dcache->ptid == null_ptid)
|
|
{
|
|
printf_filtered (_("No data cache available.\n"));
|
|
return;
|
|
}
|
|
|
|
printf_filtered (_("Contains data for %s\n"),
|
|
target_pid_to_str (dcache->ptid).c_str ());
|
|
|
|
refcount = 0;
|
|
|
|
n = splay_tree_min (dcache->tree);
|
|
i = 0;
|
|
|
|
while (n)
|
|
{
|
|
struct dcache_block *db = (struct dcache_block *) n->value;
|
|
|
|
printf_filtered (_("Line %d: address %s [%d hits]\n"),
|
|
i, paddress (target_gdbarch (), db->addr), db->refs);
|
|
i++;
|
|
refcount += db->refs;
|
|
|
|
n = splay_tree_successor (dcache->tree, n->key);
|
|
}
|
|
|
|
printf_filtered (_("Cache state: %d active lines, %d hits\n"), i, refcount);
|
|
}
|
|
|
|
static void
|
|
info_dcache_command (const char *exp, int tty)
|
|
{
|
|
dcache_info_1 (target_dcache_get (), exp);
|
|
}
|
|
|
|
static void
|
|
set_dcache_size (const char *args, int from_tty,
|
|
struct cmd_list_element *c)
|
|
{
|
|
if (dcache_size == 0)
|
|
{
|
|
dcache_size = DCACHE_DEFAULT_SIZE;
|
|
error (_("Dcache size must be greater than 0."));
|
|
}
|
|
target_dcache_invalidate ();
|
|
}
|
|
|
|
static void
|
|
set_dcache_line_size (const char *args, int from_tty,
|
|
struct cmd_list_element *c)
|
|
{
|
|
if (dcache_line_size < 2
|
|
|| (dcache_line_size & (dcache_line_size - 1)) != 0)
|
|
{
|
|
unsigned d = dcache_line_size;
|
|
dcache_line_size = DCACHE_DEFAULT_LINE_SIZE;
|
|
error (_("Invalid dcache line size: %u (must be power of 2)."), d);
|
|
}
|
|
target_dcache_invalidate ();
|
|
}
|
|
|
|
static void
|
|
set_dcache_command (const char *arg, int from_tty)
|
|
{
|
|
printf_unfiltered (
|
|
"\"set dcache\" must be followed by the name of a subcommand.\n");
|
|
help_list (dcache_set_list, "set dcache ", all_commands, gdb_stdout);
|
|
}
|
|
|
|
static void
|
|
show_dcache_command (const char *args, int from_tty)
|
|
{
|
|
cmd_show_list (dcache_show_list, from_tty, "");
|
|
}
|
|
|
|
void _initialize_dcache ();
|
|
void
|
|
_initialize_dcache ()
|
|
{
|
|
add_setshow_boolean_cmd ("remotecache", class_support,
|
|
&dcache_enabled_p, _("\
|
|
Set cache use for remote targets."), _("\
|
|
Show cache use for remote targets."), _("\
|
|
This used to enable the data cache for remote targets. The cache\n\
|
|
functionality is now controlled by the memory region system and the\n\
|
|
\"stack-cache\" flag; \"remotecache\" now does nothing and\n\
|
|
exists only for compatibility reasons."),
|
|
NULL,
|
|
show_dcache_enabled_p,
|
|
&setlist, &showlist);
|
|
|
|
add_info ("dcache", info_dcache_command,
|
|
_("\
|
|
Print information on the dcache performance.\n\
|
|
Usage: info dcache [LINENUMBER]\n\
|
|
With no arguments, this command prints the cache configuration and a\n\
|
|
summary of each line in the cache. With an argument, dump\"\n\
|
|
the contents of the given line."));
|
|
|
|
add_prefix_cmd ("dcache", class_obscure, set_dcache_command, _("\
|
|
Use this command to set number of lines in dcache and line-size."),
|
|
&dcache_set_list, "set dcache ", /*allow_unknown*/0, &setlist);
|
|
add_prefix_cmd ("dcache", class_obscure, show_dcache_command, _("\
|
|
Show dcachesettings."),
|
|
&dcache_show_list, "show dcache ", /*allow_unknown*/0, &showlist);
|
|
|
|
add_setshow_zuinteger_cmd ("line-size", class_obscure,
|
|
&dcache_line_size, _("\
|
|
Set dcache line size in bytes (must be power of 2)."), _("\
|
|
Show dcache line size."),
|
|
NULL,
|
|
set_dcache_line_size,
|
|
NULL,
|
|
&dcache_set_list, &dcache_show_list);
|
|
add_setshow_zuinteger_cmd ("size", class_obscure,
|
|
&dcache_size, _("\
|
|
Set number of dcache lines."), _("\
|
|
Show number of dcache lines."),
|
|
NULL,
|
|
set_dcache_size,
|
|
NULL,
|
|
&dcache_set_list, &dcache_show_list);
|
|
}
|