binutils-gdb/gdbsupport/btrace-common.h
Kevin Buettner a51951c258 Disable record btrace bts support for AMD processors
Some Intel processors implement a Branch Trace Store (BTS) which GDB
uses for reverse execution support via the "record btrace bts"
command.

I have been unable to find a description of a similar feature in a
recent (April 2020) AMD64 architecture reference:

    https://www.amd.com/system/files/TechDocs/40332.pdf

While it is the case that AMD processors have an LBR (last branch
record) bit in the DebugCtl MSR, it seems that it affects only four
MSRs when enabled.  The names of these MSRs are LastBranchToIP,
LastBranchFromIP, LastIntToIP, and LastIntFromIP.  I can find no
mention of anything more extensive.  While looking at an Intel
architecture document, I noticed that Intel's P6 family from the
mid-90s had registers of the same name.

Therefore...

This commit disables "record btrace bts" support in GDB for AMD
processors.

Using the test case from gdb.base/break.exp, the sessions
below show the expected behavior (run on a machine with an
Intel processor) versus that on a machine with an AMD processor.
The AMD processor in question is reported as follows by "lscpu":
AMD Ryzen Threadripper 2950X 16-Core Processor .  Finally, I'll
note that the AMD machine is actually a VM, but I see similar
behavior on both the virtualization host and the VM.

Intel machine - Desired behavior:

[kevinb@mohave gdb]$ ./gdb -q testsuite/outputs/gdb.base/break/break
Reading symbols from testsuite/outputs/gdb.base/break/break...
(gdb) start
Temporary breakpoint 1 at 0x401179: file /home/kevinb/sourceware-git/native-build/bld/../../binutils-gdb/gdb/testsuite/gdb.base/break.c, line 43.
Starting program: /home/kevinb/sourceware-git/native-build/bld/gdb/testsuite/outputs/gdb.base/break/break

Temporary breakpoint 1, main (argc=1, argv=0x7fffffffd748, envp=0x7fffffffd758)
    at /home/kevinb/sourceware-git/native-build/bld/../../binutils-gdb/gdb/testsuite/gdb.base/break.c:43
43	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */ /* set breakpoint 6 here */
(gdb) record btrace
(gdb) b factorial
Breakpoint 2 at 0x40121b: file /home/kevinb/sourceware-git/native-build/bld/../../binutils-gdb/gdb/testsuite/gdb.base/break.c, line 63.
(gdb) c
Continuing.

Breakpoint 2, factorial (value=6)
    at /home/kevinb/sourceware-git/native-build/bld/../../binutils-gdb/gdb/testsuite/gdb.base/break.c:63
63	  if (value > 1) {  /* set breakpoint 7 here */
(gdb) info record
Active record target: record-btrace
Recording format: Branch Trace Store.
Buffer size: 64kB.
Recorded 768 instructions in 22 functions (0 gaps) for thread 1 (process 19215).
(gdb) record function-call-history
13	do_lookup_x
14	_dl_lookup_symbol_x
15	_dl_fixup
16	_dl_runtime_resolve_xsavec
17	atoi
18	strtoq
19	____strtoll_l_internal
20	atoi
21	main
22	factorial
(gdb) record instruction-history
759	   0x00007ffff7ce0917 <____strtoll_l_internal+647>:	pop    %r15
760	   0x00007ffff7ce0919 <____strtoll_l_internal+649>:	retq
761	   0x00007ffff7cdd064 <atoi+20>:	add    $0x8,%rsp
762	   0x00007ffff7cdd068 <atoi+24>:	retq
763	   0x00000000004011b1 <main+75>:	mov    %eax,%edi
764	   0x00000000004011b3 <main+77>:	callq  0x401210 <factorial>
765	   0x0000000000401210 <factorial+0>:	push   %rbp
766	   0x0000000000401211 <factorial+1>:	mov    %rsp,%rbp
767	   0x0000000000401214 <factorial+4>:	sub    $0x10,%rsp
768	   0x0000000000401218 <factorial+8>:	mov    %edi,-0x4(%rbp)

AMD machine - Wrong behavior:

[kev@f32-1 gdb]$ ./gdb -q testsuite/outputs/gdb.base/break/break
Reading symbols from testsuite/outputs/gdb.base/break/break...
(gdb) start
Temporary breakpoint 1 at 0x401179: file /ironwood1/sourceware-git/f32-master/bld/../../worktree-master/gdb/testsuite/gdb.base/break.c, line 43.
Starting program: /mesquite2/sourceware-git/f32-master/bld/gdb/testsuite/outputs/gdb.base/break/break

Temporary breakpoint 1, main (argc=1, argv=0x7fffffffd5b8, envp=0x7fffffffd5c8)
    at /ironwood1/sourceware-git/f32-master/bld/../../worktree-master/gdb/testsuite/gdb.base/break.c:43
43	    if (argc == 12345) {  /* an unlikely value < 2^16, in case uninited */ /* set breakpoint 6 here */
(gdb) record btrace
(gdb) b factorial
Breakpoint 2 at 0x40121b: file /ironwood1/sourceware-git/f32-master/bld/../../worktree-master/gdb/testsuite/gdb.base/break.c, line 63.
(gdb) c
Continuing.

Breakpoint 2, factorial (value=6)
    at /ironwood1/sourceware-git/f32-master/bld/../../worktree-master/gdb/testsuite/gdb.base/break.c:63
63	  if (value > 1) {  /* set breakpoint 7 here */
(gdb) info record
Active record target: record-btrace
Recording format: Branch Trace Store.
Buffer size: 64kB.
warning: Recorded trace may be incomplete at instruction 7737 (pc = 0x405000).
warning: Recorded trace may be incomplete at instruction 7739 (pc = 0x0).
Recorded 7740 instructions in 46 functions (2 gaps) for thread 1 (process 1402911).
(gdb) record function-call-history
37	??
38	values
39	some_enum_global
40	??
41	some_union_global
42	some_variable
43	??
44	[decode error (2): unknown instruction]
45	??
46	[decode error (2): unknown instruction]
(gdb) record instruction-history
7730	   0x0000000000404ff3:	add    %al,(%rax)
7731	   0x0000000000404ff5:	add    %al,(%rax)
7732	   0x0000000000404ff7:	add    %al,(%rax)
7733	   0x0000000000404ff9:	add    %al,(%rax)
7734	   0x0000000000404ffb:	add    %al,(%rax)
7735	   0x0000000000404ffd:	add    %al,(%rax)
7736	   0x0000000000404fff:	.byte 0x0
7737	   0x0000000000405000:	Cannot access memory at address 0x405000

Lastly, I'll note that I see a lot of gdb.btrace failures without
this commit.  Worse still, the results aren't always the same which
causes a lot of noise when comparing test results.

gdbsupport/ChangeLog:

	* btrace-common.h (btrace_cpu_vendor): Add CV_AMD.

gdb/ChangeLog:

	* nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
	processors.
	(cpu_supports_bts): Add CV_AMD case.
2020-05-14 17:56:33 -07:00

264 lines
6.4 KiB
C++

/* Branch trace support for GDB, the GNU debugger.
Copyright (C) 2013-2020 Free Software Foundation, Inc.
Contributed by Intel Corp. <markus.t.metzger@intel.com>.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef COMMON_BTRACE_COMMON_H
#define COMMON_BTRACE_COMMON_H
/* Branch tracing (btrace) is a per-thread control-flow execution trace of the
inferior. For presentation purposes, the branch trace is represented as a
list of sequential control-flow blocks, one such list per thread. */
/* A branch trace block.
This represents a block of sequential control-flow. Adjacent blocks will be
connected via calls, returns, or jumps. The latter can be direct or
indirect, conditional or unconditional. Branches can further be
asynchronous, e.g. interrupts. */
struct btrace_block
{
/* The address of the first byte of the first instruction in the block.
The address may be zero if we do not know the beginning of this block,
such as for the first block in a delta trace. */
CORE_ADDR begin;
/* The address of the first byte of the last instruction in the block. */
CORE_ADDR end;
/* Simple constructor. */
btrace_block (CORE_ADDR begin, CORE_ADDR end)
: begin (begin),
end (end)
{
/* Nothing. */
}
};
/* Enumeration of btrace formats. */
enum btrace_format
{
/* No branch trace format. */
BTRACE_FORMAT_NONE,
/* Branch trace is in Branch Trace Store (BTS) format.
Actually, the format is a sequence of blocks derived from BTS. */
BTRACE_FORMAT_BTS,
/* Branch trace is in Intel Processor Trace format. */
BTRACE_FORMAT_PT
};
/* An enumeration of cpu vendors. */
enum btrace_cpu_vendor
{
/* We do not know this vendor. */
CV_UNKNOWN,
/* Intel. */
CV_INTEL,
/* AMD. */
CV_AMD
};
/* A cpu identifier. */
struct btrace_cpu
{
/* The processor vendor. */
enum btrace_cpu_vendor vendor;
/* The cpu family. */
unsigned short family;
/* The cpu model. */
unsigned char model;
/* The cpu stepping. */
unsigned char stepping;
};
/* A BTS configuration. */
struct btrace_config_bts
{
/* The size of the branch trace buffer in bytes.
This is unsigned int and not size_t since it is registered as
control variable for "set record btrace bts buffer-size". */
unsigned int size;
};
/* An Intel Processor Trace configuration. */
struct btrace_config_pt
{
/* The size of the branch trace buffer in bytes.
This is unsigned int and not size_t since it is registered as
control variable for "set record btrace pt buffer-size". */
unsigned int size;
};
/* A branch tracing configuration.
This describes the requested configuration as well as the actually
obtained configuration.
We describe the configuration for all different formats so we can
easily switch between formats. */
struct btrace_config
{
/* The branch tracing format. */
enum btrace_format format;
/* The BTS format configuration. */
struct btrace_config_bts bts;
/* The Intel Processor Trace format configuration. */
struct btrace_config_pt pt;
};
/* Branch trace in BTS format. */
struct btrace_data_bts
{
/* Branch trace is represented as a vector of branch trace blocks starting
with the most recent block. This needs to be a pointer as we place
btrace_data_bts into a union. */
std::vector<btrace_block> *blocks;
};
/* Configuration information to go with the trace data. */
struct btrace_data_pt_config
{
/* The processor on which the trace has been collected. */
struct btrace_cpu cpu;
};
/* Branch trace in Intel Processor Trace format. */
struct btrace_data_pt
{
/* Some configuration information to go with the data. */
struct btrace_data_pt_config config;
/* The trace data. */
gdb_byte *data;
/* The size of DATA in bytes. */
size_t size;
};
/* The branch trace data. */
struct btrace_data
{
btrace_data () = default;
~btrace_data ()
{
fini ();
}
btrace_data &operator= (btrace_data &&other)
{
if (this != &other)
{
fini ();
format = other.format;
variant = other.variant;
other.format = BTRACE_FORMAT_NONE;
}
return *this;
}
/* Return true if this is empty; false otherwise. */
bool empty () const;
/* Clear this object. */
void clear ();
enum btrace_format format = BTRACE_FORMAT_NONE;
union
{
/* Format == BTRACE_FORMAT_BTS. */
struct btrace_data_bts bts;
/* Format == BTRACE_FORMAT_PT. */
struct btrace_data_pt pt;
} variant;
private:
DISABLE_COPY_AND_ASSIGN (btrace_data);
void fini ();
};
/* Target specific branch trace information. */
struct btrace_target_info;
/* Enumeration of btrace read types. */
enum btrace_read_type
{
/* Send all available trace. */
BTRACE_READ_ALL,
/* Send all available trace, if it changed. */
BTRACE_READ_NEW,
/* Send the trace since the last request. This will fail if the trace
buffer overflowed. */
BTRACE_READ_DELTA
};
/* Enumeration of btrace errors. */
enum btrace_error
{
/* No error. Everything is OK. */
BTRACE_ERR_NONE,
/* An unknown error. */
BTRACE_ERR_UNKNOWN,
/* Branch tracing is not supported on this system. */
BTRACE_ERR_NOT_SUPPORTED,
/* The branch trace buffer overflowed; no delta read possible. */
BTRACE_ERR_OVERFLOW
};
/* Return a string representation of FORMAT. */
extern const char *btrace_format_string (enum btrace_format format);
/* Return an abbreviation string representation of FORMAT. */
extern const char *btrace_format_short_string (enum btrace_format format);
/* Append the branch trace data from SRC to the end of DST.
Both SRC and DST must use the same format.
Returns zero on success; a negative number otherwise. */
extern int btrace_data_append (struct btrace_data *dst,
const struct btrace_data *src);
#endif /* COMMON_BTRACE_COMMON_H */