mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-21 01:12:32 +08:00
7397181903
So the target knows whether we're detaching breakpoints. Nothing uses the parameter in this patch yet. gdb/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * break-catch-sig.c (signal_catchpoint_remove_location): Adjust interface. * break-catch-syscall.c (remove_catch_syscall): * breakpoint.c (enum remove_bp_reason): Moved to breakpoint.h. (remove_breakpoint_1): Pass 'reason' down. (remove_catch_fork, remove_catch_vfork, remove_catch_solib) (remove_catch_exec, remove_watchpoint, remove_masked_watchpoint) (base_breakpoint_remove_location, bkpt_remove_location) (bkpt_probe_remove_location, bkpt_probe_remove_location): Adjust interface. * breakpoint.h (enum remove_bp_reason): Moved here from breakpoint.c. (struct breakpoint_ops) <remove_location>: Add 'reason' parameter. * corelow.c (core_remove_breakpoint): New function. (init_core_ops): Install it as to_remove_breakpoint method. * exec.c (exec_remove_breakpoint): New function. (init_exec_ops): Install it as to_remove_breakpoint method. * mem-break.c (memory_remove_breakpoint): Adjust interface. * record-btrace.c (record_btrace_remove_breakpoint): Adjust interface. * record-full.c (record_full_remove_breakpoint) (record_full_core_remove_breakpoint): Adjust interface. * remote.c (remote_remove_breakpoint): Adjust interface. * target-debug.h (target_debug_print_enum_remove_bp_reason): New macro. * target-delegates.c: Regenerate. * target.c (target_remove_breakpoint): Add 'reason' parameter. * target.h (struct target_ops) <to_remove_breakpoint>: Add 'reason' parameter. (target_remove_breakpoint, memory_remove_breakpoint): Add 'reason' parameter.
133 lines
4.3 KiB
C
133 lines
4.3 KiB
C
/* Simulate breakpoints by patching locations in the target system, for GDB.
|
|
|
|
Copyright (C) 1990-2016 Free Software Foundation, Inc.
|
|
|
|
Contributed by Cygnus Support. Written by John Gilmore.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "symtab.h"
|
|
#include "breakpoint.h"
|
|
#include "inferior.h"
|
|
#include "target.h"
|
|
/* Insert a breakpoint on targets that don't have any better
|
|
breakpoint support. We read the contents of the target location
|
|
and stash it, then overwrite it with a breakpoint instruction.
|
|
BP_TGT->placed_address is the target location in the target
|
|
machine. BP_TGT->shadow_contents is some memory allocated for
|
|
saving the target contents. It is guaranteed by the caller to be
|
|
long enough to save BREAKPOINT_LEN bytes (this is accomplished via
|
|
BREAKPOINT_MAX). */
|
|
|
|
int
|
|
default_memory_insert_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
CORE_ADDR addr = bp_tgt->reqstd_address;
|
|
const unsigned char *bp;
|
|
gdb_byte *readbuf;
|
|
int bplen;
|
|
int val;
|
|
|
|
/* Determine appropriate breakpoint contents and size for this address. */
|
|
bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
|
|
if (bp == NULL)
|
|
error (_("Software breakpoints not implemented for this target."));
|
|
|
|
bp_tgt->placed_address = addr;
|
|
bp_tgt->placed_size = bplen;
|
|
|
|
/* Save the memory contents in the shadow_contents buffer and then
|
|
write the breakpoint instruction. */
|
|
readbuf = (gdb_byte *) alloca (bplen);
|
|
val = target_read_memory (addr, readbuf, bplen);
|
|
if (val == 0)
|
|
{
|
|
/* These must be set together, either before or after the shadow
|
|
read, so that if we're "reinserting" a breakpoint that
|
|
doesn't have a shadow yet, the breakpoint masking code inside
|
|
target_read_memory doesn't mask out this breakpoint using an
|
|
unfilled shadow buffer. The core may be trying to reinsert a
|
|
permanent breakpoint, for targets that support breakpoint
|
|
conditions/commands on the target side for some types of
|
|
breakpoints, such as target remote. */
|
|
bp_tgt->shadow_len = bplen;
|
|
memcpy (bp_tgt->shadow_contents, readbuf, bplen);
|
|
|
|
val = target_write_raw_memory (addr, bp, bplen);
|
|
}
|
|
|
|
return val;
|
|
}
|
|
|
|
|
|
int
|
|
default_memory_remove_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
return target_write_raw_memory (bp_tgt->placed_address, bp_tgt->shadow_contents,
|
|
bp_tgt->placed_size);
|
|
}
|
|
|
|
|
|
int
|
|
memory_insert_breakpoint (struct target_ops *ops, struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
return gdbarch_memory_insert_breakpoint (gdbarch, bp_tgt);
|
|
}
|
|
|
|
int
|
|
memory_remove_breakpoint (struct target_ops *ops, struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt,
|
|
enum remove_bp_reason reason)
|
|
{
|
|
return gdbarch_memory_remove_breakpoint (gdbarch, bp_tgt);
|
|
}
|
|
|
|
int
|
|
memory_validate_breakpoint (struct gdbarch *gdbarch,
|
|
struct bp_target_info *bp_tgt)
|
|
{
|
|
CORE_ADDR addr = bp_tgt->placed_address;
|
|
const gdb_byte *bp;
|
|
int val;
|
|
int bplen;
|
|
gdb_byte cur_contents[BREAKPOINT_MAX];
|
|
struct cleanup *cleanup;
|
|
int ret;
|
|
|
|
/* Determine appropriate breakpoint contents and size for this
|
|
address. */
|
|
bp = gdbarch_breakpoint_from_pc (gdbarch, &addr, &bplen);
|
|
|
|
if (bp == NULL || bp_tgt->placed_size != bplen)
|
|
return 0;
|
|
|
|
/* Make sure we see the memory breakpoints. */
|
|
cleanup = make_show_memory_breakpoints_cleanup (1);
|
|
val = target_read_memory (addr, cur_contents, bplen);
|
|
|
|
/* If our breakpoint is no longer at the address, this means that
|
|
the program modified the code on us, so it is wrong to put back
|
|
the old value. */
|
|
ret = (val == 0 && memcmp (bp, cur_contents, bplen) == 0);
|
|
|
|
do_cleanups (cleanup);
|
|
return ret;
|
|
}
|