mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-04-12 14:33:06 +08:00
4e2182df14
PR libsframe/32589 - function start address is zero in SFrame section dump
Currently, readelf and objdump display SFrame section in object file
with function start addresses of each function as 0. This makes it
difficult to correlate SFrame stack trace information with the
individual functions in the object file.
Use the dump_dwarf () interface to dump SFrame section. The current
infrastructure (for DWARF debug sections) already supports relocating
the section contents before dumping, so lets use that.
Even after the section contents are relocated, there is need to fixup
the function start address, which is what sframe_fde_tbl_reloc_fixup ()
is about.
As a side effect, objdump now adds two new ways of dumping SFrame sections:
- objdump -WS <obj>
- objdump --dwarf=sframe
We do not publicize these options. The lone advertised user interfacing
option (in --help) remains:
- objdump --sframe
Furthermore, we continue to keep the same error messaging as earlier (by
folding the check for section into the new display_sframe_section ()
function):
$ objdump --sframe=sframe bubble_sort.o
...
No sframe section present
$ objdump --sframe=.sfram bubble_sort.o
...
No .sfram section present
Note the new API dump_sframe_reloc (). This new API is exposed because
objdump / readelf will need it. Since this addition is backwards
compatible, update libtool-version with age+1 and revision+1.
TBD:
- Add tests where the fixup function is exercised. No explicit tests
for that yet on x86_64. Although the AArch64 one sort of suffices ?
binutils/
* dwarf.c (display_sframe): New definition.
(dwarf_select_sections_all): Enable SFrame section too.
(struct dwarf_section_display): Add entry for SFrame section.
* dwarf.h (enum dwarf_section_display_enum): Add enumerator for
SFrame.
* objdump.c (dump_section_sframe): Remove.
(dump_sframe_section): Add new definition.
(dump_bfd): Use dump_sframe_section.
* binutils/readelf.c (dump_section_as_sframe): Remove.
gas/testsuite/
* gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.d:
README for GNU development tools This directory contains various GNU compilers, assemblers, linkers, debuggers, etc., plus their support routines, definitions, and documentation. If you are receiving this as part of a GDB release, see the file gdb/README. If with a binutils release, see binutils/README; if with a libg++ release, see libg++/README, etc. That'll give you info about this package -- supported targets, how to use it, how to report bugs, etc. It is now possible to automatically configure and build a variety of tools with one command. To build all of the tools contained herein, run the ``configure'' script here, e.g.: ./configure make To install them (by default in /usr/local/bin, /usr/local/lib, etc), then do: make install (If the configure script can't determine your type of computer, give it the name as an argument, for instance ``./configure sun4''. You can use the script ``config.sub'' to test whether a name is recognized; if it is, config.sub translates it to a triplet specifying CPU, vendor, and OS.) If you have more than one compiler on your system, it is often best to explicitly set CC in the environment before running configure, and to also set CC when running make. For example (assuming sh/bash/ksh): CC=gcc ./configure make A similar example using csh: setenv CC gcc ./configure make Much of the code and documentation enclosed is copyright by the Free Software Foundation, Inc. See the file COPYING or COPYING.LIB in the various directories, for a description of the GNU General Public License terms under which you can copy the files. REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info on where and how to report problems.