mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-17 13:10:12 +08:00
d2f8a107b7
There is a single declaration of set_tdesc_osabi that is shared
between gdbserver/ and gdb/, this declaration takes a 'const char *'
argument which is the string representing an osabi.
Then in gdb/ we have an overload of set_tdesc_osabi which takes an
'enum gdb_osabi'.
In this commit I change the shared set_tdesc_osabi to be the version
which takes an 'enum gdb_osabi', and I remove the version which takes
a 'const char *'. All users of set_tdesc_osabi are updated to pass an
'enum gdb_osabi'.
The features/ code, which is generated from the xml files, requires a
new function to be added to osabi.{c,h} which can return a string
representation of an 'enum gdb_osabi'. With that new function in
place the features/ code is regenerated.
This change is being made to support the next commit. In the next
commit gdbserver will be updated to call set_tdesc_osabi in more
cases. The problem is that gdbserver stores the osabi as a string.
The issue here is that a typo in the gdbserver/ code might go
unnoticed and result in gdbserver sending back an invalid osabi
string.
To fix this we want gdbserver to pass an 'enum gdb_osabi' to the
set_tdesc_osabi function. With that requirement in place it seems to
make sense if all calls to set_tdesc_osabi pass an 'enum gdb_osabi'.
There should be no user visible changes after this commit.
Approved-By: Luis Machado <luis.machado@arm.com>
Approved-By: Simon Marchi <simon.marchi@efficios.com>
76 lines
2.5 KiB
C
76 lines
2.5 KiB
C
/* Copyright (C) 2017-2024 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "amd64.h"
|
|
#include "gdbsupport/x86-xstate.h"
|
|
#include "gdbsupport/osabi.h"
|
|
#include <stdlib.h>
|
|
|
|
#include "../features/i386/64bit-avx.c"
|
|
#include "../features/i386/64bit-avx512.c"
|
|
#include "../features/i386/64bit-core.c"
|
|
#include "../features/i386/64bit-linux.c"
|
|
#include "../features/i386/64bit-segments.c"
|
|
#include "../features/i386/64bit-sse.c"
|
|
#include "../features/i386/pkeys.c"
|
|
|
|
#include "../features/i386/x32-core.c"
|
|
|
|
/* Create amd64 target descriptions according to XCR0. If IS_X32 is
|
|
true, create the x32 ones. If IS_LINUX is true, create target
|
|
descriptions for Linux. If SEGMENTS is true, then include
|
|
the "org.gnu.gdb.i386.segments" feature registers. */
|
|
|
|
target_desc *
|
|
amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux,
|
|
bool segments)
|
|
{
|
|
target_desc_up tdesc = allocate_target_description ();
|
|
|
|
#ifndef IN_PROCESS_AGENT
|
|
set_tdesc_architecture (tdesc.get (),
|
|
is_x32 ? "i386:x64-32" : "i386:x86-64");
|
|
|
|
if (is_linux)
|
|
set_tdesc_osabi (tdesc.get (), GDB_OSABI_LINUX);
|
|
#endif
|
|
|
|
long regnum = 0;
|
|
|
|
if (is_x32)
|
|
regnum = create_feature_i386_x32_core (tdesc.get (), regnum);
|
|
else
|
|
regnum = create_feature_i386_64bit_core (tdesc.get (), regnum);
|
|
|
|
regnum = create_feature_i386_64bit_sse (tdesc.get (), regnum);
|
|
if (is_linux)
|
|
regnum = create_feature_i386_64bit_linux (tdesc.get (), regnum);
|
|
if (segments)
|
|
regnum = create_feature_i386_64bit_segments (tdesc.get (), regnum);
|
|
|
|
if (xcr0 & X86_XSTATE_AVX)
|
|
regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum);
|
|
|
|
if (xcr0 & X86_XSTATE_AVX512)
|
|
regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum);
|
|
|
|
if (xcr0 & X86_XSTATE_PKRU)
|
|
regnum = create_feature_i386_pkeys (tdesc.get (), regnum);
|
|
|
|
return tdesc.release ();
|
|
}
|