Commit Graph

13147 Commits

Author SHA1 Message Date
Alan Modra
8e2a4f11d4 PR20932, Internal error during record link assignment
PR ld/20932
	* elflink.c (bfd_elf_record_link_assignment): Handle warning symbols.
2016-12-08 21:35:11 +10:30
GDB Administrator
e2f9914792 Automatic date update in version.in 2016-12-08 00:00:27 +00:00
Nick Clifton
c2596ca5d7 Fix internal error in the linker by replacing a call to abort with an error message.
PR ld/20932
	* elflink.c (bfd_elf_record_link_assignment): Replace call to
	abort with an error message and error return value.
2016-12-07 10:19:42 +00:00
GDB Administrator
86a6934561 Automatic date update in version.in 2016-12-07 00:00:19 +00:00
Nick Clifton
4f3ca05b48 Fix seg-fault in strip when copying a corrupt binary.
PR binutils/20931
	* elf.c (copy_special_section_fields): Check for an invalid
	sh_link field before attempting to follow it.
2016-12-06 16:53:57 +00:00
Nick Clifton
92744f0580 Fix seg-fault running strip on a corrupt binary.
PR binutils/20929
	* aoutx.h (squirt_out_relocs): Check for relocs without an
	associated symbol.
2016-12-06 15:58:15 +00:00
Alan Modra
39eeab2534 PowerPC64 toc optimisation for power9
Recognize power9 and a few other insns from older machines.  Fixes
linker complaints like "toc optimization is not supported for
0xf4090002 instruction".  0xf4090002 is stxsd v0,0(r9)

bfd/
	* elf64-ppc.c (ok_lo_toc_insn): Add r_type param.  Recognize
	lq,lfq,lxv,lxsd,lxssp,lfdp,stq,stfq,stxv,stxsd,stxssp,stfdp.
	Don't match lmd and stmd.
ld/
	* testsuite/ld-powerpc/tocopt7.s,
	* testsuite/ld-powerpc/tocopt7.out,
	* testsuite/ld-powerpc/tocopt7.d: New test.
	* testsuite/ld-powerpc/tocopt8.s,
	* testsuite/ld-powerpc/tocopt8.d: New test.
	* testsuite/ld-powerpc/powerpc.exp: Run them.
2016-12-06 18:25:14 +10:30
GDB Administrator
e99f7af2bf Automatic date update in version.in 2016-12-06 00:00:23 +00:00
Nick Clifton
fa6631b4ee Fix seg-fault in the binutils utilities when reading a corrupt input file.
PR binutils/20905
	* peicode.h (pe_ILF_object_p): Use strnlen to avoid running over
	the end of the string buffer.
2016-12-05 16:34:45 +00:00
Nick Clifton
52c4f3bdd5 Fix abort when running tools on a bogus binary.
PR binutils/20907
	* peicode.h (pe_ILF_build_a_bfd): Replace abort with error return.
2016-12-05 14:59:02 +00:00
Nick Clifton
e2996cc315 Fix seg-fault running strip on a corrupt binary.
PR binutils/20921
	* aoutx.h (squirt_out_relocs): Check for and report any relocs
	that could not be recognised.
2016-12-05 14:32:30 +00:00
Alyssa Milburn
597e138ca0 bfd,ld: Continue after partially-successful relaxed call relocations in sparc.
bfd/ChangeLog:

2016-12-05  Alyssa Milburn <amilburn@zall.org>

  	* elfxx-sparc.c: Do not stop processing relocations after
    	partially relaxing a call with WDISP30.

ld/ChangeLog:

2016-12-05  Alyssa Milburn <amilburn@zall.org>

	* testsuite/ld-sparc/wdispcall.s: New file.
    	* testsuite/ld-sparc/wdispcall.dd: Likewise.
    	* testsuite/ld-sparc/sparc.exp: Run new test.
2016-12-04 22:59:18 -08:00
Nick Clifton
a55c9876bb Fix seg-fault attempting to strip a corrupt binary.
PR binutils/20922
	* elf.c (find_link): Check for null headers before attempting to
	match them.
2016-12-05 13:35:50 +00:00
Nick Clifton
daae68f4f3 Fix seg-fault in linker parsing a corrupt input file.
PR ld/20924
	(aout_link_add_symbols): Fix off by one error checking for
	overflow of string offset.
2016-12-05 12:25:34 +00:00
Nick Clifton
39d4daf68e Fix assertion failure in linker triggered by corrupt input file.
PR ld/20925
	* aoutx.h (aout_link_add_symbols): Replace BFD_ASSERT with return
	FALSE.
2016-12-05 12:14:22 +00:00
Nick Clifton
e9a1e93eca fix typo 2016-12-05 11:25:26 +00:00
GDB Administrator
df9236f896 Automatic date update in version.in 2016-12-05 00:00:22 +00:00
GDB Administrator
4132f1c0df Automatic date update in version.in 2016-12-04 00:00:23 +00:00
Alan Modra
8c5b4e5228 PowerPC64 dot-symbol compatibility bugfixes
Lots of fixes for the compatibility code that handles linking of
-mcall-aixdesc code (or that generated by 12 year old gcc) with
current ELFv1 ABI code.

1) A reference to a dot-symbol in an object file wasn't satisfied by a
   function descriptor in later object files.
2) The as-needed code had bit-rotted;  Shared libs now need a strong
   reference to be counted as needed.
3) --gc-sections involving dot-symbols was broken, needing
   func_desc_adjust to be run early and lots of other fixes.

bfd/
	* elf64-ppc.c (struct ppc_link_hash_entry): Delete "was_undefined".
	(struct ppc_link_hash_table): Delete "twiddled_syms".  Add
	"need_func_desc_adj".
	(lookup_fdh): Link direct fdh sym via oh field and set flags.
	(make_fdh): Make strong and weak undefined function descriptor
	symbols.
	(ppc64_elf_merge_symbol): New function.
	(elf_backend_merge_symbol): Define.
	(ppc64_elf_archive_symbol_lookup): Don't test undefweak for fake
	function descriptors.
	(add_symbol_adjust): Don't twiddle symbols to undefweak.
	Propagate more ref flags to function descriptor symbol.  Make
	some function descriptor symbols dynamic.
	(ppc64_elf_before_check_relocs): Only run add_symbol_adjust for
	ELFv1.  Set need_func_desc_adj.  Don't fix undefs list.
	(ppc64_elf_check_relocs): Set non_ir_ref for descriptors.
	Don't call lookup_fdh here.
	(ppc64_elf_gc_sections): New function.
	(bfd_elf64_bfd_gc_sections): Define.
	(ppc64_elf_gc_mark_hook): Mark descriptor.
	(func_desc_adjust): Don't make fake function descriptor syms strong
	here.  Exit earlier on non-dotsyms.  Take note of elf.dynamic
	flag when deciding whether a dynamic function descriptor might
	be needed.  Transfer elf.dynamic and set elf.needs_plt.  Move
	plt regardless of visibility.  Make descriptor dynamic if
	entry sym is dynamic, not for other cases.
	(ppc64_elf_func_desc_adjust): Don't run func_desc_adjust if
	already done.
	(ppc64_elf_edit_opd): Use oh field rather than lookup_fdh.
	(ppc64_elf_size_stubs): Likewise.
	(ppc_build_one_stub): Don't clear was_undefined.  Only set sym
	undefweak if stub symbol is defined.
	(undo_symbol_twiddle, ppc64_elf_restore_symbols): Delete.
	* elf64-ppc.h (ppc64_elf_restore_symbols): Don't declare.
ld/
	* emultempl/ppc64elf.em (gld${EMULATION_NAME}_finish): Don't call
	ppc64_elf_restore_symbols.
	* testsuite/ld-powerpc/dotsym1.d: New.
	* testsuite/ld-powerpc/dotsym2.d: New.
	* testsuite/ld-powerpc/dotsym3.d: New.
	* testsuite/ld-powerpc/dotsym4.d: New.
	* testsuite/ld-powerpc/dotsymref.s: New.
	* testsuite/ld-powerpc/nodotsym.s: New.
	* testsuite/ld-powerpc/powerpc.exp: Run new tests.
2016-12-03 21:00:01 +10:30
Alan Modra
b8ac28419b Tidy ppc64_elf_hide_symbol
* elf64-ppc.c (ppc64_elf_hide_symbol): Access hash table as
	elf_link_hash_table rather than ppc_link_hash_table.
2016-12-03 20:58:15 +10:30
Alan Modra
35dc6e0696 PowerPC64 add_symbol_adjust
* elf64-ppc.c (add_symbol_adjust): Delete dead code.
2016-12-03 20:57:50 +10:30
Alan Modra
8400d40d95 Indirect and warning symbols
It's possible but unlikely that an indirect symbol points at a warning
symbol.

	* elf64-ppc.c (add_symbol_adjust): Correct order of tests for
	warning and indirect symbols.
2016-12-03 20:57:27 +10:30
Alan Modra
474436e67c ppc64_elf_copy_indirect_symbol versioned_hidden fix
As per _bfd_elf_link_hash_copy_indirect.

	* elf64-ppc.c (ppc64_elf_copy_indirect_symbol): Don't copy dynamic
	flags when direct symbol is versioned_hidden.
2016-12-03 20:55:25 +10:30
GDB Administrator
10c56208ee Automatic date update in version.in 2016-12-03 00:00:22 +00:00
Nick Clifton
7ed7e438bf Fix typo in changelog entry 2016-12-02 17:53:42 +00:00
Nick Clifton
d7f399a8de Fix seg-fault in linker when passed a corrupt binary input file.
PR lf/20908
	* elflink.c (bfd_elf_final_link): Check for ELF flavour binaries
	when following indirect links.
2016-12-02 17:47:07 +00:00
Nick Clifton
531336e3a0 Fix seg-fault in the linker when examining a corrupt binary.
PR ld/20909
	* aoutx.h (aout_link_add_symbols): Fix off-by-one error in check
	for an illegal string offset.
2016-12-02 16:41:14 +00:00
Gary Benson
08698b7b46 Always pass a valid section header offset to elf_parse_notes
_bfd_elf_make_section_from_shdr calls elf_parse_notes with an offset
of -1.  This argument is used to calculate Elf_Internal_Note.descpos,
which ends up set to a positive but meaningless value.  This commit
updates _bfd_elf_make_section_from_shdr to pass the correct offset to
elf_parse_notes, making Elf_Internal_Note.descpos correct in all cases.

bfd/ChangeLog:

	* elf.c (_bfd_elf_make_section_from_shdr): Pass offset to
	elf_parse_notes.
2016-12-02 11:34:58 +00:00
Josh Conner
d5451cd453 Add support for Fushia OS.
* configure.ac: Add fuchsia to targets that use ELF.
        * configure: Regenerated.

bfd     * configure.tgt: Add support for fuchsia (OS).

gas     * configure.tgt: Add support for fuchsia (OS).

ld      * Makefile.am: Add dependency information for earmelf_fuchsia.c.
        * Makefile.in: Regenerate.
        * configure.tgt: Add support for aarch64-*-fuchsia, arm*-*-fuchsia*, and
        x86_64-*-fuchsia* targets.
        * emulparams/armelf_fuchsia.sh: New file.
        * emulparams/armelfb_fuchsia.sh: New file.
2016-12-02 10:44:29 +00:00
GDB Administrator
6a67d49e55 Automatic date update in version.in 2016-12-02 00:00:35 +00:00
Yury Norov
5cd1d8bcc2 Fix accesses to the GOT for AARCH64 operating in 32-bit mode.
PR ld/20868
bfd	* elfnn-aarch64.c (elfNN_aarch64_tls_relax): Use 32-bit accesses
	to the GOT when operating in 32-bit mode.

ld	* testsuite/ld-aarch64/tls-relax-gd-ie-ilp32.d: New test.
	* testsuite/ld-aarch64/relocs-ilp32.ld: Linker script for the new
	test.
	* testsuite/ld-aarch64/aarch64-elf.exp: Run the new test.
2016-12-01 12:31:51 +00:00
Ma Jiang
40a0bfddf0 Fix handling of MIPS16 HI16 relocs.
PR ld/16720
	* elfxx-mips.c (mips_elf_calculate_relocation): Remove overflow
	test for HI16 relocs.
2016-12-01 12:21:30 +00:00
Nick Clifton
e82ab856bb Fix a seg-fault disassembling a corrupt binary.
PR binutils/20892
	* aoutx.h (find_nearest_line): Handle the case where the function
	name is empty.
2016-12-01 10:49:39 +00:00
Nick Clifton
50455f1ab2 Fix seg-fault running addr2line on a corrupt binary.
PR binutils/20891
	* aoutx.h (find_nearest_line): Handle the case where the main file
	name and the directory name are both empty.
2016-12-01 10:15:07 +00:00
GDB Administrator
5084b13657 Automatic date update in version.in 2016-12-01 00:00:20 +00:00
Alan Modra
e9a38e0f52 Revert accidental elf.c change
* elf.c (get_program_header_size): Revert accidental change.
2016-11-30 22:12:00 +10:30
Alan Modra
ea3d7d1cab PR20886, looping in ppc64_elf_size_stubs
The PR20886 binary is large enough that there are two stub sections
servicing .text (which is 88M).  It so happens that between one
iteration of sizing and the next that one stub section grows while
the other shrinks.  Since one section is always growing, the loop
never terminates.

This patch changes the algorithm to not update previous size on
shrinking, once we go past a certain number of iterations.

	PR ld/20886
	* elf64-ppc.c (ppc64_elf_size_stubs): Make rawsize max size seen
	on any pass past STUB_SHRINK_ITER.
2016-11-30 15:43:49 +10:30
GDB Administrator
f0e9390be5 Automatic date update in version.in 2016-11-30 00:00:20 +00:00
GDB Administrator
aec6cd371d Automatic date update in version.in 2016-11-29 00:00:22 +00:00
Nick Clifton
cd58485720 Partially revert patch for PR 20815 - do not sort the PT_LOAD segments. Non-ordered segments are needed by the Linux kernel.
PR ld/20815
	* elf.c (phdr_sorter): Delete.
	(assign_file_positions_except_relocs): Do not sort program
	headers.
2016-11-28 17:50:04 +00:00
H.J. Lu
4deb8f714d Properly hide hidden versioned symbol in executable
A hidden versioned symbol in executable should be forced local if it is
locally defined, not referenced by shared library and not exported.  We
must do it before _bfd_elf_link_renumber_dynsyms.

bfd/

	* elflink.c (_bfd_elf_fix_symbol_flags): Hide hidden versioned
	symbol in executable.
	(elf_link_output_extsym): Don't change bind from global to
	local when linking executable.

ld/

	* testsuite/ld-elf/indirect.exp: Add a test for PR 18720.
	* testsuite/ld-elf/pr18720.rd: New file.
2016-11-28 08:03:46 -08:00
GDB Administrator
9e27646a6d Automatic date update in version.in 2016-11-28 00:00:22 +00:00
GDB Administrator
0584673719 Automatic date update in version.in 2016-11-27 00:00:30 +00:00
GDB Administrator
cf6451802f Automatic date update in version.in 2016-11-26 00:00:09 +00:00
Jon Turney
ec8f768821 Prevent problems with section alignment by not shrinking the .rsrc section.
PR ld/20193
	* peXXigen.c (rsrc_process_section): Do not shrink the merged
	.rsrc section.
2016-11-25 09:47:31 +00:00
GDB Administrator
0e722c9190 Automatic date update in version.in 2016-11-25 00:00:09 +00:00
Jiong Wang
1dcb9720d6 [ARM] Bind defined symbol locally in PIE
bfd/
	PR target/20737
	* elf32-arm.c (elf32_arm_final_link_relocate): Bind defined symbol
	locally in PIE.

ld/
	* testsuite/ld-arm/pie-bind-locally-a.s: New test source.
	* testsuite/ld-arm/pie-bind-locally-b.s: Likewise.
	* testsuite/ld-arm/pie-bind-locally.d: New testcase.
	* testsuite/ld-arm/arm-elf.exp: Run new testcase.
2016-11-24 14:01:53 +00:00
Kuan-Lin Chen
0b14696aed RISC-V/bfd: Fix bitsize of R_RISCV_ADD8.
bfd/ChangeLog:
	* bfd/elfxx-riscv.c (howto_table): Fix bitsize of R_RISCV_ADD8.
2016-11-24 10:56:15 +08:00
GDB Administrator
8bc2611fd9 Automatic date update in version.in 2016-11-24 00:00:32 +00:00
Nick Clifton
1a9ccd70f9 Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.
PR ld/20815
bfd	* elf.c (elf_modify_segment_map): Allow empty LOAD segments if
	they contain the program headers.
	(_bfd_elf_map_sections_to_segments): If the linker created the
	PHDR segment then always attempt to include it in a LOAD segment.
	(assign_file_positions_for_non_load_sections): Allow LOAD segments
	to overlap PHDR segments.
	(phdr_sorter): New function.  Sorts program headers.
	(assign_file_positions_except_relocs): Sort the program headers
	before writing them out.  Issue an error if the PHDR segment is
	not covered by a LOAD segment, unless the backend allows it.
	* elf-bfd.h (struct elf_backend_data): Add
	elf_backend_allow_non_load_phdr.
	* elfxx-target.h (elf_backend_allow_non_load_phdr): Provide
	default definition that returns FALSE.
	(elfNN_bed): Initialise the elf_backend_allow_non_load_phdr
	field.
	* elf64-hppa.c (elf64_hppa_allow_non_load_phdr): New function.
	Returns TRUE.
	(elf_backend_allow_non_load_phdr): Define.
	* elf-m10300.c (_bfd_mn10300_elf_size_dynamic_sections): Do not
	place the interpreter string into the .interp section if the
	nointerp flag is set in the link info structure.
	* elf32-arc.c (elf_arc_size_dynamic_sections): Likewise.
	* elf32-score7.c (score_elf_final_link_relocate): Allow for the
	_gp symbol not being part of the output.

binutils* readelf.c (process_program_headers): Check PT_LOAD and PT_PHDR
	segments for validity.

ld	* ld.texinfo: Note that PT_TLS can be used as a segment type.
	* testsuite/ld-discard/discard.ld: Add space for program headers.
	* testsuite/ld-elf/flags1.ld: Likewise.
	* testsuite/ld-elf/maxpage3.t: Likewise.
	* testsuite/ld-elf/noload-1.t: Likewise.
	* testsuite/ld-elf/orphan.ld: Likewise.
	* testsuite/ld-elf/overlay.t: Likewise.
	* testsuite/ld-elf/pr14052.t: Likewise.
	* testsuite/ld-elf/pr19539.t: Likewise.
	* testsuite/ld-elf/provide-hidden-1.ld: Likewise.
	* testsuite/ld-elf/provide-hidden-s.ld: Likewise.
	* testsuite/ld-elf/weak-dyn-1.ld: Likewise.
	* testsuite/ld-i386/pr19539.t: Likewise.
	* testsuite/ld-scripts/defined.t: Likewise.
	* testsuite/ld-scripts/defined6.t: Likewise.
	* testsuite/ld-scripts/dynamic-sections.t: Likewise.
	* testsuite/ld-scripts/empty-aligned.t: Likewise.
	* testsuite/ld-scripts/provide-2.t: Likewise.
	* testsuite/ld-scripts/provide-4.t: Likewise.
	* testsuite/ld-vax-elf/plt-local.ld: Likewise.
	* testsuite/ld-x86-64/pr19539.t: Likewise.
	* testsuite/ld-elf/ehdr_start-missing.d: Do not initialise the
	dynamic linker.
	* testsuite/ld-elf/ehdr_start-weak.d: Likewise.
	* testsuite/ld-elf/elf.exp (pr14170, pr17068): Likewise.
	* testsuite/ld-elf/loadaddr1.d: Update expected readelf output.
	* testsuite/ld-elf/noload-2.d: Likewise.
	* testsuite/ld-powerpc/vxworks2.sd: Likewise.
	* testsuite/ld-scripts/phdrs3a.d: Likewise.
	* testsuite/ld-scripts/size-2.d: Likewise.
	* testsuite/ld-elf/group.ld: Add program headers.
	* testsuite/ld-elf/overlay.d: Skip for SPU.
	* testsuite/ld-elf/flags1.d: Skip for RX.
	* testsuite/ld-elf/pr19162.d: Skip for HPPA64.
	* testsuite/ld-elf/pr19539.d: Skip for ALPHA.
	* testsuite/ld-scripts/empty-orphan.t: Update program headers.
	* testsuite/ld-scripts/size-2.t: Likewise.
2016-11-23 11:10:39 +00:00